From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 964D1C04E69 for ; Tue, 25 Jul 2023 05:43:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 08DA96B0074; Tue, 25 Jul 2023 01:43:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 016036B0075; Tue, 25 Jul 2023 01:43:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DF8F36B0078; Tue, 25 Jul 2023 01:43:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id CCB016B0074 for ; Tue, 25 Jul 2023 01:43:14 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 9977CB246A for ; Tue, 25 Jul 2023 05:43:14 +0000 (UTC) X-FDA: 81049041108.07.8A3A710 Received: from mail-qt1-f181.google.com (mail-qt1-f181.google.com [209.85.160.181]) by imf30.hostedemail.com (Postfix) with ESMTP id CC80480010 for ; Tue, 25 Jul 2023 05:43:12 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=QVWmh30O; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf30.hostedemail.com: domain of yuzhao@google.com designates 209.85.160.181 as permitted sender) smtp.mailfrom=yuzhao@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690263792; a=rsa-sha256; cv=none; b=Wln6sMa9Gt9rJC0VOT7nb/WpZ59v9uF3Sdc6pxA9If6I6mHgG4VmM86dDF/WB9nA8SS7K7 TVLMWvtRlkPoEAdnWFEECASWAa1sqgdMU5uHJTlAfuSsxu1OJFGSZ41Z+ExnVXVcQZxiKE NvI5IqwQDX5GaYOJklU5Q8hZAwFWhu0= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=QVWmh30O; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf30.hostedemail.com: domain of yuzhao@google.com designates 209.85.160.181 as permitted sender) smtp.mailfrom=yuzhao@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690263792; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hIDMt+ukB3iu96NN76V4i5aDHpFjPIK+TbAxUylXFbc=; b=n3IO4prjnoleQcBxc2SJFncBbFFkkJTITViN1TjCbMt/muGAnSDc3uZwrksPnbwRnSTjmx 88PQNLjWWyqns3bYlcbx6hMbXTgUG354tUXR2HfxtOPhUsnGiXRDWXr+ntVwIc9LHGZ9qt IzkeUF0bSraszRGKxxvbyBw3d5q4tM8= Received: by mail-qt1-f181.google.com with SMTP id d75a77b69052e-40540a8a3bbso119371cf.1 for ; Mon, 24 Jul 2023 22:43:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1690263792; x=1690868592; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=hIDMt+ukB3iu96NN76V4i5aDHpFjPIK+TbAxUylXFbc=; b=QVWmh30O5Tn5kmdIXi6k8D31VIjeVN906YLSjLLx5O2bPNaMTN+6zn/VxtFxdbslOo BD02+q1ZpeCzY54p4D5C34hbNBNS8RC+OLFxOfrEBzWAo1R4QzuliySjeNiBcGxNrqQR //zd2eKnCExJHH35DZesh/RxR+LCYO+8KVGEHfYu11V/nhf2+BlydSAJSDfqkDQ3gnww mPt/3ApbceJb98bsS5A22Z/aIE6fyE+S+dHCEF5pHgfAOREeHYkRk66JqRiDpQxIZj6q Cq/TEBs3QNI/Vs4EMZat48i2LI8r4gGpocKPmKdQq5knf7vdK81zwmkzxGxH/JBLPq5C VowA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690263792; x=1690868592; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hIDMt+ukB3iu96NN76V4i5aDHpFjPIK+TbAxUylXFbc=; b=IxySHety0wL2EYTuqo8j544zqrjRfTb4qh5dWdR+Jemo+uC9IugINh4fagFAC2L9/J Gy1zft6UI5IZc7XyvqN3DPzaW7OHm/f+Q6rNcO7oI7g3AYenueXsVHaGFE4ZCj5pnjd3 SBwwfelvANGSaeKWbUKoMv4OifWhKdcEwdiXvJpSgM974eGcDuKVUg9MHNVR3L/lozlg S44o6sEKC77mNnHDWwjqoJkAdxYgXQeoe1U1z4385wQJcsoSlh4HEd3CCBrSPdtHff85 ZDT/XEkcaeOYoc010j1UplfAJ7ISbrHo+DGmSiOCWH5dqf6PiPRbFwBfLelGrWS2ZRPj 8eEA== X-Gm-Message-State: ABy/qLZp4iwdcwhfBDa4QO2GBXARxA8bP3KZ/oQkF4nfAQulUptR9a6R j4ytIMKXDIa7+pymA10OPfQsSOkcEnW9QvDJSZkow7IokQLdtX+6Mv5chw== X-Google-Smtp-Source: APBJJlHKdDVd54Lf9xjbg3FDc+aM4J4ZaWYYP3CYibYSXCA+p7hZQLopCR5e78Q47BMCmPHnqHhL6mA7VLoBNoo8xvg= X-Received: by 2002:a05:622a:16:b0:3ef:5f97:258f with SMTP id x22-20020a05622a001600b003ef5f97258fmr93934qtw.16.1690263791937; Mon, 24 Jul 2023 22:43:11 -0700 (PDT) MIME-Version: 1.0 References: <20230721094043.2506691-1-fengwei.yin@intel.com> <20230721094043.2506691-4-fengwei.yin@intel.com> In-Reply-To: <20230721094043.2506691-4-fengwei.yin@intel.com> From: Yu Zhao Date: Mon, 24 Jul 2023 23:42:35 -0600 Message-ID: Subject: Re: [RFC PATCH v2 3/4] mm: add functions folio_in_range() and folio_within_vma() To: Yin Fengwei Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, minchan@kernel.org, willy@infradead.org, david@redhat.com, ryan.roberts@arm.com, shy828301@gmail.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: CC80480010 X-Stat-Signature: hzoop1fhqunh7tz3aptrd1un1bww7f6s X-HE-Tag: 1690263792-382825 X-HE-Meta: U2FsdGVkX18hestdUuHDAEuHt3L4Dr3lQqDx88GCFt5TxQTb+S5ZAK+xvdHq7+U/r/Om5Kkx90IgGYlO47jKvu7Zv0Fp1DsNIEAcTPXNs8ScEtCXc+vcgSQ8LHu2OCzBwm+EVbIhmIrUnVdfhJQyTkBrd0QOoElZ9uGlC6PK6Z/kURAkQR7gYqUpE14KFmAidLueXHECAj2ZFuT7j2taIc/Xk8doMloANARWzP3cvEKAymG59wwSbWSqr98dS2qwJRZ+1zNk72s6CnHCFxCeZjtMKbqsJet1oaPbSXMIaO+JFnit8lbt+P8ApuMMKzDlvdB7ejKOIos5ISFV9g4oZqeWiOPrxbm1LpZ5Xz39+O1aeu8dWCXidsZ4AkN5j+yAE09kPOKbBd1XvrGFODob1BEoX+Ah4jwUVx9IhyWwrITa6bOeASDwETGuaA0+2gUmZq4RRZSOL4rKJwDhhVVdbQdGNhGOLjKXJNluP4IBfHBr3o8e7bndOkMyz3Jri1jexbibd8awOcTuaYcOKZVA3lU2naiOTcJ3kDtDExcUe4uBbcMxizNakodxNmsbkq1PRl+iHbUEa+qT6rhfEVCW2nzWavm2eEyzNRr4EO288c6i0p8lLmHOsFEhV46SyRoMmPoefSLra5LFjt8T4VU/g1kOzm4upEtBuOnxuZWHaKCNk3VeO4QJfbYIO/LFIp4B573LcobUy5y2L1dpKip/omKKZbkQxR6lpE3lIjv+EJWSk84mKf7nI0MD3CLP2h61RlsWJqtUXUJyjVlAbTVGx/ooj9E079bsbGEVtmaxJDGl8eyXuXVhLGgfBK+WRSVpDgFgM58diFjC6xSN13PcZutUcU1nzju9/m9lfd+/eTdjMX4/L2g0pgieV8ZJ6z5iAF2+OUtbEpymhmlRYmWhTpt9FQKfta5P8CgkwRi582cNiBTL0Q27QOmu1xmVDOsewVpHJRFQrSIxFyEbrGI zfNeYg4C RGB6F1qCxYhTPQeN6R/lEUy21qf0OW5Mo9GfMRcmeygCgqBazWJaVptKnKJAaS+QRak/MlhltTYt8Kb1S7pDtpEzGTz71t92/F/aOG3HkX6GJtCilRkz/0RB5iFvnYRlGceVtm+VptxOu/ysl+TmXtZoK8RlVRf5zhNfHOjubXj4uzGFlJDE0jhqiI0vSrj7rj0u2x+hbeSJe7eJ6+bChP0mfVPfcbnkVdMir0Cz6Y8B+2lhYrVI5gBQJWZfyuhLJJLGeXJ0ecYadhaq+0xHFRuO5Bf10vtCA6KpQGczzwMuuEHc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 21, 2023 at 3:41=E2=80=AFAM Yin Fengwei = wrote: > > It will be used to check whether the folio is mapped to specific > VMA and whether the mapping address of folio is in the range. > > Also a helper function folio_within_vma() to check whether folio > is in the range of vma based on folio_in_range(). > > Signed-off-by: Yin Fengwei > --- > mm/internal.h | 32 ++++++++++++++++++++++++++++++++ > 1 file changed, 32 insertions(+) > > diff --git a/mm/internal.h b/mm/internal.h > index 483add0bfb28..c7dd15d8de3e 100644 > --- a/mm/internal.h > +++ b/mm/internal.h > @@ -585,6 +585,38 @@ extern long faultin_vma_page_range(struct vm_area_st= ruct *vma, > bool write, int *locked); > extern bool mlock_future_ok(struct mm_struct *mm, unsigned long flags, > unsigned long bytes); > + > +static inline bool > +folio_in_range(struct folio *folio, struct vm_area_struct *vma, > + unsigned long start, unsigned long end) > +{ > + pgoff_t pgoff, addr; > + unsigned long vma_pglen =3D (vma->vm_end - vma->vm_start) >> PAGE= _SHIFT; > + > + VM_WARN_ON_FOLIO(folio_test_ksm(folio), folio); > + if (start < vma->vm_start) > + start =3D vma->vm_start; > + > + if (end > vma->vm_end) > + end =3D vma->vm_end; > + > + pgoff =3D folio_pgoff(folio); > + > + /* if folio start address is not in vma range */ > + if (pgoff < vma->vm_pgoff || pgoff > vma->vm_pgoff + vma_pglen) > + return false; > + > + addr =3D vma->vm_start + ((pgoff - vma->vm_pgoff) << PAGE_SHIFT); > + > + return ((addr >=3D start) && (addr + folio_size(folio) <=3D end))= ; Not sure how much we care but better to avoid (addr + folio_size()), since it might wrap to 0 on 32-bit systems. Reusing some helpers from mm/internal.h, e.g., vma_pgoff_address(), would be great, if it's possible (I'm not sure if it's).