From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9724CCD1284 for ; Fri, 5 Apr 2024 01:44:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2A2526B0099; Thu, 4 Apr 2024 21:44:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 22B946B009D; Thu, 4 Apr 2024 21:44:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0A4DA6B009F; Thu, 4 Apr 2024 21:44:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D91476B0099 for ; Thu, 4 Apr 2024 21:44:56 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 1518F1206DB for ; Fri, 5 Apr 2024 01:44:56 +0000 (UTC) X-FDA: 81973784592.09.8C96574 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by imf01.hostedemail.com (Postfix) with ESMTP id 3A5AE40014 for ; Fri, 5 Apr 2024 01:44:53 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=3smJO0Hj; spf=pass (imf01.hostedemail.com: domain of yuzhao@google.com designates 209.85.128.48 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712281494; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7v4H4iPqjB8TunHOy2slwnPiBChxNL6+GU28qrAJ2tc=; b=ad5E0l5oD7+MIFncxOcmN1JZBEenh3oh2u2DDBMtQstnwZCufdTVeiZwxKJg/T91a45eko xJiKESGm6cjfgkoAjoA3CB/MqauLw1TncxTOue6lVbVJFvLvnqkg6Hx1VWSoK66ksPHsLq uKdizjf/Jco6TtNKdrjcTMt8gYpxXTI= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=3smJO0Hj; spf=pass (imf01.hostedemail.com: domain of yuzhao@google.com designates 209.85.128.48 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712281494; a=rsa-sha256; cv=none; b=K5VvUqrq1nRPDNzs7zucCZULS7D21Q3vYdYnc3HIwfLuz2xzJU/jt4pjQWfEXXhB9USLju YbpiJeYMsozWNKhujmH2Ab4W256aMtgJ7SQ04aMZuGo7v4OAaI4N525yklgjt0hyh6CGfO T9zh7yOplLNHgw5zoF1+treloH3dysw= Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-41549a13fabso22675e9.1 for ; Thu, 04 Apr 2024 18:44:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1712281492; x=1712886292; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=7v4H4iPqjB8TunHOy2slwnPiBChxNL6+GU28qrAJ2tc=; b=3smJO0HjpZg2lT59Wq7/kNNB20Ibkw4gZoZbdV7hHcy61mOiwYYC10EeVq6n1yy8m5 IdGcVdv+7W+okLr9ACGmYCLDWY7kdoKMX4+LZlbE/aIINpEPi3cg1d3bo0x12KcAaXe8 +FQe6je3wJw2nK2zbVz/Y34gKwyRPtpK5iXpBKlDPi/0AR0nxNHdcTPi1pqj05cmbwk2 UnbUsy9yI2uOkEqpMb5YMzJbMVBOjjVjy65Ej1W9bwDO/Kbi9Yo3Ay2zRdI0FBAy4JhT iSRQ5SLgPwSf/dbjQLtQi9C9I8XaDmEk/mLKZJrBE/hScC1t4NCT4n6phJpZIoTARPIS pcyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712281492; x=1712886292; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7v4H4iPqjB8TunHOy2slwnPiBChxNL6+GU28qrAJ2tc=; b=N+H44DxFk1hqS2T/Kagwy9HmMJgkeGmyYDRg3YGG4lRCJSxLE2+dnqudhvkmjdBcVv GuREHYPQoSm0YIWvuPvz2gQUUm/eqTk6fVvF/DdoWoYHQbVujFchkaLQUlfZSrrEoXvq JjtIrAPv+RGPeBwwGYtD06kcCFqWY6CXEUd238btOXFnmzgvpBPvmWHcl3O7tF8U8e0D 65S9rJ+2VJajtet/DmKCy+tQ81Ai4gBn0BKpvxgA0idbHN9IeVM96VI6bqwnSIF0BlTr bMvojIPFmQ12WVCZKBKHFGmv1EZcuAhltrE86nJUM4Pg7P8y5MKmEn5b7yuhZOAvatnD hCfA== X-Forwarded-Encrypted: i=1; AJvYcCVRADPnF4ZMkUrWrz+HtpyW/ce0dOn8uF2nGFqngvjp6MBBM2GNjvm3saI3mFyqss2xE8fv4lBRCuCKRWPnztHrELI= X-Gm-Message-State: AOJu0Yz6QgTQb5WBurNbHFlSIWTdmm/OP8DzLHAlG3lFu6S7CvcuMsWe ps0T2wbAYY6TW/Nau1vgOj0sCJrFp4hnOhW6e+6KGNY13bb/h1nckfPcQ7wqN/e/K3AsT34MMXv pFR1v9EDN1uurOjXDNMDqHhuiLS49+Abk78wA X-Google-Smtp-Source: AGHT+IGNzIkQ++HioHaYuqE7uw4+4B36YZSB6w3+Tg0LxaP/dZ3YAvcMaWHCFpEbt6RAzkDLWFaYIQaBqhYgu/NfxDo= X-Received: by 2002:a05:600c:5125:b0:414:daa3:c192 with SMTP id o37-20020a05600c512500b00414daa3c192mr258752wms.0.1712281492429; Thu, 04 Apr 2024 18:44:52 -0700 (PDT) MIME-Version: 1.0 References: <0000000000007545d00615188a03@google.com> <20240403180752.f95e1b77e033b5e03164c160@linux-foundation.org> In-Reply-To: From: Yu Zhao Date: Thu, 4 Apr 2024 21:44:14 -0400 Message-ID: Subject: Re: [syzbot] [cgroups?] [mm?] WARNING in __mod_memcg_lruvec_state To: Yosry Ahmed Cc: Andrew Morton , syzbot , cgroups@vger.kernel.org, hannes@cmpxchg.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mhocko@kernel.org, muchun.song@linux.dev, roman.gushchin@linux.dev, shakeel.butt@linux.dev, syzkaller-bugs@googlegroups.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 3A5AE40014 X-Rspam-User: X-Stat-Signature: 8um969yprk55t8fdm4r6bnjk41ws6goe X-Rspamd-Server: rspam01 X-HE-Tag: 1712281493-22784 X-HE-Meta: U2FsdGVkX1+lcqyjG9Kvm0u9iLM29Tw4g/3DKZ2J0XBSM5FHYwkDy0D0u0bQuc4GsH6JfwAx+wRGEvw3YuYewGob2q7KyZeKM1eTJ0tXANtHV3KeH03mdig2VtjEtdVT9NTTIcoHsmzxiahEsRSEAlO6TQLZ/0gOLNitd9wYazZwAQfMNdY7xqifnDTMOO5YhyhoXbLzXBsgIcSXiIzko+sQ+uLVrZbMaOQ6UGTzDK/DWo0Zvj2fZIvIDKhZmAFxzqUngfvxovNgAnbJKcLMThyJ+5OwUrbAzXu1b+o3uoP94yjrV7UZtb1npcyKqSvtIWy5aDBUZHzfFgIJ2vz73L54UAxKOLHhDrbke1Xr9Kf7OFpZjU5Bet9GjkWg9IQWMwygU2n3nSmbGmYxCHiecdO4u6Fz75nhV++Ei/xNWGnVrLtFi9V5oob1DRLyyI37wnz86WBZ4SLT4V6bc+/mvUFZcajvX/ivs03nDHcY73WY7k1cYPt0QEaEvJdwYV387xZTx6SnO08S7/WVPqgB8Pj0TzG1szPI0iTN9h/M/Fjk5EerajbzNtfQxFl6nTnZrwPCW5kgOqGYLm4AXzZfRUqFbptOJZWOC++J8HUbuM8nGhuOzEU3qKQ2784uB+iebZcRRy9P5GOBbGfZHqRb1HNws5PLSRqwvawNOxgNtHuuE949esvYRcNEvapN69FPqv19Ef1qnsm18Olr66R1CZABuH53wIwugmiU38sO+MRFVYmQDEakzRYGPSKG5RjiHJugnh0UxkDMUJljDsjNF0vqYPSi8mR//nocpRLRAvkYa7PxDGo1zOB2Wtk98tVRmTb49m4j3NEjml5gJAv9TqTNbRvllom0KC0ozPvoCDv8hEJDoufvCSlrAV+PWuBIAI6fWKbX9La5oMPmBDXsGtE+DhlyBxNhTaQ4+LroHibnVbyU9pN49GMCgNaI1fhq3bCsHi9XmIPBPs7H4vK DERAnzNk QaXMdZXr/iKuYJPUsOLuodwHeuLe0W7p9lmjPNpwx41fpiing9BZqyZuFuBLujWltGWmOkiy2W+RfxZZ+FdTGobLR8iJxIgztk37Twgm/ORlFS2M19uCkAhwSj7cue/6T1YuIMuSccbJNlwqm5dKHpkSfJrlvkclUyjjUE++lCIY+1MR0ke+IRhkp9yoeTazR8XFVNUhJGgdV3kahXvanKvTsfap0o4RnNV04KXvx0u7WLSJCT6AGwcSEGCcPJWbHFxi8MeTuy9njxdmg05yEFJ9DrmAAKarAILKJkFdqzrMz168v7D39jFgJOSRhoD6ytFm1kI76g65kORaBKC5hIPvq0XfILmsXDNKaQFIGU7WWjXsZUs4G6dBfto5NSASjr1tYEvDJd2vRlbA2NfOkNhkmqDNmWk50+ObGjSVAxJ8oR8UgtfSPGsGnIZbpDtQUj1uIOWPKO2+7HUQfkn3x1EVj7qHCqW7GRLBXiOrb1TQJQbZ7uh4xZvAFrTTO8famep3J86xnkGRBZDu0FQcwSjtR8gImoi9OOCmQ9saZoB9sM8Ya9E0s2dYTfn7+Y5d1VJASPGsIoM6idQa4tDrilIHCYTEEpx/eUa/HLm72qtKBjJeO5WxHWMzjyhNwnRFtaHvxL1SYrUXXvCXcsDTMi8Ni1hcRTjaMjyDNq8IQv4cjWVoTZrnUTAIQb8HfrMXpxhzbpEUiklryxHUtjS2VJ2+vbvV3zZneIkPo4JaU6ZOot0EXkDqPefSkCDJ+DOK7gxAgRj5Pg8c4uAd6hXwiO9UaOUGcvvLcLDhToMxEiZfatBfXFmRDwQcaLA2NgL10ga79i/8ra2ilXxTzNSsevH/7y1IvO2KfIPc2Z7Q0JI6mQmfReB5h5Q23k77oEfdtyJb30FHvMd0QzTemo+TRGpk4MXlJw3j145AqDHRpQg6SNWY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 4, 2024 at 7:36=E2=80=AFPM Yosry Ahmed = wrote: > > On Wed, Apr 3, 2024 at 6:08=E2=80=AFPM Andrew Morton wrote: > > > > On Tue, 02 Apr 2024 01:03:26 -0700 syzbot wrote: > > > > > Hello, > > > > > > syzbot found the following issue on: > > > > > > HEAD commit: 317c7bc0ef03 Merge tag 'mmc-v6.9-rc1' of git://git.ke= rnel... > > > git tree: upstream > > > console output: https://syzkaller.appspot.com/x/log.txt?x=3D15fd40c51= 80000 > > > kernel config: https://syzkaller.appspot.com/x/.config?x=3Df64ec427e= 98bccd7 > > > dashboard link: https://syzkaller.appspot.com/bug?extid=3D9319a4268a6= 40e26b72b > > > compiler: gcc (Debian 12.2.0-14) 12.2.0, GNU ld (GNU Binutils f= or Debian) 2.40 > > > > > > Unfortunately, I don't have any reproducer for this issue yet. > > > > > > Downloadable assets: > > > disk image (non-bootable): https://storage.googleapis.com/syzbot-asse= ts/7bc7510fe41f/non_bootable_disk-317c7bc0.raw.xz > > > vmlinux: https://storage.googleapis.com/syzbot-assets/efab473d72c0/vm= linux-317c7bc0.xz > > > kernel image: https://storage.googleapis.com/syzbot-assets/5ba3f56d36= 2d/bzImage-317c7bc0.xz > > > > > > IMPORTANT: if you fix the issue, please add the following tag to the = commit: > > > Reported-by: syzbot+9319a4268a640e26b72b@syzkaller.appspotmail.com > > > > > > ------------[ cut here ]------------ > > > WARNING: CPU: 0 PID: 30105 at mm/memcontrol.c:865 __mod_memcg_lruvec_= state+0x3fa/0x550 mm/memcontrol.c:865 > > > Modules linked in: > > > CPU: 0 PID: 30105 Comm: syz-executor.2 Not tainted 6.9.0-rc1-syzkalle= r-00178-g317c7bc0ef03 #0 > > > Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.2-debia= n-1.16.2-1 04/01/2014 > > > RIP: 0010:__mod_memcg_lruvec_state+0x3fa/0x550 mm/memcontrol.c:865 > > > Code: 45 85 e4 75 1d 48 83 c4 18 5b 5d 41 5c 41 5d 41 5e 41 5f c3 cc = cc cc cc b8 00 04 00 00 e9 80 fd ff ff 89 c6 e9 a0 fd ff ff 90 <0f> 0b 90 e= 9 a7 fc ff ff 48 c7 c7 18 43 e1 8f e8 32 51 f8 ff e9 5e > > > RSP: 0018:ffffc900034beef8 EFLAGS: 00010202 > > > RAX: 0000000000000292 RBX: 0000000000000001 RCX: 1ffffffff1fc2863 > > > RDX: 0000000000000000 RSI: 0000000000000001 RDI: ffff888024b92bc8 > > > RBP: ffff888024b92000 R08: 0000000000000005 R09: 0000000000000000 > > > R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000001 > > > R13: ffff88801c326000 R14: 0000000000000001 R15: ffff888024b92000 > > > FS: 00007f0811bf96c0(0000) GS:ffff88806b000000(0000) knlGS:000000000= 0000000 > > > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > > > CR2: 000000000cfff1dd CR3: 000000003e4e2000 CR4: 0000000000350ef0 > > > DR0: 0000000000000031 DR1: 0000000000000000 DR2: 0000000000000000 > > > DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 > > > Call Trace: > > > > > > __update_lru_size include/linux/mm_inline.h:47 [inline] > > > lru_gen_update_size include/linux/mm_inline.h:199 [inline] > > > lru_gen_add_folio+0x62d/0xe80 include/linux/mm_inline.h:262 > > > lruvec_add_folio include/linux/mm_inline.h:323 [inline] > > > lru_add_fn+0x3fc/0xd80 mm/swap.c:215 > > > folio_batch_move_lru+0x243/0x400 mm/swap.c:233 > > > > Well it beats me. I assume we failed to update for a new case. I'll > > toss this into -next to perhaps shed a bit of light. > > > > --- a/mm/memcontrol.c~__mod_memcg_lruvec_state-enhance-diagnostics > > +++ a/mm/memcontrol.c > > @@ -860,10 +860,12 @@ void __mod_memcg_lruvec_state(struct lru > > case NR_ANON_THPS: > > case NR_SHMEM_PMDMAPPED: > > case NR_FILE_PMDMAPPED: > > - WARN_ON_ONCE(!in_task()); > > + if (WARN_ON_ONCE(!in_task())) > > + pr_warn("stat item index: %d\n", idx); > > break; > > default: > > - VM_WARN_ON_IRQS_ENABLED(); > > + if (VM_WARN_ON_IRQS_ENABLED()) > > + pr_warn("stat item index: %d\n", idx); > > Line 865 from this commit should be this warning (i.e. warning because > IRQs are enabled). This also makes sense because __update_lru_size() > should not be updating any of the above stats. > > folio_batch_move_lru() in the above call stack should be acquiring the > lock with IRQs disabled though, so I am not sure what's going on from > a quick look. > > Adding Yu Zhao here. Probably an RT build where _irqsave doesn't disable IRQ?