From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FE0DC3DA6E for ; Thu, 4 Jan 2024 01:18:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E35088D006F; Wed, 3 Jan 2024 20:18:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DE4C08D006C; Wed, 3 Jan 2024 20:18:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C85218D006F; Wed, 3 Jan 2024 20:18:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B57778D006C for ; Wed, 3 Jan 2024 20:18:25 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 7BA85C01E1 for ; Thu, 4 Jan 2024 01:18:25 +0000 (UTC) X-FDA: 81639868170.17.26F975C Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) by imf03.hostedemail.com (Postfix) with ESMTP id ABB5520003 for ; Thu, 4 Jan 2024 01:18:23 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=lF5DDekM; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf03.hostedemail.com: domain of yuzhao@google.com designates 209.85.208.49 as permitted sender) smtp.mailfrom=yuzhao@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704331103; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+eOihVzL+EVjsPhR8JjZLVk3UHy9SeIcu5m/iOFaAv0=; b=ZJi3jo7raJ7rOZloirIRtm+Pnu8KajKZD6pprSeH5hz+xnWwkA5CPz5kEsdbCa6mh4t1ej arS06x+LYEiMgiU/IBHUAg5bgoAdxj7NWg/awlT1yY3UP5TSDV+meCPvSGq8wsELnphBch 0Rmh/CXXrf2mLpg7RrLcZNYH0RQxSGs= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=lF5DDekM; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf03.hostedemail.com: domain of yuzhao@google.com designates 209.85.208.49 as permitted sender) smtp.mailfrom=yuzhao@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704331103; a=rsa-sha256; cv=none; b=D2RBXAVO8T6QGFYQ+UL1hoMObTwbi3MeZZsPIeEPemSzY+saTcTZwBifl9QkXyCgIsksLt O48XksCRyHYFJoAwBadtLPV4FgI3zeQM2Xu6O5SYFZBUgNbVFN2stoSjlTaccGSJODXOR4 YDyXhgIhwRPLOZFzmj28c8JMxtuSZPg= Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-54744e66d27so6614a12.0 for ; Wed, 03 Jan 2024 17:18:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1704331102; x=1704935902; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=+eOihVzL+EVjsPhR8JjZLVk3UHy9SeIcu5m/iOFaAv0=; b=lF5DDekM+BDfcAWy0eauW1h1ScFKmQE8FodAleMiqjpbNBKZFdqQwEGWsknmjabS51 Io5RUZCgDB0pXw+dVFHNMIfqOeJC9EJuACVlU1/zoAj++PKKJHWKSXHNTwIZLdtAsVEV J4d67+MGSqYAXa4fAefIOn2XFhrqj/5zZoLHV2OeGM4eIgYFVVwCY/VOrsec9xdwIkjv YkaM8/5edL+/SUYrakkjWQQReZLg0wdegip3cuHFNM9XmMlY3YFzENZLlLwqZRZrQzai jslpIVakbUSvesC1M2QxgxSJONkQTe1W0Y5XZNVLpDrQwvpvQccaY2JlXeyXttvgfSRn c4cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704331102; x=1704935902; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+eOihVzL+EVjsPhR8JjZLVk3UHy9SeIcu5m/iOFaAv0=; b=lKJkxGdgvp3Qija67bQHOgj4GgvHfP+smfA3/wDGE8pEevmFwPkGGzVue+zGNNfvII I4UU3r27/60aSCBBKfkr47scENs4Tn0F2/N9e2mAnx4yXENjgQ5Al0F1PEFJXkTZ44XN xio/9nNhMNrtuh/KXkpgz34PdblftI2L2SuwyN5MO/rbqHFXpoVi5mk0YtIpmRlgbysK jvuKQM9jT4G2W1XBkA7xIaX+Zq5T7agX09xPKRPI80SeEp9AM3/4b6D6rgUrp19MdH7c imLDYh4awAFr7tPrrKeSkuQJdBAKE4S3M3d9BpC96Tm8hLvlHyHU0IlEjMkvUXrFprYV CSWQ== X-Gm-Message-State: AOJu0Yxaqp5Tb3FrW29zKFEfQTCFOAl/5xCNp8BF7xirrTQ3ryDnO3rP n1Y4VI0/9qVRpreLMCfzPUULYNooby83Rhf2Jx+63ZZo5qWQ X-Google-Smtp-Source: AGHT+IHkDaYXx3vIf2LQ/rTC9gJtpfrx24b7Zag7MbADMq8MnjXCdGVLkz4I2hDjvet/5H2gw+LHsrFnWNOczjuZXIQ= X-Received: by 2002:aa7:d412:0:b0:557:15d:b784 with SMTP id z18-20020aa7d412000000b00557015db784mr16278edq.2.1704331102029; Wed, 03 Jan 2024 17:18:22 -0800 (PST) MIME-Version: 1.0 References: <20240103164841.2800183-1-schatzberg.dan@gmail.com> <20240103164841.2800183-3-schatzberg.dan@gmail.com> In-Reply-To: From: Yu Zhao Date: Wed, 3 Jan 2024 18:17:44 -0700 Message-ID: Subject: Re: [PATCH v6 2/2] mm: add swapiness= arg to memory.reclaim To: Dan Schatzberg Cc: Andrew Morton , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, Yosry Ahmed , Michal Hocko , David Rientjes , Chris Li , Tejun Heo , Zefan Li , Johannes Weiner , Jonathan Corbet , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , David Hildenbrand , Matthew Wilcox , Kefeng Wang , Yue Zhao , Hugh Dickins Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: ABB5520003 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 6w14cadx4xpmnmbyh1xszzmhmbhcw6x3 X-HE-Tag: 1704331103-365384 X-HE-Meta: U2FsdGVkX1+2VFVUqamDg+a+6ONgidgoqVsS97aQFZuNEQ1o0+274ebeQYMnhZoFCHXAVn0qvR5OFrP/8EP8nI4XraMjH6QSE0NdH90/AtnOcYmGfX/FC91a0Nh6YdNe7UM5dl/tG6VfjoGUDtcpbP4tAACgRAmH0B9Hd1b0hVwbtBtdOA7mFPPYb6su+R4HdAaXZxivQY8xW3PQYgRQdJWUvVwTJyj7ryoXsZnoj0phBcwCQh5Xn0sMtYEocMMMiKG6Anj1buzXtghC2wiuEtm7B04zCOBSQmvWN9vgFL3WfpSuPDX8wsHSAsU8b3jNBJ1KeFJ+EWb8iV93zkeCLpxc3T31xZLyf8QnXI4vKWc6oA1uQTCKI58t0gskkJPF/6k3rfrX/OwGG+SUOByz8STuueQmd2IvszIdTRgq6FJWnrBycB5i5aUlXv2d6ZwgxULsTwCOtZM5IJ6onNyYale//ftFsiXJuIbmYuOgKw20q2NkuNxeL5Sr5hIaTTTJtvGm4IdR6FeuMynraYg8fXRWfULnNFr9GmhgmWojd2Agu7LV8j6PfnC1oG+ODud905AA60XrVCT4W6f1qKQHH2VDLF5KEuAER1F3mccl1CLbtA0iJVY6sOurJmB0d7Vtr3aECXoAqYNctf7v+rX2HamKERlKVYO/gmrst4u9Ym8Ue625073D+b/cki7UvVxOzLJerg30/1DnLHrjLUh0ez+zZxFzkTX/ssFm6YE8wgaVeo+0XBTnERug4IKVMXGKxKa6KG/8wn79mZJkWUGt++FoHoqGhNSl9S9HXXsetlck7hsJL52EPf8dQzlrQO7mKoE2yw7X6ciQNeyq7de6Pjc74PPGkRjG2Mb9TtuZApiV26s0twzoXLhD6f0UQnTSw2qrZKrtjaByBdoyYVhH019jaGXrgO1woITB5Yjh8vyFtucvWDN7nZR2HTJg/bQibkVspZHbY2BuPlNstPb cVCoXUFq uNo5iS0EtxBX11vQKGvmnLb8tefoueFT76JSR6r58aGuShJYs7xxhBqfXbLH9+Z8xfyhNAFgweaoF4GHMYnueZY+LQsayu8QD3ZMLfewZ5hDNcOWs+RwKfkoXw4YG+B7Yz6+AqsttH0q/BfGL5IhjH6qe5n3I7E/BfNe8AA5AmVcON/3nC/qNlOinRG2AwIpOXMmIYQ9b45y6ffGQ7ChiKnpwUynKPZ4nlEj3d+Ij9yoziactgLV0X6LvqGsk2ewCl8df+CTi1S8+uBCmzjynCur/gIHN3vYpQQxZ8dvz7u7TmU5CwdfNOHparmNs1pp10X1zsPFdqHeKoyrjuUormnE1vbUTqty4M2/5RxMjJz/6qhje0OnVv4t4GNSR7oSA8m/t X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jan 3, 2024 at 11:20=E2=80=AFAM Dan Schatzberg wrote: > > On Wed, Jan 03, 2024 at 10:19:40AM -0700, Yu Zhao wrote: > [...] > > > diff --git a/mm/vmscan.c b/mm/vmscan.c > > > index d91963e2d47f..394e0dd46b2e 100644 > > > --- a/mm/vmscan.c > > > +++ b/mm/vmscan.c > > > @@ -92,6 +92,11 @@ struct scan_control { > > > unsigned long anon_cost; > > > unsigned long file_cost; > > > > > > +#ifdef CONFIG_MEMCG > > > + /* Swappiness value for proactive reclaim. Always use sc_swap= piness()! */ > > > + int *proactive_swappiness; > > > +#endif > > > > Why is proactive_swappiness still a pointer? The whole point of the > > previous conversation is that sc->proactive can tell whether > > sc->swappiness is valid or not, and that's less awkward than using a > > pointer. > > It's the same reason as before - zero initialization ensures that the > pointer is NULL which tells us if it's valid or not. Proactive reclaim > might not set swappiness and you need to distinguish swappiness of 0 > and not-set. See this discussion with Michal: > > https://lore.kernel.org/linux-mm/ZZUizpTWOt3gNeqR@tiehlicka/ > > > Also why the #ifdef here? I don't see the point for a small stack > > variable. Otherwise wouldn't we want to do this for sc->proactive as > > well? > > This was Michal's request and it feels similar to your rationale for > naming it proactive_swappiness - it's just restricting the interface > down to the only use-cases. I'd be fine with doing the same in > sc->proactive as a subsequent patch. > > See https://lore.kernel.org/linux-mm/ZZUhBoTNgL3AUK3f@tiehlicka/ Also regarding #ifdef, quoting Documentation/process/4.Coding.rst: "As a general rule, #ifdef use should be confined to header files whenever possible."