From: Yu Zhao <yuzhao@google.com>
To: Dong Aisheng <aisheng.dong@nxp.com>
Cc: Linux-MM <linux-mm@kvack.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
dongas86@gmail.com, Andrew Morton <akpm@linux-foundation.org>,
Andrey Konovalov <andreyknvl@gmail.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH V2 1/6] mm: drop SECTION_SHIFT in code comments
Date: Mon, 31 May 2021 12:08:48 -0600 [thread overview]
Message-ID: <CAOUHufZKRPP30ddVexvdN7-DrJ6EJ5Ty_wzE_OjtOwVGRpDmkA@mail.gmail.com> (raw)
In-Reply-To: <20210531091908.1738465-2-aisheng.dong@nxp.com>
[-- Attachment #1: Type: text/plain, Size: 1742 bytes --]
On Mon, May 31, 2021 at 3:20 AM Dong Aisheng <aisheng.dong@nxp.com> wrote:
> Actually SECTIONS_SHIFT is used in the kernel code, so the code
> comments is strictly incorrect. And since
> commit bbeae5b05ef6 ("mm: move page flags layout to separate header"),
> SECTIONS_SHIFT definition has been moved to
> include/linux/page-flags-layout.h,
> since code itself looks quite straighforward, instead of moving
> the code comment into the new place as well, we just simply remove it.
>
> This also fixed a checkpatch complain derived from the original code:
> WARNING: please, no space before tabs
> + * SECTIONS_SHIFT ^I^I#bits space required to store a section #$
>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Yu Zhao <yuzhao@google.com>
> Cc: Andrey Konovalov <andreyknvl@gmail.com>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Kees Cook <keescook@chromium.org>
> Suggested-by: Yu Zhao <yuzhao@google.com>
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> ---
> Changelog:
> v1->v2:
> * drop the SECTION_SHIFT code comments instead of moving it
>
Reviewed-by: Yu Zhao <yuzhao@google.com>
> ---
> include/linux/mmzone.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
> index 05cbcddbf432..a6bfde85ddb0 100644
> --- a/include/linux/mmzone.h
> +++ b/include/linux/mmzone.h
> @@ -1203,8 +1203,6 @@ static inline struct zoneref
> *first_zones_zonelist(struct zonelist *zonelist,
> #ifdef CONFIG_SPARSEMEM
>
> /*
> - * SECTION_SHIFT #bits space required to store a section #
> - *
> * PA_SECTION_SHIFT physical address to/from section number
> * PFN_SECTION_SHIFT pfn to/from section number
> */
> --
> 2.25.1
>
>
[-- Attachment #2: Type: text/html, Size: 2882 bytes --]
next prev parent reply other threads:[~2021-05-31 18:09 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-31 9:19 [PATCH V2 0/6] mm/sparse: a few minor fixes and improvements Dong Aisheng
2021-05-31 9:19 ` [PATCH V2 1/6] mm: drop SECTION_SHIFT in code comments Dong Aisheng
2021-05-31 18:08 ` Yu Zhao [this message]
2021-05-31 9:19 ` [PATCH V2 2/6] mm/sparse: free section usage memory in case populate_section_memmap failed Dong Aisheng
2021-05-31 15:06 ` Liam Howlett
2021-06-01 2:37 ` Dong Aisheng
2021-06-01 8:19 ` David Hildenbrand
2021-05-31 9:19 ` [PATCH V2 3/6] mm/sparse: move mem_sections allocation out of memory_present() Dong Aisheng
2021-05-31 14:39 ` Liam Howlett
2021-06-01 2:38 ` Dong Aisheng
2021-06-01 8:22 ` David Hildenbrand
2021-05-31 9:19 ` [PATCH V2 4/6] mm: rename the global section array to mem_sections Dong Aisheng
2021-06-01 8:22 ` David Hildenbrand
2021-06-01 8:37 ` Dong Aisheng
2021-06-01 8:40 ` David Hildenbrand
2021-06-01 8:44 ` Dong Aisheng
2021-06-01 23:52 ` Andrew Morton
2021-06-02 1:11 ` HAGIO KAZUHITO(萩尾 一仁)
2021-06-02 2:26 ` Andrew Morton
2021-06-02 3:03 ` Baoquan He
2021-06-02 5:02 ` HAGIO KAZUHITO(萩尾 一仁)
2021-06-02 5:22 ` Baoquan He
2021-05-31 9:19 ` [PATCH V2 5/6] mm/page_alloc: improve memmap_pages dbg msg Dong Aisheng
2021-06-01 8:23 ` David Hildenbrand
2021-05-31 9:19 ` [PATCH V2 6/6] mm/sparse: remove one duplicated #ifdef CONFIG_SPARSEMEM_EXTREME Dong Aisheng
2021-06-01 8:26 ` David Hildenbrand
2021-06-01 8:39 ` Dong Aisheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOUHufZKRPP30ddVexvdN7-DrJ6EJ5Ty_wzE_OjtOwVGRpDmkA@mail.gmail.com \
--to=yuzhao@google.com \
--cc=aisheng.dong@nxp.com \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@gmail.com \
--cc=catalin.marinas@arm.com \
--cc=dongas86@gmail.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox