From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA0D3EB64DB for ; Thu, 15 Jun 2023 04:59:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 302F26B0072; Thu, 15 Jun 2023 00:59:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2B3A06B0074; Thu, 15 Jun 2023 00:59:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1A20B8E0001; Thu, 15 Jun 2023 00:59:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 00A086B0072 for ; Thu, 15 Jun 2023 00:59:54 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id BD6E540989 for ; Thu, 15 Jun 2023 04:59:54 +0000 (UTC) X-FDA: 80903779908.23.E941161 Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com [209.85.160.177]) by imf19.hostedemail.com (Postfix) with ESMTP id EE81C1A0007 for ; Thu, 15 Jun 2023 04:59:52 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=5OjI0opU; spf=pass (imf19.hostedemail.com: domain of yuzhao@google.com designates 209.85.160.177 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686805193; a=rsa-sha256; cv=none; b=jkMpfAT2ynkn6MdGHh8q+LEtRKXMlOxxYCZXoGEpzPxs2/yv1yl7rZ6ccsE5EtedxgHXaK A2sRK/lb9fxk0CT1NwgqMoIOH0rfzmfb2jWrKuCPnL2nnb11YrkKsHJIhAEL+25+Z6k8RW l2Wt3jolHvsQgkXpeHy/x2EUixMRVfU= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=5OjI0opU; spf=pass (imf19.hostedemail.com: domain of yuzhao@google.com designates 209.85.160.177 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686805193; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KnSTeR3wugqfczOIo0WVbaWFbXtLzRyoPYMenUB46Z0=; b=GnrWNUWkRHBJ+KEiTS4OwE5N+xAobCnVNtpYAfEOpZRqv6KgSCbl4DRrutlmSYMgXpeFws lLXblydKEDlGdUgA3zIPUxMpR1SezZLb8H8/jhiF17crMtFGYo6MJBFnvcdRHQtaUbjbf4 8NddkqGYlhrKR+KPVy5+ZyuVY5TsIVQ= Received: by mail-qt1-f177.google.com with SMTP id d75a77b69052e-3f98276f89cso95051cf.1 for ; Wed, 14 Jun 2023 21:59:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1686805192; x=1689397192; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=KnSTeR3wugqfczOIo0WVbaWFbXtLzRyoPYMenUB46Z0=; b=5OjI0opU3eK26QBayVjzyad7e3zQbSFETTyJ8gesBTqvWCouRMUcqWOb9hmlwB+hG0 jPD7ZGihijI+AMvu2gP/fe4g8lh9DmonCbi3qwKm5UcLUr3Dqfcql5moAMOE1wOnwoUp 1ZfcdmgLaTxjmfJLtWw5tTnxnoaucjOpBn7IYXpAFZJCcvzeSMqml0lU24fuEw8vQpo4 onBXPGIhtGvDWiO8MOG4bS/THLU+e95uzJzS6/vSVhO1kC2VW/C3XPYI8hSog6QBs92G ySMbz8dV7JjQ6FA9WfPtZD8tukhSP7pWK9TtFy8wf/9xwsegh9hbvrnh/cAIe6h+TlOV 8wcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686805192; x=1689397192; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KnSTeR3wugqfczOIo0WVbaWFbXtLzRyoPYMenUB46Z0=; b=OF2CyTGv8YUDkzrZDSNzeo9Sh+SC7E2ALFf6naB9DfHW05pFpQto8H2cVFAFwQHIr/ 1WIOGzjQIHZGM6nHK+A33D2WM4KkVzXtYNV6+WBRngw8WYIKwntlZ3amp0lQB54yhoTQ liazsYn3NumHvcVSeX6Gc2vWHvBgxp7/RiYzqoCDtUUrnh25ehmQI1HISRvSnBnmdXTL 2F8slesCPWNlT/lX5lg6hP8dWL1W2cVYPAx5GhHI7p4Cn0B5RI7ywcxlAxZkg8OYAHns Tg/RVTWdTgsSbyKUbHNWOCAoqFrOMiuVtloV0sq0qnEpgA+OOGsJtaDSRolYUyrAdWUW LkbQ== X-Gm-Message-State: AC+VfDxAKuUlbL4rdPA1udANdVoo5u8Zinl5CFdGgn6kKlJaa3mVGJF1 KAPBNTOBAqf1nVcuSpy2sx6DFUeoBCQhOB+J13ldbQ== X-Google-Smtp-Source: ACHHUZ61RHaTwcXA7SxcW9tOHyDHq6/O4mrfOyD00XOAdsiYes1CNQm70NgDMAabZum3DNA7kXrc7QvcZ6/LvcwY3OU= X-Received: by 2002:ac8:7f8c:0:b0:3f8:6685:c944 with SMTP id z12-20020ac87f8c000000b003f86685c944mr80467qtj.14.1686805191933; Wed, 14 Jun 2023 21:59:51 -0700 (PDT) MIME-Version: 1.0 References: <20230615034830.1361853-1-hezhongkun.hzk@bytedance.com> In-Reply-To: <20230615034830.1361853-1-hezhongkun.hzk@bytedance.com> From: Yu Zhao Date: Wed, 14 Jun 2023 22:59:15 -0600 Message-ID: Subject: Re: [RFC PATCH 1/3] zram: charge the compressed RAM to the page's memcgroup To: Zhongkun He Cc: minchan@kernel.org, senozhatsky@chromium.org, mhocko@suse.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Fabian Deutsch Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: EE81C1A0007 X-Stat-Signature: c73t4h91t64o54r4ja7ua7buzsgefgfg X-Rspam-User: X-HE-Tag: 1686805192-885667 X-HE-Meta: U2FsdGVkX19EoK8jedaHvgNPBvprvmbAuclg39jgDNkhJwU1a18lMRGBKNvlwECb3iRoqH9ebPowNuNEAtt6VhMdTBOkjMRk8LM8cZbBUZl88QuRIUAO1aVAHJnFTL+pTQ3wZnF3SVKBxAGJM7dMBgBVui1kaVMNcUdeyspJ3vWOmdCDJBd5Hna3f0ifpDmgEoj7162jmCr1Dz1WYdw82yX3D/CbjaLI+TppLwZvLL6QULCCe5Hq80aZvMwqHOwyJEVefhaGmqfOWRGx0g0eWIY7Upsd5f2BEr9ZRjI7lX2Uz771SN8SQRQOdvZ8//usArF5XRk8SZ0m/Bts8toh2eQ4KpDKeOKqW6SZv0an15LVqjeob1YflSsdyDEHNNL1w2S13O6k3QSxwKDdhnTCkFtAWvBe7G49tWPvnV8VprcIq+LuGLruJZpYzba1ybr/HSDM93A8NqYfSGC2kbzm/0joZZB2DOJmSp18z4AuG30vn+9ADin50M4dAL8iD7Lf7PczFvZeHvU62GBmHmNdF2KqZrV26bLl4gMMU8KKRcKLoAu1mG4fa+GGc2ZKh5aXFqnTuB1cQR9+iB38AgVmHoPCXiRVnXn+gpDiWzbXRl5JsHvA8mznDZCZY3fkd6WBXAEKwJTkY5raGRx12UhOym9jy4yNp6ZxMTWOyFUanZXeZhcou8m2+yGw9X2yq4XoA1A5uJPF+texRGU6+P+p8Qvo4sqPLHCOvam73Zw6LUX5MOA44FdpmAQqAooqK6FwZKuj/n9ZecSb5lAY8UlHGvX0b515JJ5moSvg5MasiQdqgZSVZb+kgOdrjkco+vCVM+6ma55ZCJqUtYEEs48ay90MPTEPd+qLEZ9utbp1f6yfaplNe11MF0Cxj//1gOJk9yu+/2o9Hn1KOuQkTg8TeTTDzWFbsBaQI45bVmnVEY4BY/F7cWcgVY4AKnsdHf1vpmrhamWSHOI7OU73cEz vaQUw4g4 eM9M/b9wV/1Bw8fqW4qRJQHRNV3+CPMnwg9cbMn3ntr4oF0LMQohCMxiFdlDn/zG3Dhf/1FDmQbQ5FSPsjD+2rTAPV0XxANqnarvmaJZYMY4HzWB7IBTcEmB7ygV34Hz25gf0i5Zmb4GU7HweQSAvZ8g5so7mdgMP7+65DO1r/gi42duAQZGldCMgCizt5lz/VH1E32Nmgd3H1ybyMJqTeBZT51NB4JVLsbiJAtQEZdn4TtlUVIlC5DvQJKevNdidt10C1qtuxnPtMersxm/nqz4JY+ab458gW1igIpTq965oiX9/ewpHb8mzHrpaW9lYhQCbU+rgMiuQZXycYoZ+LWQsSg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 14, 2023 at 9:48=E2=80=AFPM Zhongkun He wrote: > > The compressed RAM is currently charged to kernel, not to > any memory cgroup, which is not satisfy our usage scenario. > if the memory of a task is limited by memcgroup, it will > swap out the memory to zram swap device when the memory > is insufficient. In that case, the memory limit will have > no effect. > > So, it should makes sense to charge the compressed RAM to > the page's memory cgroup. We used to do this a long time ago, but we had per-memcg swapfiles [1[ to prevent compressed pages from different memcgs from sharing the same zspage. Does this patchset alone suffer from the same problem, i.e., memcgs sharing zspages? [1] https://lwn.net/Articles/592923/