From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87AF5E6F06E for ; Fri, 1 Nov 2024 16:55:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F31A16B0082; Fri, 1 Nov 2024 12:55:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EE1FC6B0085; Fri, 1 Nov 2024 12:55:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DA8C26B0088; Fri, 1 Nov 2024 12:55:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id BAB526B0082 for ; Fri, 1 Nov 2024 12:55:48 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 653541C4ACC for ; Fri, 1 Nov 2024 16:55:48 +0000 (UTC) X-FDA: 82738127136.22.A601BFF Received: from mail-vk1-f182.google.com (mail-vk1-f182.google.com [209.85.221.182]) by imf25.hostedemail.com (Postfix) with ESMTP id 2A534A000F for ; Fri, 1 Nov 2024 16:55:25 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=ZBD7ITHl; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf25.hostedemail.com: domain of yuzhao@google.com designates 209.85.221.182 as permitted sender) smtp.mailfrom=yuzhao@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730480090; a=rsa-sha256; cv=none; b=p6phP/qj6ERsctLqyL+dIswnsLKFPBXFab34CL2J1rZ8xtC6cvORRHgry9/stEyShZ0XwY gVNRfO6BgJbeJvm2HrMf0OYnuwSkwMYk4c7+teTPigV0VlCJFk2krg40X/PSWwGohn3VMY R98B3DhRLL7fLOKMPnlkDu/Fclut46c= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=ZBD7ITHl; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf25.hostedemail.com: domain of yuzhao@google.com designates 209.85.221.182 as permitted sender) smtp.mailfrom=yuzhao@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730480090; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Rgoz85RyAEyVb43zEkPR5VrDGsaUOIsOPq8nppTbaQw=; b=rd0z2AlUSKujUK+IFsgH7dvGv822hqCg5UIgr+F/oaLBQuDIuy/ybUgsX4Q23RmcpNPfth pGEeavXDvwumL2BaS3sFiSgFP9Sb5qlYIyqne1bqTqMyoOSN2yD4lAlfmlZcI/nC3c92JZ l5w4yQUaszc89bzQhpchHgb/gkQM0gI= Received: by mail-vk1-f182.google.com with SMTP id 71dfb90a1353d-50d34db4edeso988770e0c.0 for ; Fri, 01 Nov 2024 09:55:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1730480145; x=1731084945; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Rgoz85RyAEyVb43zEkPR5VrDGsaUOIsOPq8nppTbaQw=; b=ZBD7ITHlCvNRVRpYpgaaBl5HPiLs9M9QNntOcbF0zF4/o0ZBoV+P7HOrCuYrWXk1yE UIi7avZbjLfymTa2U/HVY0Tts+Wpa0yQI/jASyqMbCp7QwZOBD438Ctwm/Fx9Ku3VhYp BPn3T7PO9JRnHtcGndUxWBfbBoxrG2gsj5rmCZvvOTna9QgBiTB0Girm+BAh3zT9hZAq K8xyZKprLp21p8TSQkRlV5B/ffLMIQh/82fElYGCByXgtB0JfFWTjKA6f/O5I0EUTv3V J0Ep/L5MwbpU5qkNdTiPwa+NYdvDr1MOeck5P5KXv1EB0ZZ9vy0ZqyqoSN8qwSQbh8M3 B4Og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730480145; x=1731084945; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Rgoz85RyAEyVb43zEkPR5VrDGsaUOIsOPq8nppTbaQw=; b=lBUe2kWe0ELz2gCkdPphXJ8Y/FqGzCwqui6mm3mx91vtvv3V94x+tlHk8AyeQRfE0Z Y0y3PPC2Nh3CsdfIIGo4rVFqmU+U/i2eOyrirS0iClF0Cbi2kqnsQZCTfxFhuuVpyuSA enXu9nD7Uf+2GqAM7b7tcr9phugFxVgDhKOBu4tpouFNBQE97q6B+aC8PIRgllujraNk 3X6obyzFub8qyhINTwP5OXxYVsgejsV0N/wfjYk0XqGvyBz0g8a1gw/FFJjY8ZStKo6a Jq/o0EPWUaxvKRH5wPSLfrxPAMzevqosxr1tSiEtKInaDkIk817rptb+zCKtGpuNSo4E 06Bg== X-Forwarded-Encrypted: i=1; AJvYcCWzLK/j5z1vXdMXcPdtJsd+oD6ENzWUrkzHXa7PDBwSFotAH/yO0paxXW3ZWS/ygs+agE5+Gc6AcQ==@kvack.org X-Gm-Message-State: AOJu0YxG4jyYN5eZJlhpLi/DDNb14BwshfMeqnvfukjEx1TrUq7un8pD xWuicuJrg+fw41V/bPrPUHV7gZh3vkB9Bvdpsc2ecWNH4YvxbGiEv7as2qOEFTYvrJ0JO95KcMj hKLfjaFwui9vmc8VZAS4dg8rvv4LrSKtkjrAb X-Google-Smtp-Source: AGHT+IEJ6lugV4pd2uUxjmqGcgTZnScesaGv25qSw7yd5DxNmaoci3Z07vOEnucJX8qN7wAzcINKeoccOUiFU80Mm4k= X-Received: by 2002:a05:6122:3295:b0:50d:530b:6c0d with SMTP id 71dfb90a1353d-51226c9a7d1mr4516046e0c.1.1730480145302; Fri, 01 Nov 2024 09:55:45 -0700 (PDT) MIME-Version: 1.0 References: <20240229183436.4110845-1-yuzhao@google.com> <20240229183436.4110845-2-yuzhao@google.com> <2352282c-e96d-bd17-7591-9012e3b341dd@quicinc.com> In-Reply-To: <2352282c-e96d-bd17-7591-9012e3b341dd@quicinc.com> From: Yu Zhao Date: Fri, 1 Nov 2024 10:55:07 -0600 Message-ID: Subject: Re: [Chapter One] THP zones: the use cases of policy zones To: Charan Teja Kalla , Barry Song <21cnbao@gmail.com> Cc: lsf-pc@lists.linux-foundation.org, linux-mm@kvack.org, Jonathan Corbet Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: 2A534A000F X-Rspamd-Server: rspam01 X-Stat-Signature: yxbs9aq5tw7dnbi9pb8xpssmrpih5cxx X-HE-Tag: 1730480125-273814 X-HE-Meta: U2FsdGVkX1/uB9X1gQXoULlec6lF0TVRTd0V3fNVpNbeeRTOpmO0SDYFFGMq4Ng+lJwWf/HUiTqhpwyjGKDy6IgIzgXQYulpYKikLxEZ0LSdYGL0CFCY3Xa+xtVXwfwo6uvC0+S6A+wtufAU/ESQoAy6O0sLRonJ/WJq5BQWTC0LAZkLXZmtwf0y9RSzo7rkdxRT1+9Myg5wRmj/Qgvuz8jitS00A1t1747KIYBiqtWzG+E3llDtsSMEUpDcnVS44CSQvPgkzS7q6VJHPCK7RBRwSPj7v0enpPwKuOkqc+CBgqqO0B8UEYcj0ia1oihersP4A84HbG5ia9huhxrlEmvdBGXtSdpF41oZIVmmKOQuGQPXhyPwaVFm6UsB+LTspIbaZ050dhtplp92XNoDCJOO7Zdeiqz+mFsXA4pkwoKiLZkuoYAfVuwhOqi3HFJS5nCR+p1JN76XMAgwzlW1SSGiZfPeGEW+fvsu9WFirDJ0l+baewPkS2ciCnrkyCq03uOBt4CImXlZkrRweCNMu/HRFuUzUM++vdOcrN1Nh2ikKIV5BVIQuBKOr+VFcdxns9S12xUs7+ZB1sXUOipQ7WI4SKIIWQ8mKu7OEFbq6806m6o1FL+9WKS/HSsu//I1LFNfqCIaZIM39ixC5soOf+RAxxKQ7NnL8J06PmbB5EUefhaDE2Qr2uTS22W2WyT+8N7HO2OAdRDtuz98tIuknW4uqU1Q0NSZeNZiTGjtzkBxBGzHfMtCWqnHrHkyPPIdt6dLgB45LvVbZpabbbQ7KP52l2uBohHwKuvNhjQSsKHbaegezocms5PeI+ZpmQ/D+1ghgknF3lNjSnUeQMGcTiLPZlkoz8kx0MYaTl+KVB/jTYjZ5vDqeWAg7AUq38ja+324FnsVBEybuRoYLWS0vpBdLXYcmuOjMu/Av9O8XM0x70/tGH50Qd/ZM/aX4CAnCZVY0fVP+lNcCAKf89W DaFEqQ+q OBVG2qWT13B7Q7CCKcaQEKv7eJPvDmUb9fexP2PNhoyJhG2FGDCV5P0wpd/MdSpBTM8JC4j9HYi6NEIpYgN8hhbNXs36HUtHnE6bKf99M8ETwCFIYOM32A1pMjRoRPvuw84EPbw8E6lutrBXyrVptRy0pArYpk2vSx0AgnahCCq6nxjBlMCGQv/b1TQWoL0CRxulwmzxMqHYkGjqDnfMfMAMnFU7sHPOl/2LUs6y7zkn930VSsl2qv2uNFQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.027228, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Oct 31, 2024 at 8:35=E2=80=AFPM Charan Teja Kalla wrote: > > Hi Yu, > > On 3/1/2024 12:04 AM, Yu Zhao wrote: > > diff --git a/include/linux/gfp.h b/include/linux/gfp.h > > index de292a007138..c0f9d21b4d18 100644 > > --- a/include/linux/gfp.h > > +++ b/include/linux/gfp.h > > @@ -88,8 +88,8 @@ static inline bool gfpflags_allow_blocking(const gfp_= t gfp_flags) > > * GFP_ZONES_SHIFT must be <=3D 2 on 32 bit platforms. > > */ > > > > -#if defined(CONFIG_ZONE_DEVICE) && (MAX_NR_ZONES-1) <=3D 4 > > -/* ZONE_DEVICE is not a valid GFP zone specifier */ > > +#if MAX_NR_ZONES - 2 - IS_ENABLED(CONFIG_ZONE_DEVICE) <=3D 4 > > +/* zones beyond ZONE_MOVABLE are not valid GFP zone specifiers */ > > #define GFP_ZONES_SHIFT 2 > > #else > > #define GFP_ZONES_SHIFT ZONES_SHIFT > > @@ -135,9 +135,29 @@ static inline enum zone_type gfp_zone(gfp_t flags) > > z =3D (GFP_ZONE_TABLE >> (bit * GFP_ZONES_SHIFT)) & > > ((1 << GFP_ZONES_SHIFT) - 1); > > VM_BUG_ON((GFP_ZONE_BAD >> bit) & 1); > > + > > + if ((flags & (__GFP_MOVABLE | __GFP_COMP)) =3D=3D (__GFP_MOVABLE = | __GFP_COMP)) > > + return LAST_VIRT_ZONE; > > + > Not sure If someone had already reported this: With this patch, we allow > pages to allocate from movable zone(through fallback from > LAST_VIRT_ZONE) even with out __GFP_HIGHMEM. The commit cc09cb134124a > ("mm/page_alloc: Add folio allocation functions") sets the __GFP_COMP by > default and user has just to pass the __GFP_MOVABLE. Please CMIW. Hi Charan, I don't remember whether we have this fixed in the Android kernel off the top of head -- I'll ask Kalesh to take a closer look and follow up with you. Thanks!