From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F14EC77B61 for ; Sun, 16 Apr 2023 07:21:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0E83D6B0071; Sun, 16 Apr 2023 03:21:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 098BE6B0074; Sun, 16 Apr 2023 03:21:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EA15C6B0075; Sun, 16 Apr 2023 03:21:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DACF36B0071 for ; Sun, 16 Apr 2023 03:21:16 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 9C99840141 for ; Sun, 16 Apr 2023 07:21:16 +0000 (UTC) X-FDA: 80686408152.25.10F41DC Received: from mail-il1-f177.google.com (mail-il1-f177.google.com [209.85.166.177]) by imf05.hostedemail.com (Postfix) with ESMTP id D700F10000F for ; Sun, 16 Apr 2023 07:21:14 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=7m3mqhjF; spf=pass (imf05.hostedemail.com: domain of yuzhao@google.com designates 209.85.166.177 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681629674; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aLEQTsqzCVRCUPiGUlNa/vQf/juGQHTnx9NiZ9KIoGE=; b=Uk4yaIrD9CY5Vet9wCQpqpiHIIczF98yfEaLPvCLtXbfQ2Nlr7v2wOpGzog/4s8LJjCdza B8bdIhp4RHFVSpyKQ4y6168I/vAMEjMYxwJzN5pmRRPxwYdd/jC0/ev6zB/j5bm0qIpkvk mFQ4MvOcxDI9e5Jk25QHoOk6ujFPV5o= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=7m3mqhjF; spf=pass (imf05.hostedemail.com: domain of yuzhao@google.com designates 209.85.166.177 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681629674; a=rsa-sha256; cv=none; b=b0nFGjkMDTZfvn1pPeOVARDGpdRhAGXVsDJjBHV75SJenNzIKhuYfG6J8KGJ93g5jiNA3c sgtejIgqKheT40BSwcMK50M9NC/n+wxcF2FTV+z+PhsflCndTXGo0lwOFbz1SxuksTCr/9 YrNreKZm4Zm6BtjKW+ZM5M/tNMoIAFs= Received: by mail-il1-f177.google.com with SMTP id e9e14a558f8ab-329577952c5so435335ab.1 for ; Sun, 16 Apr 2023 00:21:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1681629674; x=1684221674; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=aLEQTsqzCVRCUPiGUlNa/vQf/juGQHTnx9NiZ9KIoGE=; b=7m3mqhjFjn/sQucXGVwMV5Pyau6vm8qKgpT712mQJFrIBM5ljzDOZbdIKgVYAmLKT5 jhe3/9dXIZaVEz5nHQcxXCwgfGUmvGa3A1tiB9uTeVnIyMYeJjzWYARx6etheiSYraFE 6HfRLguVuveOvirylb1zzx3EcZmBVuVVszBT5cMsWRDKRLzCOkpoOrrjqpi6YWWgKB1R /3DakLtX62B9rZi27dsIKz5/ywG29PKYI39/GyUhWiy4Mx/cEPdWRO44s3YE2V7T733p AcsthrKI2lfG3JQCoNYD8yjcJTZQvotxo3R3a7ziy/cp3aSL/VmzG8obu2IC8AF5wG+E W/UQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681629674; x=1684221674; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aLEQTsqzCVRCUPiGUlNa/vQf/juGQHTnx9NiZ9KIoGE=; b=hfKiVYmrIvRNzz6H7z2KhaCunUuHDS9kjszfL6GEjGT0exj7dOG25KwF2dQ/+nsES+ 7b9uFWdiWp7tLH+TMLpxzrHftd9yZ5K3EJBvTkUaiRcMU+AmgqD+FrmtHREriyXbd0O6 eRjpHAtTqtvevmrLIYtJZUuIb+8H/Px8blVfeABPVFTg9jAr3XZIMlvrPB6EPOAGbN5e wpy0HJ2rpaL0FpjQxUjkoVsGzjBbFAPaf/0b3fCc/F1i3x/CEAolDPnVJd7swI8yPD/o ybHC0dH8YyPvCgjo+zqqpbu6vVARGTe1rTiI+LEGMpxbUA/p07FNqujb2HxbsO8hm5lH UYtw== X-Gm-Message-State: AAQBX9egsMmhuDIWbHe086zzV/uB/sQ5OnU2IkPCW3RaJzTaoMR+5xST IOhjRs4aTP4TpH4MwSaZPPJBh2B8nmNqNQR5QKkYMw== X-Google-Smtp-Source: AKy350az7d9NJOT3IqdR8km3o0Zj2SR3hy8JSwCFtU/L69vtqoCH3RWX4MMgyhNC4eBhfnYYTlVVzL0fsy89/SzASRM= X-Received: by 2002:a05:6e02:2186:b0:32a:dc6a:3b97 with SMTP id j6-20020a056e02218600b0032adc6a3b97mr159138ila.0.1681629673725; Sun, 16 Apr 2023 00:21:13 -0700 (PDT) MIME-Version: 1.0 References: <20230304034835.2082479-1-senozhatsky@chromium.org> In-Reply-To: <20230304034835.2082479-1-senozhatsky@chromium.org> From: Yu Zhao Date: Sun, 16 Apr 2023 01:20:37 -0600 Message-ID: Subject: Re: [PATCHv4 0/4] zsmalloc: fine-grained fullness and new compaction algorithm To: Sergey Senozhatsky Cc: Minchan Kim , Andrew Morton , Yosry Ahmed , linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: mztuqxttbmh3jb4bgr7uwui3er5q6aah X-Rspamd-Queue-Id: D700F10000F X-HE-Tag: 1681629674-724948 X-HE-Meta: U2FsdGVkX1++TY+Ywy7jVxsll2F+qaTeCeGX0OrnokMWKZquvVJixD6cs1qk8kBigD1XBYaAwfe7rFbW+lFcHvXdLXSBKFfwnSTirS57khixqH2m/a8a82hybvFRZoATI6GsYDlLy+3V4CZmeeMDP1GDmGbthZ1dZPwenKqqofzCS83U0Z62bcrWNpX5X9q2n30Z4/Q4/EwhQl7U+5XX/f3ngxMJLUH4kIZT8CjCYxE3oCpKnpWSnp0KwngiHgXyfpaBNeLL9k4UlyiUZIFnshrInCujj1YWE9XslEmyHqZfbg0L3R4RJVJJ+mzf0uq/DBBUdPcF6cDBbmrhxmB4ui3dQZYsmjFFFxkX6ab6pXT8bwpy+PS/g4WzvmwQhJcfpPByUzotUcxZXsgGG19PWW1cVLmfs967yEC6GXHahEgLypCs33WeiBZbY2nhzc14OZSN02WqzHN+SEWB5O4fqQDC4o2+bcxJoO66GgH1cg/fLmoQHX+hc4lkm/9yunGHxSHHWh5j8MgHRi516ra9qlvDRhaX1MTdzVDxbFZatW4wUt5WRPFITdMi/cs9Di2ZcusCbrBxK85MS12f1OyYeHyGOyuMqaOhodkXsAHcYJrJdPpBiyXUFIdWH0qmV69yE/j4AbHBL8O9lWdXK2Q6KYfVT/TEEC1CjAJSnZO4GlUa6BClS+QU90zSmiLbN99VV88AaoLAi3QIcG3d9taTkr12HxHAhZIs4g+0y+YZMgRZZ/B9xZyrwYKM9mIHizd/MP+L6/F28bsJtyvHp9shRJ707J6TjlvxOo9EAQNYf/yrcn3AxsprYCt4SNxQloc+YKlAzAgdGQZScIAxde1P+iEqfLDZbARQdCzfgM2QFcTOKsymGiFNI3uZV2u8ncVPWDcjklcASuLGvWpNH1C1aMV2MsUTFKOPis4y5v6aLTo7tCmKFLxCMQRjrlABwJB0bGYnz3SUuj4bzHOsGeo P7qO47Bg q83Tp92TvB8kQcpq1V9PEmCXQIBQEzuRPWuMULSBvSvgG5jbRmlY+qPEmqNqEsBsr1X+kNIdJUfBxwKx9GAvjTYa4njAA4uvq7dN0Nvt4Wue6j/UPRK9XjgbUEuzbQ7N5PJHK0+Yd1izi5DGPHMTD356yoDEr1UHiK3wXQoXril6tVusaj7GKz4jJOt6vUUGCWK7FtQ2vB2/4DZDd302WBQvXlEET9813R9VkKIS2ADhHKpYq9D31IGPNMaymTmuAfGPHUKgzp/+YVrI7lMGwkBqw0KthGMVIRe5eQo9KjJ+yhXbu+118JWe7BUhK8AeZvfK94Rgly20ipuZKvxMGcU92Ww== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000246, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 3, 2023 at 8:48=E2=80=AFPM Sergey Senozhatsky wrote: > > Hi, > > Existing zsmalloc page fullness grouping leads to suboptimal page > selection for both zs_malloc() and zs_compact(). This patchset > reworks zsmalloc fullness grouping/classification. > > Additinally it also implements new compaction algorithm that is > expected to use less CPU-cycles (as it potentially does fewer > memcpy-s in zs_object_copy()). > > Test (synthetic) results can be seen in patch 0003. Seeing the following crashes from mm-unstable. Please take a look. Thanks. list_add corruption. next is NULL. kernel BUG at lib/list_debug.c:26! Call Trace: zs_compact+0xbf6/0xda0 zs_shrinker_scan+0x19/0x30 do_shrink_slab+0x1ac/0x450 shrink_slab+0xdc/0x3d0 shrink_one+0xe2/0x1d0 shrink_node+0xc7f/0xea0 do_try_to_free_pages+0x1b5/0x500 try_to_free_pages+0x396/0x5d0 __alloc_pages_slowpath+0x5d0/0x1030 __alloc_pages+0x1de/0x280 __folio_alloc+0x1e/0x40 vma_alloc_folio+0x4c0/0x530 shmem_alloc_and_acct_folio+0x1a6/0x3b0 shmem_get_folio_gfp+0x689/0xf00 shmem_fault+0x81/0x240