From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6928C02183 for ; Wed, 15 Jan 2025 21:52:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E12D5280002; Wed, 15 Jan 2025 16:52:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DC1ED280001; Wed, 15 Jan 2025 16:52:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CB153280002; Wed, 15 Jan 2025 16:52:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A7773280001 for ; Wed, 15 Jan 2025 16:52:21 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 499701A037D for ; Wed, 15 Jan 2025 21:52:21 +0000 (UTC) X-FDA: 83011035282.20.2244223 Received: from mail-ua1-f43.google.com (mail-ua1-f43.google.com [209.85.222.43]) by imf12.hostedemail.com (Postfix) with ESMTP id 869C440003 for ; Wed, 15 Jan 2025 21:52:19 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=spcfxRUH; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf12.hostedemail.com: domain of yuzhao@google.com designates 209.85.222.43 as permitted sender) smtp.mailfrom=yuzhao@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736977939; a=rsa-sha256; cv=none; b=N8B3V6OaIyXXfEV6klyg9kuDB6PlF2hM45S6Hs6JITTjitduB/CDVgXRnnvIHMdAdcFea1 FAYCxnqhDUIwcq/nfItQUlpgIblu0mQ9GyIMEfEZmtHPGktTKWKH+wQj6kWvoZ+qDrTq4F jYQfkCaBqioWI3y9L4VMc++1AD6sQUA= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=spcfxRUH; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf12.hostedemail.com: domain of yuzhao@google.com designates 209.85.222.43 as permitted sender) smtp.mailfrom=yuzhao@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736977939; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gBoocj/o3i/RSdo/k61FcSwF9FfCsAQoxz57o6jOsZU=; b=b0dBgxtH1qyFcanPF803UKO3T2NdZz0QgtZle6hae+J+N8ZQgIEoGr+bQLoQqG2hHWbVIJ ATe+jcOxHdN3jXphFTJZmGoduNXO2hkZBfnxiO/X9SKe5MP6l20YlOq8/HD4yf4u9FgyOF cXaSIZbcFlz5oIZhk/86rGocBFtQNmM= Received: by mail-ua1-f43.google.com with SMTP id a1e0cc1a2514c-85c4e74e2baso34270241.0 for ; Wed, 15 Jan 2025 13:52:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1736977938; x=1737582738; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=gBoocj/o3i/RSdo/k61FcSwF9FfCsAQoxz57o6jOsZU=; b=spcfxRUHa+cbnIQmZdG6b1hHsT2BPS49UlFFpct+5q/NiH7OR7rk+sTzQWy3r1u6// G6juSp+DKa7h6YSTRvBUSwDhhTBhq7gB5bqWmIktCPeS598b01cT1HfC9Yr19G/5xS4M yRjevn41kYDhD6qIOHdVfKJsMo7dn3DifhLArhPJwldTanAVRrRxFLT8xo4yDpeTGUI9 VeY/6Dzkjn1UdQGEgXQSgTjk2hVWUZEXOu5eI7LfmbL5x4RuCtWz4tttPYAFRKsRCIRZ NSEubg2KqI4MuUe5ui71IYX+J6qY3O28vgqT1OvLiFRVuQOMNoj5B2Xs4Ny8uKh+B8Mp 8SLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736977938; x=1737582738; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gBoocj/o3i/RSdo/k61FcSwF9FfCsAQoxz57o6jOsZU=; b=BC/lJDa3rmHu71m9cFvs2Tm3zFeUROjgM30JYIgqhn5aJCjsVUEShRscqdqy0VP1Mj 1+s+DConwThGP4j3Nv6fBKkdLF9M9aZAWHh0JYFEIFtIhRa8luHjS4Zterb6cavdncRx FZPy/4WtTLwsvap70rVsslDWJFUXugAQKlFdAv9fdAhr2TMFm+FQv41/S5QJhP9DmzQ9 WwIc5J2x3W12zxr2XUKqhpUkRFcAaAPwOIMivqTpC9Wh/mqfyJ0/VrX0oXPlkTIw0V56 dtw/pc8xKE/WwgMaYTS6JUlW2n3aXMiQXqt3yr0OokjoazpvFvTk6FqMtv2AKyk7+1I5 RguQ== X-Gm-Message-State: AOJu0YzAMrvDj3/+HqMwB6U46MxjLf5OHxPWXKeon3nFhUcdMmhaP5Hp pc0OmmqcVlpTGc3BQDLoAS2ISXe8BUfL0bslWeB/xbzHFcU3IN0GUEvZDiJ8PMIsd2PQHwwDi0M ZG1uW8pi18Wr889A35P5qiZeSx65N4hMrPntA3+tpTgAu0bwjBw== X-Gm-Gg: ASbGncvgVXiz/AwPCa4FDHdhZR2GNCNDZCni3G/xzv7vD4qR3PyKzF0ffB/nCgJmj4Z tS+NMxGUB33VabkFBm51ItegMhTTvyTB+39rFvRjdsqLTuno2GdOgKJjyQto4+5tDKMNW X-Google-Smtp-Source: AGHT+IGJn4jwUG/YK56vpT6RA1tKx9BrKYCrIaKMcMkmDIYCRSxVoZif4KhyxpbheZb7EepOmABGAhLFz7JguTpZD3A= X-Received: by 2002:a05:6102:38c8:b0:4b2:c391:7d16 with SMTP id ada2fe7eead31-4b3d0f90aacmr27395694137.7.1736977938486; Wed, 15 Jan 2025 13:52:18 -0800 (PST) MIME-Version: 1.0 References: <20250110122133.423481-1-lizhijian@fujitsu.com> <20250110122133.423481-2-lizhijian@fujitsu.com> In-Reply-To: <20250110122133.423481-2-lizhijian@fujitsu.com> From: Yu Zhao Date: Wed, 15 Jan 2025 14:51:41 -0700 X-Gm-Features: AbW1kvbnnlBO4bEYUoRVVJ6jcG-Rd9kfprgf0zfQqF5Q10Siuf6FSaJ8bGurnEM Message-ID: Subject: Re: [PATCH 2/2] mm/vmscan: Fix pgdemote_* accounting with lru_gen_enabled To: Andrew Morton Cc: linux-mm@kvack.org, Kaiyang Zhao , linux-kernel@vger.kernel.org, Li Zhijian Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 869C440003 X-Stat-Signature: 6dxfsab9ydcpyham7p7apithiguunwec X-HE-Tag: 1736977939-288585 X-HE-Meta: U2FsdGVkX1+DVXUl5xTZ8Ry5rp08kx1JpWzi7kcQCi1P15lwbtPQeKyO1SSjleBI87cQjPNE7yDFqNDnSclOLWqE4fbX8MpZ4n2j+BicsuIzLYwONukRcY/psfNFp/pltNGW9g1CaXxY+MyuQi6eoiB4YuPHfg4z8xajC6UWBmnhQJSg6jiFDVqsPHPwsAWrDBg4yUCdsPURzND0G2G3aqMXcz0M9JLQVrtCl5wN/fBz73AvrTHIIOmdM9QnlxIqLPGf6Ccr60zvP4pvasqk4EjvIifhBqatphoXT6Ia00aLziw1gZKB6CWexf948Pxtux08r9Boxi31x6T1fWQWVRkZ/P+zHpJLlcud0YUUxzPIfFFELf6waacOLRKEh6X3oiBtoBue+THxw72427GcbaptCRpeWFOy5BwBYsnBKpxql/wVNDiTddFh59c55+i8VZG/y1KvISQ1nTATlLOOIequ48m/Dv9gg7GMHL1y3O01iQbBG6s+x8etAdfunHbPqlHmMQ/kMkkIJCJunPO0h22vOBILV0rFQMRtIWejikx1/FM851+Vdxttqpbue9pWwlHk54Uby2FlJf4mFr8OADbOplRm7AC8DDUx6SN06ZZijX3bsURCICgLfSWJpzZ2v0/wpqDhBWXZiwEXVy6SXV1ew5jlvQGyidda/kVGDE+yKtgEhxXisGX5Q/1aDKx71jDpqbHLqm29V13+w5NYt5K0h7Z7507nd3IAw5fxkiD2UHdTlxUP+78B++4BpdGBcMNj8wVlHCmuJnZZZW5c7D5t8x8QJdYtPFXlq1TIffh0nViGlEDbCqe7EtqielWs23z/ZQne/im7r1oopDnbaEqDqHX9e4nQzJ4QbuSzPmG15HppbsgKdVRooSU7R6ynDHvKuSmBvlpFXhl04x+xPW0w0ltEjgLDbuHMpZoxYZqXwtjtJLc64F1+4P4oCaRsqe0K9uDSQkQbaxKEihE 4Ly7Ocl8 MEfLOzcv1zc2uu5X74Z5W+6xdk3EumhEnXdMHZ5fkDZV44OZqKZGZW1r4dIPJi5ADYbfyX3PrP0JzKVHkGbmFN6HslGg8oTA3eWAvLbSLsGme8gIas88Dh0zXXBwhhq/luOaMbdBXo7X6rPzqV7hZMnbBDPBUdqGnJmbIxCay8iBBupaYsk5SC+Wa81eVDyvH/afxBSHZd7sAMaQOTEa5ahqKrivgMK5vPtfU7LOq9tNavrmSiD+oDsRfQ0X7MzhF0bUlA4a7ijLaaNzJd/jSTep8trMHWVaEgYHPH9biysX9SJW1JNpbf2SBZw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000951, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jan 10, 2025 at 5:20=E2=80=AFAM Li Zhijian = wrote: > > Commit f77f0c751478 ("mm,memcg: provide per-cgroup counters for NUMA bala= ncing operations") > moved the accounting of PGDEMOTE_* statistics to shrink_inactive_list(). > However, shrink_inactive_list() is not called when lrugen_enabled is true= , > leading to incorrect demotion statistics despite actual demotion events > occurring. > > Add the PGDEMOTE_* accounting in evict_folios(), ensuring that demotion > statistics are correctly updated regardless of the lru_gen_enabled state. > This fix is crucial for systems that rely on accurate NUMA balancing > metrics for performance tuning and resource management. > > Fixes: f77f0c751478 ("mm,memcg: provide per-cgroup counters for NUMA bala= ncing operations") > Signed-off-by: Li Zhijian > --- > mm/vmscan.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 430d580e37dd..f2d279de06c4 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -4642,6 +4642,8 @@ static int evict_folios(struct lruvec *lruvec, stru= ct scan_control *sc, int swap > reset_batch_size(walk); > } > > + __mod_lruvec_state(lruvec, PGDEMOTE_KSWAPD + reclaimer_offset(), > + stat.nr_demoted); The mm-hotfixes-stable already has the same fix from Donet: https://lore.kernel.org/linux-mm/20250109060540.451261-1-donettom@linux.ibm= .com/ Andew, can you please drop this one from mm-unstable so that we won't increment the counter twice? Thanks!