From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 361C5EB64D9 for ; Tue, 27 Jun 2023 07:09:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9686E8D0002; Tue, 27 Jun 2023 03:09:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 917778D0001; Tue, 27 Jun 2023 03:09:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7E0088D0002; Tue, 27 Jun 2023 03:09:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 701998D0001 for ; Tue, 27 Jun 2023 03:09:18 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 39789408A1 for ; Tue, 27 Jun 2023 07:09:18 +0000 (UTC) X-FDA: 80947651596.09.0C15AC0 Received: from mail-qt1-f173.google.com (mail-qt1-f173.google.com [209.85.160.173]) by imf19.hostedemail.com (Postfix) with ESMTP id 4D9FA1A000B for ; Tue, 27 Jun 2023 07:09:16 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=52XxEQkL; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf19.hostedemail.com: domain of yuzhao@google.com designates 209.85.160.173 as permitted sender) smtp.mailfrom=yuzhao@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687849756; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HieCM9bprQuKzTV5MIdIK9yRrt8+ns3v3zkTmfeSLKc=; b=dy4EJasAFOPBKxQRtVuB1EX/tqqo06hnM9laNAd9z6I2BbHl8cmvNQoGgYP/60TrBSvNDB El8WVnFEpLhJ87jI3BJ34F6aWkvbTzZBxu05gG8WIJB9YWkunjz8sopRY0kv+yjmcrLHWc uKKiaAJoNWE5GzEa1Xl4au3a0tTR6yc= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=52XxEQkL; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf19.hostedemail.com: domain of yuzhao@google.com designates 209.85.160.173 as permitted sender) smtp.mailfrom=yuzhao@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687849756; a=rsa-sha256; cv=none; b=kVPeVpcBUAGFhrXDyGyb8rSEr1B9ctDMKvtO+JON6c4P7sMN3KHJ83JQ88TzPsiH27+YtL JlAqq2E8qY3lwwvfV4XIVO0o6g1JETKIzhVIyxEffdSuYzw9dyRZ09qpBPzxqBwUOk455L +jOGMw9qBb66rQx5aS6D5ybQax5aew0= Received: by mail-qt1-f173.google.com with SMTP id d75a77b69052e-401d1d967beso177281cf.0 for ; Tue, 27 Jun 2023 00:09:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1687849755; x=1690441755; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=HieCM9bprQuKzTV5MIdIK9yRrt8+ns3v3zkTmfeSLKc=; b=52XxEQkLZfNDLpT9HTPeOhwHeMUcO2f29g7st6oKFDRLgRJgZOggFrQHqpH5BTCO0l JiyQDR0m2a+yyKPjncLVMV+D7XmYNbJQDN2PHlbjG9NXua2kajsdQFbworKBUGSrXA1K 3DtJiI5SVYTOagC5pmHJtRL9YHvXmJwIw5Gxk3XcbYjDmtnHKtOQFG1C0AcTUUnrjrF4 gq0Bm0ndRuWGwDD4beBWtg+ML0ILBdznqOXSZHKp/eP+LTLKEvZx4Q3xAeKlCVjYI8Gd eMX8j57znm88QiYubcYdMSC948zjulA+TPATPOWPEnTNb8HW/R/UmZcH01LkBb081EJt Pn5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687849755; x=1690441755; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HieCM9bprQuKzTV5MIdIK9yRrt8+ns3v3zkTmfeSLKc=; b=WoRW0ccqBIKb7VoujL0TlApDnGDGHKQcR779QNBUmIA2KhSbv52gdVIGxynAZOGHUV H9fwfi5oeDRX0T7W6EUyYRMQxudp5KTFRb0SnjdrnJ55NNkZYvnyXZ7rABY9M7TQ7zT6 NTVPQdu5s59UF0g8z7JF0DE2tqOocV6Fjc7ldYdYATDKqWdkZfQsgMLXvAoH+rUnHKvw jRm3OtkNS0GZxTi/YxzNenr66aceOLx2JyjnVUnhIb8ntBbfd6JIvViNiMsc3Jqbw1Py K2Sn7g3xmhjmuO5ue4VxHeFaN3TD2Ho6Yg1eKa7Qa4BGzINQE65oCVWahMeFpsPuuRPZ onRg== X-Gm-Message-State: AC+VfDwFkesnlCTq2VDJJEBm+dznSuur5ji+2xY5ksxJ/I6Ae0igCTyi IAqQk5z3H4DWNVCMc2GmDhqLSq4ZRV2OPNSxZsIN9A== X-Google-Smtp-Source: ACHHUZ4PKTvNibPpiBw9Yw6RXxVIG2HKehlwY+KnLEMPY8PhvxrvGj0uBU4UnF9B4YdnnCPTS8uK4kxL+UpjhiOsPPU= X-Received: by 2002:a05:622a:285:b0:3f8:5b2:aef2 with SMTP id z5-20020a05622a028500b003f805b2aef2mr100813qtw.26.1687849755160; Tue, 27 Jun 2023 00:09:15 -0700 (PDT) MIME-Version: 1.0 References: <20230626171430.3167004-1-ryan.roberts@arm.com> <20230626171430.3167004-5-ryan.roberts@arm.com> In-Reply-To: <20230626171430.3167004-5-ryan.roberts@arm.com> From: Yu Zhao Date: Tue, 27 Jun 2023 01:08:39 -0600 Message-ID: Subject: Re: [PATCH v1 04/10] mm: Implement folio_add_new_anon_rmap_range() To: Ryan Roberts Cc: Andrew Morton , "Matthew Wilcox (Oracle)" , "Kirill A. Shutemov" , Yin Fengwei , David Hildenbrand , Catalin Marinas , Will Deacon , Geert Uytterhoeven , Christian Borntraeger , Sven Schnelle , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-s390@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: sdwu8s74edjiimjtjo6d4cek6yht1mcw X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 4D9FA1A000B X-HE-Tag: 1687849756-402722 X-HE-Meta: U2FsdGVkX1+zR9cMeh4pjaiSLdbTr559+L8qrTHAuRZpyfQwGz2lers2r0PUSAZZqt+/Q1L8AIdU8p3//MFIZSBVyvptjHLrF9ZrphvhHCF0wJsCiZnUcu4zVG1YubgEaQYdPJ8OAuSPep/XdaGr6NSgHmypU41X3zkhZjfRarWWDieIt8eax+5yoYVbYRmFTvs3Rm2ronwCk4LngEx+lvcGBCJeHnGeofDZA1GiZvNiEyRYR8XUgigKNpFXnlrdd3nY/uS3g1Dt10YOWtJxM7LtLQFCAgwMNne7b9H+96iBmaZFC3uWSXMkKlWY+XviNOc3KhsEyCR8/2zFyKSfoJnelIT+LhSJyVmWEg2oYAlEH4+0MGR6NMD6kLUgSdYEXARw1VFVA2F01ojxjJg5XIwu5ialskN8qgsikQDR46HwTeMQvy7+Pvpn97lcLyvhWvLE3fyHHlUfiGuzMF5EgtnM8i4ACXkdgxyHGuOmTnED+huAqzjI7qG57xDtHh0wPm4D7apc8z7vyBKs3rV1T2YHiW5R3rqPx4ImG+zYxZNM4DAxfZGnYwOPE9EuhQSCflUwLHX27Wa41lCmYLhvY49P0Eh5olDSui63k1V3dAb2rt2T2NnIZ1mcbp3AyU8g/uU09mStg47G81eStlspWBWr8L4EIb1KYAtg7VpQMu7rJeYnyII7BpucmiG7OYtJC/wGr3MHr8GYHYy7UonCdpwcdsW5AH0c46yPWkjwIKUx3OzDyc/sLjg6WU9sE5ovtBAk2Zfe8WpVmgw0Cf3A3Pe8ui80D8tJw9t2Tea1PFbSpDbvyYj/QFyInYAujsVSYW1DH6eR8gde7FdmwBqnjHvL02tez8EEc937XH80EKGHSYYg5lM8OC/tp6T+IZvIv5yhx6P5KJjjMQBTQwRS83y8+DJJey5ADdaVsbhD9K2sU0qQXd6S2Bcb6IVSWglJhKxwvLW0cC2ylN+dvzX 4b7nQUYY 6SQdHW7yCuRrYljTstJG9VAVhirELQHNF/AiCH3OG2CIzXNEQmRe2Z7sP+1TMM2Z5UTVi1NgaxKrr8MdQ+/owyw2TCcBvYIKfKgDXhUfQcDtyaSBLMLi/qkwvQVa/mMIcKarH0CkLX6zAcNr/tNvqj3tmxDf6QRfK4zDTxqQugKdeqHk3rF3iG20Xw4EIebR3XjwwpPHNQNeLcaRxK0yIxtv212VDru2PFpISIf0KFBlJmVHG8M9L/Xzp282c5/m1C1C1nIuYF3xiud9iKrYyMoD7u+hSYfx7VWnVmjpR7WGrD8gzyMxj9TO/fyCUs/gAglp30jQoRzZd8BdriArTfUmY7w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 26, 2023 at 11:14=E2=80=AFAM Ryan Roberts wrote: > > Like folio_add_new_anon_rmap() but batch-rmaps a range of pages > belonging to a folio, for effciency savings. All pages are accounted as > small pages. > > Signed-off-by: Ryan Roberts > --- > include/linux/rmap.h | 2 ++ > mm/rmap.c | 43 +++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 45 insertions(+) > > diff --git a/include/linux/rmap.h b/include/linux/rmap.h > index a3825ce81102..15433a3d0cbf 100644 > --- a/include/linux/rmap.h > +++ b/include/linux/rmap.h > @@ -196,6 +196,8 @@ void page_add_new_anon_rmap(struct page *, struct vm_= area_struct *, > unsigned long address); > void folio_add_new_anon_rmap(struct folio *, struct vm_area_struct *, > unsigned long address); > +void folio_add_new_anon_rmap_range(struct folio *folio, struct page *pag= e, > + int nr, struct vm_area_struct *vma, unsigned long address= ); We should update folio_add_new_anon_rmap() to support large() && !folio_test_pmd_mappable() folios instead. I double checked all places currently using folio_add_new_anon_rmap(), and as expected, none actually allocates large() && !folio_test_pmd_mappable() and maps it one by one, which makes the cases simpler, i.e., if (!large()) // the existing basepage case else if (!folio_test_pmd_mappable()) // our new case else // the existing THP case > void page_add_file_rmap(struct page *, struct vm_area_struct *, > bool compound); > void folio_add_file_rmap_range(struct folio *, struct page *, unsigned i= nt nr, > diff --git a/mm/rmap.c b/mm/rmap.c > index 1d8369549424..4050bcea7ae7 100644 > --- a/mm/rmap.c > +++ b/mm/rmap.c > @@ -1305,6 +1305,49 @@ void folio_add_new_anon_rmap(struct folio *folio, = struct vm_area_struct *vma, > __page_set_anon_rmap(folio, &folio->page, vma, address, 1); > } > > +/** > + * folio_add_new_anon_rmap_range - Add mapping to a set of pages within = a new > + * anonymous potentially large folio. > + * @folio: The folio containing the pages to be mapped > + * @page: First page in the folio to be mapped > + * @nr: Number of pages to be mapped > + * @vma: the vm area in which the mapping is added > + * @address: the user virtual address of the first page to be mapped > + * > + * Like folio_add_new_anon_rmap() but batch-maps a range of pages within= a folio > + * using non-THP accounting. Like folio_add_new_anon_rmap(), the inc-and= -test is > + * bypassed and the folio does not have to be locked. All pages in the f= olio are > + * individually accounted. > + * > + * As the folio is new, it's assumed to be mapped exclusively by a singl= e > + * process. > + */ > +void folio_add_new_anon_rmap_range(struct folio *folio, struct page *pag= e, > + int nr, struct vm_area_struct *vma, unsigned long address= ) > +{ > + int i; > + > + VM_BUG_ON_VMA(address < vma->vm_start || > + address + (nr << PAGE_SHIFT) > vma->vm_end, vma); BTW, VM_BUG_ON* shouldn't be used in new code: Documentation/process/coding-style.rst