From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA750C48297 for ; Mon, 12 Feb 2024 18:28:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 50F916B007D; Mon, 12 Feb 2024 13:28:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 497836B0080; Mon, 12 Feb 2024 13:28:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 310FD6B0082; Mon, 12 Feb 2024 13:28:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 1A9836B007D for ; Mon, 12 Feb 2024 13:28:21 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D08ACC0A8A for ; Mon, 12 Feb 2024 18:28:20 +0000 (UTC) X-FDA: 81783986760.07.2D1226E Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by imf07.hostedemail.com (Postfix) with ESMTP id 0F1EC40019 for ; Mon, 12 Feb 2024 18:28:17 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=SqXNegmE; spf=pass (imf07.hostedemail.com: domain of yuzhao@google.com designates 209.85.128.46 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707762498; a=rsa-sha256; cv=none; b=lPrvdMH7XyRQLZxWwpCnLOFDqjmSxQkh1YxJAVukUePKJ3UPJDtoBDA+XblB4LGE0Qbhbt vud16xCpbkk5xRyTMpDUpa+bdLw6X5FD9Dbxt+KRV3EKoTmrCTKdW+zTGrL0UzZSnkorl9 ItuxTNRauQkvclBldVBWxQWGAjt8XMU= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=SqXNegmE; spf=pass (imf07.hostedemail.com: domain of yuzhao@google.com designates 209.85.128.46 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707762498; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ypHcUZ+aGWwSqOIX8vKscvJOnKGBfRqwg/T41r3ZbLM=; b=Fkh81asO7d+5XChgNobTFqvOhtu6x1E3uGxxEwRyNUJXeoTU3+GgPnSNReR7GL1B5lQ1oJ 7Kj9fRT2XuOgO7thIeqNTxuShEMkZbGxNYckP5gl6D8EJ60hctp29VDzPI5RcrMtuNnmN/ YrF/xTet0sMvW5RnUBt+QcJB4g9ajkw= Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-410cf70a057so4885e9.0 for ; Mon, 12 Feb 2024 10:28:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1707762496; x=1708367296; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ypHcUZ+aGWwSqOIX8vKscvJOnKGBfRqwg/T41r3ZbLM=; b=SqXNegmEjxHqFy/DnxFNObmPOiuwpn215WdCeLRG0wahKWagsuGRYR9Prm6JnhDL49 18mGzJ/ToBWJC8ByfDXpxl9wwdUiVFJUnfyA31sqyUL9fEZgmJrg3W5PXirJJLk4yEsn w+Y5ufpnlw6WKESqpFsf2Yp7d2i2xPgIBqq+d8TMVgdX1gDjupxyc3A8pl84PmLlsB3O 394iy+I8GtsqMPfe5WkIFb625jBUN7BQMHoynPCuJccKDb+lyTT+A/oB4C/nJYneSGqw 0QAlyp8SMwb/whghuvA+V8wgEt5ASgyw78W0jOlNxyevwv6xVDLJfEfWrwkC76zrFo4T 5TIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707762496; x=1708367296; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ypHcUZ+aGWwSqOIX8vKscvJOnKGBfRqwg/T41r3ZbLM=; b=bnsiIjb4+cVnBgZr/gsYW7UIWks1dxmW8dbJF0w2MQBLSLSBoeECK9rlx3fK7D1jGS rGxX0RYurpwa55+/AT163lj0UBnyxEmkZ2fPNF0aSBUgg6sdMtsbriGD6vbceU0PDqJw f8K+EbV7S0aJNmZM4AuSXvs4xObgtaOZeUssuVsbCGexVLPloyR4gOYON540vfo9HgIw hPWCcbSVX4tkkj0zY9A+yMi1aIRtsh1jTayW4FP3wkWoDUc0Yu9bGkuxoWyTWK6SdVnX 0Yk7/vKGlUlBZqo/Iw+HD4DSwBqYTJXC0PlFF5wtiRfTZ9pQi+0DAinpicmqTzVcJFI7 PmXg== X-Gm-Message-State: AOJu0YxWWAto+3+EyRiUQoTGcK2/1vV+935KRj2ziQFOaAzIs1EuWC6C FaGa2YVHRW1mprkcX/Z3n7/TfqBb69looNLi7CRKAnUZHTw40Vh9/XImA0qPuJgWfwcw5R3tSR1 enlFtY8BksYxWarW+nDPCJ2Q2K610sIjCI0Li X-Google-Smtp-Source: AGHT+IENUbcQetxdbVJUWkDcZV9wBOKwUA5KBVKb3q8kwwNwrJ81UhZO9mANnq3JBZ4CWFIexcNdopfgQFazsqAn7Lc= X-Received: by 2002:a05:600c:1f1b:b0:410:d18a:290b with SMTP id bd27-20020a05600c1f1b00b00410d18a290bmr200842wmb.7.1707762496373; Mon, 12 Feb 2024 10:28:16 -0800 (PST) MIME-Version: 1.0 References: <20240212163510.859822-1-zi.yan@sent.com> <20240212163510.859822-4-zi.yan@sent.com> In-Reply-To: <20240212163510.859822-4-zi.yan@sent.com> From: Yu Zhao Date: Mon, 12 Feb 2024 11:27:38 -0700 Message-ID: Subject: Re: [PATCH v4 3/3] mm/compaction: optimize >0 order folio compaction with free page split. To: Zi Yan Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Huang, Ying" , Ryan Roberts , Andrew Morton , "Matthew Wilcox (Oracle)" , David Hildenbrand , "Yin, Fengwei" , Vlastimil Babka , "Kirill A . Shutemov" , Johannes Weiner , Baolin Wang , Kemeng Shi , Mel Gorman , Rohan Puri , Mcgrof Chamberlain , Adam Manzanares , "Vishal Moola (Oracle)" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 0F1EC40019 X-Stat-Signature: qrms18tfcyyn1hg4heehygb9xine3spz X-Rspam-User: X-HE-Tag: 1707762497-120111 X-HE-Meta: U2FsdGVkX1+ZaiXrF6Q7MxC4jKUavcySF7QZ2cclCgzZWowQ3oHxpWdIzjfD3ML9U0z2dqnmJikNz8eZjGpMSIKlZl167FXK8/37zpjOm1qiPRBma2sfc+uKQgEDvtx/SwOAn9wxQ2ZTdk8BDgZD5/21nFdoyHFTXueuRfpf4aLchDvC3XEsi0ja5ArlwaDVTLwx2P84xZYx+VcO0cy3C6RA63RAisH0L7LpKYXcm8bDRfxITtwT5mCH0YpLt1UjaAQUdrfQko7JIOO/81Iq3cHWK0sL4I0fs9uM5LqDh6wZJXQxfe4vetZO+fNN78gxMKGpojzkFOwL2AMCuI8Tv9k06Q4OSuQTl6vnYqgkLnAZBCBz2pQu2PdSGlgn6t5j1a2tjXfpFJQhJMnRE1veeYMnwSBIQ5BsMRtlOBzaJ5R/4yFK7g2Ujwzyet1cGdDEeBn13opRlhCj188cC6JS02FaqyRmFOEUQ+shKPS1wbDg0HSW1KKEN7pR/a3b/bDb1aWOAPGmhj53a1eYJ2YDks558Bmo8p84HwCznd5JmTbuJuTnM39taY3RI1FRa53de/jhl+VWvHIlwPtjhzCjBJ4XUDgdMOJ7kaMZ4l8Xee0C5+JeLQlfX2cT4lFiOt73b5mTiasthaVpF6nz3svhIlFgXNpr/5X0YfRewFPcE25g1YHOB9GEkexBw9VPhp/gnQLfu2HfoVE0YEjmWQZSfZY2vQ+TQ7qlFIm6/3veIriZdIYHXhx7bRKTv1OvJ0sfxRyk1KJ8MKaoVZH4E0XUSXsjiJEqLC5Vp8OTlLwnqyB4JeFCdQuExnIUNMb7Z40r6dzsX63pd/K6Jj68oe1Bz4tW4ruMxLahyGYl1v+kfHgvcoM8spCztkn5dggGrXoqpXcoCrRwoo8UOGVgAbl3vlVVzU1mOIxK3q6wFdZ4XdzQIgP5x3O/ZEQsTduO72SRbVvjnELziSxjdFobz7c YtDL5qob C7PISpX+lvFZL73HX0ELynSDb2fo43jdpLhqVw+8zpipH2kCtwQipixv0pdRzJ4xPNlimIL/W1AFVRrtGzc+ZoQoDlhqWI7uIZ30wdmH219Y+e3Ev+os1iguWBFcyofvPprZVMHKR23mmHiirhglQZwFtlj+6tQPhegqXhEmNxQoK9oHIhAt8TKfmpkKHzOHBV7lpLkenAiXREQvojNoWd47edVwqyILFksBa8f1oEnFEMVmLEDUJbQoaw6z9PVklpVMumCcjRjDNtsuuGHVT3wy7JZIX1bPQZ7f+aahOVu7JJqpAf6ot/x103l0fYr29n4xD/uPXd5eRiXLcTBbmWBwNfdk6FrqR8e5xITe2aSzFwDbu1jSvyR4RyiSENZeoUIR3UWVQ0FOV9DGkwYFHj/CzTOb16gdTa3RwexMeTWbArF3E9DZsRn+DPwylhdsnNLWd4J4/giAvi0oanS7CNKVU2AjHbL7d72sMs20QMuI5SfjjNJm/zXeYuOAa3+7roxO7Fa3YnPcUB9krf0DnbCw/unNe+YtoiGziOSsOndYWaU8rH7xKzIJzQ1/UpqTIwQNV7kIas+90CXg51LjKGRKbY9zBslwQKmox+ERv2MRi4T5WKW0Z4RnTuplnjZ49xsgkK4gDtu7acrnRrP4KiKGkTB95nhJHh5yUsA2cqO/b9SqfrixEV7DPjdfKquBVyTKyLeqHDWvpmRbxOcpRk12AW3EoSu/g6ZcQLXApOMVtfkHYww04CyYnmgiW1o780fHhZpnI8gbOIwMso+Xx4RDatu7kCuq/Ri3alYkgYI26RcTnJaZ0nLDxt/XdcUNMHRMnmmZQdx6NCzOlOghmC+CuAPpbHqnJPFZkow3tJxyElmxV385LgQIXRQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 12, 2024 at 9:35=E2=80=AFAM Zi Yan wrote: > > From: Zi Yan > > During migration in a memory compaction, free pages are placed in an arra= y > of page lists based on their order. But the desired free page order > (i.e., the order of a source page) might not be always present, thus > leading to migration failures and premature compaction termination. Spli= t > a high order free pages when source migration page has a lower order to > increase migration successful rate. > > Note: merging free pages when a migration fails and a lower order free > page is returned via compaction_free() is possible, but there is too much > work. Since the free pages are not buddy pages, it is hard to identify > these free pages using existing PFN-based page merging algorithm. > > Signed-off-by: Zi Yan > Reviewed-by: Baolin Wang > Tested-by: Baolin Wang > Cc: Adam Manzanares > Cc: David Hildenbrand > Cc: Huang Ying > Cc: Johannes Weiner > Cc: Kemeng Shi > Cc: Kirill A. Shutemov > Cc: Luis Chamberlain > Cc: Matthew Wilcox (Oracle) > Cc: Mel Gorman > Cc: Ryan Roberts > Cc: Vishal Moola (Oracle) > Cc: Vlastimil Babka > Cc: Yin Fengwei > Cc: Yu Zhao > --- > mm/compaction.c | 36 +++++++++++++++++++++++++++++++----- > 1 file changed, 31 insertions(+), 5 deletions(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index d0a05a621b67..25908e36b97c 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -1832,15 +1832,41 @@ static struct folio *compaction_alloc(struct foli= o *src, unsigned long data) > struct compact_control *cc =3D (struct compact_control *)data; > struct folio *dst; > int order =3D folio_order(src); > + bool has_isolated_pages =3D false; > + int start_order; > + struct page *freepage; > + unsigned long size; > + > +again: > + for (start_order =3D order; start_order < NR_PAGE_ORDERS; start_o= rder++) > + if (!list_empty(&cc->freepages[start_order])) > + break; > > - if (list_empty(&cc->freepages[order])) { > - isolate_freepages(cc); > - if (list_empty(&cc->freepages[order])) > + /* no free pages in the list */ > + if (start_order =3D=3D NR_PAGE_ORDERS) { > + if (!has_isolated_pages) { > + isolate_freepages(cc); > + has_isolated_pages =3D true; > + goto again; > + } else > return NULL; Nit: remove the "else" above, or just: if (has_isolated_pages) return NULL; isolate_freepages(cc); has_isolated_pages =3D true; goto again;