From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB2FEE7717B for ; Sat, 7 Dec 2024 19:10:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3ACC36B0350; Sat, 7 Dec 2024 14:10:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 35C876B0351; Sat, 7 Dec 2024 14:10:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1FE438D0015; Sat, 7 Dec 2024 14:10:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 01F076B0350 for ; Sat, 7 Dec 2024 14:10:19 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 6FCE3140142 for ; Sat, 7 Dec 2024 19:10:19 +0000 (UTC) X-FDA: 82869103548.28.3C77242 Received: from mail-vs1-f42.google.com (mail-vs1-f42.google.com [209.85.217.42]) by imf15.hostedemail.com (Postfix) with ESMTP id C4380A0004 for ; Sat, 7 Dec 2024 19:09:58 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=kKr15cmz; spf=pass (imf15.hostedemail.com: domain of yuzhao@google.com designates 209.85.217.42 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733598609; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/15KxmJ0SxonIY9baR1wg6KbQJZwmraFLzWVHuQbZwg=; b=fB0t0HUWrZ3u9JiOERuGatImQe2pDCo+KWmdcucegBfGKZ1ND5wx7jOq0JYf0ECR4VtBWV 6CyMfm/RsdBSJyp8Ws6fIipAEK3BAQGG4+Kun3MA8bBYAmcziJy4MqVde/0R0GIqwlXJJq u1Xes4GyjOBcdZOl+RyiSzCaamzLt6Q= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733598609; a=rsa-sha256; cv=none; b=v+76WGc5zN09bsLX1BB9Cbep3uMzM9fyhcxJsGvmRTsEGlfpX1GClGCTltuI1bAtWUrlJs QUoyg+L/fQB4tvLPrARtHntKf3OQ6iArbQrldaCQlSVWtpLNvM/yXrUQvhOxxwayAzmeuS wxfunxwddoE52uX3+Fv/FVmgnwgKfvA= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=kKr15cmz; spf=pass (imf15.hostedemail.com: domain of yuzhao@google.com designates 209.85.217.42 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-vs1-f42.google.com with SMTP id ada2fe7eead31-4afde39e360so236626137.0 for ; Sat, 07 Dec 2024 11:10:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1733598617; x=1734203417; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=/15KxmJ0SxonIY9baR1wg6KbQJZwmraFLzWVHuQbZwg=; b=kKr15cmzorVILNgSKYJFsn6Afqfv/aD+G1l9RL/kuRavnonY70XOH6tCHKvAKmOP/d NZNJW6Uknd6XGP6KTR/h7+3hvEdrjT7JZ0ymS3tW2YDM6pC86TwUXFSXPajJYo0M5IHh qXS+zD6YlJPOt6cHeBkZmXCVvoOw3mig0+1fasx95KtPAIZPrtEHeVdmvbTuhNIPVuK8 +ymPtOeHBMrJpH45yJ4XV5m/v7B2NLhu4OZqA/tRP72mEwowg5nJdk6zvJQD5Uw0NJHP bAnTFrWgJee+9Yuwyq9PZwqeYAGbVhLmuTKfV0lDEOehEloYttG+7A0gNRcK637ie8U5 udhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733598617; x=1734203417; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/15KxmJ0SxonIY9baR1wg6KbQJZwmraFLzWVHuQbZwg=; b=rYlP4+VFaZ+I1pyxMh+h4/jrFpYLDlLcORivKjCg3kUkXkV5p9mFO60vC97J7LR+nG wzxbrTVBfiuHWCvQ2Ua3CXfVwFPtQ869dHELK4eNk58WyKkzbTxchmh9OPiRZwX8arjm P+gz0kPG9lv5J+3eVe2zq+24+zoC6TniRf4ekmeiZ3L7rmo7/EK7lsQaoEq/bpVUR2zW cQMKqvEwX93x+sUjGFg0xViN/PGtJFBqyABYmJJ0jsx3AAITGvsA4HxV3citpUPJgZBw rFrMmbqCkO+/u522JNVXJV7luNbLEDOrhzq8F8SAIKsOPzwX+OVemvGjPTXtC9HoCaH6 chFg== X-Gm-Message-State: AOJu0YzHsAMH91e5t20+ZHnb3Wp0AWRWF4x9PAx0shtKuEqBMM9cWAFS TNserpBkboa7O2K/Vk87JkkPiiSOX8Dr5ei6XYemZPM5r/axPH4SnJ+whRq954Yt/6Kz3iKGfWj kas63CegQ5IPe5bydplDGofRBLsZ9Z9cWToUW X-Gm-Gg: ASbGncvseiFcw2PTo77CD2CJPjnudxy0VQdveeYcerlPiyaERW26tDBZqe6YM0zNFcQ EFHhi2Spq5i4TvleCKOB2E/hVwQcMK3b6IsqTL03r+pBqRJPWetylfeVivRPWu7G6 X-Google-Smtp-Source: AGHT+IGuq3rFffhHTtpguXfM3plGXJvmjCmHPM+myu+JVCptyY7LMNoXXEUsfJSCZauBj6tzApx30AMUgco60LAziLo= X-Received: by 2002:a05:6102:50a0:b0:4ad:de0b:fde9 with SMTP id ada2fe7eead31-4afcaaf3b31mr8243693137.24.1733598616434; Sat, 07 Dec 2024 11:10:16 -0800 (PST) MIME-Version: 1.0 References: <20241206003126.1338283-1-yuzhao@google.com> <20241206003126.1338283-7-yuzhao@google.com> In-Reply-To: From: Yu Zhao Date: Sat, 7 Dec 2024 12:09:39 -0700 Message-ID: Subject: Re: [PATCH mm-unstable v2 6/6] mm/mglru: rework workingset protection To: Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kairui Song , Kalesh Singh Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: C4380A0004 X-Stat-Signature: z4zg7d1mmrdok4o4yeq731kyxgfgppy1 X-Rspam-User: X-HE-Tag: 1733598598-619119 X-HE-Meta: U2FsdGVkX19X8TjwZEjsRaUx9AWrgtzgeln0tfHk5yeMd9Yao74p/VSkyt7hW0+CmyZ+IZMC9N7snGRNZCW+Qk70TcQ2dStM0xmsiHwzYfkinbUUZMRL3i1po5A3ROrih5xY4EXDb+vFKtmDpO7ErINSfnFb6UhEWCmUSwabqK86NR0dBcQC3JuLDBCVxEWf9HZV27RlHEtr9ZSZjYYCRIWWcKTmDs/JzPYwKczyyYmbSQSldn2RGGu+wPlZCx3Jq8JgCjtt447YPtP6LcV+RjSDI21RQJFafgTd0gBlVr+NrznsajuHke6pcG6SnLPF7XTdx54qd+Avld7fhs95nbQLiQoa5YtrGWx93r3kfwtghBCcu3tQJtijXu5/gq17oK8IsTrF4FYE/gDJIdBSPFPsniNoQSi57uOp161WNhJdyVSbGgKkeA8b3imrguaqRI3BKyOLdDr49oKPo2ccDigXPJK6agKn0a+A8X5pVWBpR/dx6/EhTBpNMxOc0+YMJSCn6jnm9887zccG3yoi4xY6dKDioipbZE1cj4Qks5WnGDjskaSV1hsqsP3fEfc2X27xd9HaSx5GCALaFios+BR2cvIisbR5YosTvWP7PRJeZtDBk42/U55rtFBqdyx1I6zd/kvX5pT3jmD1ANERxi6sU7DYRdpBIKczwfey1ZjzQGV+0igUFoY5UQ8p2glKP3Z8zGFPHlQbsg0ICwjnH6UbNsaIP+kzJx+NmlMWslkJCSHpqPej6vgTR4C1mRwYKN7sIM1Z6g639M6s97L1l51HBJHMx+MhG8GS7wuj7uRTpzx0+rPFkXcy+7iZRvrmfwn/z3LdRIzwJoZe9zdnsBEt4Xb2GN1SQpQW4RpIBY1n1jNXiPdIgKXafLFilOBtahtGPe85RUfbpIO8vVU/d4v35IxlilXV5CQA1cBsJS6cYr1zXP42hgzHljZe4p1briLuxt9lPGosjeixP+h PH5ONiPM 9dP+5KH3SKwyKmraptcgcEVOM4NTkoCwQ/ptEDah+7FY0UV+elM92l4IGoGKMk8dt/0dIlmG1icbrrKjjeCWCD43WQdYIV74zvgVWDiPDVFzVWBE153CMg0tJteoab58B8YnevNYwfqReCCra3fu5RfNIp6l3lxH9Gr3ENRL3xtIrFjtZ/0113vhhDWbrB1VvrAxwFEQpVTNQsjCSe0kZJvKrdny5AZnvFQOuom6xr/dGizsbHXB9qfs0Lcb4juUGzbYbBlYPW+9YkLftDcAvy/JjTUpHzCg2cRE9k/F/3gFsy4G4PqBa1e9AVYXTz6r3WbAyuvG1euNxDaFYafiIejiPew== X-Bogosity: Ham, tests=bogofilter, spamicity=0.020644, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Dec 6, 2024 at 9:44=E2=80=AFPM Yu Zhao wrote: > > On Thu, Dec 05, 2024 at 05:31:26PM -0700, Yu Zhao wrote: > > With the aging feedback no longer considering the distribution of > > folios in each generation, rework workingset protection to better > > distribute folios across MAX_NR_GENS. This is achieved by reusing > > PG_workingset and PG_referenced/LRU_REFS_FLAGS in a slightly different > > way. > > > > For folios accessed multiple times through file descriptors, make > > lru_gen_inc_refs() set additional bits of LRU_REFS_WIDTH in > > folio->flags after PG_referenced, then PG_workingset after > > LRU_REFS_WIDTH. After all its bits are set, i.e., > > LRU_REFS_FLAGS|BIT(PG_workingset), a folio is lazily promoted into the > > second oldest generation in the eviction path. And when > > folio_inc_gen() does that, it clears LRU_REFS_FLAGS so that > > lru_gen_inc_refs() can start over. For this case, LRU_REFS_MASK is > > only valid when PG_referenced is set. > > > > For folios accessed multiple times through page tables, > > folio_update_gen() from a page table walk or lru_gen_set_refs() from a > > rmap walk sets PG_referenced after the accessed bit is cleared for the > > first time. Thereafter, those two paths set PG_workingset and promote > > folios to the youngest generation. Like folio_inc_gen(), when > > folio_update_gen() does that, it also clears PG_referenced. For this > > case, LRU_REFS_MASK is not used. > > > > For both of the cases, after PG_workingset is set on a folio, it > > remains until this folio is either reclaimed, or "deactivated" by > > lru_gen_clear_refs(). It can be set again if lru_gen_test_recent() > > returns true upon a refault. > > > > When adding folios to the LRU lists, lru_gen_distance() distributes > > them as follows: > > +---------------------------------+---------------------------------+ > > | Accessed thru page tables | Accessed thru file descriptors | > > +---------------------------------+---------------------------------+ > > | PG_active (set while isolated) | | > > +----------------+----------------+----------------+----------------+ > > | PG_workingset | PG_referenced | PG_workingset | LRU_REFS_FLAGS | > > +---------------------------------+---------------------------------+ > > |<--------- MIN_NR_GENS --------->| | > > |<-------------------------- MAX_NR_GENS -------------------------->| > > > > After this patch, some typical client and server workloads showed > > improvements under heavy memory pressure. For example, Python TPC-C, > > which was used to benchmark a different approach [1] to better detect > > refault distances, showed a significant decrease in total refaults: > > Before After Change > > Time (seconds) 10801 10801 0% > > Executed (transactions) 41472 43663 +5% > > workingset_nodes 109070 120244 +10% > > workingset_refault_anon 5019627 7281831 +45% > > workingset_refault_file 1294678786 554855564 -57% > > workingset_refault_total 1299698413 562137395 -57% > > > > [1] https://lore.kernel.org/20230920190244.16839-1-ryncsn@gmail.com/ > > > > Reported-by: Kairui Song > > Closes: https://lore.kernel.org/CAOUHufahuWcKf5f1Sg3emnqX+cODuR=3D2TQo7= T4Gr-QYLujn4RA@mail.gmail.com/ > > Signed-off-by: Yu Zhao > > Tested-by: Kalesh Singh > > --- > > include/linux/mm_inline.h | 94 +++++++++++++------------ > > include/linux/mmzone.h | 82 +++++++++++++--------- > > mm/swap.c | 23 +++--- > > mm/vmscan.c | 142 +++++++++++++++++++++++--------------- > > mm/workingset.c | 29 ++++---- > > 5 files changed, 209 insertions(+), 161 deletions(-) > > Some outlier results from LULESH (Livermore Unstructured Lagrangian > Explicit Shock Hydrodynamics) [1] caught my eye. The following fix > made the benchmark a lot happier (128GB DRAM + Optane swap): > Before After Change > Average (z/s) 6894 7574 +10% > Deviation (10 samples) 12.96% 1.76% -86% > > [1] https://asc.llnl.gov/codes/proxy-apps/lulesh > > Andrew, can you please fold it in? Thanks! Never mind. syzbot found another warning. So let me fix that and post v3. > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 90bbc2b3be8b..5e03a61c894f 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -916,8 +916,7 @@ static enum folio_references folio_check_references(s= truct folio *folio, > if (!referenced_ptes) > return FOLIOREF_RECLAIM; > > - lru_gen_set_refs(folio); > - return FOLIOREF_ACTIVATE; > + return lru_gen_set_refs(folio) ? FOLIOREF_ACTIVATE : FOLI= OREF_KEEP; > } > > referenced_folio =3D folio_test_clear_referenced(folio); > @@ -4173,11 +4172,7 @@ bool lru_gen_look_around(struct page_vma_mapped_wa= lk *pvmw) > old_gen =3D folio_update_gen(folio, new_gen); > if (old_gen >=3D 0 && old_gen !=3D new_gen) > update_batch_size(walk, folio, old_gen, n= ew_gen); > - > - continue; > - } > - > - if (lru_gen_set_refs(folio)) { > + } else if (lru_gen_set_refs(folio)) { > old_gen =3D folio_lru_gen(folio); > if (old_gen >=3D 0 && old_gen !=3D new_gen) > folio_activate(folio);