From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6CEBC2BD09 for ; Tue, 9 Jul 2024 22:30:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 48BC46B008A; Tue, 9 Jul 2024 18:30:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 43BBD6B0092; Tue, 9 Jul 2024 18:30:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 329CE6B0093; Tue, 9 Jul 2024 18:30:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1458E6B008A for ; Tue, 9 Jul 2024 18:30:47 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 798D3140798 for ; Tue, 9 Jul 2024 22:30:46 +0000 (UTC) X-FDA: 82321660092.30.1DF7D6B Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com [209.85.160.178]) by imf23.hostedemail.com (Postfix) with ESMTP id A6786140012 for ; Tue, 9 Jul 2024 22:30:44 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=YNk75ATs; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf23.hostedemail.com: domain of yuzhao@google.com designates 209.85.160.178 as permitted sender) smtp.mailfrom=yuzhao@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720564209; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HGcoQxstQZI9VHlyh4ftH4+Bg/qn65S531lrhcPLrVY=; b=n/BpQccyLVazHEz3DNQqh/GqhsydTzHaWiVa1bl6h0QwOEVtLw1cOhANLVCnDn2e3vo7i9 aqT9GBr0n3Ec6xkuy0Ozp+mGNn8Y6NAbmozIymQbRojjjXgC81jgeql08ptuznwKbKe5Vm MT+wYOc5L2/an5tpxvfZSwstirM2Ank= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720564209; a=rsa-sha256; cv=none; b=VXdfPTpsOjTL4fbxadi7ymliGqflhY54pshwWfQpFynNiiRAsMt1zrULPIZzr+tZ6C4Vp/ S31Xdwg1CbFcZtr//HInC1XQvosgi9BAp32aZLZ+Jvh4w9llTgW2B85iBWkSzDMB9F1P8K j398SONm/GS8gk64vpEcteXqVwqTzlo= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=YNk75ATs; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf23.hostedemail.com: domain of yuzhao@google.com designates 209.85.160.178 as permitted sender) smtp.mailfrom=yuzhao@google.com Received: by mail-qt1-f178.google.com with SMTP id d75a77b69052e-44664ad946eso36981cf.1 for ; Tue, 09 Jul 2024 15:30:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1720564244; x=1721169044; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=HGcoQxstQZI9VHlyh4ftH4+Bg/qn65S531lrhcPLrVY=; b=YNk75ATsqRPCVy+EpAZlRs5sxSO2jBHyDJSY9EtT5+uM4n0ZjMU+BAZoIlsivASdE3 zTT0xRxkt/R7MNrwIGF5bPB89bL2Pg/lEbc+LFR/6ZvlcdwRwbsZW4+BNAfle/hGUAxu lbTU26okozFGu/WLHpcJbZbcV5AwyxzYldt2X6VTRu1JEqvWQG5DUWGDF6etLi61AEMu 8H0eKHYNl/p92VywHGehyGdOVzoVaMcsTeMzsuzyi5GzHHXS5CQv2qQCuVAPPF4oidQv JMUJxImuOnpt/dxokTbV0ZkwdjIymTDYakgz4FXY/SxqJ4xcchFQ5nsdgX7Wl+ALYWf1 P7Zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720564244; x=1721169044; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HGcoQxstQZI9VHlyh4ftH4+Bg/qn65S531lrhcPLrVY=; b=l2CRgbNXXJA18/M/yguF/0MSngcu1uSr+r5cZmA5fX2I+rlgIDxJi5TLjxHO2llQtM zzE56qGvNsHd3oVzDZhj9Zzq0fHZfK/8sNyTBVmmyEW0cRwFc1k4xyq0oXpVA+hLKazl 1FuUSWBAdmuBsWkx6rwbrItkwamsaxQbt1bG5EsQ+cxHOwwy3oFjd1Zk6dl/rtL7uIaF RmrjsyX1JW2V8ukK84zCVIXEYX2zhGdB7csUtKhZuSt2sI/E7VX2ZVcZfPJKBBQT5gCt 64N89YHOoLmOAhjmYisoeM9qTd9APXjNuZdQQvefIbUblFWeUV80IQ2p0UdS8Ne3YnYE qfHQ== X-Forwarded-Encrypted: i=1; AJvYcCUct6vxiDHWWg4VmFtb8OjB5RBcGLCYl8WWc/ECnUdwpgsn5S1wsJEn91mYQ++0v0P0l1YFnZtY0EHB3ylbShOYa44= X-Gm-Message-State: AOJu0YzRxhMzzPcPiTjtFpKkq9+pCTIitcWWpz1H+pB6uh620OZkJnTI zyMIUA5mGfG8fMHSsQnZK3Ei7iVs90aANjvZ9lOk9nWrba2wAGVICv2hdnCDTY+w7I+YsgDocYt /3qJz/fSd3eRgwuC2vd+Jsh+Q4D5fQ7TCgBBy X-Google-Smtp-Source: AGHT+IFinXKb6sb/B8zLRBy/AQDpfa2WMQ7T0fuQo4Vb2ClhStHbMg6cFDXdplbrVSNLbw3WNy44RLQEoTSing9bmcM= X-Received: by 2002:ac8:73d9:0:b0:447:f958:ab83 with SMTP id d75a77b69052e-44b19e672cemr497141cf.21.1720564243653; Tue, 09 Jul 2024 15:30:43 -0700 (PDT) MIME-Version: 1.0 References: <20240708212753.3120511-1-yuzhao@google.com> In-Reply-To: From: Yu Zhao Date: Tue, 9 Jul 2024 16:30:06 -0600 Message-ID: Subject: Re: [PATCH mm-unstable v1] mm/truncate: batch-clear shadow entries To: Matthew Wilcox Cc: Andrew Morton , Bharata B Rao , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: A6786140012 X-Stat-Signature: jzafdkw4g5eo37tq7rcazio9a1i6oqb1 X-Rspam-User: X-HE-Tag: 1720564244-798841 X-HE-Meta: U2FsdGVkX1/k9b5QzpdWatJ4SJZOoQz3bDewxMNbWSLbE4hk5D8Zr3Z8orXynlZR0eHk1RGwA2UB6Z5hHsZXCgkz67YOhS5jrW2Wl/Pc6z2E8v5I0t7Mipar0rHsPecQAGbc1StZrErF2BbcBTi+KAUiBBW0vo5xed6zqAMm4bE0RyQ4U6PVt3AxVSyanIuq64tyaVCDoID/pfvBvClB8AvIg6ysVOGKL+R8Rj+gHPDxhbt6dUBcQ8P8zNK/W6LDOTLEb0XyHLD6iTsXP5ZD8IpterygRC7CFYR18SVCMREOIRmDeFwFAAUOgSF+dH2goFQZO88KeRze3KW3OQ75UgP9TYKQyv8+EWJSPD7NGEnqXmeliEdtRZhMKK3VXXfvTxDTKL53tY7nG8Too/okRYPbigY1EYgQ00xln4XwPK9sAvOychI6Nro9GcKI7oDDPojRGD89dJTMKk9BZK/fnq2OC/hHe+w6g0PIM9lbenTivNWESQvSnWfbKYWbVuGiSsIjVIlBjqGFdCst0P0d5ZzgngqqPO/gyQE2Vgw23T0D2DyOWCN1BakyDdzMp88Sr4l5b3MkMggt4dMjsILbFKgPx6z5lWjC2rgnQqIuMfC6+bsHVpGVX5/xJlpsDEM3c1Ev14RZtgGwqQMVsgNoXxUyZkQhOx5qf9pOE/J5xE1k7b6Dct5OYSoWRG2fb/DA+iTlJwd+DZZnHOnKaNR+2n1yY4BIE627OB7CFJ3vifYLY/bAVSlXu+yIIlMgrcnY1XZkMjPYfsUcdLxzPsAqY324yNSTUbC9gMKy8WebhkQyuTzOlVVl8kshkuZUaPD2nzhSny+G/Mqy7WAe0qJH7fq8yfvZ1CPdmatLbCViXyG9ik6qP4mCc14pGLoLqHbf8hXy//muvDocaMxfZpE7RPFEk+eD3QNb1m1V7/VXNQ627g04fnSpiaLpQy7qmngszDMHU/SKuKHwLCpLN1M kdTvAg+Y MY5QApgL01drT+NnCdXZWJXqdDomI+LP5LEDskxK5L7tY+Bg29JjRBloF55E0Z7ConIJGY7kzVqczPhB5rteEcQxjr7s8AUXzS/doYlAtC0T9pHbwe4xEu/jRhBwKFDr+HkjEAI1WyNGhkoTET6dBE9D+Syc8HTxccJx8oPNIZ81XINoVzNX9sqWesm4WLgagnMJNHXJKSRjdmhg+nEJ0B8Bv6Zpx7fbJ4SEZ X-Bogosity: Ham, tests=bogofilter, spamicity=0.002985, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jul 8, 2024 at 4:36=E2=80=AFPM Matthew Wilcox = wrote: > > On Mon, Jul 08, 2024 at 03:27:53PM -0600, Yu Zhao wrote: > > Make clear_shadow_entry() clear shadow entries in `struct folio_batch` > > so that it can reduce contention on i_lock and i_pages locks, e.g., > > I think it needs to be renamed, perhaps to clear_shadow_entries(). Yes, thank you. > > @@ -503,8 +486,8 @@ unsigned long mapping_try_invalidate(struct address= _space *mapping, > > /* We rely upon deletion not changing folio->inde= x */ > > > > if (xa_is_value(folio)) { > > - count +=3D invalidate_exceptional_entry(m= apping, > > - indices[i], = folio); > > + xa_has_values =3D true; > > + count++; > > Mmm. This is awkward. It's supposed to return the number of pages, > not the number of folios (or shadow entries) invalidated. I didn't think about this much. It seems to me no callers really care about it other than some debugging messages?