From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05D44C433EF for ; Thu, 14 Apr 2022 22:15:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0F9596B0071; Thu, 14 Apr 2022 18:15:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0A9926B0073; Thu, 14 Apr 2022 18:15:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E63BB6B0074; Thu, 14 Apr 2022 18:15:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0058.hostedemail.com [216.40.44.58]) by kanga.kvack.org (Postfix) with ESMTP id D40796B0071 for ; Thu, 14 Apr 2022 18:15:32 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 72835183A3529 for ; Thu, 14 Apr 2022 22:15:32 +0000 (UTC) X-FDA: 79356892104.27.C44A889 Received: from mail-vs1-f49.google.com (mail-vs1-f49.google.com [209.85.217.49]) by imf02.hostedemail.com (Postfix) with ESMTP id 0468C80009 for ; Thu, 14 Apr 2022 22:15:31 +0000 (UTC) Received: by mail-vs1-f49.google.com with SMTP id z139so341998vsz.0 for ; Thu, 14 Apr 2022 15:15:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gHW02OLiilkH2/+Tws3AW48zmC2lykajHWPQE7KEVbE=; b=cX6Ui3wEnVf9lN85AlE0FUWBTpgPIOpS5e99y4DrkVKNYMrdgCzmfdADxyijNbm6X1 fz6WHCq5ohnl6+yC1UncZ1WpwyrihRAm9+jQSz6roUqF3/rjYSLROEUKjtqFyl9yjNIW 7FHHbh6ObMLZbvzOvy94zur3rSlaNpITjBE+UFhtNiStA7J4ErpcYT5A2sbt7UjAeoXn CFYFmnrc3yVx9SOLuvGYpNrGFN2pqix/LOPwZbkZ1gQjNN9YpJqXxPcCKI75QgCXcLF9 RG1ruAr+T6nchpqowA3VtEiWGkXX+PzH5Wqrqn1mPSxULozp8gPcvMGiuZyRLtL1yhVy 3n0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gHW02OLiilkH2/+Tws3AW48zmC2lykajHWPQE7KEVbE=; b=NCKVY1hy5zth+lcFYFqTMw+OoXGMSaZWwIzRhYRjmAe5ew58p+a7v435cKT+rCiLP3 F9NShLvL8XRg8mbG/+iann2TVhAFwcTAFdYm4Zc0cb0sIXdsIDN75XweXN/GkBYp+jjg bV68UA0/5H5tg67ynZCMzOfQvj6pb+DiPbbWK+PJJ0yhso0NsL31jwYkOD5U/73URdV8 PskU3Hb/T4WjHuM3OOzaEaz07OFGApsywFDcULPGi69oOb1OEhfrT+c1kpzyJ64FUh8H C480dBaXMUzjPZjWmkknERygXOG3CuBNqyxepiiMGaP+lqwHvqwBbradntfhpXcLo12i h5/A== X-Gm-Message-State: AOAM533HTF0MYNcm/ANZWXlYUcE0vGzN1SDeRDVBqR/yxwoCAiWkXJ5Y PDnor3rF9H3bbr9h27Ngu5XD7mukW6HjQPj8+MJsQQ== X-Google-Smtp-Source: ABdhPJwseL3VhTE0AoGeVMgj+ftKNkyXKHXFohiK3nY6OH3s/IVxakxl8Gh+bQzen5ztytFfSWNkxCPOFoJ/uG2ezQg= X-Received: by 2002:a05:6102:5cc:b0:320:9bd2:3823 with SMTP id v12-20020a05610205cc00b003209bd23823mr2297960vsf.81.1649974531117; Thu, 14 Apr 2022 15:15:31 -0700 (PDT) MIME-Version: 1.0 References: <20220407031525.2368067-1-yuzhao@google.com> <20220407031525.2368067-7-yuzhao@google.com> <20220414143959.0daf4534613f2511b9b27f11@linux-foundation.org> In-Reply-To: <20220414143959.0daf4534613f2511b9b27f11@linux-foundation.org> From: Yu Zhao Date: Thu, 14 Apr 2022 16:14:55 -0600 Message-ID: Subject: Re: [PATCH v10 06/14] mm: multi-gen LRU: minimal implementation To: Andrew Morton Cc: Barry Song <21cnbao@gmail.com>, Stephen Rothwell , Linux-MM , Andi Kleen , Aneesh Kumar , Catalin Marinas , Dave Hansen , Hillf Danton , Jens Axboe , Jesse Barnes , Johannes Weiner , Jonathan Corbet , Linus Torvalds , Matthew Wilcox , Mel Gorman , Michael Larabel , Michal Hocko , Mike Rapoport , Rik van Riel , Vlastimil Babka , Will Deacon , Ying Huang , LAK , Linux Doc Mailing List , LKML , Kernel Page Reclaim v2 , x86 , Brian Geffon , Jan Alexander Steffens , Oleksandr Natalenko , Steven Barrett , Suleiman Souhlal , Daniel Byrne , Donald Carr , =?UTF-8?Q?Holger_Hoffst=C3=A4tte?= , Konstantin Kharlamov , Shuang Zhai , Sofia Trinh , Vaibhav Jain Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=cX6Ui3wE; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf02.hostedemail.com: domain of yuzhao@google.com designates 209.85.217.49 as permitted sender) smtp.mailfrom=yuzhao@google.com X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 0468C80009 X-Stat-Signature: 5kownkeyr1enjkyjk7kqphbcrn58p38m X-HE-Tag: 1649974531-699969 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 14, 2022 at 3:40 PM Andrew Morton wrote: > > On Thu, 14 Apr 2022 14:36:03 -0600 Yu Zhao wrote: > > > > or it is only something > > > meaningful for the internal code? > > > > This is how swappiness is interpreted. > > > > > if so, can we rename it to > > > something else? otherwise, it is quite confusing. > > > > Feel free to suggest something. > > It is confusing, swap_preference? It's still largely swappiness -- the original swappiness is twisted a bit around the corners (0, 1 and 200) to make it more suitable for internal use. I vote for __swappiness or lrugen_swappiness, which look ugly to me but it captures what this variable actually is, i.e., an overridden version of the original swappiness. And similar for lru_gen_mm_walk *walk vs mm_walk *walk. In other languages where polymorphism is supported, there are established naming conversions. In this patchset, I just used the same variable name when two things are closely related but distinguishable from the _contexts_ they are used.