From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0873EC00140 for ; Wed, 10 Aug 2022 17:54:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3FF806B0071; Wed, 10 Aug 2022 13:54:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3AE5B6B0072; Wed, 10 Aug 2022 13:54:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 277218E0001; Wed, 10 Aug 2022 13:54:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 150456B0071 for ; Wed, 10 Aug 2022 13:54:47 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 94C52414A8 for ; Wed, 10 Aug 2022 17:54:46 +0000 (UTC) X-FDA: 79784433372.19.E7D19ED Received: from mail-vs1-f49.google.com (mail-vs1-f49.google.com [209.85.217.49]) by imf23.hostedemail.com (Postfix) with ESMTP id 4B414140167 for ; Wed, 10 Aug 2022 17:54:46 +0000 (UTC) Received: by mail-vs1-f49.google.com with SMTP id s129so15898371vsb.11 for ; Wed, 10 Aug 2022 10:54:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc; bh=Rlv2WQ1JmFKF5LVuV05sS5o0PVRGZSe94PF6HIeV4q4=; b=RijjTTaUH2ZlP08yANZYBkSU9HSQOgcbY8bcsSTx0zMK/KC0OXPgf1Kc+FnhdK8HxM YS0Zjh8zGaezHcboSrpY0mqtXImQGhDM4H+lILyGcUa2SNtGnIS5FEk+dxx5KVZecXsV dqaTruyolmywIXWwPTijg574GzxvC1R2DJ+O3p0rs57TvDuzLjxIYU25lTw+NjLbfYJI 0AbW0n/kyGN0DNPiqE7Sbue5WUPoeKMNFFLgdpWgax6g75NkPZHTpnqnyoiRuEZf5rPY 8mQF0wp98Kcv+Fvndz9qaOxB5jHR2xc1oukiVN0ctlaGIcpHDlNsgHLyFZGTH+/YL07l udFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc; bh=Rlv2WQ1JmFKF5LVuV05sS5o0PVRGZSe94PF6HIeV4q4=; b=w/RFvTGU5N811Jk5/P310erKTHYR4cG8b1DaFUDbTknNYZVWfgWE8seJfTF+aK44CH m01ffssEAEdsyU5AwRfri7lMtsvSMs1lETbNBKnUJo/guZ5jxYiIH4S9OFSEzNVhzMBt KRtwlnhark6sNxs5kW0XhiX0k0Smzh9RppkdM6w2KJSgou7zKHnsJm4UIiT6R0R7XeRx vBgrdVOilEVy6FWWHAhdbgNu/3kyKBgqVueCuy9/aGEtug7ATo+gTg/xZAud2wEnD8Y2 bNvqMkmedPaMZbzeYupZcSIw63fuHOT3Jti2cmL/RJsFWFfFpAek61DBgUebkCrNycXU OBCQ== X-Gm-Message-State: ACgBeo0epndyZQeFfaQ/J0KulZ5qDNcEl2NVdAdZ4fM3oAMuhFX/CA5i XF6JS4kTfcdg0t3SueKz3GWik+9eTY7fEB9D1c0SXw== X-Google-Smtp-Source: AA6agR5kY/kLbzuH9ZykaZBVWHJV5Zhb70+5G9OYvVxmweSmQ5yeuSJXIzMQLuRs/5VyHzU9HKpuuu97NKmRrwn97Rk= X-Received: by 2002:a05:6102:665:b0:387:b34:d579 with SMTP id z5-20020a056102066500b003870b34d579mr11561008vsf.50.1660154085425; Wed, 10 Aug 2022 10:54:45 -0700 (PDT) MIME-Version: 1.0 References: <20220805184016.2926168-1-alexlzhu@fb.com> <0b16dbac6444bfcdfbeb4df4280354839bfe1a8f.camel@fb.com> <1F8B9D85-A735-4832-AD58-CA4BD474248D@fb.com> In-Reply-To: From: Yu Zhao Date: Wed, 10 Aug 2022 11:54:09 -0600 Message-ID: Subject: Re: [PATCH v3] mm: add thp_utilization metrics to /proc/thp_utilization To: "Alex Zhu (Kernel)" Cc: Yang Shi , Rik van Riel , Kernel Team , "linux-mm@kvack.org" , "willy@infradead.org" , "linux-kernel@vger.kernel.org" , "akpm@linux-foundation.org" , Ning Zhang , Miaohe Lin Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660154086; a=rsa-sha256; cv=none; b=i5ry9fNCiiXbKCX1EvqURKxVmhIEiMHaogSrtD3DmMeI6H1rLPbXnuOf4I5xFcxfdLt0Y0 jG8qkOw6a/ilRbj4WZsLhhxLirLKPGQyaN3WcgdOztWLy1KgWGlzfChipDV9aILcWWRZHQ p0fgHkSkn8OjyOwCSO9NIRgJuD1X58I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660154086; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Rlv2WQ1JmFKF5LVuV05sS5o0PVRGZSe94PF6HIeV4q4=; b=UOFd0gnl7P2cfSBfkMedt/XJHg2GH8vTv0Yv1wVpNGj/dY5lk+05a55Z87Nx8VQr7nq96u gWQKYyrSu1Suhc0imEM7y7Ow58krJ3GMPMu9qk+2bSESfOq6ihhHW1n0Q6b5UpESc2mh2P tvdlQBMrkk4GbWpXgMM0K/xl85d2Xow= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=RijjTTaU; spf=pass (imf23.hostedemail.com: domain of yuzhao@google.com designates 209.85.217.49 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com X-Stat-Signature: 39a3gdjzjyt344nmf6ft5zd847ecs5em X-Rspamd-Queue-Id: 4B414140167 Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=RijjTTaU; spf=pass (imf23.hostedemail.com: domain of yuzhao@google.com designates 209.85.217.49 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1660154086-136775 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 10, 2022 at 11:15 AM Alex Zhu (Kernel) wrote: > > > > On Aug 10, 2022, at 10:07 AM, Yang Shi wrote: > > > > On Tue, Aug 9, 2022 at 4:36 PM Yu Zhao wrote: > >> > >> On Tue, Aug 9, 2022 at 11:16 AM Alex Zhu (Kernel) wr= ote: > >>> > >>> > >>>> OK, it is hard to tell what it looks like now. But the THPs on the > >>>> deferred split list may be on the "low utilization split" list too? > >>>> IIUC the major difference is to replace zero-filled subpage to speci= al > >>>> zero page, so you implemented another THP split function to handle i= t? > >>>> > >>>> Anyway the code should answer the most questions. > >>> > >>> They can indeed end up on both lists. This did have to be handled whe= n > >>> implementing the shrinker. > >>> > >>> We free the zero filled subpages, while modifying the existing split_= huge_page() > >>> function. Will follow up that change in another patch. > >> > >> FYI. This series does it: > >> > >> https://lore.kernel.org/r/20210731063938.1391602-1-yuzhao@google.com/ > >> > >> And this one: > >> > >> https://lore.kernel.org/r/1635422215-99394-1-git-send-email-ningzhang@= linux.alibaba.com/ > > > > Thanks, Yu. I totally forgot about these series. It is time to refresh > > my memory. > > I looked through these patches yesterday. There are indeed parts that are= very similar, but the approach > taken seems overly complicated compared to what I have written. What=E2= =80=99s the status of work on this since last year? Overly complicated... which patches and how? At a minimum, you'd need 1 & 3 from the first series and this patch: https://lore.kernel.org/r/20220608141432.23258-1-linmiaohe@huawei.com/