From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8579EC4332F for ; Fri, 30 Dec 2022 21:59:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 116E58E0002; Fri, 30 Dec 2022 16:59:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0C7518E0001; Fri, 30 Dec 2022 16:59:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EF77D8E0002; Fri, 30 Dec 2022 16:59:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id DE27C8E0001 for ; Fri, 30 Dec 2022 16:59:46 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 9D8621A04CA for ; Fri, 30 Dec 2022 21:59:46 +0000 (UTC) X-FDA: 80300340372.14.5CE8119 Received: from mail-vs1-f50.google.com (mail-vs1-f50.google.com [209.85.217.50]) by imf23.hostedemail.com (Postfix) with ESMTP id 1D84C140007 for ; Fri, 30 Dec 2022 21:59:44 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=ZlXVJI2u; spf=pass (imf23.hostedemail.com: domain of yuzhao@google.com designates 209.85.217.50 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672437585; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ojCvjpUwmQcpqlhAqAXahIQg5LmJzJtnHdnov88yJMs=; b=U21txqk31dz7/f6jNeKgKY6gpIdMknzsOaT7erYuUd0GGjqKyLisvfQa4ymz2hAvCHxHKP npMcbZ160GV28Hp2tAkjirOo9xvj0EMf34h8GqZBXi2Kg5m6JvhXVMMUCD3CfZdG8tjGl/ bo1ab/L3Tj2WkYGudc/Qslwpd2qFgC4= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=ZlXVJI2u; spf=pass (imf23.hostedemail.com: domain of yuzhao@google.com designates 209.85.217.50 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672437585; a=rsa-sha256; cv=none; b=0DrOBDEnYcLX/2ppBwiQpruRIO6ZH3wvbY3+yz23NjirBQAI1uwjDibRTPTpHIVM7UHqU+ RDyIhqhfrHbzmzFYZ9j5mdE2J3A9ImYBZCJbguT2aGb1Aocc92jvjFOWPt/P4XNaL7Xb5z xMVCsHSTa1bpnG/Wbo9t8oFTrLGrMKE= Received: by mail-vs1-f50.google.com with SMTP id k4so18365085vsc.4 for ; Fri, 30 Dec 2022 13:59:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ojCvjpUwmQcpqlhAqAXahIQg5LmJzJtnHdnov88yJMs=; b=ZlXVJI2uLZhNL3WGmXGzQbeJ+Y9BZcsePf40pR3SW0CbR6qoB+Ce9wZvSMjvacx3TK VR5gqxU9e5BtU360p9T8tGR3aNMt1abiiG2Jos2ghZFmXEx9eNiH0NPr7FFwacW5i3f8 xhBbOGNegv3yvGegSG6BZ3za7+mvKWD4+06557JEYa7qjgszntkNt+84dhY/IVM6mvU2 r40JZJrBvzdHysFXwtHNOfp6D6MKTqhP9bdDEegX21uONIX6QXjLNSuMXlchC/xHRCkK 6EgsbOyze+/xSUh7Wz7F+op/f7aIKl09JEg1qD5+llHkHvYUHWTQYEJe/OjXIbaQ1ynR sjVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ojCvjpUwmQcpqlhAqAXahIQg5LmJzJtnHdnov88yJMs=; b=0q9UMI75uog3s4yb0GM8m3j9y7x2bFd3RRh297VEv3rfBiWnknyymzLNpDG3mQQ/h4 VT6ItyPbD1+kRBmho7N92WnBczYj8qS9S8Gr7pMMx6rUxzMIaCfrlmGI5dcBTWyje6lY mtwUWNhQDWPuVR68rUjkzLq3Vh0DwnXh4jAoT+fgFJPw8JlzfilbxYz6XkWIY7L7yT5f 2w8EkQ53oXdnjzoOQAl8sjf73R2MnFCQuECtT2+qyNbQIYbTj4RPVXqA8A6qVYwPwPRg 5n5KKRF/Me9gucU1QzDa1fgkq4+RNoiIk4j0Q4xsQ2yOvaKPjoVKP35SDfJAE2cRGFyH gUQQ== X-Gm-Message-State: AFqh2kqA6euNpr139CC9KYFRL14BrxV4m/uhaPJVX0P2jX63SGUBe1/G DtevP121k/ioL9R/RfuRFFiGGL/ibSueVzkvbS66qA== X-Google-Smtp-Source: AMrXdXsMbDKNYMIrLNNEHL37FFgKk2+piZDk5e8JDw1OEPqIetTy7RlBmJ1yAcxxST6OWGS2se4bKXJHEFqLA2nsLdU= X-Received: by 2002:a05:6102:3d9f:b0:3c4:4918:80c with SMTP id h31-20020a0561023d9f00b003c44918080cmr2914595vsv.9.1672437584212; Fri, 30 Dec 2022 13:59:44 -0800 (PST) MIME-Version: 1.0 References: <20221222061341.381903-1-yuanchu@google.com> <20221222104937.795d2a134ac59c8244d9912c@linux-foundation.org> <20221222122937.06b9e9f3765e287b91b14954@linux-foundation.org> In-Reply-To: <20221222122937.06b9e9f3765e287b91b14954@linux-foundation.org> From: Yu Zhao Date: Fri, 30 Dec 2022 14:59:08 -0700 Message-ID: Subject: Re: [PATCH 1/2] mm: add vma_has_locality() To: Andrew Morton Cc: Yuanchu Xie , Ivan Babrou , Johannes Weiner , Alexander Viro , Steven Barrett , Brian Geffon , Oleksandr Natalenko , Suren Baghdasaryan , Arnd Bergmann , Peter Xu , Hugh Dickins , Gaosheng Cui , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 1D84C140007 X-Rspam-User: X-Stat-Signature: wqn7iq4ten1tg6tnbn17pratgikkghfn X-HE-Tag: 1672437584-666351 X-HE-Meta: U2FsdGVkX1+BAhtyvilxbnoRuoBBIWdZqr5XTt2fxifsYZFmvHNCNBwa0Wh3K3nKwV1fdBhJX3SkKESIHx08BgZCaWvv1iy9CAKaJhmpgylE7V1dDa9QucyyCDxx2veI9HxIx3/+s1OSa/eacs5/ZiM6Q9cYiucDRxfLy+rQdAXrVuttCfIbKEKKWkwtbSd7UeZa4p/dmm1neY9Ecauz1eZuWKrTXVzmUNZwYTFvV315onKDJYzdlPuHFOM5TWg5opEmI+dH0nTYmCtfKJQW355gv/8v2pIbKuZVm4trJ60B8kBqFDZjVy0GLb/G18EnBwF8HcpXIARvXL5bWuDvtlvnp6a4wNvWZKI+fD1WthJ2O/m4vh6gdh/dXRhPqORQXmPsNHQL9TvwkwAOYISqhot+rZAWXun/ALhFfT204/Ma2H+W3wsQTSXLr8RtFyWeR4bVkYfndAunYTayCAV96EH72C+RCixvsgkDOtiHo/gUSujU67qEpjVSFd/TEohQahnREBO/2Dr8gpJiZo4o42u5GlbBQP12glrK9iZbdxP6aorgKTcdqmENM9Cfre8P6kfmGTSf+joFamjO860r3w8X52rR850N86sX2f+OB/GjKKaG0rI5m9Zi2q2xi3vI62r7K85ZHnW0Bn6xabnOlrZN/pziSrBPtkXAdVSvDUTBU7E3GIoGMZLV2kITKNx5wXvH73rmAdeU4vx9Yi0wfP9frEKl7F2nVUYWmCKCPB+0j2u6kTdutZ58QQN3OabKRgnxT6aPFqpv+faQ2dIyEvpd7GDe/Firvrc63jkhrlEjZtvLgzOOXZQokAi54qdUMJ8Di8Mui7RWpgc3IoHvM+cyilSfiANruxqGkv9vlxWCM57V1fXVLUccWasFF6CC/Ik0OSmj5PHhFZ0eyy6RTA3LVkuKepa+/Yo9toxdKRI+XR2sC6Q8omVim4i/W1UDsUWRPeOSLEtK8LMGd0Y 48pE/pF/ fuSlC6VvtiMELS2Ja6Oqpb4XbtemJr8SAY2MmXvSD/fpP3AmorcZS15LD2g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Dec 22, 2022 at 1:29 PM Andrew Morton wrote: > > On Thu, 22 Dec 2022 12:44:35 -0700 Yu Zhao wrote: > > > On Thu, Dec 22, 2022 at 11:49 AM Andrew Morton > > wrote: > > > > > > On Wed, 21 Dec 2022 22:13:40 -0800 Yuanchu Xie wrote: > > > > > > > From: Yu Zhao > > > > This works; suggested-by probably works even better, since I didn't do > > the follow-up work. > > > > > > Currently in vm_flags in vm_area_struct, both VM_SEQ_READ and > > > > VM_RAND_READ indicate a lack of locality in accesses to the vma. Some > > > > places that check for locality are missing one of them. We add > > > > vma_has_locality to replace the existing locality checks for clarity. > > > > > > I'm all confused. Surely VM_SEQ_READ implies locality and VM_RAND_READ > > > indicates no-locality? > > > > Spatially, yes. But we focus more on the temporal criteria here, i.e., > > the reuse of an area within a relatively small duration. Both the > > active/inactive LRU and MGLRU rely on this. > > Oh. Why didn't it say that ;) > > How about s/locality/recency/g? Thanks. I've done this, and posted the v2 which includes much better commit messages.