From: Yu Zhao <yuzhao@google.com>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: linux-mm@kvack.org
Subject: Re: [bug report] mm/mglru: fix underprotected page cache
Date: Fri, 12 Jan 2024 00:42:37 -0700 [thread overview]
Message-ID: <CAOUHufYWxQ6Sn35ueznsvO71tfVHhvO+MqiiRFWr_cmM-z4ScA@mail.gmail.com> (raw)
In-Reply-To: <1eeadcc6-8c6a-4ba6-ab2f-1ec3b5d4730e@moroto.mountain>
On Fri, Jan 12, 2024 at 12:13 AM Dan Carpenter <dan.carpenter@linaro.org> wrote:
>
> Hello Yu Zhao,
>
> The patch 081488051d28: "mm/mglru: fix underprotected page cache"
> from Dec 7, 2023 (linux-next), leads to the following Smatch static
> checker warning:
>
> mm/workingset.c:318 lru_gen_refault()
> warn: always true condition '(refs >= ((((1))) << (__builtin_choose_expr((4 == 4), (((2) < (64 - 26 - 3 - 3 - 0 - 10 - 0 - (8 + 14))) ?(2):(64 - 26 - 3 - 3 - 0 - 10 - 0 - (8 + 14))), ))) - 1) => (s32min-s32max >= 0)'
>
> mm/workingset.c
> 308 atomic_long_add(delta, &lrugen->refaulted[hist][type][tier]);
> 309 mod_lruvec_state(lruvec, WORKINGSET_ACTIVATE_BASE + type, delta);
> 310
> 311 /*
> 312 * Count the following two cases as stalls:
> 313 * 1. For pages accessed through page tables, hotter pages pushed out
> 314 * hot pages which refaulted immediately.
> 315 * 2. For pages accessed multiple times through file descriptors,
> 316 * they would have been protected by sort_folio().
> 317 */
> --> 318 if (lru_gen_in_fault() || refs >= BIT(LRU_REFS_WIDTH) - 1) {
> ^^^^^^^^^^^^^^^^^^^^^^^
> In my x86 allmodconfig this is zero and refs is always >= 0. This could
> be intentional, but I thought it was worth checking.
Appreciate the manual work!
This indeed is intentional if LRU_REFS_WIDTH is 0. What would be the
best way to suppress this warning?
next prev parent reply other threads:[~2024-01-12 7:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-12 7:13 Dan Carpenter
2024-01-12 7:42 ` Yu Zhao [this message]
2024-01-12 8:29 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOUHufYWxQ6Sn35ueznsvO71tfVHhvO+MqiiRFWr_cmM-z4ScA@mail.gmail.com \
--to=yuzhao@google.com \
--cc=dan.carpenter@linaro.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox