linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Yu Zhao <yuzhao@google.com>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	 Jeff Xu <jeffxu@chromium.org>,
	"Liam R . Howlett" <Liam.Howlett@oracle.com>,
	 Jann Horn <jannh@google.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	 David Hildenbrand <david@redhat.com>
Subject: Re: [PATCH] MAINTAINERS: update MEMORY MAPPING section
Date: Fri, 13 Dec 2024 02:00:09 -0700	[thread overview]
Message-ID: <CAOUHufYSQFNS16YBe1W=ZpxzT0r5yKLj-56az+fpioGf2BqWsA@mail.gmail.com> (raw)
In-Reply-To: <e3a61eb1-2224-4700-8df2-28a93e2aa1a6@suse.cz>

On Fri, Dec 13, 2024 at 1:25 AM Vlastimil Babka <vbabka@suse.cz> wrote:
>
> On 12/13/24 06:50, Yu Zhao wrote:
> > On Wed, Dec 11, 2024 at 11:57 AM Lorenzo Stoakes
> > <lorenzo.stoakes@oracle.com> wrote:
> >>
> >> > I'd like to be added as a reviewer on mm/mseal.c.  Is there any way to
> >> > indicate this from this file ?
>
> I don't think the format and tooling supports adding a reviewer for a single
> file out of a subsystem. mm/mseal.c would have to be an own subsystem, or
> Jeff would be indicated as a reviewer for whole memory mapping.
>
> >> This is something we can consider in the future, sure.
> >
> > What'd be the downsides of having an additional reviewer?
>
> General answer to general question: being R: means 1. getting email for
> patches touching the files (if people use tooling properly, sigh). This can
> be also achieved on the receiver wised by e.g. the lei tool.
> 2. being perceived as an authority for people sending patches, some of them
> not being familiar with the subsystem and the people working on it.

I think you are saying 1 & 2 above (the meaning of being R) can lead
to the following?

> This is
> why it could be counter productive to be given out to just anyone who asks.

I understand the words, but I still don't see the logical connection.
Also, Jeff is not "anyone", and I'm not sure why he can't be
"perceived as an authority" on mseal.

Anyway, I would encourage more technical contributions rather than
"administrative" barriers.


  reply	other threads:[~2024-12-13  9:00 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-11 10:53 Lorenzo Stoakes
2024-12-11 18:36 ` Jeff Xu
2024-12-11 18:57   ` Lorenzo Stoakes
2024-12-13  5:50     ` Yu Zhao
2024-12-13  8:25       ` Vlastimil Babka
2024-12-13  9:00         ` Yu Zhao [this message]
2024-12-13  9:10           ` Vlastimil Babka
2024-12-13  9:17       ` Lorenzo Stoakes
2024-12-13  9:23         ` Lorenzo Stoakes
2024-12-13  9:36         ` Yu Zhao
2024-12-13 15:05         ` Jeff Xu
2024-12-13 15:19           ` Lorenzo Stoakes
2024-12-12  8:09 ` Vlastimil Babka
2024-12-12 14:40 ` David Hildenbrand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOUHufYSQFNS16YBe1W=ZpxzT0r5yKLj-56az+fpioGf2BqWsA@mail.gmail.com' \
    --to=yuzhao@google.com \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=david@redhat.com \
    --cc=jannh@google.com \
    --cc=jeffxu@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox