From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF3B5C001B2 for ; Thu, 22 Dec 2022 19:52:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 52742900003; Thu, 22 Dec 2022 14:52:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4D787900002; Thu, 22 Dec 2022 14:52:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 39F42900003; Thu, 22 Dec 2022 14:52:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 2E701900002 for ; Thu, 22 Dec 2022 14:52:46 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 0C325AAAE6 for ; Thu, 22 Dec 2022 19:52:46 +0000 (UTC) X-FDA: 80270989932.23.9A6589F Received: from mail-vk1-f180.google.com (mail-vk1-f180.google.com [209.85.221.180]) by imf07.hostedemail.com (Postfix) with ESMTP id 7848F4001E for ; Thu, 22 Dec 2022 19:52:44 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=USvUd87M; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf07.hostedemail.com: domain of yuzhao@google.com designates 209.85.221.180 as permitted sender) smtp.mailfrom=yuzhao@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671738764; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1knc7b7bkvXdXPfMt9YKoMsAvgwNeZbmN9qBo7ZQ/FM=; b=uWXS3jaIV9yh7J7dh96YPC6rz/cWDadzlvoQz/zQL2ES+uQuCm2xTZJ3UwIIX4C9xo1WNN /su/exiKQZxVHxkjtJLQ15mHT57/wA4icPwAgkDuVR99rzral1Rh9RTvQqSvhM3C5QwrtV O1Ri+7No2A423mtCPNQQKaylaV99FcA= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=USvUd87M; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf07.hostedemail.com: domain of yuzhao@google.com designates 209.85.221.180 as permitted sender) smtp.mailfrom=yuzhao@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671738764; a=rsa-sha256; cv=none; b=L8C43lXzOXkIv4rHUEwLs8a44jyDRBj9nKjsFOmoBDnlPhjct8PHAN0QnElTZQwJeaUo8b RgGfO4IE0q72jqcB+9wPimAiYACQA3We37mwEluL6UL01ZjyuF8/1gOjxxDPkRqH6KICtS 8uvrzD+74WIEfbQ1G4bZ0hpHDm01kKI= Received: by mail-vk1-f180.google.com with SMTP id t4so123038vkt.7 for ; Thu, 22 Dec 2022 11:52:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=1knc7b7bkvXdXPfMt9YKoMsAvgwNeZbmN9qBo7ZQ/FM=; b=USvUd87Mb0zOooOPpuhbGREHxvLaWuV51l8idqP7PcPFsyK6L2JyNx39ZSoQdXVfai OGGOq3OWAIO3INr9HPrnRnHrJ8Tk+s4KM/BacF90k3jhTzyl/tW+S+G5+kkhp85zLU5N t5nSd8Skr8AJtmuwa9K3nf1DTIyUyRNeuUMWOC9RRXwDQsq6t7TLbCiOuYPXKxqzInHG aOQndXAh78UAW3p4vB4jwy2GJE4uiSXlMavNgOh9OtHKqFcREA6UqJ6RlGHGv0Uw0ItD 4r2Jvwv/MZqd4JT7itetc5LYmpHLDs8IZK/O7hVPu02tFJaWDIVIKr5LfSmdDtmgkuTj T9bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1knc7b7bkvXdXPfMt9YKoMsAvgwNeZbmN9qBo7ZQ/FM=; b=N0Q3yFXymKUELnATHOJUd4rhccyDUsVFNG9cN/aW4ExpY5nfY9Kj7PPIBZPYY7Ma2i 0wISvucgLV89nG/RX6mLbPM5jPH5m/9yxsKBFhieJtyYy/UDIzSYVqiVLZeX0oYanZX7 S02i3akj8TXRhihKAvizTqwR+eY+MBgxJrhS7ZxtMKJ7JFlUoyJFIvIwPt+FaH24Fk0i vGQqkD2wpZ+Pl5KFTVnJLMEz4lFXyHRf449sXzzIjTqK697RIOIzrMKu1pXHiOQL6cEI lruNHm9zeTnK5omz7WuoX/btaKuO0ouvLTk3pssnZd50MbWq2P4OdZFKdQm+WjLAoKtO nVng== X-Gm-Message-State: AFqh2krBKn6HvoHy632Ow72QQVGSQg5pU48F9AYJNo5r0KuKicA3K/lT 4qhvWz37cFR27rNbcsmz+xxkif+YSoh/sV3WDiiunw== X-Google-Smtp-Source: AMrXdXvE5I8dhv8FjwC9O4WzXUntlzKQ4NhndP0HGdMPybFzPPykl2av9rwFu5gmyM7Dl3pniiM9k17bBOP1+aEqb8g= X-Received: by 2002:a1f:43d3:0:b0:3bc:65ea:864f with SMTP id q202-20020a1f43d3000000b003bc65ea864fmr797713vka.30.1671738763518; Thu, 22 Dec 2022 11:52:43 -0800 (PST) MIME-Version: 1.0 References: <20221222061341.381903-1-yuanchu@google.com> In-Reply-To: <20221222061341.381903-1-yuanchu@google.com> From: Yu Zhao Date: Thu, 22 Dec 2022 12:52:07 -0700 Message-ID: Subject: Re: [PATCH 1/2] mm: add vma_has_locality() To: Yuanchu Xie Cc: Ivan Babrou , Johannes Weiner , Alexander Viro , Andrew Morton , Steven Barrett , Brian Geffon , Oleksandr Natalenko , Suren Baghdasaryan , Arnd Bergmann , Peter Xu , Hugh Dickins , Gaosheng Cui , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 7848F4001E X-Stat-Signature: 1miht7g3gp51h8fuh31xr7enngk5xe7c X-HE-Tag: 1671738764-7472 X-HE-Meta: U2FsdGVkX1/8QE/Oxc4n1RGSuXP6NJKLSy4Ilxz7vh2Gvu2ChZO5hItZ73H7j1Y2B6Bd+cMEbplF6xX1DQFH07HzKh7eqe0zr3s03ga+vclJu47rJuNdVCkqQUTg+Dsk5w2hUzJ3B+25X+FeZQ0pynul+U9upsW7bSMMoyr+mwEv86Fp8lmQ6Bsgh8FglshPgPbQK6Pcrh6HPM7MIQpe3gKeJUzrFAO2uiulMJblgMjBQaWggLk1v112iMl1r9VMYeIYOxUSHdCuGffPgcP0WKI8yCJcu8Saa2ZVSg/bffXgEqWYP9wSPuhEd0Jxzz87G4+U3PItcv5FBuZdv7teg41tYYKhZkm7ZNXFLYuwdPWdIDJFYlSbxSZKWU3GMgqv69WA28zDHDf6wC+NwDKwUSWILHHsciyeI34W/m8wosiGkNJhj33haF+hXpuU2X6Om2g5BycLZkzTNfZhvLsFqiYn+lg0OI8jrXehAgL3Ltt2INAFwb6PnB9s0qMNMjpgVrzGhoC4Np7WpmDFK/03Lw6XfKA96KM0wgzVcMkqw8akzn51N3dfVUuhchi2w14tMjh9700vdqXyjLlK5IT7AoPpyZSIXOeru0IZ+QGHcJxAqtkdKSSsDJtolLBpbskI8i4XAsXeUQ9aK0exq0BBdOmZVSJs1zTNCG05TaFuTc09BxRgrXnpLPwDBboTX2zlw2N9QnHRpAIVMSSgtSFxEDLWRh375oFY/TLpVFpi3QXFSlbWEt8bfsIDQ8mlxmlb3CeX9xMzOjfdZzvQdE3cjdmlnTtwLoXabmf0lJjMlWwVxbDMJYPAh+8xWra/znxTD0EdtvbmOC4+GLPq1BuUD3TUKZzPs7yrnJltf4WEFzVVTtnEUwerJJLCkpQ+28QNM+gSrIMQ6l89udAV67HE/TJ8UtSaPUJ8C0gVtsxXdGJhIf9VSd9tet+cO2LzUxR9cfKt37cAzYghPr35ZCg qd1i5Zyk 07Jd4h0+rkmitBAnoYsS4yEG2mECNp4lsT20OeGHUSq/rbphYevhvACK1iA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 21, 2022 at 11:13 PM Yuanchu Xie wrote: > > From: Yu Zhao > > Currently in vm_flags in vm_area_struct, both VM_SEQ_READ and > VM_RAND_READ indicate a lack of locality in accesses to the vma. Some > places that check for locality are missing one of them. We add > vma_has_locality to replace the existing locality checks for clarity. Need benchmark results. A simple fio test will do; doesn't need to be the curl one. > + /* > + * If we are reclaiming on behalf of a cgroup, skip counting on behalf > + * of references from different cgroups Nit: add a period at the end. > @@ -906,6 +908,7 @@ int folio_referenced(struct folio *folio, int is_locked, > .arg = (void *)&pra, > .anon_lock = folio_lock_anon_vma_read, > .try_lock = true, > + .invalid_vma = invalid_folio_referenced_vma, Nice. (What I suggested isn't as clean: https://lore.kernel.org/all/Y31s%2FK8T85jh05wH@google.com/)