From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42B97C433F5 for ; Wed, 5 Oct 2022 21:14:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A777E6B0071; Wed, 5 Oct 2022 17:14:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A272D6B0073; Wed, 5 Oct 2022 17:14:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8EED26B0074; Wed, 5 Oct 2022 17:14:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 7B1586B0071 for ; Wed, 5 Oct 2022 17:14:20 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 51505140DF1 for ; Wed, 5 Oct 2022 21:14:20 +0000 (UTC) X-FDA: 79988149080.27.B0B464C Received: from mail-vs1-f44.google.com (mail-vs1-f44.google.com [209.85.217.44]) by imf15.hostedemail.com (Postfix) with ESMTP id E8ED9A0021 for ; Wed, 5 Oct 2022 21:14:18 +0000 (UTC) Received: by mail-vs1-f44.google.com with SMTP id t18so164427vsr.12 for ; Wed, 05 Oct 2022 14:14:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=cN737y3rFnqPr5hK14+5V1D+jLG9F1NJvLgYSv/BW3Q=; b=m7u9bzZ+v0v4cC+WovU8Rc5TX7yyu3iQY8wm4xQpdfGxClu5PDZJPcsoF1xnpzGqZ4 tSxxQR5BiHq5xB1bXuS/NaMYPC+OK1FvAT5VNuQhqPGRrP3IpwzhxXjvgkoUqJmKWbVj ds0meJVAmA/HT1WymnHW2SdfeuuAWp6p3BB/IONL5/G/s0ZjyMGTps9vCg5cqUTh/79C cVyUTeLI2gs7pous/40q2pAs60gmhbGIziAv601fzEC38amdKC3xUWeCaS6IZeObYr8u mmmOAjeAXu9QlueCgnC4Bzrs+Ogra4s6RJ2ZmYRxIIApbHytIATg3g1SO1bEAQ8jYyKL okkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=cN737y3rFnqPr5hK14+5V1D+jLG9F1NJvLgYSv/BW3Q=; b=KhR1EKf9QgIr9GwZ9oomBV9BxiULRVvI5O9AAqb7Fq4mu6Pe4lgI1//GMf5k0dMRcL 1yRtvjBpVaXk7HdD0/H+HOHU+UEZ0MUjuTy64p7P6WDA0ouS9cSa9LG3bZGspubiD/4W cWu8AA/VAfzfQQ4AoPIbeRo8myh3KU8amO1+zkJDPoBzGxumOteGfzX5YrswqPFgwexg Bs+jhgHtB4DZYwP0zxHSGkCcWaHxPYaht53s3X1yRhnZZ96ZfxYHvkoBJUWEXOtSEb6W VoCjFwqczwZOSvuUiMNGK5Y80i7ly9tQSfhgCWYRMvaGWfr6VDrIbfgzzNccQHMBJi62 vQoA== X-Gm-Message-State: ACrzQf210PupSdb7634nxvsSeoHEecwZXlaqiY7UVRYBWlpw1xwvuk0p bgyxfwsdvxRCLOy4Pjd7yChDni42To5FZ/jfd0dG/w== X-Google-Smtp-Source: AMsMyM5g0dHid+ksefS25KT9kew8SpkqJGuIferob/ufa0Xm55Rk+vs6rLWj9e2MiCZyPr0GKvsLsZoKEg5YPZiOX84= X-Received: by 2002:a67:d50c:0:b0:3a6:8ed7:3f00 with SMTP id l12-20020a67d50c000000b003a68ed73f00mr747101vsj.15.1665004455202; Wed, 05 Oct 2022 14:14:15 -0700 (PDT) MIME-Version: 1.0 References: <20221005173713.1308832-1-yosryahmed@google.com> In-Reply-To: From: Yu Zhao Date: Wed, 5 Oct 2022 15:13:38 -0600 Message-ID: Subject: Re: [PATCH v2] mm/vmscan: check references from all memcgs for swapbacked memory To: Yosry Ahmed Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Greg Thelen , David Rientjes , Cgroups , Linux-MM Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1665004459; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cN737y3rFnqPr5hK14+5V1D+jLG9F1NJvLgYSv/BW3Q=; b=s0HCRIZrFwGdKNfOrP0nBJB5j/7jtgRRpxQTQFk0syoolZdHLT37Ku7j5OsHPrjeWraADP Dk1aT4VnHl4N/gq1LCdQyLx4Fe+YrYnTEev3qwlHuLy6IRiY+GopbzBkbHBsKr0qlScNAI hPW3paZN45ro/WP9QD0B8Vcl2wmJyfc= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=m7u9bzZ+; spf=pass (imf15.hostedemail.com: domain of yuzhao@google.com designates 209.85.217.44 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1665004459; a=rsa-sha256; cv=none; b=3uz9WmqZ/xTKES3oIvoHhCPeW7gUqXo/3gT3RpRf1g0xxGJBaXwNVglChWKL3b2VU/Z0mK R47FpSEhIlOekXxvpFd5cj6y8EXe8VhWDt+UzCHJowpUppVU1Cnfj6RGG4HCJ7s4VxtIzN v/2y5y8HB8tm+h0Ye51jnzjWsYRAmZc= X-Rspamd-Queue-Id: E8ED9A0021 Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=m7u9bzZ+; spf=pass (imf15.hostedemail.com: domain of yuzhao@google.com designates 209.85.217.44 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspamd-Server: rspam06 X-Rspam-User: X-Stat-Signature: 989xj79zkcukdj46cyt5a3fiu4w34u8s X-HE-Tag: 1665004458-975910 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 5, 2022 at 3:02 PM Yosry Ahmed wrote: > > On Wed, Oct 5, 2022 at 1:48 PM Yu Zhao wrote: > > > > On Wed, Oct 5, 2022 at 11:37 AM Yosry Ahmed wrote: > > > > > > During page/folio reclaim, we check if a folio is referenced using > > > folio_referenced() to avoid reclaiming folios that have been recently > > > accessed (hot memory). The rationale is that this memory is likely to be > > > accessed soon, and hence reclaiming it will cause a refault. > > > > > > For memcg reclaim, we currently only check accesses to the folio from > > > processes in the subtree of the target memcg. This behavior was > > > originally introduced by commit bed7161a519a ("Memory controller: make > > > page_referenced() cgroup aware") a long time ago. Back then, refaulted > > > pages would get charged to the memcg of the process that was faulting them > > > in. It made sense to only consider accesses coming from processes in the > > > subtree of target_mem_cgroup. If a page was charged to memcg A but only > > > being accessed by a sibling memcg B, we would reclaim it if memcg A is > > > is the reclaim target. memcg B can then fault it back in and get charged > > > for it appropriately. > > > > > > Today, this behavior still makes sense for file pages. However, unlike > > > file pages, when swapbacked pages are refaulted they are charged to the > > > memcg that was originally charged for them during swapping out. Which > > > means that if a swapbacked page is charged to memcg A but only used by > > > memcg B, and we reclaim it from memcg A, it would simply be faulted back > > > in and charged again to memcg A once memcg B accesses it. In that sense, > > > accesses from all memcgs matter equally when considering if a swapbacked > > > page/folio is a viable reclaim target. > > > > > > Modify folio_referenced() to always consider accesses from all memcgs if > > > the folio is swapbacked. > > > > It seems to me this change can potentially increase the number of > > zombie memcgs. Any risk assessment done on this? > > Do you mind elaborating the case(s) where this could happen? Is this > the cgroup v1 case in mem_cgroup_swapout() where we are reclaiming > from a zombie memcg and swapping out would let us move the charge to > the parent? The scenario is quite straightforward: for a page charged to memcg A and also actively used by memcg B, if we don't ignore the access from memcg B, we won't be able to reclaim it after memcg A is deleted.