From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBB88C77B75 for ; Mon, 22 May 2023 05:27:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6992C6B0074; Mon, 22 May 2023 01:27:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 64992900002; Mon, 22 May 2023 01:27:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 511BF6B007B; Mon, 22 May 2023 01:27:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 44B2A6B0074 for ; Mon, 22 May 2023 01:27:27 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 0175E120726 for ; Mon, 22 May 2023 05:27:26 +0000 (UTC) X-FDA: 80816758134.04.C0126F2 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by imf21.hostedemail.com (Postfix) with ESMTP id 0B9F11C0006 for ; Mon, 22 May 2023 05:27:24 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=CxIsFQHw; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf21.hostedemail.com: domain of yuzhao@google.com designates 209.85.128.47 as permitted sender) smtp.mailfrom=yuzhao@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684733245; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nUYFaqomu9xKCIIon32Rhv6GrSs1+seRAs7JgNCqEgg=; b=AzHpy2BYyPhHffzE9Mf3h/Dot+hDhL+8+XySNekZCv6uHVL0jfA/akbaF0HiBVaNAc+UlR OHanZsJNlkAFCfCMPbkxAjFa4rkfqnsnd+sNm2KLnVHzbFN9xvOgR1GGpdJsd1PFrTxaor 7OIbughkId3n5iiCZexLPIoPajQ9Jpw= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=CxIsFQHw; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf21.hostedemail.com: domain of yuzhao@google.com designates 209.85.128.47 as permitted sender) smtp.mailfrom=yuzhao@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684733245; a=rsa-sha256; cv=none; b=Pj63diXUg+Kk6rn+UmatHhn036XFK/yiqH/s78vJcdqPmxvIf8reJLziDqOZv5x0ah0hs8 HORfzq0QE0u5TwyLQ1hpzJYB84mPdHG/pERys2sq/HqoYBYoA+/NY9EctXwvZhYPgk48qK 6Fjvpm3UXOolWoDz2ekfv/AOuTDgsSg= Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-3f600a6a890so21865e9.0 for ; Sun, 21 May 2023 22:27:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1684733243; x=1687325243; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=nUYFaqomu9xKCIIon32Rhv6GrSs1+seRAs7JgNCqEgg=; b=CxIsFQHwfyWbdkzEiDB/txSO5lO5sVYC/zo3XI6Xj25esFKzII8g1yoA22hibu5Q87 6gehC/W/72gBWD0eoa+P1wNYSuhEBB4kY5IXaO4rctzM0q8bsr+6DUvX8HVFc8geHGV/ ajJxq7ZmtbOY2jGLThnRLZ8+Mo+4G3dSDSzSqcM+5dCrzKo3WBZbcEo+3XBnhevROzam Cv3lXP58kCnvv0/O3viPTNxvlPRlX9w0y2BANaW1ArY4SkSAZptMKAGOb2iALTJ25P/A UQXSDJ/qDvDrFV9mpht10TADWK597uzu2+1Xkphk7Gku9ebuGOMI4i8oINAH3KAHuCWU rZXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684733243; x=1687325243; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nUYFaqomu9xKCIIon32Rhv6GrSs1+seRAs7JgNCqEgg=; b=ep1pYdPfbAkcu8SfPkCAsl+FXu8EJudZTvE8ZxiT1V6ylUT5/6llhnFYm2RLZm9ExV LX4atpnppSEhGiJ+rtBg+HyuEwzuC++EDCvwP8IpG5J+0PJfXQG073JujcYpx5qV+M8b VPzT24xuHbnhtTHs/Hw/avrC3xmXHfdB1+09K+/RlxM837+ghg+FyjTGWGsGpqcblYmn ylFHic02obY9I31VCttgsb1LmF+Hi0ce3NybyvWd0R2TYAz6zt7Pm0Gxx+PSbMaqTvDJ ILo63dtegjyn/10dQFPfllIYgKKZMLiUWWj8A3j8o1y80I9qxAEdt6wULM1YYqIHNgdS ri+w== X-Gm-Message-State: AC+VfDwbkHzn8aaX4Iz6zCSy4hIFmVxymOR7+UMQ3qUWTia33ga1ffLA CI1A8vf905Fcy+lrXRhezPBvZiBp2hpZxeVL+RfE7g== X-Google-Smtp-Source: ACHHUZ7UiBcuBYwvsDB0X8S8S7MU+Y3lAiMkx4braM41bjoBrYtHeyBL0CSFnikDS9zVfC3DYqDh3Grt1MnpTaNQR4c= X-Received: by 2002:a05:600c:4f4f:b0:3f4:2594:118a with SMTP id m15-20020a05600c4f4f00b003f42594118amr631680wmq.2.1684733243392; Sun, 21 May 2023 22:27:23 -0700 (PDT) MIME-Version: 1.0 References: <68a97fbe-5c1e-7ac6-72c-7b9c6290b370@google.com> <242721-1e64-845e-226a-bf2b2dc72dd@google.com> In-Reply-To: <242721-1e64-845e-226a-bf2b2dc72dd@google.com> From: Yu Zhao Date: Sun, 21 May 2023 23:26:46 -0600 Message-ID: Subject: Re: [PATCH 23/31] mm/mglru: allow pte_offset_map_nolock() to fail To: Hugh Dickins Cc: Andrew Morton , Mike Kravetz , Mike Rapoport , "Kirill A. Shutemov" , Matthew Wilcox , David Hildenbrand , Suren Baghdasaryan , Qi Zheng , Yang Shi , Mel Gorman , Peter Xu , Peter Zijlstra , Will Deacon , Alistair Popple , Ralph Campbell , Ira Weiny , Steven Price , SeongJae Park , Naoya Horiguchi , Christophe Leroy , Zack Rusin , Jason Gunthorpe , Axel Rasmussen , Anshuman Khandual , Pasha Tatashin , Miaohe Lin , Minchan Kim , Christoph Hellwig , Song Liu , Thomas Hellstrom , linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 0B9F11C0006 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: xtfuz7iowpfbxcqaen5jbskwayiac9q7 X-HE-Tag: 1684733244-664588 X-HE-Meta: U2FsdGVkX1/+//ag7pnWmVHTHIPtaAkqD+FNUcMrB4vzBJuVNqG1r+/jso3rmBkSVju8lv2KKYtOYE+7kg/vEGlpGkcVxqI77QDza708lF39W9d5h4e3rzbnUxiJlUd8GIIaCG/q+R6vUy7y05IBufVP9jAnhrctGp4GTlFHekNqc1I54OUlKLwCSXcny01xQtf3Sqis6pmoD8hOQ0Aw+UwLAmCwqwJFcXUDDbjKM3Cb6N+ivS5vKcUveBESmMqHu9r6CBVyh9mzJ8PWtj7sf3eXDK15v5zIQ34uGcWS9/4CAmYVvKp43+2RDAE93IZXHjHd/9XA6D5gSboL9SglW13AyeaTfo1ov5zaUHHsHfaN9CCWCgBG9/hbkQVUr3+hp3BkS+zB2IWHFzwAOSMUiwRxdiTxNF+f6pjKnwjf3RkIiVgLTAudwvRjzayU95NfJYUVyCN1JDZmgUHiGsPC0wwQRtjKazoQNfJEmzfAdgwLCDHfktISbH4uL5jWoQMi9V/9F4tTRBnHzZo0ZCPdOrUYO1MZB3DwBpjiRDE/BuAMXDlHIylyejrHeqm1ZyqTw6TIwAoH2laQSoxoOnXgAGRbyOMMswtjmQndAKDaFHEypjogPt5vxKYmtRBwX69qDxDo3P4vlrj63mkIpOft/Q1e1cw7KszaF8Ikg2KmzTWKlTGipJp7d46a1VqKj5i7fdpWzUNgB/X3Io6oYLmsMGsXyTQ7hdvoR0XT7Z1qwOeaIHJveLWraX7DSTlgX+gJpOa5BAGfwtHsfAb/BRkd9XynA9S+EooZTUUz0qPPJSOUc4zQDNX0WM326C0Y5JZAsdD/r1KagM0Pj3gpvBQcbRy/KI4cECcFgWYXHAhdqcgtpBYj9hGsAPm0T0Q/nMMpeGrUJx8y5mLYgCHMBVDoyaDZyE5IatfgXh3OhyIOdvOCn15D20GV749sLRktv0VsZaYti1KJZzavipeIbTk lLRgkprr 0NCSChU6kz3Xqf5GkQxrrWnRiWLbcVgsgJkDtmTm9F5n5apu0pqjffVXb3+W+ZwwKm3ujoHOi7H6HCOIG4bbQuCHBwj5QngImVPM4kj46ULht5abSPaUc//7D0OzT+mYHq8itPDyVeJhZNlf1Ua7nlHoRLW4F/WiweywpwB+zmGFY1E/iRF0oXjSV8Yl9snw5Qle+3Vdgtux/sVYH4kOJsR0Cn5H1ROnrAbXp9HeM2rpApYq+XfH5tBgZr5eN4OAAgOBTNYyz8Uv9cATrPowlLomQ9QRwfMISGl/+o948bJkPfUE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, May 21, 2023 at 11:19=E2=80=AFPM Hugh Dickins wr= ote: > > MGLRU's walk_pte_range() use the safer pte_offset_map_nolock(), rather > than pte_lockptr(), to get the ptl for its trylock. Just return false > and move on to next extent if it fails, like when the trylock fails. > Remove the VM_WARN_ON_ONCE(pmd_leaf) since that will happen, rarely. > > Signed-off-by: Hugh Dickins Acked-by: Yu Zhao