From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E177E69E99 for ; Mon, 2 Dec 2024 22:24:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D046F6B0089; Mon, 2 Dec 2024 17:24:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CB44E6B008A; Mon, 2 Dec 2024 17:24:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B54AB6B008C; Mon, 2 Dec 2024 17:24:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 96A106B0089 for ; Mon, 2 Dec 2024 17:24:58 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 3F158C0399 for ; Mon, 2 Dec 2024 22:24:58 +0000 (UTC) X-FDA: 82851449898.12.F8D4E71 Received: from mail-ot1-f49.google.com (mail-ot1-f49.google.com [209.85.210.49]) by imf22.hostedemail.com (Postfix) with ESMTP id C0FC1C0011 for ; Mon, 2 Dec 2024 22:24:42 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=v8W5klJF; spf=pass (imf22.hostedemail.com: domain of yuzhao@google.com designates 209.85.210.49 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733178283; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YJCGC/sgJEzOQ87RHSL5ZFr+7rlghNfPZJAqWvkg6xg=; b=xxPB926ejRjrYfUdJl1QPI0V7D+VDQkeMG7yTSwJw3RGQvHUZ8d253g1KhJyk1cT2xKFdH j+tuQNoTuLI+plvkc5QWO8tDyo8QnARtJwGSSzBfhXkFQeyPnj94lI6VdYsuAQKwo2XTXo 1KWdbH22oIxIkjILgZrOqH8sX4h+qZc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733178283; a=rsa-sha256; cv=none; b=kg6inNww2iIe499ksWTlhu944dvsHTbKUlmc5OxpxuJyG+3wuZGYoJeT2SeuQXqUlxRZrT mQXwVlOFGshFnm6HfNpz8r2vjzalY5kfgBl5EuMI27RqcVFFGzBtqFcOMTBLx3M4sb8UW2 BN/5ijWKB5tuQm1O1Nl3o/98Q/c/08Y= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=v8W5klJF; spf=pass (imf22.hostedemail.com: domain of yuzhao@google.com designates 209.85.210.49 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-ot1-f49.google.com with SMTP id 46e09a7af769-71d4e043dd9so2111224a34.1 for ; Mon, 02 Dec 2024 14:24:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1733178295; x=1733783095; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=YJCGC/sgJEzOQ87RHSL5ZFr+7rlghNfPZJAqWvkg6xg=; b=v8W5klJFugmlkOWXjm+kjW6iANmKpZkpw6Y0MghtsygxZYXF+E1+HJA8+eNWj1Dwc9 v40KZXXGwmQCD7LewP3BFFeYEznUmUrVZOF2DJUtzLGRmu74KiPL0jdMlzeWD2J+kAhp giSoVO85Dvd5N3nEvJJyAU+SO7QS/lueFtLJg5xdEGy9ysRJ9mGSbY3CcoyB1zCN+2he HxR0rN2DHSFRDvxlHUan7WWACO35hYga3OtAeG1g4f/hag98n5hZ+HqKkJ5QI18HrkPj E7PiJE4qd9nrog6CdUgmqdylrTH7NrTZuO68I9MOItJ67O8Tl+I3epkwvUcMrifcQHaJ jLrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733178295; x=1733783095; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YJCGC/sgJEzOQ87RHSL5ZFr+7rlghNfPZJAqWvkg6xg=; b=LqJrX2THJnBSFbkrvRdr+FN1HYr28/RzQDQOXdfP+I6dLceKq/JYi1cI6B2ib0M9SK t5WG52iAsPkP2aZwjU9qHVTPDasPxYFUkQfiXtf7Spncr8J/mon9ixxGnaPEvfvSEn3B QsLsmxnG5Vb54J0w72sEw40weVLVVBVQ3VxWOA9Vflu/GVeCYTl0wd9RysSUz+uXay5Y +aye8VyKjBL7+QoLU+hb40AxaxK+v6/tT1N1ppRv1hHK21htzPML8miJU0iljk1cE0AC jx9hSXzjLOtxFQpTR9Gr6jVi4pF5G/CMWeHhzRFUa1dEfdm/WVrODb0V150pSAb+oc0x /I5Q== X-Forwarded-Encrypted: i=1; AJvYcCX95/vv7wipmhTQybPYHBIdEhoFifyU9N+haUTq+E+dHb7SallE+nq4GGw1m+dwedbsC+xWTLxL9A==@kvack.org X-Gm-Message-State: AOJu0Yzp9BMSmWEFVfUTuoapj5W9E/xYiVO53ZzgyhLhPA1uZvoXxntO Ivgww8oQcRnABndl1wWj3txJih6RjeUYE3/76aIbwEj2WHMuUllwZDFxLiaKv0Ud/BwjHtX8Rox N3TsEubBhKnImLlF0UPMZ2FVi/i6uc15coaDT X-Gm-Gg: ASbGncsYk2diW4Eh8aMYdSTjwq3DFaKJJa/xQq1T/3/k9Chb1Ru3UZm/RA3g5zLqKQS z2EuPepRWDkapzucKh1URw26t4qDUlLIkCohLw7F0ygG2M8DOuugIPiAXqV/0emc= X-Google-Smtp-Source: AGHT+IGeeo+ghKLojpnbWTzZom5/ogyh7WRdIQxYXPU0UtlV2C/NyHWZ8m/Ani2xjLVRzoyaFLhWiHGqggOcj7aCcyE= X-Received: by 2002:a05:6358:280d:b0:1c3:7415:693d with SMTP id e5c5f4694b2df-1caeaa8ba16mr49600855d.5.1733178295304; Mon, 02 Dec 2024 14:24:55 -0800 (PST) MIME-Version: 1.0 References: <202411291513.ad55672a-lkp@intel.com> In-Reply-To: <202411291513.ad55672a-lkp@intel.com> From: Yu Zhao Date: Mon, 2 Dec 2024 15:24:18 -0700 Message-ID: Subject: Re: [linus:master] [madvise] 2f406263e3: stress-ng.mremap.ops_per_sec 6.7% regression To: oliver.sang@intel.com Cc: Yin Fengwei , oe-lkp@lists.linux.dev, lkp@intel.com, linux-kernel@vger.kernel.org, Andrew Morton , Ryan Roberts , David Hildenbrand , Kefeng Wang , Matthew Wilcox , Minchan Kim , Vishal Moola , Yang Shi , linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: C0FC1C0011 X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: 99qw6d59yx6qktiubbz3gp9uws7txxes X-HE-Tag: 1733178282-756916 X-HE-Meta: U2FsdGVkX1+cnCbcIvNRyEcnuFZcbqhfAx5t7GoMVq3FBJIRQvatwoBdMcFj4EeuYoGvrny514di5lPNA2PB9bl5T06LMYwRY/mtIn11f3JLFwRqfTZwpofmykXNVeHamu/kDCpP6eJmb9h61qEGfEBcWvslQdvwgfs3kEALcYPd9u4cLk2dt+tnOe5da5hlSulZoCZCR90+h6sVZXc+ae1yqGjs1YIACYnzjuGgbxRpxATs+EwHcBrdy2an4ZebUU1+/dj+TRyNHFiBJ4u5ELATgISN/t4pZHXdt2iwORMqq29ZCnFK5/j5wjrpHHkOC6cDs0iC3YBM82ZOEHA6ZpBETtco2RBN05zVME3CwmK4LdshQfkN4WR3y5rve9vE1MApvXcB2IOITE/B7wO/pELpxtmlz6/XK+lSCaQqX1k8iiDgFCxYG+Bv0YTOpq3UszZhRY0ng8xn3/t0X37LqRHHce/kvq0sJttkkX3eVtGvlyF8dUsx3K6UTBDErcpnilOtPeRgiWHuWMu9juXuby/rkc8ePmJNWWR1ezDWACUjfYqLSAR8TovXVa5P4n9/Sctv5KUflXTz3b9JD7Qw0UB7Y04kb0Vyawed+xzGYYUQKTQVGLAq0p3USkzRKfT2GfsAbM1jhbT4hwGOwaKVeJ6lR/sVfQ0aOsdErDW3P/4GHM1jnqIGH2o41tPdKbKhc/7s18dRXiKglpwEFZqtmnAoNvQBLbQQiNjUReiCwSWXqr/MSdkognv8PMEksO9QsX8VOajYm8QFvL/UEVe5jaayZoxFmlNBh0gdvyXpXpN/dCv+gcLKXNwqiQXRzor2aUkvcdB/N4tBTRgdRvZqHl0NP1e73Dwbg/SogfxXIt79VU+KG5afPeDW4rPDcLwBK+Lq1xXcSKPNTk1AuEkiWi2DRa/5i7xPqgyN0AG5xEhSSoUEfAOxgr6l9R46/HDZ+wKvPZ2v352GenJtZK4 MIUf164Y XSL892wDBlyOf+dQhfiRlFJGSm6TUV4NjVhcbuhbIeGX8kK29ntFDF93fSdQlPP3Hk7wz84/U2//XoRc6swh65mJLBmYTvGw0QZrBrdvmQimrh+tKg2+USYSHNA1Ie+2PoQA0KgxcnhoF6XqDQAZ2phGaYDSDRrCfksxuU9vd/ojnV68qIuKR8jEvKlxxdaGBHKlTBn4J1LRzi6hyVHMDDaspTHbfBMyPXDOqi47o8krwS65x9vdMkHwjNgtWylLyYS96Z55z31h8JW0kl6Kp7Rd9/TntRUoQG1pv0uE9PMGUEF7m+0NQNaVQbQnpw8QyZKFEB/m24zyPhWR/R1nF6a1nexJle/h+IZR3apcUVBhKv2yCDacH2pdwlqMGf9gxx66ynhCOwtbxjhyx7xLpgIyaDGWDGmyLdIvC X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Oliver, On Fri, Nov 29, 2024 at 12:50=E2=80=AFAM kernel test robot wrote: > > > > Hello, > > kernel test robot noticed a 6.7% regression of stress-ng.mremap.ops_per_s= ec on: > > > commit: 2f406263e3e954aa24c1248edcfa9be0c1bb30fa ("madvise:madvise_cold_o= r_pageout_pte_range(): don't use mapcount() against large folio for sharing= check") > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master > > [still regression on fix commit cc864ebba5f612ce2960e7e09322a193e8fda0d7] > > testcase: stress-ng > config: x86_64-rhel-8.3 > compiler: gcc-12 > test machine: 64 threads 2 sockets Intel(R) Xeon(R) Gold 6346 CPU @ 3.10G= Hz (Ice Lake) with 256G memory > parameters: > > nr_threads: 100% > testtime: 60s > test: mremap > cpufreq_governor: performance > > > > > If you fix the issue in a separate patch/commit (i.e. not just a new vers= ion of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-lkp/202411291513.ad55672a-lkp@intel.= com > > > Details are as below: > -------------------------------------------------------------------------= -------------------------> > > > The kernel config and materials to reproduce are available at: > https://download.01.org/0day-ci/archive/20241129/202411291513.ad55672a-lk= p@intel.com > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > compiler/cpufreq_governor/kconfig/nr_threads/rootfs/tbox_group/test/testc= ase/testtime: > gcc-12/performance/x86_64-rhel-8.3/100%/debian-12-x86_64-20240206.cgz/l= kp-icl-2sp7/mremap/stress-ng/60s > > commit: > 6867c7a332 ("mm: multi-gen LRU: don't spin during memcg release") > 2f406263e3 ("madvise:madvise_cold_or_pageout_pte_range(): don't use map= count() against large folio for sharing check") The .config you attached shows CONFIG_LRU_GEN_ENABLED is NOT set for LKP. So this regression can't be from the first commit above. Also, I asked you a few times if it's possible to set it to 'y'. It'd be great if we could do that :)