From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81292E7717D for ; Fri, 13 Dec 2024 05:51:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BA1C76B007B; Fri, 13 Dec 2024 00:51:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B51676B0082; Fri, 13 Dec 2024 00:51:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A19986B0083; Fri, 13 Dec 2024 00:51:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 863816B007B for ; Fri, 13 Dec 2024 00:51:02 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 3FB34AF13C for ; Fri, 13 Dec 2024 05:51:02 +0000 (UTC) X-FDA: 82888861818.18.4FC371C Received: from mail-vs1-f46.google.com (mail-vs1-f46.google.com [209.85.217.46]) by imf08.hostedemail.com (Postfix) with ESMTP id 88084160002 for ; Fri, 13 Dec 2024 05:50:43 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=KIUVnA+H; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf08.hostedemail.com: domain of yuzhao@google.com designates 209.85.217.46 as permitted sender) smtp.mailfrom=yuzhao@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734069036; a=rsa-sha256; cv=none; b=e6IIkEJmmkSdIZZMIpGYV1FXVvps7PQQ7mUV9o1QyIs3OpzcaEexqakVAusxMbYUgZyfHS wMEXH6Whzgzkf+sTQVr+9m5GDIVPcxue8gmAT7MsuAKrJ/w32aEFcxFTzYus1Q31FtoEPD u+ixzcuEkvNglehlTBeHxAbS6lVtpN4= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=KIUVnA+H; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf08.hostedemail.com: domain of yuzhao@google.com designates 209.85.217.46 as permitted sender) smtp.mailfrom=yuzhao@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734069036; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=u1pi4Bm8p0bfLXi2mAJqGR7jkl/IYPNq3XoUf1+4fLE=; b=mUuiWbI+/rAgXta/rkRYbUNY7N28+2Vv+EaV0QOF817Ktg06/TYzP+HUz2UrQMFPSJFB+V dTDh/07VBn3XIokmaGQCX4Abt0vDrOaBf5C0himJIRwId/ZxI3QKJs+gu3pD7Hasn2xGAm 5ts/PWsOd8V4ZOSNEoKObiyOYFVIGeo= Received: by mail-vs1-f46.google.com with SMTP id ada2fe7eead31-4afdf300d07so733506137.3 for ; Thu, 12 Dec 2024 21:51:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1734069059; x=1734673859; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=u1pi4Bm8p0bfLXi2mAJqGR7jkl/IYPNq3XoUf1+4fLE=; b=KIUVnA+HmA5t4hIhlxYGhkJyXKRn7UKn8cRo4X566PC/qlgiIOKEWMiQS/46hWP2re szlsIDV9IX505R2quU9+a0dPjnG42aZ1MkeewysfSA1OaBxrOOLLho2STEkiD0Q5Ng7F iXyo9Ghrk3h4+eb3LrvjQ/iQKr+ff2PkMNrrUpqw7Wx0pw+plO1r1xMwZXWHrIZ0bgOP zgdi5RCSrtMMva4LJigVC1PDQc+6oHBHP5VzJLhDxbxUMTgCil6e5I9ult5lhcOlEI+3 MALdZRWsRPud02fGwksYf/X50+YaAu56yjQMjlfSlN25OP3Jze1ugGe0Yam2JFkJ0Urz aj2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734069059; x=1734673859; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=u1pi4Bm8p0bfLXi2mAJqGR7jkl/IYPNq3XoUf1+4fLE=; b=JDo6OaayzCrDUgLAedJTHHxDDohsEtg3wKHS3tq5mhm/+M3dHUYLg3MqQr6n1GKirM hEHtgwgikJ6+cxU+2L13OUoealY0wVVtgNbLofhX0v42J7SN0hbPT1T6X/QMGzIRNSOQ NkrhsSfPuk7KRHDrNLdIpnu1A+4A6NYDOXUWXekwZhgYGZwxm2RMxFI2cdoNgbcGol61 VPhYo9pDjnN+7plEVMZimd9PRGA5iFrxxqN8zbaHVLeuRGttYWBcm7BLK5Ax8zGqGlXi zKXTB2Uk2bH171ZLvxu+HUOQzuju3PauD6Q4UQp67RlEF/O6OrxXgxfYj+WjaBtjqnsY ar/Q== X-Forwarded-Encrypted: i=1; AJvYcCV79zD8uQBVPrOK7VLvYseVA6FfmgCjpnvko3DWVEPiBcAZKYpnH2hh0DmQG25ul3BGik6kLo29qA==@kvack.org X-Gm-Message-State: AOJu0Ywv5GlieR1zU7yYyPXjK7XqvOqNL2NKACJyqnlNkZR+VGMTwsa/ 2KdwIXfO4o02ctPGVXxxBIGYfcfnkKcQSuU/Vp6i8VnUrQ4wvEPlqFXHOKmKiasP1Yu9dmFbV11 2uPWWmQxVn7dCU4cd75u0+CWm0D8qaHc3PoCs X-Gm-Gg: ASbGncvABCNsmjCkY/paVM7UWIcoe+cGoxrD/KPvUwcAtC1BxwuDlG3o8CmlbF1WgxV g6yeutzj6P9J693trRgLNYX7CVyn7czuXqTEUS4RIY6/BpSFELbEMGojzbwO09iS8Q7owDO0= X-Google-Smtp-Source: AGHT+IEu2Oib6VYKcn5uKqwxJs9eWc+HYKWzUG6wFe6xGaxUShvZ1zFkkTXthYtahXmlPHiAA/ESdqg1GZCRDZphRqA= X-Received: by 2002:a05:6102:3e27:b0:4b0:2d7c:43ca with SMTP id ada2fe7eead31-4b25ddc752dmr1543399137.18.1734069058939; Thu, 12 Dec 2024 21:50:58 -0800 (PST) MIME-Version: 1.0 References: <20241211105315.21756-1-lorenzo.stoakes@oracle.com> In-Reply-To: From: Yu Zhao Date: Thu, 12 Dec 2024 22:50:19 -0700 Message-ID: Subject: Re: [PATCH] MAINTAINERS: update MEMORY MAPPING section To: Lorenzo Stoakes , Andrew Morton Cc: Jeff Xu , "Liam R . Howlett" , Vlastimil Babka , Jann Horn , linux-mm@kvack.org, linux-kernel@vger.kernel.org, David Hildenbrand Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 88084160002 X-Stat-Signature: b8chnakokjquyw65w3mzqu3ej8atkri5 X-Rspam-User: X-HE-Tag: 1734069043-798994 X-HE-Meta: U2FsdGVkX18M8QnFncYzj/1dqqyvAL10ZisXvm7YHx9Hbo9BenKTkERWPiBT18dPeEreH5tR6jCykN8fg4UPp0tzvYuiH+h/Uj4y8xonb6LZbm4dSQ214iJm1FsooVaqI5Hs516bkW4Xts14ybzCRi1cQ4P9/SuqEgnDTgkXI24CAKfSOg8NO9xuwxiveNHKhAF0eTdyYFD2c42ql1IFnRMWIp7LqwaqGCKjeIoVpbVV4Oj0B2/HQXeAxKANWvRu+WiXH4g+25SbJBsD1FrmHW8ZHr2f+7j+3efaHR+sN6/x3icZVRdZdOrVWOUCmYDqJAWDsobxf7AwGIimG/D0WG2GUf1p0xwcKQ1nzMi00IgTCysxESrYT10PdDg2iVCJbJVzv9ENu5eVt/S449y2SK8kFXl5FqRpV3dkdQT6o434d5gSPd4A05PWInqbPzlyY0kBf6dQ4GZ+Wy/9okxnvBYDUon3/5XR073tyGr7VmP7lYAdHjDx6mSUl9HS6dcds7zfrAd2k4rY/+H0zhXLXnMicdwQnyjMd4E3R68QE0KHTDBP7hTbOptzC5Cz8auj14unB2su7gCCLaEab3bvWdRe/7YdKc9r8sDIUblKEs9orRoT6MCMVgsF+7Zeip2+fcx9+bjQ81QGLYeNEQsrPZBklnjAXIX7C6LjK+zuyEDwnX6V+zUkvyzFIXSj5ha8rpwHBeV31MRDleRq2QmOsJToBSYhlNBKVnBksrhbbSmgaK2TBHU0J4ogw8DZZ7jxGifsLKeH6mZKvnIeaAVogHIzmRX/Qypmg74UDPLBSF1UpP2iNA5ykB6sp9QdB3nAntaJ3L3ruM+TyD/nyu2+KtFmrBBvVZohsv3jh384XQUM8Gk1WaIFOpAv0qVn0tCjZPXrhr6kIZI4/v3IQ7x2iZGhxYDBcBU33+1r0aOoI7gxp8VZx/Qk/bRNKGgFVZMrzll+KV2lyowHH9dBifF LN1Sul9/ rCC+JF+ykUnPgGG+To8ARuAi0uJy7C97apB1ldG2AHR9n2Nw0xK+gUIN+8vr//ehBl98GiQXWVJ4jczyE6EgTnrSpktQby6dV1xWD1wgK1AstfQTynPNKsLXSquw/dvGy4tVK88s0fljyxDWr1mP3VbgiJbRbA5u9Q2M7jJLv1pGsPMrUQf9q6ku55WKj7hrGEKSJyRgpHphBNG0ITEQJeJ6PVBrpQAGB4nikyh7PO4OiqrZZDix0gdFRbVUbjeBNkiga4Z5Beacuf/2ixOU8h9+jikP7TNSK0qzNwDM0uXB8xDGzvP8ZPiL2caJgV8QUzT3Ru2zXOv+4NE2OupoSj+0sNiFheb0ylBnZlGQ9mYOg7ro= X-Bogosity: Ham, tests=bogofilter, spamicity=0.079342, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Dec 11, 2024 at 11:57=E2=80=AFAM Lorenzo Stoakes wrote: > > On Wed, Dec 11, 2024 at 10:36:42AM -0800, Jeff Xu wrote: > > On Wed, Dec 11, 2024 at 2:53=E2=80=AFAM Lorenzo Stoakes > > wrote: > > > > > > Update the MEMORY MAPPING section to contain VMA logic as it makes no > > > sense to have these two sections separate. > > > > > > Additionally, add files which permit changes to the attributes and/or > > > ranges spanned by memory mappings, in essence anything which might al= ter > > > the output of /proc/$pid/[s]maps. > > > > > > This is necessarily fuzzy, as there is not quite as good separation o= f > > > concerns as we would ideally like in the kernel. However each of thes= e > > > files interacts with the VMA and memory mapping logic in such a way a= s to > > > be inseparatable from it, and it is important that they are maintaine= d in > > > conjunction with it. > > > > > > Signed-off-by: Lorenzo Stoakes > > > --- > > > MAINTAINERS | 23 ++++++++--------------- > > > 1 file changed, 8 insertions(+), 15 deletions(-) > > > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > > index 68d825a4c69c..fb91389addd7 100644 > > > --- a/MAINTAINERS > > > +++ b/MAINTAINERS > > > @@ -15071,7 +15071,15 @@ L: linux-mm@kvack.org > > > S: Maintained > > > W: http://www.linux-mm.org > > > T: git git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm > > > +F: mm/mlock.c > > > F: mm/mmap.c > > > +F: mm/mprotect.c > > > +F: mm/mremap.c > > > +F: mm/mseal.c > > > +F: mm/vma.c > > > +F: mm/vma.h > > > +F: mm/vma_internal.h > > > +F: tools/testing/vma/ > > > > > Will madvise be here too ? > > No. We had a long discussion about this on another version of this patch = :) > it's blurry lines but it, in the end, is too much related to things other > than VMA logic. > > We probably need better separation of stuff, but that's another thing... > > > I'd like to be added as a reviewer on mm/mseal.c. Is there any way to > > indicate this from this file ? > > This is something we can consider in the future, sure. What'd be the downsides of having an additional reviewer? Especially the one who wrote the code... > However at this time you have had really significant issues in engaging > with the community on a regular basis I'm not aware that this can disqualify anyone from being a reviewer of a specific file. > so I think the community is unlikely > to be open to this until you have improved in this area. I do not know Jeff personally, but I think the community should make anyone who wants to contribute feel welcome. > You will, of course, remain cc'd on any mseal changes regardless, so > functionally nothing will differ. > > And equally, this change doesn't alter my or Liam's role, we will apply t= he > same review regardless. > > The purpose of this change is, as the message says, to ensure the integri= ty > and maintainership of logic relating to memory mapping, and mseal is real= ly > entirely a VMA operation so has to be included as a result. > > So it is administrative in nature, ultimately. Sorry -- I couldn't make out what you are trying to say here. So I'd like to ask bluntly: is there any previous disagreement between you and Jeff to make you reject his request? If so, I think we'd need a 3rd party (probably Andrew) to review his request. If not, I'd urge you to use his help.