From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 934F7C433F5 for ; Fri, 15 Apr 2022 20:18:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ED7666B0072; Fri, 15 Apr 2022 16:18:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E89656B0073; Fri, 15 Apr 2022 16:18:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D26CD6B0074; Fri, 15 Apr 2022 16:18:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id C3C546B0072 for ; Fri, 15 Apr 2022 16:18:21 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 93B6780B2A for ; Fri, 15 Apr 2022 20:18:21 +0000 (UTC) X-FDA: 79360225602.20.E587423 Received: from mail-vs1-f43.google.com (mail-vs1-f43.google.com [209.85.217.43]) by imf24.hostedemail.com (Postfix) with ESMTP id 1761E180003 for ; Fri, 15 Apr 2022 20:18:20 +0000 (UTC) Received: by mail-vs1-f43.google.com with SMTP id z139so2424453vsz.0 for ; Fri, 15 Apr 2022 13:18:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Cbb1YDb5NaiuUde42DTRSKAfH6XbrCM5Doeox4W/L1U=; b=R+fWKSybpUALXVyi7dr5ULcwrcaXsKRmDx3orLXnDSP1dKdn6sslxaR84/Vt1idESV R0gbbnc2Eo5O2hvxGNOm5+O5l7zO9r5grwhRC/H1pjlfnAengg/oNlV3PjITQ52N9xvj ttmr00bahnI6zPcHkkGyVH85UyIFb3BiDQXe1wN6D7t4+4SOidckXgXl4WmZtYM9G8g/ aed3/o6NSjZAcWDOvNGsi7PFryJv2kBPX+cLbidK7S7FBT3z2r51EStnpXahSrD5q8Gs bTdzVJmEmNuyfh9W4BKstW6XQcg/tnhQUf9CLonBDa0jnHYmD9BzjVmbUocVwfvlS2tZ ESWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Cbb1YDb5NaiuUde42DTRSKAfH6XbrCM5Doeox4W/L1U=; b=eghAzG1NYqz4gN4+i6iI0BdJXjIExG01LFUtr5JShs+JZQ4u2YJGmdGjXWg/3UEgDe DvO6Sz96glQjGAmZKnp9IfCkFbUrZlVEl2BojTTajwX0h114CawHnmn4R7oIO6lFiBUu Rhu9vDeaEp3bGMjZdFuhR8K7FE1h2d4p1cvRvhJPabXXYxZ27tr9og8F7/X6tgce7Ki/ BZ5Y0N/+3e/1DV9EWxfzyiRmexBqld7MDUHMqbVFgcd0O25e+gQeTgysAv/xc5dSn8Hf FbJyx+mRqHtbGWgJE4BJas+l8LWrhno30iLVKUaGC2t3doOZOaFhAJ8grI8P4U6Qtac3 Ad2w== X-Gm-Message-State: AOAM533YqCW2pv5q4XMcE6CltHYyRGTZnD7DlrCbbjhi8yYa7P81GpXF GMmC2G1VkPcb1JlXj64D4wGqmmCFJEOP0ITF3N7aDjpp8Tm+ww== X-Google-Smtp-Source: ABdhPJwO94bILh3nEx3+nxP4ZO5hEG2ftNGY6x330YGarczURLY5R/Y+L+rCRpLt0Wpji7SMuT9MzVQDZVeugH9nIdA= X-Received: by 2002:a67:de17:0:b0:32a:4007:cd86 with SMTP id q23-20020a67de17000000b0032a4007cd86mr220678vsk.22.1650053900285; Fri, 15 Apr 2022 13:18:20 -0700 (PDT) MIME-Version: 1.0 References: <20220407031525.2368067-1-yuzhao@google.com> <20220407031525.2368067-7-yuzhao@google.com> <20220414143959.0daf4534613f2511b9b27f11@linux-foundation.org> In-Reply-To: From: Yu Zhao Date: Fri, 15 Apr 2022 14:17:43 -0600 Message-ID: Subject: Re: [PATCH v10 06/14] mm: multi-gen LRU: minimal implementation To: Barry Song <21cnbao@gmail.com> Cc: Andrew Morton , Stephen Rothwell , Linux-MM , Andi Kleen , Aneesh Kumar , Catalin Marinas , Dave Hansen , Hillf Danton , Jens Axboe , Jesse Barnes , Johannes Weiner , Jonathan Corbet , Linus Torvalds , Matthew Wilcox , Mel Gorman , Michael Larabel , Michal Hocko , Mike Rapoport , Rik van Riel , Vlastimil Babka , Will Deacon , Ying Huang , LAK , Linux Doc Mailing List , LKML , Kernel Page Reclaim v2 , x86 , Brian Geffon , Jan Alexander Steffens , Oleksandr Natalenko , Steven Barrett , Suleiman Souhlal , Daniel Byrne , Donald Carr , =?UTF-8?Q?Holger_Hoffst=C3=A4tte?= , Konstantin Kharlamov , Shuang Zhai , Sofia Trinh , Vaibhav Jain Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Queue-Id: 1761E180003 X-Stat-Signature: 9bfe98amst1f5uczknjkd53y67u7u8c3 Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=R+fWKSyb; spf=pass (imf24.hostedemail.com: domain of yuzhao@google.com designates 209.85.217.43 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspamd-Server: rspam01 X-HE-Tag: 1650053900-157624 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 15, 2022 at 4:16 AM Barry Song <21cnbao@gmail.com> wrote: > > On Fri, Apr 15, 2022 at 9:40 AM Andrew Morton wrote: > > > > On Thu, 14 Apr 2022 14:36:03 -0600 Yu Zhao wrote: > > > > > > or it is only something > > > > meaningful for the internal code? > > > > > > This is how swappiness is interpreted. > > > > > > > if so, can we rename it to > > > > something else? otherwise, it is quite confusing. > > > > > > Feel free to suggest something. > > > > It is confusing, swap_preference? > > seems to be much better. might also be worth using MACRO to replace those > 1, 200, 0 magic numbers to tell readers the exact meaning? How do you read "swap_preference=0"? I read it as "no (swap) preference", which means anon and file are equal. The real meaning though, is "don't swap"; and the "no preference" value is actually 100.