From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0CEAC6FA82 for ; Tue, 20 Sep 2022 19:14:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 09507940008; Tue, 20 Sep 2022 15:14:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0445D940007; Tue, 20 Sep 2022 15:14:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E4E30940008; Tue, 20 Sep 2022 15:14:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D7DB5940007 for ; Tue, 20 Sep 2022 15:14:21 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 9B6C71A0CE3 for ; Tue, 20 Sep 2022 19:14:21 +0000 (UTC) X-FDA: 79933414722.09.FF04245 Received: from mail-vs1-f50.google.com (mail-vs1-f50.google.com [209.85.217.50]) by imf05.hostedemail.com (Postfix) with ESMTP id 6401D10000C for ; Tue, 20 Sep 2022 19:14:21 +0000 (UTC) Received: by mail-vs1-f50.google.com with SMTP id m65so4257519vsc.1 for ; Tue, 20 Sep 2022 12:14:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=DYSX+rzfvx6PPE4TbO9ukbYwi6O5v4DOvDShsPehjZs=; b=O9Q67sTKdIdUkUfAw3T4g0KL2Ft6B/58Vpl4IvTpCswVqim24o4vIF5JM4gPz/8WQo x0DqwmKq0Cro4XHojFU+CZnphwndc0MTmScUuneb4RzwD6q4MldGCqa2N0Ir/nWsNuDR bABI1mTPRymfI7SJwZWgw1BnakG/Y3KDIF7ua2kKdnpREIXkqHlf7sg7ZT+sCHld7fBn AWBmu+XgwShCHB24+0BbUWzLh0u3dNqwjarEIU3V7dfOlDkuLpgoXT43Dy0bd+T7/dUT Qdlgnu4oy2jFH1YH1dCiCRRcfGHSqIZFnLD+ckznWW3AiYL0/Kog1ycSLWL+1o6zXs1k Y0ZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=DYSX+rzfvx6PPE4TbO9ukbYwi6O5v4DOvDShsPehjZs=; b=wVr9HBZ1Q9oNyI8RJzbYC1Q8kPqMhkQ/PU/nH2Fo8wp5BMKe1gyANMmenXUCE093Qs 0MZWxIrXJDzIlqhh06dFYXPJVf9qQukBN8noRHmR0+4jBzGWuZb8ZiHEhuUrLWlxTNNY ws/ASi92C5LxSHSzDihrugbJmmNKv/brjyQFuFQUXAxJhtOQdFhRfmjdjerTdN/Jig+4 6axrFy/qrI6kYdhWaFXw/EMzFLKWC0Tkx6WnDrbRg86oQXz1goPl6P6WLDP4we/gMRvG aIuN9Rlhzk/+SoVrRCubtY0yvwgjBKirSm0NdkCsmjnFy413t7gLd4vKDUlMMFXtuJg7 ESAA== X-Gm-Message-State: ACrzQf10pNngBJz4t6ehqmrYP2XTSZhdLgw8WyMB5J7XX4ovZOZGM+UD mPRCPl4kjXGD2BDwHQunjgWlyN8/JdR/gr0o517sUg== X-Google-Smtp-Source: AMsMyM6UkmBURuxxZvOTXRzp2UnuhL60STzSwNNNChfdCbuCxSjuqja+8Wo2jgYB7Vd6EladthWqIQmcnJnWldhyhSc= X-Received: by 2002:a05:6102:3309:b0:39a:e5eb:8508 with SMTP id v9-20020a056102330900b0039ae5eb8508mr5938462vsc.65.1663701260563; Tue, 20 Sep 2022 12:14:20 -0700 (PDT) MIME-Version: 1.0 References: <576182d194e27531e8090bad809e4136953895f4.1663700262.git.andreyknvl@google.com> In-Reply-To: From: Yu Zhao Date: Tue, 20 Sep 2022 13:13:44 -0600 Message-ID: Subject: Re: [PATCH mm] kasan: initialize read-write lock in stack ring To: Marco Elver Cc: andrey.konovalov@linux.dev, Andrew Morton , Andrey Konovalov , Alexander Potapenko , Dmitry Vyukov , Andrey Ryabinin , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663701261; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DYSX+rzfvx6PPE4TbO9ukbYwi6O5v4DOvDShsPehjZs=; b=MVq4lZuEV9lZPmcW1NDfmqqHElVkMyfalOYInL3doqXSBRZfwdCbe0m1aIaX6wVyt5+FxJ A/D1EFBLFJWBZpMp+Ptf6xEO6omtGWVaP+XaOcSTVNi6x9I4kHP0O2x7vcgIiEcKO6GFB6 n8HvTFCxxJd+WL0IQSgpGL0+nn5RN9M= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=O9Q67sTK; spf=pass (imf05.hostedemail.com: domain of yuzhao@google.com designates 209.85.217.50 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663701261; a=rsa-sha256; cv=none; b=4aDj5Au4wFo3BtofxdhUJXoZUtOW7vB9YD2mD9i7DI9SOOnh29+gT9qSO5WRUwhwcb3p+P KHE0wcU2wW4Usb0d0Olchdj4ECL2OoX6UkHqKkHQb9AuODWX81nJssnShJMwCTArlS5l99 1tZoxQwMXksJYimxGblEEaVRu1M3mAA= Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=O9Q67sTK; spf=pass (imf05.hostedemail.com: domain of yuzhao@google.com designates 209.85.217.50 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspamd-Server: rspam07 X-Stat-Signature: q8qgkfhurnqkjtqn5owb68iepnqgwiwz X-Rspamd-Queue-Id: 6401D10000C X-Rspam-User: X-HE-Tag: 1663701261-648110 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Sep 20, 2022 at 1:10 PM Marco Elver wrote: > > On Tue, 20 Sept 2022 at 20:58, wrote: > > > > From: Andrey Konovalov > > > > Use __RW_LOCK_UNLOCKED to initialize stack_ring.lock. > > > > Reported-by: Yu Zhao > > Signed-off-by: Andrey Konovalov > > > > --- > > > > Andrew, could you please fold this patch into: > > "kasan: implement stack ring for tag-based modes". > > --- > > mm/kasan/tags.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/mm/kasan/tags.c b/mm/kasan/tags.c > > index 9d867cae1b7b..67a222586846 100644 > > --- a/mm/kasan/tags.c > > +++ b/mm/kasan/tags.c > > @@ -36,7 +36,9 @@ DEFINE_STATIC_KEY_TRUE(kasan_flag_stacktrace); > > /* Non-zero, as initial pointer values are 0. */ > > #define STACK_RING_BUSY_PTR ((void *)1) > > > > -struct kasan_stack_ring stack_ring; > > +struct kasan_stack_ring stack_ring = { > > + .lock = __RW_LOCK_UNLOCKED(stack_ring.lock) > > +}; > > Reviewed-by: Marco Elver Tested-by: Yu Zhao