From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64E5FE77188 for ; Tue, 14 Jan 2025 17:02:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 049BD6B0088; Tue, 14 Jan 2025 12:02:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F3CD66B0089; Tue, 14 Jan 2025 12:02:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DB4C86B008A; Tue, 14 Jan 2025 12:02:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B75526B0088 for ; Tue, 14 Jan 2025 12:02:32 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 7426F14088D for ; Tue, 14 Jan 2025 17:02:32 +0000 (UTC) X-FDA: 83006676144.25.0ADF55B Received: from mail-qk1-f182.google.com (mail-qk1-f182.google.com [209.85.222.182]) by imf29.hostedemail.com (Postfix) with ESMTP id 5A550120005 for ; Tue, 14 Jan 2025 17:02:30 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=JDXqPQJM; spf=pass (imf29.hostedemail.com: domain of yuzhao@google.com designates 209.85.222.182 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736874150; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5pwRPv3AC50iLCk2Zf2oVFdf10HsOLZLViQlkbWzupw=; b=NFAK8WNuoy1UV5FipBrhmR5XX945aPA84Is7K8wn3WhWKPgcQPKz2MKqAXqAq+y3QFHoT+ MKKUm7jC+3in7l8H2ArSvLkqnJyI9DxKJbGDuYYoJrBeekOY8iPA03PMqwgUjy41N9etoY llyIZ5ffdHrv9eHaiczA+WdQJdMleck= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=JDXqPQJM; spf=pass (imf29.hostedemail.com: domain of yuzhao@google.com designates 209.85.222.182 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736874150; a=rsa-sha256; cv=none; b=lxOlXeEde88bdJC7uhMAQHcLGYpa3MoyzoaprRNTVAuDrfnZgoWhs02NtvRInMrhGvjBEI HySKq7lsj/lk5uxC8WU2liA/udO3e5PB36ewIFa2KG/aUMoaG+Oga6n8rDNLXvAPg7mGBc oYmF7gWK4MTh66Obz4UVsKpP/48mtqM= Received: by mail-qk1-f182.google.com with SMTP id af79cd13be357-7be3f230436so193612985a.3 for ; Tue, 14 Jan 2025 09:02:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1736874149; x=1737478949; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=5pwRPv3AC50iLCk2Zf2oVFdf10HsOLZLViQlkbWzupw=; b=JDXqPQJMfbmjNXI08WW4r9pHKhRdJiL99M3SrWtVHX5utNfbneUhCh4+RasZZLCtAb TR+wCRvtZp6nxhcs1aJR/fzCwdx27am8dyDBkzKVFGwecIL7aOPgaVwuNvAsbXxs8vU4 7j25lj/Wy+ubJejbnUhZmkF8R69syr3iw0DLs/9ULK8gu4x7vjSDlYjiZ8EgvfeP9b7v Rk1dDzj1LVWsdO7Q1iaF3ejIKR2+0TpY2xqRz3wV1iDVfDcutAYI0gnMWRxkqo/GpTcU O909ebfgHsSUVOCmSD01O53jYH5RwgH2caWLRPVIlkG2oiWQAEjKb9o52enwilbk4p5A txEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736874149; x=1737478949; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5pwRPv3AC50iLCk2Zf2oVFdf10HsOLZLViQlkbWzupw=; b=C/tGSMkZyzcwZIHsXdP7c1jmeHeuY3sFn9tenb2ejjuyA1QeImg3rIzZGfGarYnBhQ rUQWGaQ3C4t7LS2e2Zb0Gxl/lCDHLpxUjw6Xr5L3avqGxoQvu4ocavhcJtke4P8BYYhS MWipuQ2I8sLjLVG88fm/pH35LGbE205rPveux/n1UqTaKQRCVq1+b6j8E5j7z+SX+GF2 H+Dxq6zWIMbH1qoiB5yXwe47CAhGHzmWChGCw+NxIwsTP4tsIpJbABxIEX+0nPXRTq7u qhteCey2y6/KbMGuW89d6RKaF3vnEtoLxqzy+HueFuKIKMUbha5pWKPqzCPdq3TGxUt3 W7IA== X-Forwarded-Encrypted: i=1; AJvYcCV1S2VwNNCrFITwpqJcVbuJcbcFzR75/Hjq+r0BpBbnm89T6RdJQ5gVr/dHCrvnwvpLrBHOwm9uOg==@kvack.org X-Gm-Message-State: AOJu0Yz82HZJcZZ/1G8Zg62PnRnJml1Xf3fTkHhmhMMCNSc3p6cdBwpU yjMenYyhCPaJDUlZBZGshG7ktOt8YAOIru2mIwAJ+YCvFxWG9hEGmfEyKC91lgKgNAOhaOKJ1ld 9eJy47238I5Y/tgfzzGTXO/2nQJFcZDKAVubz X-Gm-Gg: ASbGncvCm7KUZzP9gKxf44YPvEoDRTm+8ULeEwBmwvJZHDzesjsa+y6Cd7/BB0gGkHI K7DDMm6erCSdzsjO2FnzKKegWNuOCHwWM7nFs3nQLfbVL4BB/TRlEWVRRfNxqdp3bf7PYPcw= X-Google-Smtp-Source: AGHT+IEmCebGY2XiXiMSHiPH6lyzErlM2sxmSzBWB4EBYHNDzzHKKbPlbhF+bpXyENdSkK3zvR6V00VYB1KaeeKmh74= X-Received: by 2002:a05:620a:244d:b0:7b7:142d:53b8 with SMTP id af79cd13be357-7bcd97c97e1mr4649151185a.53.1736874149139; Tue, 14 Jan 2025 09:02:29 -0800 (PST) MIME-Version: 1.0 References: <20250113093453.1932083-1-kirill.shutemov@linux.intel.com> <20250113093453.1932083-9-kirill.shutemov@linux.intel.com> In-Reply-To: From: Yu Zhao Date: Tue, 14 Jan 2025 10:01:52 -0700 X-Gm-Features: AbW1kvYQkyXZbUdcH1QNEYpQQw7S18-Qu-i6iGpqw5vVBDdyuuTWt_dBq2WlT1M Message-ID: Subject: Re: [PATCH 8/8] mm: Remove PG_reclaim To: "Kirill A. Shutemov" Cc: Matthew Wilcox , Andrew Morton , Jens Axboe , "Jason A. Donenfeld" , Andi Shyti , Chengming Zhou , Christian Brauner , Christophe Leroy , Dan Carpenter , David Airlie , David Hildenbrand , Hao Ge , Jani Nikula , Johannes Weiner , Joonas Lahtinen , Josef Bacik , Masami Hiramatsu , Mathieu Desnoyers , Miklos Szeredi , Nhat Pham , Oscar Salvador , Ran Xiaokai , Rodrigo Vivi , Simona Vetter , Steven Rostedt , Tvrtko Ursulin , Vlastimil Babka , Yosry Ahmed , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 5A550120005 X-Rspam-User: X-Stat-Signature: ogjm71bxuowsqw4gpyd4u6oedyarn84t X-HE-Tag: 1736874150-957022 X-HE-Meta: U2FsdGVkX1+z17lyxda+T8cKH9PWLDIiqY1BY5m1kD9ZpcVNPB5AWs8/Qmj/glbFXkpv3k5g6Xp6DMNLNruHaEOVaAohCUJnDc3eAOW8FJX9NVp8z0QjEGrJLHOU5u/5HzwTQSC9WkFGg1aUpQtnPkcux283zdK1Ddq4xHV3diaShnA/kFC0ncuudybWAuhvJWsS64hee2J91CWJxkDtJiPRsx5BL/K6EZ8rcw86nLqunqQ3ogv344UmojzsMeFaHlKmCrIR1bXjaZx2QdSrkFjM4wQufzE1PCjDJF/rg9AxuHiALCwMmDee6vhS1CMtjnh7tULq20Jo3JhkoXgXVrElSg985wVdnLs9D6oJJyJ90YE5joOh4baF4x4YD2o75wQdieBO9smc88c9arOfQ2pTd2q+BjyDKdWhLhaU32R/uM6PR8wXpZBYtuBInUk54vH37JNa3TSCKm+bZ735rT8BqAfYu6r77naSfQtJElnCdQZ/pd90bj1AG6J0aQe7QePr/VDaNQ8oXOn2YbmdEIOJTtaEETSloBTVtfweVDmRHTS+zwYvKQV6v8BY2FyXW99XatW1NqLsQS0LWkN80l6nEaDZjGV5/8oBR5zGMIAWVHjaARFM3YS6bsweRAe6dCb0x1emljE9IjxBiU0S9kYGR7/wiaEX7st1a/kV2Ax7EfENiAIcA9p7fFimU/ICQ3iHnvGhT3Payiv4iuuLTsFbzcBiuze44RxuLFiai+xxF92PGF5S+YcfUhbiv6stW98ZZxI4O65QSiFzcUGzIuoSUHAmfTdHx4+paGtpgSo2sMfg/r0PgPNVQunKyG150kTqxyOPyarVRQ251MijP8QXdmR9p60HPbaCus/+SLG+U2TaQIX/uWbX3cbsC40mAqgUdbaw4ALlhQNBH5Pz1ix1gKbBGGOtuATuvc7pigoaec4g1eoSoXuztoCbuZ9/mdBfd+B1ZW02kpPorhA Xvg0Iubn Ob8UM/9+Hi6sly5tJ9cKC85wlU8hxx+t6vHsHKKrTrgssClP8lvbuDbXdR536SMnkWmDsDALaG+zN2/ze/WUJQYBzDaAgWxUziVu3l6R5JeiU4v/qi53E/e37zZWBl2lbVgtKjFJvgJqJAQ+p0Kf6t5BWNQvce0L95/JJzWaedu2syduUCVsicR3TnBgBczzX6mw7if969fgtuEUhgw3/Pccp5tyFLry896hXpKNE1LFe/cejyqm9l3Cvm8XmORMNh4AxKTtA3H+VK9Q= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jan 14, 2025 at 1:30=E2=80=AFAM Kirill A. Shutemov wrote: > > On Mon, Jan 13, 2025 at 03:28:43PM +0000, Matthew Wilcox wrote: > > On Mon, Jan 13, 2025 at 11:34:53AM +0200, Kirill A. Shutemov wrote: > > > diff --git a/mm/migrate.c b/mm/migrate.c > > > index caadbe393aa2..beba72da5e33 100644 > > > --- a/mm/migrate.c > > > +++ b/mm/migrate.c > > > @@ -686,6 +686,8 @@ void folio_migrate_flags(struct folio *newfolio, = struct folio *folio) > > > folio_set_young(newfolio); > > > if (folio_test_idle(folio)) > > > folio_set_idle(newfolio); > > > + if (folio_test_readahead(folio)) > > > + folio_set_readahead(newfolio); > > > > > > folio_migrate_refs(newfolio, folio); > > > /* > > > > Not a problem with this patch ... but aren't we missing a > > test_dropbehind / set_dropbehind pair in this function? Or are we > > prohibited from migrating a folio with the dropbehind flag set > > somewhere? > > Hm. Good catch. > > We might want to drop clean dropbehind pages instead migrating them. > > But I am not sure about dirty ones. With slow backing storage it might be > better for the system to migrate them instead of keeping them in the old > place for potentially long time. > > Any opinions? > > > > +++ b/mm/swap.c > > > @@ -221,22 +221,6 @@ static void lru_move_tail(struct lruvec *lruvec,= struct folio *folio) > > > __count_vm_events(PGROTATED, folio_nr_pages(folio)); > > > } > > > > > > -/* > > > - * Writeback is about to end against a folio which has been marked f= or > > > - * immediate reclaim. If it still appears to be reclaimable, move i= t > > > - * to the tail of the inactive list. > > > - * > > > - * folio_rotate_reclaimable() must disable IRQs, to prevent nasty ra= ces. > > > - */ > > > -void folio_rotate_reclaimable(struct folio *folio) > > > -{ > > > - if (folio_test_locked(folio) || folio_test_dirty(folio) || > > > - folio_test_unevictable(folio)) > > > - return; > > > - > > > - folio_batch_add_and_move(folio, lru_move_tail, true); > > > -} > > > > I think this is the last caller of lru_move_tail(), which means we can > > get rid of fbatches->lru_move_tail and the local_lock that protects it. > > Or did I miss something? > > I see lru_move_tail() being used by lru_add_drain_cpu(). That can be deleted too, since you've already removed the producer to fbatches->lru_move_tail.