From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D111AEEAA5D for ; Thu, 14 Sep 2023 17:47:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 51A398D001A; Thu, 14 Sep 2023 13:47:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4C9648D0001; Thu, 14 Sep 2023 13:47:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 391848D001A; Thu, 14 Sep 2023 13:47:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 276488D0001 for ; Thu, 14 Sep 2023 13:47:15 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id F1F831A060C for ; Thu, 14 Sep 2023 17:47:14 +0000 (UTC) X-FDA: 81235934388.18.EEBF1A7 Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) by imf25.hostedemail.com (Postfix) with ESMTP id 1EC06A0026 for ; Thu, 14 Sep 2023 17:47:12 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=iiONNhoG; spf=pass (imf25.hostedemail.com: domain of yuzhao@google.com designates 209.85.160.179 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694713633; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OapqwkKCf4YIRdOK5eipqLOcrCetpXM2XnBK/inREIE=; b=iWjkHj5FftFZ3tKOx/k+IKPS+5LRBcfAqJ0PoIM0jchBvDyfOO4L8gkWJ8Ernn+xbU0uPd tSHBwhs6GriX8QMtMKteqDh2b0f3PL7d/Kq79wc3/8Ax0YBszPqKCn66flFUW33uLchLlh 1T04qqJvN+bzTkA8gQ14JCzRsQlPJuY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694713633; a=rsa-sha256; cv=none; b=Ojtgm4HOZ1gGlxvI0xBt8FSIXXtKXITuhtAHC9Hl1Qfvx5xPkiDQ3yT1+apYI3iM4RPUlG Reg9TcdIHqbGdH7wlaDKfITg2oPP3XDJSvaomCwFIL/Epi5Wt2QXwe2QpXpOWlJ8da4aRW w1CRx4PBTF9xip9MwsCPW/Jb05omOy8= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=iiONNhoG; spf=pass (imf25.hostedemail.com: domain of yuzhao@google.com designates 209.85.160.179 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-qt1-f179.google.com with SMTP id d75a77b69052e-415155b2796so26171cf.1 for ; Thu, 14 Sep 2023 10:47:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1694713632; x=1695318432; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=OapqwkKCf4YIRdOK5eipqLOcrCetpXM2XnBK/inREIE=; b=iiONNhoGE7joFzwsozA12NLvWRU8fcVuFGKK4nYiEZ2C5YwsxONMxFKnsF1gN+d1iI 8qHamgneOg7oNGfXAMPtKQLH+vfCnERxoYSev6dUpy1Yzc2DcdML0IOsIqunX/erf9U/ U6V0ckSGOQQ/u1EJ1P+4rE21iTVElVeeMEN/3+a688YVM+J4PC1g2cF7jHw5oXwiG7Bh SQ3OQHbe+F1DMaFSGr1COXxqIRbl3A7d1eytS7UIoB6P2WCi2DBFHfw9k8iUPEirfNiQ N08HYxWfl5rtb1g3UMQxyXlU8d1Ed+vafANi5K2M2e1ZpOZVapaP1HNAQdbWWJzqHwKa oQHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694713632; x=1695318432; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OapqwkKCf4YIRdOK5eipqLOcrCetpXM2XnBK/inREIE=; b=nBuLeFsa8qMhSDizJ/C8FAIVudRTnuIiNL+hUlyxYVshkNOhVbgq7SdacH/TumsI4x LC+h7grE8uwnac2RVUgpgyCZAEexdSntn2uF7hf19lG/652fh8IHGr3s9txWRyvhRVIS uQYHR2Ca4lULiUlmr7dbHJa9M0uhonpencYtXbn9aDAxacr142hv3UEKyrm1VXoqJC1d 3dYUkxvz6vfqF4m5zvy0h5wzuqshYurFfUYSCbPZpOlzdjhjRxonMx58M865DeBpQhGg nbghZYGHKrINERwJnmsQSE6vqeVyly6GaQimd65ZUoELkwsM89gU2R8gFTIL6Oa5Kd55 8oRg== X-Gm-Message-State: AOJu0YyplVE4rKFJyJECBA9IT08vBTqN5w8BUEvtuqros5V1ff5ug7Wr L6YkrQFmuAZj8aUj2ZdbzdLvqpRfEmhuMKLVOuZC5w== X-Google-Smtp-Source: AGHT+IG3dCEOE5PEHdrU+RjQG71bo20lPeEalZi4ir7k35XVyOQ4/Mg/UvcNdhM+698GCDtKbdL+6QOc/dR/UWSrgQ8= X-Received: by 2002:ac8:7f4e:0:b0:403:fdf1:e05e with SMTP id g14-20020ac87f4e000000b00403fdf1e05emr10948qtk.19.1694713631986; Thu, 14 Sep 2023 10:47:11 -0700 (PDT) MIME-Version: 1.0 References: <20230914140823.1732-1-justinjiang@vivo.com> In-Reply-To: <20230914140823.1732-1-justinjiang@vivo.com> From: Yu Zhao Date: Thu, 14 Sep 2023 11:46:35 -0600 Message-ID: Subject: Re: [PATCH] mm: mglru: fix add unevictable folio to lruvec->lists To: Zhiguo Jiang Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, opensource.kernel@vivo.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: 7yn3c6j31f6i9re9q1wibhj45n6qkyqy X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 1EC06A0026 X-Rspam-User: X-HE-Tag: 1694713632-413999 X-HE-Meta: U2FsdGVkX1/14NuM0po4WV1xeVOsrD2ope3lsXiKH7UqkBXVR7p98Cv3Fgg1rxTrep4UN3jxfijop3r36HSwvA1IlLD0Y1+JYBX9bCgEgboVa3qoANnfg9+jYeFWEQSq58YRPhLbWARUefp9RhQ1uXJQwrZe7obuVh2aDH4VDy3X2P9QD85XjubkLHv1hRWGAIFTmsVU+TQELRKBYwTV8vOE5kr2Fw1gzN6ejBgowWqkAFtcg/CRu/TS7YLqwXgohrZzQTjSH2kd36Ev0V3ZJcB1b7JgcnV64UEHbYrgLVlPQfVqaWH/JKhg8DyiQ8iJbrxE6BB3KPi1A8O3MXXWzYVx1Q1RPf8E5RFs6qfMJxycqCCf5LiQKIDX+/5XaQQo2uLbnkICuprFRt/Oc/9ED1lMfC/iIDbHp64MtGcnrG4MIiqQXxUVCkbUzupeVqtBvKxRKgBFwVLqsPFPmzwVnCk5Z9R1qkDby0ZzmPLPNE0mfRgoWAOlVy4bJSXALztZVcvDtnZHjSlKeYuXTsMBegZw9YqV6zSnVvP49xm66BfcROZmBMdPgQz+azN5bVOd6Bjzw55BOww9YQQa2JofjArrht6wrNJS39/xuZuPHTVASiPaQc92QnQqAxJHV4pxX0rFe53pTtAC5rknsJ77NHjt468znt6UZeq9VucgpTVrIghU5/4ptdefVwbIPMv37EPyXQayovweRxHuviHL7D89Q4wXqR26NDS/OaAjBV64H7vR/9PCmnTovOwYpGCDM2to4duv0xZnMG+z7O91Q+8MvvThCbY/wrJrWUwx1MmQYvSjM3dmtQAB4pBUzf/Wg2OIwKf3ppFD3uqhPpMLKbn5cGivxlHJBd1T8mj16x6FeI95C1WgRi92bki2biSKY1hFefRgn1Y0AM2+UC2blTGbwvq4CwpRb+548NtP7ekn2IPhX8A1rJX9CA/B9TW0VjfhnNI9oYHS7X2/B8G Qjpm5WKE Wq2uhLimmf7o0KA+0zfTR4d0h2xJrwf2ulNg/3F7ly7etCFR0kDkdxwf8Lu0Yry5C22EuDSG4AGIedN1OaTdgRZxXHs0lDsOo9oZAovyDMrh+1reLWgXjhKzfgJGFU5IImoQq/kyBaai3AtFhlwb6IyOcNUeSQ7xNI6BNxoYhRDBwgCiWaAopAqyjIm+gQcpCxAcWgjmpE+APHKAPmBIrii1AP1RjgYK3Q4DsrNpzcI4vjbqLjPB0B9AKrtW6AtIpKLLDZbQV2Mnj7MlWgnXz1EndxDZn89nhNIFN X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 14, 2023 at 8:08=E2=80=AFAM Zhiguo Jiang = wrote: > > The unevictable folio is not supported to add to lruvec->lists > in lruvec_add_folio(). > > So use lruvec_add_folio_tail() instead of lruvec_add_folio() > to add unevictable folio to lruvec->lists in sort_folio(). > > Signed-off-by: Zhiguo Jiang > --- > mm/vmscan.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > mode change 100644 =3D> 100755 mm/vmscan.c > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 661615fa709b..a15e45632034 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -4237,7 +4237,7 @@ static bool sort_folio(struct lruvec *lruvec, struc= t folio *folio, struct scan_c > success =3D lru_gen_del_folio(lruvec, folio, true); > VM_WARN_ON_ONCE_FOLIO(!success, folio); > folio_set_unevictable(folio); > - lruvec_add_folio(lruvec, folio); > + lruvec_add_folio_tail(lruvec, folio); > __count_vm_events(UNEVICTABLE_PGCULLED, delta); > return true; > } NAK. lruvec_add_folio() { ... if (lru !=3D LRU_UNEVICTABLE) list_add(&folio->lru, &lruvec->lists[lru]); } lruvec_add_folio_tail() { ... /* This is not expected to be used on LRU_UNEVICTABLE */ list_add_tail(&folio->lru, &lruvec->lists[lru]); } struct page { ... union { struct list_head lru; /* Or, for the Unevictable "LRU list" slot = */ struct { ... }