From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 600FAC77B7E for ; Mon, 29 May 2023 16:36:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5826A900002; Mon, 29 May 2023 12:36:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 532836B0074; Mon, 29 May 2023 12:36:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3FA66900002; Mon, 29 May 2023 12:36:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 2CA266B0072 for ; Mon, 29 May 2023 12:36:27 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id EDC4A1202DB for ; Mon, 29 May 2023 16:36:26 +0000 (UTC) X-FDA: 80843845572.12.7739288 Received: from mail-yw1-f173.google.com (mail-yw1-f173.google.com [209.85.128.173]) by imf18.hostedemail.com (Postfix) with ESMTP id 3F1B11C0017 for ; Mon, 29 May 2023 16:36:25 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=gD4kPaLL; spf=pass (imf18.hostedemail.com: domain of nitheshshetty@gmail.com designates 209.85.128.173 as permitted sender) smtp.mailfrom=nitheshshetty@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685378185; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XGlmlfpGRhYW8HjfyI5EG9tKXwTbZGzHl2Gw/X6ax14=; b=En984QgVWwmAx6PffxMZsuAcoIETOfKu02gca3bgJ1ZdNmC0ZI7t7hPFUny63Gta2o9/5L QspwGMHDt1BcQ3/PRLjU7g+7rE3SzuGhRzWYYCn4/fHSKTJnY0x5IaMPEXptCvxi5ew2VD dUWfyIW+A+WTHOi2yMxY/Y6PGdfJ9G0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685378185; a=rsa-sha256; cv=none; b=Y3qzheACXqLFcgTOTZklXDFirYkOs6RR44A+tuvNgMJcF8s8+dVo55MGCS/Q2sM7er+5hr mNk+TSj3fkiYlJBGL64AuJxX4ZY/yRQEgCgh+ZmAHsOstJsu65NAdzZqOrEG92ZM8pH/f/ 8yd+SqihF+tc0gM2Xaa0fhNiamC4yiE= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=gD4kPaLL; spf=pass (imf18.hostedemail.com: domain of nitheshshetty@gmail.com designates 209.85.128.173 as permitted sender) smtp.mailfrom=nitheshshetty@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-yw1-f173.google.com with SMTP id 00721157ae682-565e6beb7aaso26298967b3.2 for ; Mon, 29 May 2023 09:36:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685378184; x=1687970184; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=XGlmlfpGRhYW8HjfyI5EG9tKXwTbZGzHl2Gw/X6ax14=; b=gD4kPaLLf9pJV0lpw2cIWttEo9EVBn7x8f+92LW12OXCCFANe21Fg01PjDXO0UtxY2 Ub5I5H1SdDWAoWmUFNeFLAYHmxDq8YTSmOaqguooZLFZobRrzvTxGbtaD72knDH23eOR MY6ARUPzlKzmyW1m+BBJysdYOhoJdDqFYBuSUXe+0EMClHkTcg4RjJwjoiWhoOTKM3Dt 9K997gDZQsyxazGzIDcLguDZimyccw5IT7vyORCRBHtiqJDhUH/qSIl0d7GezyQg513/ VW7HwcNry8jcfbS5LOs9BUzeIfyV4CP5ISfkACbfC7ABZjMV3VQHFd1Zf4JXCiU+XtDx EW2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685378184; x=1687970184; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XGlmlfpGRhYW8HjfyI5EG9tKXwTbZGzHl2Gw/X6ax14=; b=Xe3g36/CreKCQCLbJ4+/uHYkv8o5YbGOjNNra+6kbJL9l3QdNARBac6njLGqGauU/H jtjY9jy6oNmOKZGWnOdIBzCKp9P9nQO7BohN94qioVJs4FxczFbATLzHMnVFV+PlZ+KO daLmKg3vgVznqMPQmuIufQjABkGvjETiPEe4S63uuU8FX3SNVJw3uqNmhOjcG52PucAd KhNJ+d/MXKpFVCKMfrLCUF+amCnxliQqAhlNqdCcOKcDxta0LNkztDuRIf0cflPe6sLk JSeUVs9ZpsSt8rc60ETAZ8GVlJ1XDHGUooJ6rK0LvlkIVY6XN1ZM7TrJClJuoT4ukjlc C2cg== X-Gm-Message-State: AC+VfDzbe0sgS+/weF3gNKdsBNicvrNxG9xCNeluiWH1wsziGWMjBBGD xXCYqUOBH5hqh3v4TPEj7yepin2ZyzjzJv6v2Dk= X-Google-Smtp-Source: ACHHUZ7InCRLGF330bSJ+LMuRh4g/NfzTfd2m8OEywQty5+b+eU+JLZRKLHh0ktsR3qbMPwu4QSHwqAz7Ha/ifAXWSw= X-Received: by 2002:a0d:d88b:0:b0:565:bb04:53fa with SMTP id a133-20020a0dd88b000000b00565bb0453famr11663162ywe.10.1685378184319; Mon, 29 May 2023 09:36:24 -0700 (PDT) MIME-Version: 1.0 References: <20230522104146.2856-1-nj.shetty@samsung.com> <20230522104146.2856-3-nj.shetty@samsung.com> <20230524154049.GD11607@frogsfrogsfrogs> In-Reply-To: <20230524154049.GD11607@frogsfrogsfrogs> From: Nitesh Shetty Date: Mon, 29 May 2023 22:06:13 +0530 Message-ID: Subject: Re: [dm-devel] [PATCH v11 2/9] block: Add copy offload support infrastructure To: "Darrick J. Wong" Cc: Nitesh Shetty , Jens Axboe , Alasdair Kergon , Mike Snitzer , dm-devel@redhat.com, Keith Busch , Christoph Hellwig , Sagi Grimberg , James Smart , Chaitanya Kulkarni , Alexander Viro , Christian Brauner , "Matthew Wilcox (Oracle)" , Andrew Morton , linux-block@vger.kernel.org, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, linux-mm@kvack.org, gost.dev@samsung.com, anuj20.g@samsung.com, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, ming.lei@redhat.com, James.Bottomley@hansenpartnership.com, linux-fsdevel@vger.kernel.org, dlemoal@kernel.org, joshi.k@samsung.com, bvanassche@acm.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 3F1B11C0017 X-Rspam-User: X-Stat-Signature: 8ewgs6ndms16hbrzm33bcgc43iosymku X-Rspamd-Server: rspam03 X-HE-Tag: 1685378185-460591 X-HE-Meta: U2FsdGVkX18/0KK8Vm3108C3a2uUn6s+vWDqfrz3TicR7U2Vw/NPNquf+2xBf8o/sPxIDpInlHO8Ygqeh1uk9LeKYEFhUJFZxyE+ZXTU8cXOlR9yTyH9BESlWLcJRO01Nj39xKvcElPFjc+R7hHhbJZrMDHNprzjQcUmYOAFS8Bg+TVrviqCjUW27MzI5CWDmk/GGj4tdeqskVuaW2pKAskzE5ulJ1ddUkALt7zfmSQZwtQV0Am0nfFi/87y8Y8ODeypA4cWrNoiimCtKWVAHkpvQ3GTIXgmUSR5UO9D6JhG4Cu2VgpDHJIvm/mNyPXNRYGSxXYvio/1YSNgTEnI7U3LCjb97gHYRs9usyK4PN89ZNWFssfDtWYJ70MGrWP9KqVXWD+BLvuBMTtSonqHSj3RWVcYFobx5b4DOOS1c1kN+x5ofOHBoV6xzGp0+oRq65iqnphUG2pbTCbFje09CQAoGOYgdCNddTz498/kPI2IGITwelyW+jrE250uCZMLjmWXYxxY3uHKFiuIapcd8Zx6TL/xeSTf0XklbN2BU9uOFQ3rFuRMd8bTZEIYXAS+A45oOZdZI5qHDUa2boF26c/XH4jsi3Ik2S3vZA89X9cEhJwLbVAkPzaUhK89RAkVTygW7tHgy6JB6BMkfgUtWXh4X8gvfx0zGKQGC3YUlzZdMJEDrY8R+++8/83u8L669c/FpcUGcEghOeagleaXMwk0iB5AxntnJARGHhbl9J1UB3uzP8G3atsyYw7uAYKzA/JlWilHn+3iK/B4wkbO/AIRn5/J/fTYq0k84a0QdbRNLHJ5gdwZA/ClpSCmD6P7i2bTzbkbdgECJvP/r1wCDVA2Cft1ofaEmt0SyryFFTNcrrW/HeIut6kcEyFiBE1c/O6334MnXh/TNGdu7SzEyP1uhdtehKVslOyg3Ko1P+zr651AG3qstunQrpSvvriuJ2eAGlIqf/5Ijw6kiFF SLZTXtRg zKfNSOzG1rOujI/uZVj+4B0DWcW6tQyzeKru7181Jo33vQO5MTNV0jAauFlpCxv5zkOKMkFqN+ewe1JV6l2Ofw/Fi9/BW6snVDUPLj26p5mssyMO7C6oR2bROmMqdLYWhrA2cTIvsNCpC1gbE9smdr0dprOXnHW6+mK34gRvteGWX0AD6Ae8YogE5PJqaKKNWyTadp47ra/13RPTCrwSyqn5uzZr8zH3ZX8IVY0bYMIWjCVjRKC1GETNGYxMXflwyw7f14Wqyr9rgATlk/lDi4Eeb+YtTGPHNR+b7E4tGuXmmVcNUOG4apjH3DEyNKCkiOy8ny83Im/+GUfhgn8Ln82xc5YvO+NBuLnyf X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > > +/* > > + * @bdev_in: source block device > > + * @pos_in: source offset > > + * @bdev_out: destination block device > > + * @pos_out: destination offset > > + * @len: length in bytes to be copied > > + * @endio: endio function to be called on completion of copy operation, > > + * for synchronous operation this should be NULL > > + * @private: endio function will be called with this private data, should be > > + * NULL, if operation is synchronous in nature > > + * @gfp_mask: memory allocation flags (for bio_alloc) > > + * > > + * Returns the length of bytes copied or error if encountered > > + * > > + * Description: > > + * Copy source offset from source block device to destination block > > + * device. Max total length of copy is limited to MAX_COPY_TOTAL_LENGTH > > + */ > > +int blkdev_issue_copy(struct block_device *bdev_in, loff_t pos_in, > > I'd have thought you'd return ssize_t here. If the two block devices > are loopmounted xfs files, we can certainly reflink "copy" more than 2GB > at a time. > > --D > Sure we will add this to make API future proof, but at present we do have a limit for copy. COPY_MAX_BYTES(=128MB) at present. This limit is based on our internal testing, we have plans to increase/remove with this limit in future phases. Thank you, Nitesh Shetty