From: Tejun Heo <tj@kernel.org>
To: Petr Tesarik <ptesarik@suse.cz>
Cc: Cong Wang <xiyou.wangcong@gmail.com>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>,
Vivek Goyal <vgoyal@redhat.com>,
surovegin@google.com, gthelen@google.com
Subject: Re: Is per_cpu_ptr_to_phys broken?
Date: Thu, 15 Dec 2011 10:40:42 -0800 [thread overview]
Message-ID: <CAOS58YP8o9xQvZJtpEJobChhJ+pSDQ9PqDwaXFS_h+JFd65jOw@mail.gmail.com> (raw)
In-Reply-To: <201112151139.32224.ptesarik@suse.cz>
Hello,
> Now, per_cpu_ptr() gives the correct virtual address, but
> per_cpu_ptr_to_phys() gets the result wrong, regardless whether it thinks that
> the address is in the first chunk or not:
Yeah, that's me forgetting "+ offset_in_page()" after vmalloc page
translation, which incidentally was also discovered by surovegin last
night. It has been broken forever, by which I mean longer than six
months. I wonder why this is coming up only now. Anyways, please send
me a patch, I'll be push it mainline & to stable.
Thanks.
--
tejun
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-12-15 18:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-13 23:33 Petr Tesarik
2011-12-14 16:17 ` Cong Wang
2011-12-15 10:39 ` Petr Tesarik
2011-12-15 18:40 ` Tejun Heo [this message]
2011-12-16 8:04 ` [PATCH] Do not round per_cpu_ptr_to_phys to page boundary Petr Tesarik
2011-12-16 8:40 ` Petr Tesarik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOS58YP8o9xQvZJtpEJobChhJ+pSDQ9PqDwaXFS_h+JFd65jOw@mail.gmail.com \
--to=tj@kernel.org \
--cc=gthelen@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ptesarik@suse.cz \
--cc=surovegin@google.com \
--cc=vgoyal@redhat.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox