From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx188.postini.com [74.125.245.188]) by kanga.kvack.org (Postfix) with SMTP id 2337E6B0032 for ; Mon, 17 Jun 2013 19:08:14 -0400 (EDT) Received: by mail-pa0-f49.google.com with SMTP id ld11so3295452pab.8 for ; Mon, 17 Jun 2013 16:08:13 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1371128589-8953-1-git-send-email-tangchen@cn.fujitsu.com> <1371128589-8953-4-git-send-email-tangchen@cn.fujitsu.com> <20130617210422.GN32663@mtj.dyndns.org> Date: Mon, 17 Jun 2013 16:08:13 -0700 Message-ID: Subject: Re: [Part1 PATCH v5 03/22] x86, ACPI, mm: Kill max_low_pfn_mapped From: Tejun Heo Content-Type: text/plain; charset=ISO-8859-1 Sender: owner-linux-mm@kvack.org List-ID: To: Yinghai Lu Cc: Tang Chen , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Andrew Morton , Thomas Renninger , Jiang Liu , Wen Congyang , Lai Jiangshan , Yasuaki Ishimatsu , Mel Gorman , Minchan Kim , mina86@mina86.com, Chen Gong , vasilis.liaskovitis@profitbricks.com, lwoodman@redhat.com, Rik van Riel , jweiner@redhat.com, Prarit Bhargava , the arch/x86 maintainers , linux-doc@vger.kernel.org, Linux Kernel Mailing List , Linux MM , "Rafael J. Wysocki" , Jacob Shin , Pekka Enberg , ACPI Devel Maling List On Mon, Jun 17, 2013 at 2:13 PM, Yinghai Lu wrote: >> No bigge, but why (1ULL << 32) - 1? Shouldn't it be just 1ULL << 32? >> memblock deals with [@start, @end) areas, right? > > that is for 32bit, when phys_addr_t is 32bit, in that case > (1ULL<<32) cast to 32bit would be 0. Right, it'd work the same even after overflowing but yeah, it can be confusing. Thanks. -- tejun -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org