From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D0E8C33C9E for ; Tue, 7 Jan 2020 06:54:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 10E38207E0 for ; Tue, 7 Jan 2020 06:54:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VauDvkWv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 10E38207E0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9F9728E0017; Tue, 7 Jan 2020 01:54:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 982698E0001; Tue, 7 Jan 2020 01:54:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 849F38E0017; Tue, 7 Jan 2020 01:54:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0024.hostedemail.com [216.40.44.24]) by kanga.kvack.org (Postfix) with ESMTP id 693F18E0001 for ; Tue, 7 Jan 2020 01:54:36 -0500 (EST) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id D79795823 for ; Tue, 7 Jan 2020 06:54:35 +0000 (UTC) X-FDA: 76349924910.05.plate02_afcddb791722 X-HE-Tag: plate02_afcddb791722 X-Filterd-Recvd-Size: 5344 Received: from mail-il1-f194.google.com (mail-il1-f194.google.com [209.85.166.194]) by imf05.hostedemail.com (Postfix) with ESMTP for ; Tue, 7 Jan 2020 06:54:35 +0000 (UTC) Received: by mail-il1-f194.google.com with SMTP id t17so44798573ilm.13 for ; Mon, 06 Jan 2020 22:54:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+SCicnEjkyGwhQ2AgjvMF6X8DeQvHHm5K6F+M+EsiSo=; b=VauDvkWvynYu3g7Fs6x0yQotweycU1WnoCLtCr61aTA7fmLaQ0tMBm6lm6lyPzBJEr pKm512nt7Bn8iunBUOhvg9mNL6dKI6YrstUHevxFGjMryXMnXtSbr8Jgm6iS7SnukDHU X1k+q7mDT2d3DVYzK4G9PketVqxnQhZwo6SuLu79XVoTHYLdRk0dWdK0IJTiPnPQsVDd bDbg7zu4/Fyl6TEO8J+AYb8uG5qccIWPQKU/w1+L4i6KKAK66Ezni4xpN0AHyGdRi/CV fUiT7h4O8D1pwRdHlHTi/vXzZ85O7uZsFLkM/M8/n/fUOUCeo9BWWObsBNrhQoaJy1ET ZzIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+SCicnEjkyGwhQ2AgjvMF6X8DeQvHHm5K6F+M+EsiSo=; b=JPDcIetzJhXy7Z+1Hz4fWf3P6GB2XHXprRsUZHpNCOFsPGn1NG/u0SNGGjASKtdGLF r52hP0XvLOFFS2S/Tlsg/BvrlTrvfOJ3kzmcmQBfLzeimv5WzJY30SSKH6m5AjRFP5cO yqMu4Avz3yc61k+GoFV7lIwy6BBxu0hTCtLg0oHWcPZV/a3uUBaeU4imhPS+innI5pNx Z4ygmJkFulbta1DK1zQFWHKGLt6Zyxp5QAge4O2dzi2SWoa6qPxbQrciH2MGFpDNdVEX L0k1kAxe2v+VJl1hWjZtla0c0roGan/OiY4PmawSAqdvUZW/TR3IVDwWhSJZbdt1G8IU FAZA== X-Gm-Message-State: APjAAAWHsJiPsC2x7/Hy/2SB3aYIeW+JSy6kYsshezvFGN2Ry8+rAv00 GWec/fnVHazhIpAYZRrewLidtgRGMLdKod9jySg= X-Google-Smtp-Source: APXvYqxCG63+ToFv7QxbgGA8nekvOLEB3uq0vA184/pCTkC0mQiIYHbo0bQs0D1l/B5uwGv5o8P/yTE1tHYkViMPURA= X-Received: by 2002:a92:88d0:: with SMTP id m77mr94426988ilh.9.1578380074721; Mon, 06 Jan 2020 22:54:34 -0800 (PST) MIME-Version: 1.0 References: <20200107001039.GM23195@dread.disaster.area> <20200107001643.GA485121@chrisdown.name> <20200107003944.GN23195@dread.disaster.area> In-Reply-To: <20200107003944.GN23195@dread.disaster.area> From: Amir Goldstein Date: Tue, 7 Jan 2020 08:54:23 +0200 Message-ID: Subject: Re: [PATCH v5 2/2] tmpfs: Support 64-bit inums per-sb To: Dave Chinner Cc: Chris Down , Linux MM , Hugh Dickins , Andrew Morton , Al Viro , Matthew Wilcox , Jeff Layton , Johannes Weiner , Tejun Heo , linux-fsdevel , linux-kernel , kernel-team@fb.com Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 7, 2020 at 2:40 AM Dave Chinner wrote: > > On Tue, Jan 07, 2020 at 12:16:43AM +0000, Chris Down wrote: > > Dave Chinner writes: > > > It took 15 years for us to be able to essentially deprecate > > > inode32 (inode64 is the default behaviour), and we were very happy > > > to get that albatross off our necks. In reality, almost everything > > > out there in the world handles 64 bit inodes correctly > > > including 32 bit machines and 32bit binaries on 64 bit machines. > > > And, IMNSHO, there no excuse these days for 32 bit binaries that > > > don't using the *64() syscall variants directly and hence support > > > 64 bit inodes correctlyi out of the box on all platforms. > > > > > > I don't think we should be repeating past mistakes by trying to > > > cater for broken 32 bit applications on 64 bit machines in this day > > > and age. > > > > I'm very glad to hear that. I strongly support moving to 64-bit inums in all > > cases if there is precedent that it's not a compatibility issue, but from > > the comments on my original[0] patch (especially that they strayed from the > > original patches' change to use ino_t directly into slab reuse), I'd been > > given the impression that it was known to be one. > > > > From my perspective I have no evidence that inode32 is needed other than the > > comment from Jeff above get_next_ino. If that turns out not to be a problem, > > I am more than happy to just wholesale migrate 64-bit inodes per-sb in > > tmpfs. > > Well, that's my comment above about 32 bit apps using non-LFS > compliant interfaces in this day and age. It's essentially a legacy > interface these days, and anyone trying to access a modern linux > filesystem (btrfs, XFS, ext4, etc) ion 64 bit systems need to handle > 64 bit inodes because they all can create >32bit inode numbers > in their default configurations. > Chris, Following Dave's comment, let's keep the config option, but make it default to Y and remove the mount option for now. If somebody shouts, mount option could be re-added later. This way at least we leave an option for workaround for an unlikely breakage. Thanks, Amir.