From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A55ED597BE for ; Wed, 13 Nov 2024 00:06:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CB4A86B00B4; Tue, 12 Nov 2024 19:06:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C64C26B00B5; Tue, 12 Nov 2024 19:06:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B2B816B00B6; Tue, 12 Nov 2024 19:06:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 944E56B00B4 for ; Tue, 12 Nov 2024 19:06:12 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 1A3BC4068D for ; Wed, 13 Nov 2024 00:06:12 +0000 (UTC) X-FDA: 82779128922.02.6B208AF Received: from mail-qv1-f49.google.com (mail-qv1-f49.google.com [209.85.219.49]) by imf28.hostedemail.com (Postfix) with ESMTP id 4E090C0006 for ; Wed, 13 Nov 2024 00:05:27 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=fNVeoBqS; spf=pass (imf28.hostedemail.com: domain of amir73il@gmail.com designates 209.85.219.49 as permitted sender) smtp.mailfrom=amir73il@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731456315; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9EL2scJFXnccPjhChzPUjKuhb1mAN3zWhyrLCbq7A30=; b=BUGJZNNQgFQWqM99QAvGaGfMBY4K7S4oTqX7B6Eoxu6UyTWZNKFOeUtDDIZ/M6CExabEnD uYjKfnzbmg/1y2hVvcSlaYp/WMOZt79LJYZBTN967AFyboxx38/1TRcAvAFKwljBHDO1bt dlfBYNMu8JXrBL4tAtAkdEGJStpzwXE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731456315; a=rsa-sha256; cv=none; b=wsPi/WCTS9YRYVTVXHhmWNAhB7a/IZf4qoVq0E+fm9Mr9lGSPYU5O1p+VrO8lQElly8Ngq ATjZpO3JYNcar2JIEqc774OAH09gxV31IGgWNApqtyimAJMxz1ZRYWoiKgRVMeKD4trCAu tFsF2qyE3TgSREYTtxlnI9lk6Rb0kAM= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=fNVeoBqS; spf=pass (imf28.hostedemail.com: domain of amir73il@gmail.com designates 209.85.219.49 as permitted sender) smtp.mailfrom=amir73il@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-qv1-f49.google.com with SMTP id 6a1803df08f44-6cbd092f7f0so42225856d6.0 for ; Tue, 12 Nov 2024 16:06:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1731456369; x=1732061169; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=9EL2scJFXnccPjhChzPUjKuhb1mAN3zWhyrLCbq7A30=; b=fNVeoBqSu1EVtGrMhgZ9RPT6HC5uZNZdDRQb2fNabe5nVAl1iv3DsaKSUEBMqQ31zw 9XWI2PWXIwjlTCAdsQaxf84JKELzcz40nHRXc4Gh6feLGhYIyxKanFMU2JFJoY9B9cs9 km7srbu6HGu5OoKmJAsCHfHj2MFYm9GZmBThwblKsqo1Khdr65A9LLcr18s6GOB3+fCQ D0YIsxOjcf3oZ4vp729QJSzMh9oL26ALweDOFuFEvQc+Ds0EhJJytcOerx0KvJ2MeJNx NP5PoSlGvwqgKNYSQCpbnZxpPhLMyqKuB1rnF8riJu8p0a/0lxp+LThozt8zktJjdfnV c9Fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731456369; x=1732061169; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9EL2scJFXnccPjhChzPUjKuhb1mAN3zWhyrLCbq7A30=; b=BJxMcdXcFbF8W3+v/jALKtzRgAJKCiDHtnrfySLhmZs3BdEATSBSQoiDX1HX67caFt /v6qS/9YIk1zDEMBVOWrCkf2jltOzVYcdKejFE1elx21Tx4yF9pTwU0wS1sY6aVXrZZt nmBQRIHAQ6SJpA/ZVno6ag0CUk0tPzUjhc4buD/44/zePQy6M+pOhLqPpzvL9jBc13Gz 0JD2tyn4H0JHAtbYbnNxhn5lDWTxZ2lR1yOiBWPzNwQJ4mf42UQsGtPMowvPvxMgixSS mvDe6ugm6X0wZz+tAy9H2nlMVNZlZW6bc+4tRohbsOa6AMGc4/SvVmGC08Rc2lUeklAS U0kQ== X-Forwarded-Encrypted: i=1; AJvYcCXb5QX/XlIyTHjmGPccRwnH+KksIqZNnXTYrV0/Ne+IboOINj4pQqZnrQq83e3IbZ9tzpLJbGO7Sg==@kvack.org X-Gm-Message-State: AOJu0YwhFMmYuekhxNxeH/dELXMFmIllhEPV01viLJkA2e1k8l+P0xQR AgApFI4ApphCrUjlrPYG7/LWLHs8YJ7OO0XVEJprghWfmkjmnxzdLt3Z5v4MrhDYMfK7nFvUjty fqrjEBSStVnprq6g9Y8RPTClCwwM= X-Google-Smtp-Source: AGHT+IHkvSgq/EOVX4LpHBlkcl1hDns6d7bWEXuH8vWxtTEazMpiUPJkYBXQtgxz2fPI5ACmGcS0nB3VO6Ms5GyJOoA= X-Received: by 2002:a05:6214:570b:b0:6d1:992e:4c5a with SMTP id 6a1803df08f44-6d3d03a9ac0mr63223186d6.45.1731456369379; Tue, 12 Nov 2024 16:06:09 -0800 (PST) MIME-Version: 1.0 References: <141e2cc2dfac8b2f49c1c8d219dd7c20925b2cef.1731433903.git.josef@toxicpanda.com> In-Reply-To: From: Amir Goldstein Date: Wed, 13 Nov 2024 01:05:58 +0100 Message-ID: Subject: Re: [PATCH v7 05/18] fsnotify: introduce pre-content permission events To: Linus Torvalds Cc: Josef Bacik , kernel-team@fb.com, linux-fsdevel@vger.kernel.org, jack@suse.cz, brauner@kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-mm@kvack.org, linux-ext4@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: 3aa9nbqtos117z45qrfon1wm7opr17ih X-Rspam-User: X-Rspamd-Queue-Id: 4E090C0006 X-Rspamd-Server: rspam02 X-HE-Tag: 1731456327-406 X-HE-Meta: U2FsdGVkX19bbZwODCLm381pHPA2e1ptE4F9b9kHhRQJ1bjYu9u8STi75SLSldT4Jgfa8F7OIaVDnkLxC6VtcIz9YCOQm6hibgWbZBlgXkGRyepo8IWtnWQuOl6guXic3x+ioeQWL5uvlTchuPWadci7Vl4SrbVerc1IdEswXVbZB6nwgFO83QKM4TvXJsU5T/RwjvengIk+iTycalOEq4xIm6HdfICGGoF2sXxb1EfznWXZZX3oviR/vfpVAqwyYHDE5lTiGj1g8pwNBRIW75MYO2mZObQgPQ5VYGPRsqqgg/psnp2CIXa9mLpkgIbcm6NFbBAaZsmSoq0MZY9Ybh61bXheZkaBD5kw2IdEieVVR6bgrB9mqcUlnxHTEKgRnindCtwBsemBVPYaj1MVYITDQ4JCCA8seFv9mrFLk+/FXvrqWvDQYH4Ma7azYeTFDSCehGn3GI6m/g9xBEQUiGEhf5L1EidtlD3zByd/wJ9DdTJCtD4JpErhKCCuQotIQskYjjtTAHUVkiSPEbKDiU9klKNG7fmc2nHlMjVMSZ/12et00nAuO5hw4gcQEbDtqihkVv6rC/hteTujmMhC1+wLLUQpXnD8JIFHOuP+J+xTIoVlGFNpBNwbnurO2WUbtMe+/9vgEBnbOm0ro1Rrs3SK0kVGT9uLpemmELbGn6l1p0kjeq97DaDEpy8+Bs0mqjhKSwsnpOJqMsHl1Z88kRhI86OSYvzHQQvuTXcgCCcnz8X32gtAjdeSTacUe6WXFgRN45fXlLO6vcs1gF2iDKygD+IKcd3Daf5Y5jvocteN21s3slXbf0Sfx7UnABSVDJqyk/W2H1rPqCVfpoH4rcKMH/mZNeaxrr13pvBUq4JUltcM0m51L0xTks0K3E17msEyXEHJ4hx6dcKHTkLWblf+oRWtb/ynYQNk1R6/v3yNZJVCMTz5yDOkgtmpbPn5qYihB4R0CjwTD1tKQM+ vTwEEADu MBVBLEzMZsEwO3vSgYg+KRLKNVyTfsQkqw5anFNyVFgSXd0kClggxsCx/Msba0qmp39gHKumFqJ8ov7Oeo5hES/aeovG8fPjj9FKkmMNqgdSOa2hQZl1SJaubr8PuPVZodYH6sJy2+kT68i1E09vvBT1JNCTiBBdFrEgEWVJXnLFdnTBH/xAF1jOYCQ4Kkx6wGG0GuUr2LuMxGzAutvRrXvJjO8eqxGDx0SqOGRmJrFXleengmLHHOA1iQOIS9YtVa96SOYB9Bg+5SJxTwaeZF4QWgLFubYzMz8bL29ZZlErqA0dedjgPtGudW/cfKJrcNXWwE27HFnAppm8S9fMgCV1xKKyx09IzvLZJgVzKlosFoazDQqux8XzSQlffdOFux8RmglbjXdeAlL5tck5h9OnKDg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000094, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Nov 13, 2024 at 12:48=E2=80=AFAM Linus Torvalds wrote: > > On Tue, 12 Nov 2024 at 15:06, Amir Goldstein wrote: > > > > I am fine not optimizing out the legacy FS_ACCESS_PERM event > > and just making sure not to add new bad code, if that is what you prefe= r > > and I also am fine with using two FMODE_ flags if that is prefered. > > So iirc we do have a handful of FMODE flags left. Not many, but I do > think a new one would be fine. > Maybe I could use just this one bit, but together with the existing FMODE_NONOTIFY bit, I get 4 modes, which correspond to the highest watching priority: FMODE_NOTIFY_HSM (pre-content and all the rest) FMODE_NOTIFY_PERM (permission and async) FMODE_NOTIFY_NORMAL (only async events) FMODE_NOTIFY_NONE (no events) Thanks, Amir.