From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD060C25B48 for ; Thu, 26 Oct 2023 20:25:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3EDB48D0030; Thu, 26 Oct 2023 16:25:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 39E248D0001; Thu, 26 Oct 2023 16:25:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 265BB8D0030; Thu, 26 Oct 2023 16:25:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 1A3918D0001 for ; Thu, 26 Oct 2023 16:25:34 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id E10A5404BA for ; Thu, 26 Oct 2023 20:25:33 +0000 (UTC) X-FDA: 81388742946.14.FC8B31F Received: from mail-qk1-f180.google.com (mail-qk1-f180.google.com [209.85.222.180]) by imf20.hostedemail.com (Postfix) with ESMTP id 2B0B41C000B for ; Thu, 26 Oct 2023 20:25:31 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=E+vE8W6s; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf20.hostedemail.com: domain of amir73il@gmail.com designates 209.85.222.180 as permitted sender) smtp.mailfrom=amir73il@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698351932; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cwwdVPbm3RceMbBfT8tCSmgbB4MiJAWQJEs/zNkepU0=; b=fwM8+YQNi5KC4W/QPxTh/5nL49MTot8xFPLnCv6VLbWFom9w48zyS4/VDJdn3U6A7oSsjN kBlnZxDdDLk3Wa6LapBw6BbMs/7t0y0effcOquXwg/gcs4M2U6moNfzHdYtuk/wVZ2AhL8 +33xP8xKSDyFhG7Fs8Z7bvz+JgC5NnI= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=E+vE8W6s; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf20.hostedemail.com: domain of amir73il@gmail.com designates 209.85.222.180 as permitted sender) smtp.mailfrom=amir73il@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698351932; a=rsa-sha256; cv=none; b=eliwo+4UJjStpfHR0n49oafD0lMwh3wh0tbCYOnOseRyGjiXrq5bJxvhLFgux5uvdVDqut kk0PSSEgUtqiQGL7kDdxiC71kFzR4GaEO3kF9Rq6FsZOSg5zuPdabX1Mc9RrXZpfTx1xmD Qi48t2xuVohCmySvhjwyoHR7jYfWpgo= Received: by mail-qk1-f180.google.com with SMTP id af79cd13be357-7789cc5c8ccso107926885a.0 for ; Thu, 26 Oct 2023 13:25:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698351931; x=1698956731; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=cwwdVPbm3RceMbBfT8tCSmgbB4MiJAWQJEs/zNkepU0=; b=E+vE8W6sa25F6TV5nq86Fds0NFhCxs7kS5fZ1jNH1URrAAKiDH681ZZChrrwaVdnVV isbzE02+c8ytxAIK7imLLT5KXGpMKMUlHFztf+cOUf2kSALAQCPNBIH0xa5kXW4LaulC GRFVdgORVWLHjxsjyAStx5gajmJyHWpQn5Nq5r0OZw3OeAKzwi3z3J0hywV9D6E+amTy B8Mswr5nwZAAe9H9PwpJcwNXMnFHTeQmapzHOMNhz9bTFFeBdM/VP3+Qg6T9BRHTbDcg 7ygOb0wUd16I/Y+Mh6e3vioV97PDSWQMa2LcCo8TWjD+tr19OFFoYr7hDdREdCtVEIAy +z8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698351931; x=1698956731; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cwwdVPbm3RceMbBfT8tCSmgbB4MiJAWQJEs/zNkepU0=; b=bQ/EFe5xzm3JHyLqsmEleAv0hMgBT+9rF4SY6Y/naR9WE+gDwYBB3AdIHyq8SuvbSq luUHGLnRULELMJ1V05dzkRCRcpd/JlhFC9uQQ9sgyyDZu8yvujPAMW3Zs0iBX9XZ5y6h rM7anAvxwUAUwHwRtIq24BacILXnAtJVUIa+AAqSQw3NPpaSdN9LVpqrMAHQkAzQP/Ak MQ1MCcEsHwwnqRnI2bk2+qibthZQDIq0dKHgs2qYrfaQdnwQHaPkOgBWSVV13yNhIThh YTkdLFKwEGEZSQ9yPLAJ8x/Zj9PRRu/pKRVk0V3Z2dXgr3D7gzlPEB8nSWmlgjWbnaUD cDYg== X-Gm-Message-State: AOJu0YxNDF4XN2Yl8O1kkEjbO2armt9GahE6PJHX7x8mfzJH1yc4Yt3M +1x70IxhrMaGtr1Z4HQl70WkBlYoYwsqpXpL2FU= X-Google-Smtp-Source: AGHT+IElPM/DkXkc5BQ4j29FsFuPgy5EpsioROWoJjy8XLi3Kcrtp2ko7Qppbbu7Jl/NpsTgtM3I18MJCaOeosDzj24= X-Received: by 2002:a05:620a:248b:b0:76e:f686:cad8 with SMTP id i11-20020a05620a248b00b0076ef686cad8mr4627941qkn.13.1698351931090; Thu, 26 Oct 2023 13:25:31 -0700 (PDT) MIME-Version: 1.0 References: <202310262151.renqMvme-lkp@intel.com> In-Reply-To: From: Amir Goldstein Date: Thu, 26 Oct 2023 23:25:19 +0300 Message-ID: Subject: Re: [linux-next:master 14416/15220] fs/exportfs/expfs.c:357:5: error: expected identifier or '(' To: Arnd Bergmann Cc: kernel test robot , llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Christian Brauner , Jan Kara , Jeff Layton , Randy Dunlap Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 2B0B41C000B X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: t44kg1a6tjbc6t7z38k94317iaazxgxn X-HE-Tag: 1698351931-986281 X-HE-Meta: U2FsdGVkX1/aRY3nXLjjPV4ZLF9fCO5tbC+qJW7zzYGBfuvOQohLXkDbED++GA4HwGLfkY6hYTNayjaoHmOaX+UoXS0z/vcm3iKGSbGZGnyZvxl6A8cjnoQDBrNPn/j6fkMFQ6L+y6iej48OdLkwDZ+TsfANjM25WPWhpHBfFkRkvWBooX309sSpcCrahsvR4Tg1s6LEiPhg9Xq6EuqXf49/azOn5W2hHr6cNUfkF59HmGRybWGvGRYBPLpWKtXaNviCWEJ830M8SoHZVJjJhCzGkfIDY46J/cDX/8Z8cyY4eg/PSOsNl2SuzimXdrGUf1Csja5J1E+8TAnk0+t0uCyTF3buZbfxb9dmS4TGsyYgMxRy7lU8G+ZBDJ0cjSqEWjGS9FiDagLwD6I/Q+nLpMrG9vszOmjxLCsoiRWayZQWir+fcryuoe/zjfhNGrMNzxk8yNSS+VyvP5i8XWaZximPO2+zNiRHDECwaEom4jNgDKlsWIKyvP8TG8EX51wgSAKBelZncHsHzXuhEwIPl2FPvOwEqujtx1u6o1h7CoGUXYWYAEQlcFRQnL4SseXHGaiidHYln/h4lCSXrqrWiO1KC3LKKD+wZ83+x2TROyrY3HNCdR/XJDsf1EvCXEhu5iojDhYJLKe3GnFouDpXoL5ixm0HUHW/R71pM6LupIG4AshRnOEjlUB4m0Q4CaafZQB3pt5eV8it1mGTfpMAe30v/8kxly48slvJ9rXuxQl9itLd+KPNQ4fdPOi3XZtZYsQoETOGOaglU4izm92X49EXs4NuJGtIKYxlKkFGCfDNA+TpboDr/JdumzMdHSDuGaoyG/t5Pf6y+WKgyMH38tgfYw2JRFtzJhcQMj64QPKVuA4Bt7lLrmnLIiywCNUK9Y9nOcfDprqCfI80UCTNY+GASeMJg5EmZb/YEZwsd/y35kIdZ8zg3L5TEwIa5N7bDRE0p1Z5TMayvWgoV+Y sUk7ZB2m 8aqk+CMKRCiBDP3GUC96CGiMGoYgXmeA91O8R72vbgkr0Tc+Ow2LPfAaKRkPoHKeN7iIhK1bK+fzCXobABSdDSKAlczCttGaEmYF60n6TPZM03KTdKs899jnSGO3PX1DpyhE8aTEBN+ZnaNSYzFWAQFgX+yLtGomgVnJ7qv4dMWU8T6C0drFN3KcJIurwZDEjq+mStVk8XCskNWsrCZSCykA5QX42N9qI3Lyr8XaGTCt+pLpvSmc/SsD3iq7gFvD4C9+gC4rT0P9F3JBXVEpxET2dhqcgokVppiXquwsq/yrUc/bBHfkRCli73wXFDR/+CYCYHsYYkzdl5bBczkpECTZVleNwi4nmQjTHZsIRhLiwOG5AZWd19qDI/1Rqpya+7ZpVfqxzk4qLptxNPV19gSQZ8/NH0KaJmjTrMbOPx50Qlsme+CowVZyMp/hoI7RBmQcQ740g2osFcpF/nNCrxl/WQhfRHTgZ4xd2X65nTnsGmKwszn0SOHpk1Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Oct 26, 2023 at 6:15=E2=80=AFPM Amir Goldstein = wrote: > > On Thu, Oct 26, 2023 at 5:37=E2=80=AFPM Arnd Bergmann wro= te: > > > > On Thu, Oct 26, 2023, at 15:49, kernel test robot wrote: > > > tree: > > > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > > > master > > > head: 2ef7141596eed0b4b45ef18b3626f428a6b0a822 > > > commit: dfaf653dc41557548b2e75e6cd837071f7c63289 [14416/15220] > > > exportfs: make ->encode_fh() a mandatory method for NFS export > > > config: hexagon-randconfig-r015-20211224 > > > (https://download.01.org/0day-ci/archive/20231026/202310262151.renqMv= me-lkp@intel.com/config) > > > compiler: clang version 16.0.4 > > > (https://github.com/llvm/llvm-project.git > > > ae42196bc493ffe877a7e3dff8be32035dea4d07) > > > reproduce (this is a W=3D1 build): > > > (https://download.01.org/0day-ci/archive/20231026/202310262151.renqMv= me-lkp@intel.com/reproduce) > > > > > > If you fix the issue in a separate patch/commit (i.e. not just a new > > > version of > > > the same patch/commit), kindly add following tags > > > | Reported-by: kernel test robot > > > | Closes: > > > https://lore.kernel.org/oe-kbuild-all/202310262151.renqMvme-lkp@intel= .com/ > > > > > > All errors (new ones prefixed by >>): > > > > > >>> fs/exportfs/expfs.c:357:5: error: expected identifier or '(' > > > int generic_encode_ino32_fh(struct inode *inode, __u32 *fh, int > > > *max_len, > > > ^ > > > include/linux/exportfs.h:286:33: note: expanded from macro > > > > This bit is trivially fixed by allowing the protoype to > > be visible for CONFIG_EXPORTFS=3Dm > > > > --- a/include/linux/exportfs.h > > +++ b/include/linux/exportfs.h > > @@ -314,7 +314,7 @@ extern struct dentry *exportfs_decode_fh(struct vfs= mount *mnt, struct fid *fid, > > /* > > * Generic helpers for filesystems. > > */ > > -#ifdef CONFIG_EXPORTFS > > +#if IS_ENABLED(CONFIG_EXPORTFS) > > int generic_encode_ino32_fh(struct inode *inode, __u32 *fh, int *max_l= en, > > struct inode *parent); > > #else > > > > but then we instead get link failures when the callers are > > built-in: > > > > x86_64-linux-ld: fs/ext4/super.o:(.rodata+0x11a0): undefined reference = to `generic_encode_ino32_fh' > > x86_64-linux-ld: fs/ext2/super.o:(.rodata+0x3a0): undefined reference t= o `generic_encode_ino32_fh' > > x86_64-linux-ld: fs/fat/nfs.o:(.rodata+0x120): undefined reference to `= generic_encode_ino32_fh' > > x86_64-linux-ld: fs/ntfs3/super.o:(.rodata+0x2a0): undefined reference = to `generic_encode_ino32_fh' > > x86_64-linux-ld: fs/befs/linuxvfs.o:(.rodata+0x240): undefined referenc= e to `generic_encode_ino32_fh' > > > > Could this function just be move to fs/libfs.c or similar? > > It could, but it is quite annoying to have to build the function when no = code > should be calling it. > > IMO, it would be better to make CONFIG_EXPORTFS a bool. > fs/exportfs/expfs.c is quite small and CONFIG_EXPORTFS=3Dm > doesn't seem to be worthwhile. Forget it. I missed the fact that the problem is that none of the filesystem properly select EXPORTFS. I will see if I want to fix that or give up and move the helper to fs/libfs= .c. Thanks, Amir.