From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9370CD4F59 for ; Thu, 5 Sep 2024 07:50:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5AE666B041D; Thu, 5 Sep 2024 03:50:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 55D706B0420; Thu, 5 Sep 2024 03:50:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 44C316B0421; Thu, 5 Sep 2024 03:50:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 27D4B6B041D for ; Thu, 5 Sep 2024 03:50:09 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 72783161A3D for ; Thu, 5 Sep 2024 07:50:06 +0000 (UTC) X-FDA: 82529911212.14.FCCC97F Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) by imf13.hostedemail.com (Postfix) with ESMTP id 9D99620005 for ; Thu, 5 Sep 2024 07:50:04 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Ca5VQPmX; spf=pass (imf13.hostedemail.com: domain of amir73il@gmail.com designates 209.85.218.48 as permitted sender) smtp.mailfrom=amir73il@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725522580; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=obKZt04JKsvNVi6u0/skPlG2/rQwZ50vJNCGCR1ZGE8=; b=oBYAY7R/JlIE0Nyn+o8lGAHhxOyyLkQnwtErRxRAt4FVD5N+6sBmDbwHbUMD4TlfyEULM+ p4h8MA+wIz/gsdiMtyTGFWR5tIYWNXx/WmJRIFMbBMH06JuVwhshusLkAFCSKDE4u9md+D M1M/Y0lbudQyAct9EMSjKC3iDZqfyL8= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Ca5VQPmX; spf=pass (imf13.hostedemail.com: domain of amir73il@gmail.com designates 209.85.218.48 as permitted sender) smtp.mailfrom=amir73il@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725522580; a=rsa-sha256; cv=none; b=pq7NM7msx2T+GTkRMiYlQyZBkcup3j8z5GkoYC3IJWWJ6XBIMHxdnA17UbX2leIv/o/mRo 8/unfWCcyO748jUj2T9GZWLtAfWmNICFzq+r1DA2b9LLfR+OyhaefoUJ0LYBpLsW3S3/h2 yPj6XJLV/yrhts45enKUoSlpYX/tgYk= Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-a8a7b1c2f2bso1772266b.0 for ; Thu, 05 Sep 2024 00:50:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725522603; x=1726127403; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=obKZt04JKsvNVi6u0/skPlG2/rQwZ50vJNCGCR1ZGE8=; b=Ca5VQPmXxpiSAd7LFEL0QEzBLD6B+iOlGwfJrZhIExz7xt/i5Q3nlSvC2/6tL5AMii 6hL6pK8y9OBwOfv6gl8KrKh4W4AxqZqK673MVJ5fh6+n/ivLCwYke8UG2O0KC2PUWYVB gXX9SQSSb/rEmM1D6iOKwinf6NnVZ0IkJzZ6P2Z+GK667c/FVcg8BiSVboVBJnx57Ga9 EukI+PqMQQFWnoLkoUXm672Or59TZJ6C6/cvKECg5dpSdtFjTizfbJl+Q9/pavSUxSat RJX1kpBY+TypkA8IdoxzJnZPDrWXmk2ejjGGP2VpJGc0UBF4zdjNhPHOJ63ItCPoTV/T oQKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725522603; x=1726127403; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=obKZt04JKsvNVi6u0/skPlG2/rQwZ50vJNCGCR1ZGE8=; b=vVLzX7RthetbKCDHekk9t0Jg+RYgF4w54VOHS7Rvz/veJvK7sHbUsgjLyK87y+J0/D UppXMw+cMa4dhLd7uuU6DFhfYrNJ6mwvlYDPjC6aMvQdSWWeBnOjRvHR1EsLilXULHeV 5t/NPXi4AxYbnBr+c5JWupIvNQAysnHe9eNk20s+Dsgn3AMUCSJNt3uwsTQ5iwqdGreC O/mVlO7ObUawkifYBm7bI2Wl1S2cDGffCAUZzfUs+7efbe0Z71JXoUxZl/zzl5X6gvPg hK85KTowCpn1bGjcXruAne3RZJ0N7n0png1lr/x7L+F/DilgjTcYLRj0KrPwsSVZFcL6 rEvg== X-Forwarded-Encrypted: i=1; AJvYcCX18JOb0svS+DJvNs1nQgWqv1EoE1X6UKVmutXUIQqLD9yRDlASTESJwqVjkLYJnfuk713Jji+t5Q==@kvack.org X-Gm-Message-State: AOJu0YwUUU1zTxo49KvIdqXmE8E9GSymINOCNq941uCB6DEiKA0BDgjd Wk5WqfILrXFePBufvADqrbMZmzeg/AOHYlqXckW7Trqok11oKHDaPw2J1uJUExdV6Jdt7A06uVp hMS3zAuq+sPGlet4tg4FZx3R9tJS8oQFeOO0= X-Google-Smtp-Source: AGHT+IEHSNTpPFHkq0s7FK0k8QmUuli6ehAfPoksbiKPJcO4py5ijgctkPnEzs8y3xVPK4dpbF+h/76wGWLYfWSrqls= X-Received: by 2002:a17:907:7ea3:b0:a86:82da:2c3c with SMTP id a640c23a62f3a-a8a1d32e2femr750791266b.40.1725522602045; Thu, 05 Sep 2024 00:50:02 -0700 (PDT) MIME-Version: 1.0 References: <6a659625a0d08fae894cc47352453a6be2579788.1725481503.git.josef@toxicpanda.com> In-Reply-To: <6a659625a0d08fae894cc47352453a6be2579788.1725481503.git.josef@toxicpanda.com> From: Amir Goldstein Date: Thu, 5 Sep 2024 09:49:38 +0200 Message-ID: Subject: Re: [PATCH v5 01/18] fanotify: don't skip extra event info if no info_mode is set To: Josef Bacik Cc: kernel-team@fb.com, linux-fsdevel@vger.kernel.org, jack@suse.cz, brauner@kernel.org, linux-xfs@vger.kernel.org, linux-bcachefs@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: gzihfsk5po7zdpbbzemfwpw1mc6w9fqk X-Rspamd-Queue-Id: 9D99620005 X-Rspamd-Server: rspam11 X-HE-Tag: 1725522604-466818 X-HE-Meta: U2FsdGVkX1+rho1ihJi7Oa4a05qBbSuOfuhJqSDIqzGf/mR13MdSBvdPpUV6ooEAx2cvh45Ayj5GhK9y4QNNtCqqU8vGMwfqog0xD+mkJ5/hh/nIc87i0CsXxN/GpxgsAedijlQg0uERMhQbLgC2RzR1uvb47yiiAzZwOH6OslgiTdT92TU96uUQWnZM395eUIyVpG5TLXRkBf7owjwxeG5vku9ce3p7u6n5nsSfUcQkZA8rAXOPWyuHGQFwh+1OOS4P0UsdTR9xhWysJ+fwA0lrkN1FzZoeJNb893/8bha5NEY75WCPH3+IDQExABZ8207sTMcaZektU6akpa6lrmhmY5I+R6Oe0LRUbG/121+5ohgMBV4b5+/yIDSoM/4TjgppNNmaYaa5GJDnqGqwl+QcakOMMzMY6FKNpLn7Kwi3S7d4qc8jKVuDTeOCwgk9yRnMad5KdVqXE8JFgWNSQ0hVXoG544DrYHpczt3CepI+LNq/dR61VWKv2TpOB0sJ+gQ0FS8Q/941pMOyZoO3a5xn9oRRfWtdaTHveWK2JlcjbH1vicVEWAwVKhGUdeebK1fkRC5lyZ8zCK3+k3wxjdSJTxbuSIZ2i5uX6zQ31ycHaODYuudtu+cGBZeITyHC8llysr5KxlnQNlomdUwQxOZMoaSK9crNeuLZfoL+Kfm3F2JCZhLq2W0IPzzuqGyecmd3ZhtRcva3mBbTFDoSlwDmwaQZjqON+dcbcGBYN2wiQZfncAYbOm444fJA6cDtPzrTz5cz0SCGo7JepaMI8KIW8+CLSdSGNwlToSmo9lC+zdzAsiGmLxMTdSEOfxfK2IS6slrIo/AnD7vxhjY+QMleLZJBiRK1ol5WR1kYWzqN90R/MmQgyWy3uFPrAP8D32I67R118fgzx4qTJ+4XwZ4rznQcyE91wJfWUCqWB7jDxuFGo1MHlkCYDmySoBKyUfShq4Wa3ajoQmdTTwJ dmRaDn2H WFcj9mCKges+H9kvHSczxJ7lwnAzX4z76GpC5tD8V1SH1VW/ywZlVW9j70XseW44m5B3E0P15xWOPV1PlQ2tJ7cJQdHT6hq+YFeFHxDtn85bEREWS3XV9Z7s2737Fs34BHzcqYMXMUU9tkAAdbLDeio8hzYLhzFGGMbyWaf5LXAZ3J8fXsQXxwCfw/i+PD24EHLLAiwN7yrO2ZUp5ka8r0YJjRXtfEO3yJsLRStml2fRtqTqzpxiSmjSGv0YhYCUkOfxbrxGyzeQQg/mH0zi4FUxs5hCYAwUJMX0ldGs1m8kyJxqSNYIDmrr/1o/hEIG7fBR9q3n3TD7IMT2iGDaym+RlK/jv20GLIjkWAmLugUCDSuOxiNKtGTiyvyl1jADZU8FNxrrKC6Vj58fqy5FONvafxtBIfr0gSJBkqS2x5eWAGnTMMNhSy3BQt5GJ3vAJXEdV X-Bogosity: Ham, tests=bogofilter, spamicity=0.000104, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Sep 4, 2024 at 10:29=E2=80=AFPM Josef Bacik = wrote: > > New pre-content events will be path events but they will also carry > additional range information. Remove the optimization to skip checking > whether info structures need to be generated for path events. This > results in no change in generated info structures for existing events. > > Signed-off-by: Josef Bacik Reviewed-by: Amir Goldstein > --- > fs/notify/fanotify/fanotify_user.c | 13 ++++--------- > 1 file changed, 4 insertions(+), 9 deletions(-) > > diff --git a/fs/notify/fanotify/fanotify_user.c b/fs/notify/fanotify/fano= tify_user.c > index 9ec313e9f6e1..2e2fba8a9d20 100644 > --- a/fs/notify/fanotify/fanotify_user.c > +++ b/fs/notify/fanotify/fanotify_user.c > @@ -160,9 +160,6 @@ static size_t fanotify_event_len(unsigned int info_mo= de, > int fh_len; > int dot_len =3D 0; > > - if (!info_mode) > - return event_len; > - > if (fanotify_is_error_event(event->mask)) > event_len +=3D FANOTIFY_ERROR_INFO_LEN; > > @@ -740,12 +737,10 @@ static ssize_t copy_event_to_user(struct fsnotify_g= roup *group, > if (fanotify_is_perm_event(event->mask)) > FANOTIFY_PERM(event)->fd =3D fd; > > - if (info_mode) { > - ret =3D copy_info_records_to_user(event, info, info_mode,= pidfd, > - buf, count); > - if (ret < 0) > - goto out_close_fd; > - } > + ret =3D copy_info_records_to_user(event, info, info_mode, pidfd, > + buf, count); > + if (ret < 0) > + goto out_close_fd; > > if (f) > fd_install(fd, f); > -- > 2.43.0 >