From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EFD5E743DB for ; Fri, 29 Sep 2023 03:28:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A36D16B01F8; Thu, 28 Sep 2023 23:28:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9BE736B01FA; Thu, 28 Sep 2023 23:28:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7E8A66B01F9; Thu, 28 Sep 2023 23:28:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 665446B01F7 for ; Thu, 28 Sep 2023 23:28:12 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 3D6011A10A0 for ; Fri, 29 Sep 2023 03:28:12 +0000 (UTC) X-FDA: 81288201624.08.92503B8 Received: from mail-ua1-f47.google.com (mail-ua1-f47.google.com [209.85.222.47]) by imf28.hostedemail.com (Postfix) with ESMTP id 7099AC000E for ; Fri, 29 Sep 2023 03:28:10 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=CKbhYGd6; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf28.hostedemail.com: domain of amir73il@gmail.com designates 209.85.222.47 as permitted sender) smtp.mailfrom=amir73il@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695958090; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IiAb/i1gc98L6SazD4d4ItKm7HOWY4Sc1dUvsARnIt8=; b=uQ9Yd7xcwEjELxR+tD3pmfOiNLK+J9Uc95vsGiQ1scel599ffO31TlpzsNwsTgvRSnkqHg wc49PpMPV446VarsbCRSvgjax3ArBrhveNsIjTJF63SPIX6ePorbLFBGbYdSfKIAOW2jFZ ciEair6dXwGkR8USGtdo4sTkk+ZGXl0= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=CKbhYGd6; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf28.hostedemail.com: domain of amir73il@gmail.com designates 209.85.222.47 as permitted sender) smtp.mailfrom=amir73il@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695958090; a=rsa-sha256; cv=none; b=tzeielTrMJtyHg2HQWltKK6uMFx3TeaApPNlm4feRkQtwzriHz8cXg10A/zbQOJ316RhOq K9fgnwIlcUfNlieiebotfoArRplqNbR5+9qs1bZII4E7vWYBdblP2FPssKYlK9zl5Tswa+ bRxZmdabu6+2lH7pP1/QCF3EdutRIS0= Received: by mail-ua1-f47.google.com with SMTP id a1e0cc1a2514c-79df12ff0f0so5164971241.3 for ; Thu, 28 Sep 2023 20:28:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695958089; x=1696562889; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=IiAb/i1gc98L6SazD4d4ItKm7HOWY4Sc1dUvsARnIt8=; b=CKbhYGd6Of3NHMcmjNBZk9Gyr9817V2yZTSmBdC+JaNTXMhgmOB/yMuczYv1XawCBg 7NKFsG/9YLX5hvRcqZXtCDhiGL2PxNkDdGWWOqJ86Cw2G+PNMnEkpUCgKwXbOHrkcA2A 4aym0VZqJAit+vtw/jgkI9UiHRfdbG3Rp2h0TFDCfnMLLtnXE0qfzalEtpcztEm1LYEY GF9GGHwuWdnH5HhTjBpBLVRGRGbjOySEzoTOfvpeD/9EbxM3U5hkn++wutFp1Dq5ocqm OZUjzkShkq2/Pd4j1A+dOXqtVBWBnxGB68O1W5gWkdOqFOH7QAu70eWZ/bm6u81Ol2Rx 6TYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695958089; x=1696562889; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IiAb/i1gc98L6SazD4d4ItKm7HOWY4Sc1dUvsARnIt8=; b=LLCrpXBBowP4viF8MVJqR/RKIQ9Hfi3jnJobvAMv+NOwDKIIsGEN3Vb+QQx6ivK0mX HSKX8ooq0SoTHC4WzcYeE2h7ty+avQo0PaayoR3GtAwaWTbhbsRcXBlG2z4gseeKq2Zh W6+zUIsipUCc+OVyV8Tp8X80SY0piiricMzV98mgsFxGghVwm7T8ONmaRvhDAj991qk+ khXrZUmlONJyrZG2dJ70LPVhck9A3ZwCTCciphWB/c05TvPz75V5Cn57CChbZ5RvfJiv TBibYvCVKhH9MQ7Nxmeaq7LAaAk7TKniEGdbbLsHcnlMZ7lKR71JOCk/OILEFEvCvD0O ZBNA== X-Gm-Message-State: AOJu0Yx1UOfvEvJBcY6YMlJ2cb9XlvzYRCwjvbylteISDvxMUUKyvs9U 4PeSrMg1jzimLlOOMYNBh9ZWroBxSON3et+qBrM= X-Google-Smtp-Source: AGHT+IFwxD5MHwB8nCElH3p97gGzSZFtR6vWTxEs/mssfRQyF6PkJIQiA0uHM4z+FM+M3FEQI561MxdOs0m92SBkdVk= X-Received: by 2002:a05:6102:d8:b0:452:6da0:678f with SMTP id u24-20020a05610200d800b004526da0678fmr2890488vsp.9.1695958089382; Thu, 28 Sep 2023 20:28:09 -0700 (PDT) MIME-Version: 1.0 References: <20230928110554.34758-1-jlayton@kernel.org> <20230928110554.34758-2-jlayton@kernel.org> <6020d6e7-b187-4abb-bf38-dc09d8bd0f6d@app.fastmail.com> <20230928171943.GK11439@frogsfrogsfrogs> In-Reply-To: <20230928171943.GK11439@frogsfrogsfrogs> From: Amir Goldstein Date: Fri, 29 Sep 2023 06:27:57 +0300 Message-ID: Subject: Re: [PATCH 86/87] fs: switch timespec64 fields in inode to discrete integers To: "Darrick J. Wong" Cc: Jeff Layton , Arnd Bergmann , Alexander Viro , Christian Brauner , Linus Torvalds , David Sterba , "Theodore Ts'o" , "Eric W. Biederman" , Kees Cook , Jeremy Kerr , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Greg Kroah-Hartman , =?UTF-8?B?QXJ2ZSBIasO4bm5ldsOlZw==?= , Todd Kjos , Martijn Coenen , Joel Fernandes , Carlos Llamas , Suren Baghdasaryan , Mattia Dongili , Dennis Dalessandro , Jason Gunthorpe , Leon Romanovsky , Brad Warrum , Ritu Agarwal , Hans de Goede , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Mark Gross , Jiri Slaby , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Sterba , David Howells , Marc Dionne , Ian Kent , Luis de Bethencourt , Salah Triki , "Tigran A. Aivazian" , Chris Mason , Josef Bacik , Xiubo Li , Ilya Dryomov , Jan Harkes , coda@cs.cmu.edu, Joel Becker , Christoph Hellwig , Nicolas Pitre , "Rafael J . Wysocki" , Ard Biesheuvel , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Namjae Jeon , Sungjong Seo , Jan Kara , Andreas Dilger , Jaegeuk Kim , OGAWA Hirofumi , Christoph Hellwig , Miklos Szeredi , Bob Peterson , Andreas Gruenbacher , Richard Weinberger , Anton Ivanov , Johannes Berg , Mikulas Patocka , Mike Kravetz , Muchun Song , Jan Kara , David Woodhouse , Dave Kleikamp , Tejun Heo , Trond Myklebust , Anna Schumaker , Chuck Lever , Neil Brown , Olga Kornievskaia , Dai Ngo , Tom Talpey , Ryusuke Konishi , Anton Altaparmakov , Konstantin Komarov , Mark Fasheh , Joseph Qi , Bob Copeland , Mike Marshall , Martin Brandenburg , Luis Chamberlain , Iurii Zaikin , Tony Luck , "Guilherme G. Piccoli" , Anders Larsen , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Sergey Senozhatsky , Phillip Lougher , Steven Rostedt , Masami Hiramatsu , Evgeniy Dushistov , Chandan Babu R , Damien Le Moal , Naohiro Aota , Johannes Thumshirn , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Hugh Dickins , Andrew Morton , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , John Johansen , Paul Moore , James Morris , "Serge E. Hallyn" , Stephen Smalley , Eric Paris , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-rdma@vger.kernel.org, linux-serial@vger.kernel.org, linux-usb@vger.kernel.org, v9fs@lists.linux.dev, linux-afs@lists.infradead.org, autofs@vger.kernel.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@coda.cs.cmu.edu, linux-efi@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, gfs2@lists.linux.dev, linux-um@lists.infradead.org, linux-mtd@lists.infradead.org, jfs-discussion@lists.sourceforge.net, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-ntfs-dev@lists.sourceforge.net, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, linux-karma-devel@lists.sourceforge.net, devel@lists.orangefs.org, linux-unionfs@vger.kernel.org, linux-hardening@vger.kernel.org, reiserfs-devel@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-trace-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, bpf@vger.kernel.org, Netdev , apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org, selinux@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 7099AC000E X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 9zx4doccspe8ymqiajqy544o9578enxt X-HE-Tag: 1695958090-145776 X-HE-Meta: U2FsdGVkX1+Ybfxm7lehB6kqkCA99pXAOpuLCO2l1HyZ7gqCRi1HS98GvaM1CqcT7ZMwmkKzHoVA+Z0y4RMx9m6G49Fizls0f3/JJIVwZKr4OpvfcE+L2EtyonnJXj8IeFjq7HVbXTC/oldWK6ncTBmWXpVlvcVVz9EQZqa/8aHuyQcv9+zdy1J7D/DAMi47uMOqir3NcGNRKkAM1YZmIMlE5yIiJjJpt+S3HHWFENYSGK6lpiM7ajRdk6oRiWF1sJ+soRl3C7lh6YfBCcGNzlK6vCIkhE+hOKCNl50LF2wzc9Rg+cIGwpzMcgkcfbk86QbcV2xGCGOZKbqOX5s9+t+qt/BYsB/W0GLEf2t4m7K9/QK0f01rU/xJo3JW3ANvgBYDjVgUxC7RMD5lqvE/slmb15WyBsCHUyBAD/KSp54YRLDFbkfSTBssUROog45zPg3J6EaUUGqBLV8bt1iWyuy9rCQoIVjBrMhthTDo5so7D96Phx/8mj2jYNGOcI86vL+vEUh606ZWxIYOiSbLXDLNFLOMSCx2MJjT0tnVBF47bkt2FLldv29NmUJk85Im0hi5wUjcMxxKNa/1jR01J/T0V7fBZB/WIJtABtgn72yfwGhNZvRUQN5V6Pw2ooyZx+jiY7YijGA32gKpvABmpNbYF+5xOo42Hv2nn0E39DRKDC/euMXVPN306AlMaW1p6foIPGslA8bbpgaKTzt649IrF3PlA48XOwGadsIpTVRklLbLt2iOEdfw50wmJyh34L+nsV7EETHZ1voNFyqH/1Iz+VDrOqAyv5kWwSO9nhe9wZfKchV/u172sS4qKQ0CaDIbHSeGJuAai1VtW+ldFEsFK7W3ly1qebmcWHJ96uH8UwmOmx3XYzF07NWqMBVu9tqzo+VUsB1EHoYyoxqFEw1vtG6J8pJTfsr3wrRAvyAlXGWv7ixOr3jnZwiiAasVmfSvO9T7UyiBJjsusae /A2q/ulS FJIjYLJSVkeFCCVtNCwB3StGzm3mRKvjdHF5H7FUTwWrpHL25tsFrADbRHd4XWpFMeNelO7NHUGDh0AAOg6DuRWP5Vtw21VaLAr5vQQAOl2dPfpeD8USXUNkQbHTh8dH5meSUg8ZH8sytgZue4401nqFwuZF1Y8e12Yyfr+kn9jWbEVzATRcw8Uief8MUEu01hjbvVgtH9NPtulnOdgXGbQ4TRmELi9nEqtBgNlPcteBtgtjjRWXYXXvQJ7ON42OCyIWsd49U03x72XrlZnddFKeVGPEr1yy3vg7pHjWIySi0IBFaj3aJeGkqc4AIoJxidy/ivOqhXNvmdwVPwfnJujTH4t1v+1k4PcueTl9oV+RxxxYNk/z9amDhMTzu5HvfsOmyD8JxFjldmkXaPDgVsp/ku2qZ3tHMTGKBHzmowqjwXiqRb9r76CHahUoEmXSYB7+lIJLQNoJWGz/bDrY/3Le7W8cyibEWJmk1ZSiRx+/BwkrXwJ5QgKAoydic6lJ5LOGrCfBH7ljgrIC4NJmRTE1qlazXjzrIIFPtGjz0qCmQ4l9Mn+Zr7Kdjx+xErOcmjIQrdgUsQx1aw4Ggxboi5RmO8eT6ZrfPnV0VIzJqLVDeW+UMne7nxjLEnB01ei/bZxekMTPoh6tNQsnTcgYXevJls9HCZlg56tnv1hSVdL2SrFt3+0NzhFAsjYRmVwOH/rnygBo9JfWoDVSKfxelQ3Q2WUsc5oMpPI2PD0RghKkEbBrXfiV52ZfX+vlUrz+og7Q/KufpdJndoPraKQ8+lZ4Zahz3ZTkWp8kp9aPe1rmzxZoxusIUSXQdauIsn6Kl9P4wj8jq2H30gICuWkOgkti9xGkOrcbO5Tyh0RJvXcn+oT7nEJQAUWoN11zZnBhHNzjWNEgZsHF5khKMlajJafNkWYaRE7qhHNWJHBBoN6XhO9Meouu4KLBcsRPdgQzV74aYxDNc/a0Gq5sw6O/d64Vyr5ld CEtWXMLL sEVjPOFV0eLZPAD4FRygs7RCMy1s//ItSt7N7CsAyCPlN8sl3GgJ4cKa/dZvLH3V6WsdnZVQN9NWuV1SE2DQzFB+r4e/B/FNjNMCbXjpaPDniAhW1TebAB4ntelB7qPJruP3/lIp1GwlwgoGdYz1aCneD2vxa3NjOgKKPRL5KXLzyHbScbs1AOt4hgIjTz10gPOs7nInzVQKugarUpynkENP2fVrT7gqEZpvIQDIoHF1/8JOk78kDeNxbPSBzYqOKvKBGCMKALAg/jEWJnO/VdrLiHAuYqaDegdz+60vJnJ1KCGUP+TCRSuZSLd0QpoBKc8qphWSPmkOT1zFAF/wBIB+tB2GIRnrMDvkYZ+R8cUg73f4PvAfvqV8m3WGhRmS9L+BQYLzKRK5QVmku812IhM3w5yZyn9/11DwuxUj1n+x5wKWNzGjnRWtCozMbf8psfFx8+A4aJUiLVSu6nfJuuydSdEXded1D9WAfDDLkPmEiVGkbk7EE33RIMbpLBr9lc6h7Ap1q4bNPWPcL4knGnFiRMwvuNIFkIcru4IwkQ7FpcQXepwGBZ3qDO19J9ObY9hk+eCYNnOqzusjVwKMWmL2/csrOHmUvUeGKGGnIx3LBFLVxNN1BX3qz31tKABkn/T1HPNJ9qFq5vkUPjUWt8kybDv0Ah8baguiki4Xo9tyY7gS/cCD/l9PJ0HYYqk+E4yIY7DB33YCL7kS15oRDPepoAjsIBqI8MNR2rZW+qUzF2KdybiaLrktj03k0JAV+LhEqnbVAt54aKAj+Yi2EL6BeXIhYAeXLOjqVIauzd7b6/sI/RrSl2DANdbNQsairKe1kRiiTd3kmtFNagRDuNQOtu0J0Ye5AmKAZvSNjrOfv73iyfN2nYSC3ItFqo62b71u/szM6vyrCPKYlKbOHzkVNowTzx3yM7mO2WHmVcymXZsJyxlHAVuPQflKUqRYarXWRG7CB2tPmjlMgXPbM+dK37VaO uyTXDcgI iv/gBLUhPJqcuXQKaa9PAftd/pOx80tONEi6BaYphXXyOcXJ5rfdBj0kyYIN3ymwUs0BfLIpDwL+hhZwBHY4jnhFOZYplFmmHKGZsuBdBNidLf9cuh7aFCCkO3J9XqhDfZBK5jV3/3/eBZCIJqbZ7knPyo23gT70aHqi21yLYCOWmYX7W4Ik3rwgrWXpVWZR1QrB6nbIre8wdfuAansHlMQWlewSIVYwxJWsfZZCTidfwm+GsnNsJyfy8LlvchtP03FWbyJOKpwY4ZSWmHZT8GCAFWkF+IwWkdKT6LyvwSOKZq2TuAEqRuoKxUxH7dgQOFz2IeXCBIDmbT1gzlYfk85Gs8qmxhDk0PPYMOncfwoLLC3uSvgR76wXZFLXVTstt7tpbxXlH92aZGtvrYs3GZK1uiGFMbCcj1KZ57LRWYvuKgwJ03qlkhAqZuA1Xv+wV0HSiyMPfkwixOCxbx6v2n9o+3q+JkhNUYqsfLAA+B4yzUjd2NcOLrtzbdr/UvS8u8jytxp9oLiyYnH3/L9L9YZ9c3fgMHaahIyRMOlVQD52pdupVwnHueOALZeF9QsexpiU0wu1mOF4G3FGlFfMuQDAPo+uAo+NYCUm9eUsKDhMjoozMt4Z48pv+qIXMmKMn3t94ajPHgIJLvtFx/Yk4eV98ju1cyyDVoHcYxF0KVawhCYVz1OGcV8HeuqoyKB8LBfby6kZm4E7N2p7WEEqio2jEgr6YcdJZKlqQaJPxsmhfvrta4gGtcH6UFVR4/lVOe7ed4xci4yY6HB9HZzBnkYF7dWcrk2xSwp256fbP6BFzfKoeDS72CGTM/sZk7i4L/MjZlgIbP+REeCz4FMUwJrOHdcMfsXekhRVV43QsDhULRR7eF17j3JzLId/wp+/0G/H1XkqSMlz+6f2H3XLIyhXRDueMvYUC7QEPxn1WegSbR6iW4LShLOLC6vNQDlfTNJUI9dp74Xs/UbLKy0EDOrQihZfD odpHefrj 27hzBFd7sY9hQAnXUDTZDSG1yfksabhNbN6xCt2aMsI79vvbEL+ffY1IQnHXYtiXNv0yw/6OqlIwYa7zl/Crls7N7lFZLTlDDJL3MyIlkEYKe6CSCtLk1lqD7Hq2jYLOjcgWan/GF6MWp0kuqDAUmoBrZz2g5V+Y4XyHkbzJsmVQleIBx0+edcYIBQAAXLs0jCapRnQaP4BcL1Pctm7oaHrVaHmPak0dTmcmOMiCyW7WZBicGgoBAWnkJwNhmJJNKLkTwoB+l3taS2wm+ecc/0Q6NMHy6W8hTxvaQ+2GbwpR03GxdkrV0ezQvK2GFC/sqgv/B9/h1p26+/gr58O93O60pDnHiECfmecyCEuktN0cAjNGaKul9zIii9BqFeJ3ABBdBvroJ5y7xGaVxjK7y8khz46MHKAQo3mttU0cJLkIZhpOC+q1ETs+VHr0DBevC7874BXaXW5BlEdvSvRTfE50dZVwJYkQbE1D/ePqiAt7pMgTmKb3AeLrgcHrSr8llzHsJyxVWJCQsUgK8z3yUoDOBGD9gB/9s= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 28, 2023 at 8:19=E2=80=AFPM Darrick J. Wong = wrote: > > On Thu, Sep 28, 2023 at 01:06:03PM -0400, Jeff Layton wrote: > > On Thu, 2023-09-28 at 11:48 -0400, Arnd Bergmann wrote: > > > On Thu, Sep 28, 2023, at 07:05, Jeff Layton wrote: > > > > This shaves 8 bytes off struct inode, according to pahole. > > > > > > > > Signed-off-by: Jeff Layton > > > > > > FWIW, this is similar to the approach that Deepa suggested > > > back in 2016: > > > > > > https://lore.kernel.org/lkml/1452144972-15802-3-git-send-email-deepa.= kernel@gmail.com/ > > > > > > It was NaKed at the time because of the added complexity, > > > though it would have been much easier to do it then, > > > as we had to touch all the timespec references anyway. > > > > > > The approach still seems ok to me, but I'm not sure it's worth > > > doing it now if we didn't do it then. > > > > > > > I remember seeing those patches go by. I don't remember that change > > being NaK'ed, but I wasn't paying close attention at the time > > > > Looking at it objectively now, I think it's worth it to recover 8 bytes > > per inode and open a 4 byte hole that Amir can use to grow the > > i_fsnotify_mask. We might even able to shave off another 12 bytes > > eventually if we can move to a single 64-bit word per timestamp. > > I don't think you can, since btrfs timestamps utilize s64 seconds > counting in both directions from the Unix epoch. They also support ns > resolution: > > struct btrfs_timespec { > __le64 sec; > __le32 nsec; > } __attribute__ ((__packed__)); > > --D > Sure we can. That's what btrfs_inode is for. vfs inode also does not store i_otime (birth time) and there is even a precedent of vfs/btrfs variable size mismatch: /* full 64 bit generation number, struct vfs_inode doesn't have a b= ig * enough field for this. */ u64 generation; If we decide that vfs should use "bigtime", btrfs pre-historic timestamps are not a show stopper. Thanks, Amir.