From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2B97D78785 for ; Thu, 21 Nov 2024 16:06:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 54FCA6B0088; Thu, 21 Nov 2024 11:06:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 500096B008A; Thu, 21 Nov 2024 11:06:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3C78A6B008C; Thu, 21 Nov 2024 11:06:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 21ECE6B0088 for ; Thu, 21 Nov 2024 11:06:42 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id AD3B91A1416 for ; Thu, 21 Nov 2024 16:06:41 +0000 (UTC) X-FDA: 82810578984.05.442C71A Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) by imf11.hostedemail.com (Postfix) with ESMTP id 035C340014 for ; Thu, 21 Nov 2024 16:05:33 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=IPRUjhIO; spf=pass (imf11.hostedemail.com: domain of amir73il@gmail.com designates 209.85.218.54 as permitted sender) smtp.mailfrom=amir73il@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732205016; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=C8T8mYqrzwRHWqyx+aUozIQZh0FIc2juAi/4cJz/SjY=; b=nM67dymaoGMPq2V6nEUbjHEfErzkK2aAYWuKJkdq1rQ0DWi4o4bl+nTvHdUpawKqHIgdRO OXaWPVCpzzPrymlEn6lXrMp/19rXctAU9gIJ0c3MO2ITa6XaGU1mLWyVN5g2o/qE2567i7 93bROhj38/VQmPESqlYfGKB1XN3rmqw= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=IPRUjhIO; spf=pass (imf11.hostedemail.com: domain of amir73il@gmail.com designates 209.85.218.54 as permitted sender) smtp.mailfrom=amir73il@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732205016; a=rsa-sha256; cv=none; b=aKI0v86T4MBE6Uwo9nsHo8F5qBQ+2SzAn+DMM85p7ooQYxmBum1aM24Vj5Qgz4YWp7SjQR hFuS9G42btqfu5z8l32Mc693KEbNy2ADFfUTiyJGh3F9ozs/NFxurufMq/CHxnSqHiXgOq AVbDfkpWmDkVjYZCD/Y2XsWs3Fidl7s= Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-a9ed7d8d4e0so162013366b.1 for ; Thu, 21 Nov 2024 08:06:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732205198; x=1732809998; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=C8T8mYqrzwRHWqyx+aUozIQZh0FIc2juAi/4cJz/SjY=; b=IPRUjhIOYBcN0KhMegtI/rxAKp7iQfTfB72vQ9pOdH/bwphkbRV2aMT1/wmB2CwGKp KxdV9bHEJKHxdu+I0YIF4IUpiHn+1N6yDrIxbwXLkueaA32rD6TahCpEfuFPRN5o7ujn a1dPitMksUi7NXcA2jmbS0zMSl7NShha9nmcctdIrpPh0fDSYYoJKCC40JVRnAiDn+4r 1Nlwqtk6aND3a1TsmVM7TLp7s6Va9EGfxwLuGMUInPelFNjJunyGnl67fbNvBA4YhguU YmqC36sgxfQzN946HihHwUFTA+i2QFJlqQxBn1X+Bpfy8ZbHEbvJLR7qP5964peMvv62 xQLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732205198; x=1732809998; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=C8T8mYqrzwRHWqyx+aUozIQZh0FIc2juAi/4cJz/SjY=; b=MykSVYUH8yPT+JXl9+Qpo7GZdpkWZTiP0XMrpQkaQj2yfmD/c7ytClcimZqtL5fqI8 7Pz/PUiQWgBfDAV5Q5Cm+uQkviVrIjiSegxo/F0C2TTnSq2j6AAIAkBUwvPYuVlOB1o9 uKCvxVCVfXid/fSAMS0PMop2umL1Aa2/9zNatBWWOQB+4+uYm6VjTFDyUeQgeIBZcePM 764VTtoVBKeQewQ8D9Cqs22n2fvnxMlAAZHBR3qz+1EwEBNQchtUCiKQLSFlYoRxhEEr xbhgX9wnmw3HaJTXZ432qCUV7OExN7OGeiq35jF0k7z7olxfUzZRFEJSY8y82mKpwKfA G+jA== X-Forwarded-Encrypted: i=1; AJvYcCWAAAEToNZ19s7Y6PqRGgSPkjzw11/K/9o5hv8IcCg1DUV0rKWfXIhoYPyxNgTFkxYee9tlvJHA9A==@kvack.org X-Gm-Message-State: AOJu0YygQ3+Z/D/L8jHdBq8fsuEeHukYXJtZq6HWQIBEIsGJhC7RI+xa E7g77qpnwEtscuOQIE4lgFosT0sBEOU5uvH3W1j71zbIl37RhUU0xiNKBb1EKTa/eXntCAH0vM6 XceBWvvZTlorc0o/a7olAE5grlj96f71nxBM= X-Gm-Gg: ASbGncvnoi9QxJYwjP3EX0TPxq6gttOdReZ8x3JwXsr3uqZCuKyxvJaUWfgqq9SbN8s JfiH2MFP243XeslCcRIA8VbOEOjqfJL4= X-Google-Smtp-Source: AGHT+IGVjwdOPsUK3V0cbw4K6xWRphkCK0DuGSlSpsCdCyu66o84N965jp+z0T5f9wyLT78CKZbCDsxh+FlsY3vu8CM= X-Received: by 2002:a17:907:7ba3:b0:a9e:b471:8308 with SMTP id a640c23a62f3a-aa4dd764962mr570109266b.49.1732205197592; Thu, 21 Nov 2024 08:06:37 -0800 (PST) MIME-Version: 1.0 References: <20241121112218.8249-1-jack@suse.cz> In-Reply-To: <20241121112218.8249-1-jack@suse.cz> From: Amir Goldstein Date: Thu, 21 Nov 2024 17:06:26 +0100 Message-ID: Subject: Re: [PATCH v9 00/19] fanotify: add pre-content hooks To: Jan Kara Cc: linux-fsdevel@vger.kernel.org, Josef Bacik , brauner@kernel.org, Linus Torvalds , Al Viro , linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 035C340014 X-Stat-Signature: 6j8hjdkp1fa54z35k3ziskgw8t46q1ce X-Rspam-User: X-HE-Tag: 1732205133-105031 X-HE-Meta: U2FsdGVkX1+J8MXi+lR+1DBuHXJajTX4M5kuSas+3naQYy1ZfQ3IL+4vAuwhvX1gtikhkCq0RmwN1vPQZFwWa4YfdUCP6sX3Gvkl8i8ZkLcsqOFqpzOegwDGNgvL6lX4BQ0GkSaAeRe43IXaaZBSbVWits63zOwxDh4k1f4kax74NtIVzaoxuAs0+Jo5XJHeq9MV77Oas0EQkTdeQtfmSCgxQGlAqWKud//t0YEGKI4my0XIxfuWcXmNlvY2R35NRAzG11ehKYNtznuWg5fYk7p+ajuFreMmFIYgkagREfejZdDm7X+nkn1So4trRJkuNPc+LhMQIbD5QgpmgdsALiKANWHW4hLwuiaLp84Yj4pRyxJcEKtBSC1mhcVDmHEXIBw3SWnA7VbQlz510DVdPYxPCHv9PHc1Hiwb/RrlFAWw6UtPAZIx/RIg1U+TumGPFXQA8IdU1dsIyg+aIJJmS33E/XEie7PmfSI8Z13t3rWItnDJVLh4/NdvowGbVp6WdK5JoDncuE7G/Gf1c0kBMPLer7ItMOvcRR6LCn/qPuPDM0vGFe6eyEjXLbFKFpfG8ILvIYfJtMMN8DBadi+jwIrRhIfBcxIsSk7/gMyH4abTeXyA21wB4gix9dQml66/D7OiMNBLBNFRWzLU2BdbaxUcaCkmL2M3BLUoAqjHUQiPDh1Eoh8W+2zpr4917KAFFL9ZcmE/LljH5zaae82C5APcF11B42tVgmGjHlhRhD9uhAA9ai0smPIRbTBinQrxF789c814oHZeQAoLF5LGbZwns7Q+t+Sq1/cRsUq49hwF1MA5NNcu33uKZ0NgWnVmPVw1CVB1UWujsS9HgEUWRbq48JiN7OcvIYDIIhi1sd2qlX+z34v4RJrFbN2NaYZi0ig44E6PErmAZNEa1EQoxxkDf6wbANQtvOxr88W8IuZMI2gGcToJBfC6DDaQ4tCGklK31LeEYcKFFH+R2ix rbiNPeqI SZSjBX7v2DQV2xA1Tr3kKWVtThTRqz5brofXp5wYvj07Q74tpEbnwArBRHbNXsStqgGFDiHRgeYEa9R/iYXu1f+wUbb+vZ4UoOpMeouA5XyFJNlJ6eoJyGYm1Rc/NWiOKbov6VaUS4NBZ4m4BTGOohECeNvxMm97iMvE99KEUXCnZ18jdZy13ETH2lGOwpDTofOh79QU7AfBjxIx9MvY27JHc0IlB4F9tgE3aaoyp+I6906U4lvFwFu/kH02URMSO+C/TJC9VYqteXmoPCd8emWYypRhvO0W26HfQzddV384UYhT9BrMqzS2bc89jOH/O6OTsqv77EUsu4Jbd9s8ib6sHBiwzLowpZ9qeam+q/qT5nWLyKxfcdS0ARA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Nov 21, 2024 at 12:22=E2=80=AFPM Jan Kara wrote: > > I'm posting here the series I'm currently carrying in my tree [1]. The ch= anges > from v8 Josef posted are not huge but big enough that I think it's worth = a > repost. Unless somebody speaks up, the plan is to merge into fsnotify bra= nch > after the merge window closes. > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs.git/log= /?h=3Dfsnotify_hsm > > v8: > https://lore.kernel.org/all/cover.1731684329.git.josef@toxicpanda.com > v7: > https://lore.kernel.org/linux-fsdevel/cover.1731433903.git.josef@toxicpan= da.com/ > v6: > https://lore.kernel.org/linux-fsdevel/cover.1731355931.git.josef@toxicpan= da.com/ > v5: > https://lore.kernel.org/linux-fsdevel/cover.1725481503.git.josef@toxicpan= da.com/ > v4: > https://lore.kernel.org/linux-fsdevel/cover.1723670362.git.josef@toxicpan= da.com/ > v3: > https://lore.kernel.org/linux-fsdevel/cover.1723228772.git.josef@toxicpan= da.com/ > v2: > https://lore.kernel.org/linux-fsdevel/cover.1723144881.git.josef@toxicpan= da.com/ > v1: > https://lore.kernel.org/linux-fsdevel/cover.1721931241.git.josef@toxicpan= da.com/ > > v8->v9: > - fix DAX fault handling for ext4 & xfs > - rework FMODE_ constants a bit to keep FMODE_NONOTIFY a single bit > - move file_set_fsnotify_mode() out of line as it's quite big > - fold fsnotify_file_object_watched() into the single caller I tested this with my new test cases on LTP branch fan_hsm. One test broke, I posted a suggested fix for patch 3/19. > - use explicit f_mode checks instead of fsnotify_file_has_pre_content_wat= ches() > - fix compilation breakage with CONFIG_NOMMU > - fixed up some changelogs > Other than patch 3, all looks good to me. Thanks, Amir.