From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B7A0C19F32 for ; Fri, 7 Mar 2025 16:07:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A50C9280003; Fri, 7 Mar 2025 11:07:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9D832280002; Fri, 7 Mar 2025 11:07:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 805A1280003; Fri, 7 Mar 2025 11:07:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 5969E280002 for ; Fri, 7 Mar 2025 11:07:34 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 15D721C9650 for ; Fri, 7 Mar 2025 16:07:37 +0000 (UTC) X-FDA: 83195235354.28.BE8E181 Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) by imf20.hostedemail.com (Postfix) with ESMTP id DC26D1C002A for ; Fri, 7 Mar 2025 16:07:34 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=cBdq+yKE; spf=pass (imf20.hostedemail.com: domain of amir73il@gmail.com designates 209.85.218.47 as permitted sender) smtp.mailfrom=amir73il@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741363655; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gcRVI7e0DsHUk3FJE3VtyyH2vYlzTlEuGkFocdfHzMo=; b=7c3K6WpFa7HtxNX6GKv6UsmC0PXKkhbbZsbeiHss0CsthkJ5Q29OBYiquiorC1HEmA4nf1 xemCGdV9GNn+Ym+ra0Ah6aEhgPJKypYak1Rb6P+sJ/D7FkMMb3nc+K493Pv6tVYnHutPhc IHHkkqnoB9FXuAg+Ejy/5pwEA8WEL2U= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741363655; a=rsa-sha256; cv=none; b=fcpqErFvTpgGYqDSwI5Qy1DCx5LhxV17XXoswUB5QBrevBvSxTdvto2DJWwtJPUmTqONaF pkZT+Ylu3LQ9BF63nB2EpgYHNZ8G+vXfN0lnoZtpn04nB6VaGzlCxuDYAbWaxiAwee8k4p fAoBdIjVJKNVkoSYpXTOpYexosRsMWI= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=cBdq+yKE; spf=pass (imf20.hostedemail.com: domain of amir73il@gmail.com designates 209.85.218.47 as permitted sender) smtp.mailfrom=amir73il@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-ac1f5157c90so325160366b.0 for ; Fri, 07 Mar 2025 08:07:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741363653; x=1741968453; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=gcRVI7e0DsHUk3FJE3VtyyH2vYlzTlEuGkFocdfHzMo=; b=cBdq+yKESuB5TeHJYEt+UKSstOFiwNccWeJV/uXvtJW6EEZHTiAIiLOTWdKWB0AuJZ ES4L5PonDSzQYwoJ5ZPgh3wVHSXBpZ5FhmhZ9cgvLMdHznyrGHr59l1uwpfWpdd49pqP rCAUed6XqZOjgJWZUphLVXP+rB8100nfXb3ibFKkKPlQiFF1b0cidpDNTlq9gY2L4UvH K272R5umXnUIKBYZ6MSkYS7HFILaCoyLEz4/ve8DYMOaZfS9lvNnA8ig8A+LIY/4IBTL RCsQ0dEOmXYYRV4ewygrpntYsXuAO4e4mCDBJcB1WTKwEsN1injyXI/W/cxMUFaZwEgR ypKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741363653; x=1741968453; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gcRVI7e0DsHUk3FJE3VtyyH2vYlzTlEuGkFocdfHzMo=; b=KGoFh7YCD9QClsyNfFBK2fHTLDEy5JWiZ8eZheha1+Y/CxS2UV2ZTrkFEM28GCGBM4 bkleRBGosDRXl6N2t3R1OXf6MUQHXdYIXVnTAu7eGh2BZESCb5YCnTSlk3+JYnggrBS0 +IQUo1vjZfcAYtWhTlsME/BynYI3Ph5ZJbrqk/xztllv9tUr25AxGuilTX0DWnbPqqH6 JEAcO6h1QA5eOaqGBpCKV/KFskmbMHOGM9sc6HERidrZug2i87lYBx5ZWQPT7sypLZC5 mlLoDgMKhF+jTOyJE67c+AkUq60GEU2OTiLNhKG/ckngFKF7p4t3NY6Jw8y1GMlBApww VsRw== X-Forwarded-Encrypted: i=1; AJvYcCV8Kz0IqqOjqXpTl/tbBS1gr9zCX1zIgatsKsB2xRg1CsrgiOu2LkByM8wDJKYtBdJuqQpW+sZ3Dw==@kvack.org X-Gm-Message-State: AOJu0YwPPfCM1xpzO4IIsgvlOrIVoqiSg2w3CWLOUbqtP9we7y7f1Yat 6z49Epjv8Fl55MPF8+MyVk3Tck5qGEuKlnrxfSm0RWHiX82aaoYTLf2JiNAPqRKmQY1ujZIXLvs 3L8Soz5fVqXih8N09/UQG9nIzavU= X-Gm-Gg: ASbGncu02y2aE9DD9Dj7vPXwbarbPhU1TE0TvM1dCJySl7X5nkeEIPJFstRHKzQO+GH jLsfq5HEm/NYxZXQptUjVmNCijyU4o0DaNIQwdGxnOURa/7eGRp4QyCJDTNZ8WEKjKIiO18gqQR vSTFY/0/4X5cit73kkoJ5eVM5e0A== X-Google-Smtp-Source: AGHT+IFLLSgCLyKxpAZ92GZrXIahBQ6WnG4lhUhGiSoYcrtahVPiew7GJDIcZlQMi+s7UwVQ1oICaMl0Yx1DU3NGJts= X-Received: by 2002:a17:907:94d0:b0:ac2:1936:6f37 with SMTP id a640c23a62f3a-ac252b5742cmr463139466b.28.1741363652274; Fri, 07 Mar 2025 08:07:32 -0800 (PST) MIME-Version: 1.0 References: <67a487f7.050a0220.19061f.05fc.GAE@google.com> <67c4881e.050a0220.1dee4d.0054.GAE@google.com> <7ehxrhbvehlrjwvrduoxsao5k3x4aw275patsb3krkwuq573yv@o2hskrfawbnc> <20250304161509.GA4047943@perftesting> <20250304203657.GA4063187@perftesting> <20250307154614.GA59451@perftesting> In-Reply-To: <20250307154614.GA59451@perftesting> From: Amir Goldstein Date: Fri, 7 Mar 2025 17:07:20 +0100 X-Gm-Features: AQ5f1JosS0A-XlrWSJp17CPWYsuMc5A0FIXwxDRPC1YHVvfkUSdokDLUzW_h2FM Message-ID: Subject: Re: [syzbot] [xfs?] WARNING in fsnotify_file_area_perm To: Josef Bacik Cc: Jan Kara , syzbot , akpm@linux-foundation.org, axboe@kernel.dk, brauner@kernel.org, cem@kernel.org, chandan.babu@oracle.com, djwong@kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-xfs@vger.kernel.org, syzkaller-bugs@googlegroups.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam02 X-Stat-Signature: y8jmtrs4fmknp5heonn5gfm1r6xgukoj X-Rspamd-Queue-Id: DC26D1C002A X-Rspam-User: X-HE-Tag: 1741363654-551954 X-HE-Meta: U2FsdGVkX1/pPa9htKf2nbvxsOQlTKkjuSSxCFXjdUwPso4tOAuC2Pm1HLloq5Eqhr4+MesNmwpz536zqgKIH+FyhMQSSnUTSPGVhwIa9btqQru5b0ml1WXCE/HFB9OxzRg1lQOH1IEtIVqRJQOvdPJ73I+Ds7gXuBEGgQ7IyMzBljHtTJnpRR/hb+8R2heQXlJrKZao4l7uxDgz3VHu1RY9aZ6HIVe1nFPEyFoOjdHF5wMiT5fHS5rTVIVYGkhY8YxyWZkN8eSbp1lxtpe0U2wOLlQ5pb/3jTlZ1tfKjb3EBD7w56wOe4PBzgEeLbVRaQkMbWj7xhkGZNNVGlp4m7DSyTnSpkOjtS52VNywdq/VXrWq3ZbH29miBK8FoHziP6jnBHjoxDBJFKTnQxklje52njYmOwoun9XgvqILevNqwt5YqKOBS2FNZKQoWqL6XtUViKGbqJ4Y4sgJv4Cy/9TffPtP4LRPmVXh/FJCLLS9tBwgDwHpB/FjRda9SVaUL5TRSmS66AYXTFtvVsb3AZuoRZmpFo62NOzJdebRV58JPpw/8a9WQPe/5mZD2JTIKk5VKz1fEBiyWCOiniHosVYTt4EmembdgmLR5LkCyCPQTQuzsQzX6QA+9nN0zaDfDeUh+/MZ5L6o6OvNFdxCP6SGfrPmQYNOyDBNzfraQK1FbVIXE+3hX8i3v72AJGxt4ZzkmmGsIDK9Ry5l6TYP2mpVMeOJT7mWqx/1sAnF61N4qVGHwDmAP78Qf65twGrrSZIWDaszBV7PP3/bhCsYpScqrhnYdRVXGRfsgCd0WZMR/uTAeR8amOcZIforzVK330OsNYOJnhbYLk/G9jEYn6s1jz7BfibBuZwtl37wPwsKj/gwJN7P1R/epuhozuRQ2J5A78Aw1NvP2ZHnOU5eUOnNJlKeV0yuSH/KYAKGW0kQJQF9qQeLNWqi6c/4zboP3EKqh/3sJH1ggAGHBIB atBIIogx JElmixAYWF0BZRQgbA/QXo5CUWS/wR03EKnQbh62pU9MKlwhwODQM4EH6cOvA5MVwf4B7VjJFhr9kdupUFaRXTA9SnLLBxASp2yS5Hs0q9pcTTtE+3/Nfst4lCkxpZFNVbuJHUBVND7ZMg4jLxQEY1xEb6VWJ5b0WhQ8ipGQKW2lwAPftEXGInPzos3PpZwcIXyFR7h6+SPLltKmO7ImcN1MudR/aK/i60o4xgyf/V1D0JML6Zduvqb5dya/MioBbIRm7BmToIB4DdvArPJxxOdMZaVotiXBIQAeMS2VFNKzMAyRppUzY2ZSUMJXnv4cR4zTCiNVeILo078LDlIQpJqPmVAb/obGRk6I7AtDkhsCLYf6DT5bcqnpwN/8QsTkx+A4Ba0MBMC6J2ESlP4DTl0i6y43rEHuCAtCfxNAlVbcspJUEsFBK0wyLIOSbHO9hWuCm0EUsz251r5xwH7AWQbZle1vk3Aa/UWt42ktf3SbRHIib5jNo85oqBQUirMReNGenoIzQM6ghkpuUGZpOuv4oZYTUjErlVdUSESLHV83Vz4Q1Ehte0RfZWtP52V1SpCCdWRJi6WuyYE2eooF2btHHZw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Mar 7, 2025 at 4:46=E2=80=AFPM Josef Bacik w= rote: > > On Tue, Mar 04, 2025 at 10:13:39PM +0100, Amir Goldstein wrote: > > On Tue, Mar 4, 2025 at 9:37=E2=80=AFPM Josef Bacik wrote: > > > > > > On Tue, Mar 04, 2025 at 09:27:20PM +0100, Amir Goldstein wrote: > > > > On Tue, Mar 4, 2025 at 5:15=E2=80=AFPM Josef Bacik wrote: > > > > > > > > > > On Tue, Mar 04, 2025 at 04:09:16PM +0100, Amir Goldstein wrote: > > > > > > On Tue, Mar 4, 2025 at 12:06=E2=80=AFPM Jan Kara = wrote: > > > > > > > > > > > > > > Josef, Amir, > > > > > > > > > > > > > > this is indeed an interesting case: > > > > > > > > > > > > > > On Sun 02-03-25 08:32:30, syzbot wrote: > > > > > > > > syzbot has found a reproducer for the following issue on: > > > > > > > ... > > > > > > > > ------------[ cut here ]------------ > > > > > > > > WARNING: CPU: 1 PID: 6440 at ./include/linux/fsnotify.h:145= fsnotify_file_area_perm+0x20c/0x25c include/linux/fsnotify.h:145 > > > > > > > > Modules linked in: > > > > > > > > CPU: 1 UID: 0 PID: 6440 Comm: syz-executor370 Not tainted 6= .14.0-rc4-syzkaller-ge056da87c780 #0 > > > > > > > > Hardware name: Google Google Compute Engine/Google Compute = Engine, BIOS Google 12/27/2024 > > > > > > > > pstate: 80400005 (Nzcv daif +PAN -UAO -TCO -DIT -SSBS BTYPE= =3D--) > > > > > > > > pc : fsnotify_file_area_perm+0x20c/0x25c include/linux/fsno= tify.h:145 > > > > > > > > lr : fsnotify_file_area_perm+0x20c/0x25c include/linux/fsno= tify.h:145 > > > > > > > > sp : ffff8000a42569d0 > > > > > > > > x29: ffff8000a42569d0 x28: ffff0000dcec1b48 x27: ffff0000d6= 8a1708 > > > > > > > > x26: ffff0000d68a16c0 x25: dfff800000000000 x24: 0000000000= 008000 > > > > > > > > x23: 0000000000000001 x22: ffff8000a4256b00 x21: 0000000000= 001000 > > > > > > > > x20: 0000000000000010 x19: ffff0000d68a16c0 x18: ffff8000a4= 2566e0 > > > > > > > > x17: 000000000000e388 x16: ffff800080466c24 x15: 0000000000= 000001 > > > > > > > > x14: 1fffe0001b31513c x13: 0000000000000000 x12: 0000000000= 000000 > > > > > > > > x11: 0000000000000001 x10: 0000000000ff0100 x9 : 0000000000= 000000 > > > > > > > > x8 : ffff0000c6d98000 x7 : 0000000000000000 x6 : 0000000000= 000000 > > > > > > > > x5 : 0000000000000020 x4 : 0000000000000000 x3 : 0000000000= 001000 > > > > > > > > x2 : ffff8000a4256b00 x1 : 0000000000000001 x0 : 0000000000= 000000 > > > > > > > > Call trace: > > > > > > > > fsnotify_file_area_perm+0x20c/0x25c include/linux/fsnotify= .h:145 (P) > > > > > > > > filemap_fault+0x12b0/0x1518 mm/filemap.c:3509 > > > > > > > > xfs_filemap_fault+0xc4/0x194 fs/xfs/xfs_file.c:1543 > > > > > > > > __do_fault+0xf8/0x498 mm/memory.c:4988 > > > > > > > > do_read_fault mm/memory.c:5403 [inline] > > > > > > > > do_fault mm/memory.c:5537 [inline] > > > > > > > > do_pte_missing mm/memory.c:4058 [inline] > > > > > > > > handle_pte_fault+0x3504/0x57b0 mm/memory.c:5900 > > > > > > > > __handle_mm_fault mm/memory.c:6043 [inline] > > > > > > > > handle_mm_fault+0xfa8/0x188c mm/memory.c:6212 > > > > > > > > do_page_fault+0x570/0x10a8 arch/arm64/mm/fault.c:690 > > > > > > > > do_translation_fault+0xc4/0x114 arch/arm64/mm/fault.c:783 > > > > > > > > do_mem_abort+0x74/0x200 arch/arm64/mm/fault.c:919 > > > > > > > > el1_abort+0x3c/0x5c arch/arm64/kernel/entry-common.c:432 > > > > > > > > el1h_64_sync_handler+0x60/0xcc arch/arm64/kernel/entry-com= mon.c:510 > > > > > > > > el1h_64_sync+0x6c/0x70 arch/arm64/kernel/entry.S:595 > > > > > > > > __uaccess_mask_ptr arch/arm64/include/asm/uaccess.h:169 [i= nline] (P) > > > > > > > > fault_in_readable+0x168/0x310 mm/gup.c:2234 (P) > > > > > > > > fault_in_iov_iter_readable+0x1dc/0x22c lib/iov_iter.c:94 > > > > > > > > iomap_write_iter fs/iomap/buffered-io.c:950 [inline] > > > > > > > > iomap_file_buffered_write+0x490/0xd54 fs/iomap/buffered-io= .c:1039 > > > > > > > > xfs_file_buffered_write+0x2dc/0xac8 fs/xfs/xfs_file.c:792 > > > > > > > > xfs_file_write_iter+0x2c4/0x6ac fs/xfs/xfs_file.c:881 > > > > > > > > new_sync_write fs/read_write.c:586 [inline] > > > > > > > > vfs_write+0x704/0xa9c fs/read_write.c:679 > > > > > > > > > > > > > > The backtrace actually explains it all. We had a buffered wri= te whose > > > > > > > buffer was mmapped file on a filesystem with an HSM mark. Now= the prefaulting > > > > > > > of the buffer happens already (quite deep) under the filesyst= em freeze > > > > > > > protection (obtained in vfs_write()) which breaks assumptions= of HSM code > > > > > > > and introduces potential deadlock of HSM handler in userspace= with filesystem > > > > > > > freezing. So we need to think how to deal with this case... > > > > > > > > > > > > Ouch. It's like the splice mess all over again. > > > > > > Except we do not really care to make this use case work with HS= M > > > > > > in the sense that we do not care to have to fill in the mmaped = file content > > > > > > in this corner case - we just need to let HSM fail the access i= f content is > > > > > > not available. > > > > > > > > > > > > If you remember, in one of my very early version of pre-content= events, > > > > > > the pre-content event (or maybe it was FAN_ACCESS_PERM itself) > > > > > > carried a flag (I think it was called FAN_PRE_VFS) to communica= te to > > > > > > HSM service if it was safe to write to fs in the context of eve= nt handling. > > > > > > > > > > > > At the moment, I cannot think of any elegant way out of this us= e case > > > > > > except annotating the event from fault_in_readable() as "unsafe= -for-write". > > > > > > This will relax the debugging code assertion and notify the HSM= service > > > > > > (via an event flag) that it can ALLOW/DENY, but it cannot fill = the file. > > > > > > Maybe we can reuse the FAN_ACCESS_PERM event to communicate > > > > > > this case to HSM service. > > > > > > > > > > > > WDYT? > > > > > > > > > > I think that mmap was a mistake. > > > > > > > > What do you mean? > > > > Isn't the fault hook required for your large executables use case? > > > > > > I mean the mmap syscall was a mistake ;). > > > > > > > ah :) > > > > > > > > > > > > > > > > Is there a way to tell if we're currently in a path that is under= fsfreeze > > > > > protection? > > > > > > > > Not at the moment. > > > > At the moment, file_write_not_started() is not a reliable check > > > > (has false positives) without CONFIG_LOCKDEP. > > > > > > > > One very ugly solution is to require CONFIG_LOCKDEP for > > pre-content events. > > > > > > > Just denying this case would be a simpler short term solution whi= le > > > > > we come up with a long term solution. I think your solution is fi= ne, but I'd be > > > > > just as happy with a simpler "this isn't allowed" solution. Thank= s, > > > > > > > > Yeh, I don't mind that, but it's a bit of an overkill considering t= hat > > > > file with no content may in fact be rare. > > > > > > Agreed, I'm fine with your solution. > > > > Well, my "solution" was quite hand-wavy - it did not really say how to > > propagate the fact that faults initiated from fault_in_readable(). > > Do you guys have any ideas for a simple solution? > > Sorry I've been elbow deep in helping getting our machine replacements wo= rking > faster. > > I've been thnking about this, it's not like we can carry context from the= reason > we are faulting in, at least not simply, so I think the best thing to do = is > either > > 1) Emit a precontent event at mmap() time for the whole file, since reall= y all I > care about is faulting at exec time, and then we can just skip the precon= tent > event if we're not exec. Sorry, not that familiar with exec code. Do you mean to issue pre-content for page fault only if memory is mapped executable or is there another way of knowing that we are in exec context? If the former, then syzbot will catch up with us and write a buffer which i= s mapped readable and exec. > > 2) Revert the page fault stuff, put back your thing to fault the whole fi= le, and > wait until we think of a better way to deal with this. > > Obviously I'd prefer not #2, but I'd really, really rather not chuck all = of HSM > because my page fault thing is silly. I'll carry what I need internally = while > we figure out what to do upstream. #1 doesn't seem bad, but I haven't th= ought > about it that hard. Thanks, > So I started to test this patch, but I may be doing something very terribly wrong with this. Q: What is this something that is terribly wrong? So far it did not explode, so let's at least see if that fixed the reported issue: #syz test: https://github.com/amir73il/linux fsnotify-fixes Thanks, Amir. diff --git a/include/linux/fs.h b/include/linux/fs.h index 2788df98080f8..a8822b44d4967 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -3033,13 +3033,27 @@ static inline void file_start_write(struct file *fi= le) if (!S_ISREG(file_inode(file)->i_mode)) return; sb_start_write(file_inode(file)->i_sb); + /* + * Prevent fault-in user pages that may call HSM hooks with + * sb_writers held. + */ + if (unlikely(FMODE_FSNOTIFY_HSM(file->f_mode))) + pagefault_disable(); } static inline bool file_start_write_trylock(struct file *file) { if (!S_ISREG(file_inode(file)->i_mode)) return true; - return sb_start_write_trylock(file_inode(file)->i_sb); + if (!sb_start_write_trylock(file_inode(file)->i_sb)) + return false; + /* + * Prevent fault-in user pages that may call HSM hooks with + * sb_writers held. + */ + if (unlikely(FMODE_FSNOTIFY_HSM(file->f_mode))) + pagefault_disable(); + return true; } /** @@ -3053,6 +3067,8 @@ static inline void file_end_write(struct file *file) if (!S_ISREG(file_inode(file)->i_mode)) return; sb_end_write(file_inode(file)->i_sb); + if (unlikely(FMODE_FSNOTIFY_HSM(file->f_mode))) + pagefault_enable(); }