From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D4CDD6ED0F for ; Thu, 21 Nov 2024 11:39:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CBF5C6B00A8; Thu, 21 Nov 2024 06:39:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C6F0E6B00A9; Thu, 21 Nov 2024 06:39:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B377B6B00AA; Thu, 21 Nov 2024 06:39:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 95DED6B00A8 for ; Thu, 21 Nov 2024 06:39:22 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 505F91C7E27 for ; Thu, 21 Nov 2024 11:39:22 +0000 (UTC) X-FDA: 82809904884.10.7F2D88A Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) by imf15.hostedemail.com (Postfix) with ESMTP id 90E74A0005 for ; Thu, 21 Nov 2024 11:38:26 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="iwMQoX/O"; spf=pass (imf15.hostedemail.com: domain of amir73il@gmail.com designates 209.85.218.51 as permitted sender) smtp.mailfrom=amir73il@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732188956; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=flmqqIvHrYVf7qQ/T7+htw1AlPLKr76abtaAFtyx13k=; b=SVRoINd4Dt0djf4bAQmp8Mw0rOMVIUmh2StMmb5J4pFHPT+FaRUhPnO8OUsyRhbBgvtg0O bNl79jgKutxh5vx9FWiCMj9q5BrqGVXWY5QoNfCqY4aq8k8WENMAEk5GYQYMLr6ojUnGiN jZjaM+jvIBtKEc0lpsAPaN55a6Wp6gM= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="iwMQoX/O"; spf=pass (imf15.hostedemail.com: domain of amir73il@gmail.com designates 209.85.218.51 as permitted sender) smtp.mailfrom=amir73il@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732188956; a=rsa-sha256; cv=none; b=36ZRiK31SjCkTMtsFVm4EXeqJvLeSB+xMR5/2GjptUgQHHk5mF7g+kLS47Wnl62cT8wRdN FB/ekg8CmiS1+jk5W+A9dEzRHa3Rz3IQXxE9nJNig22d1oWQwomXAB5FlGRAA0siM5cOv8 lmsP3By7SAbOTuM9YaG6CcyKVpB8vz8= Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-aa1e51ce601so164509566b.3 for ; Thu, 21 Nov 2024 03:39:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732189159; x=1732793959; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=flmqqIvHrYVf7qQ/T7+htw1AlPLKr76abtaAFtyx13k=; b=iwMQoX/O0rZLPWJtJ2DAHceb3pE4gHphwk0SKS8h2LXT6/eGGbE42vNwebhqxN05Mv pZrIIrpigutdvr9tLWIaSK1tN+8gLgBJdWYyZoboGMNX6eyI0en/vVVSW20B1tBexweq /0ovR3UX115aG0Xj/1FmON4+IaO7/u9XSWRCeDi8jF7TB4VDphBK8NPrKaBxCGAUpZKA +dacQuGCEexee6DX3/xaINVWS6MDaHVrz9vQSDPjEGA37UMn6N12rvHy3fWBsXfoUYyu 5PxwCXi3TYXDp74INFnOP04yIy2c3f89I2XfoQMjJOmsKM2aJy/rvFrwopGpczIi7st6 TUQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732189159; x=1732793959; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=flmqqIvHrYVf7qQ/T7+htw1AlPLKr76abtaAFtyx13k=; b=v/4k+H3g75IvAUB9PGgty1eCtkhOYnIsdttdCqA0n4qoqXqZTZet0IYNIa3QwIojVo LuuiSkJNXYsS91hO2vtw/6AjfpNfYCxPkSVmdiTHskyeCwzJfsxxM31gpZ4C82+Ie+qr VC0kAKdUQz/Cz8GrMhnG/1mSPML8CozCPAHajoOCnUIYosgRxQ0yJexIj64dcUp+vi6S o5Fj/TK82PLyzBi6+rqr7GOPO1KLTQch5us0atF6bzK4GfIU9JdV/UCIU6pxAu7GCy6g +1jzU77wG9Szfpq/eVuOsN9bW8dgCJUmnB0JHF/MMBpqHl68oyfTQCiPxbDX9kmtNTQC aU2g== X-Forwarded-Encrypted: i=1; AJvYcCW3vnrhfA0d2ll7oUKc+ItV6JWmY3oeTlcQToBR4pJsm9dEWIY4W3GhfX1o4gtuDxXsKeXfRL05lQ==@kvack.org X-Gm-Message-State: AOJu0YxTTuWasctDrSkiDti6QZWvkjLM5wb9ukMktOesokde90LMCeI5 UX+u6NSO2XTH3zdiZ6pWcUydTmNyrmYlJU47UtxrovSNXLpWeHpCbk1D5BH952cszVJy2sCragF irS9PAcSEXX3xe20D+dwCET49ARY= X-Gm-Gg: ASbGncu7nyTskLv2C37DloO8dNicH/uN646xbFKOLE9bo95iQNT922E7Rv+W0Qjdu5C iPws/jyL/F/KxUVPMmSTCh5CcxMENkWA= X-Google-Smtp-Source: AGHT+IFxJ5PMK5EI0p5RcxskpZT0i1r125FE0cgnA0p0b/AF7qbdGGhs4weZZIOjMWdg/3y0jLQKqWHCYKcLqfZpGX4= X-Received: by 2002:a17:906:eec8:b0:a99:77f0:51f7 with SMTP id a640c23a62f3a-aa4dd799d4bmr586113866b.61.1732189158565; Thu, 21 Nov 2024 03:39:18 -0800 (PST) MIME-Version: 1.0 References: <5ea5f8e283d1edb55aa79c35187bfe344056af14.1731684329.git.josef@toxicpanda.com> <20241120155309.lecjqqhohgcgyrkf@quack3> <20241121-boxring-abhandeln-c2095863da2d@brauner> In-Reply-To: <20241121-boxring-abhandeln-c2095863da2d@brauner> From: Amir Goldstein Date: Thu, 21 Nov 2024 12:39:07 +0100 Message-ID: Subject: Re: [PATCH v8 02/19] fsnotify: opt-in for permission events at file open time To: Christian Brauner Cc: Jan Kara , Josef Bacik , kernel-team@fb.com, linux-fsdevel@vger.kernel.org, torvalds@linux-foundation.org, viro@zeniv.linux.org.uk, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-mm@kvack.org, linux-ext4@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 90E74A0005 X-Stat-Signature: unxi5rcrxg65cpbhipnenpdt386ar634 X-Rspam-User: X-HE-Tag: 1732189106-91442 X-HE-Meta: U2FsdGVkX1/n06gWSkb/GxWi9cFoOExbny+vP1nd6K9fRZJfqVmOHaY+D0PLTgw2Yiu9QW/Y0EGdY4FVFDhDt34+53IsAHEIOGmjL7WUCEFpRqKmZHaGCiEJy2L0zHrxTWdn/jOiqudM7qbNNQSCdK0Q8IplfNyzsTPxwy/vBQh2iQ5rFjUgMyTfSpmm/sD+0h+628FOOZWCYV6Hpzw1FK0yMHAOrYFuJc00KiNTretI/J6PMWoy1M6rRDX4qNDxgAcrTN1alcgmOv+m/qhl775RAg6/FKv1AuG5RaJmljT9imhuUgqDJ1CKtccqn9Rwx+x5LEgtL1+DwGkGkb112HuUphOk/aHhd/dRsYrs6CfXMjLdQ7FgsINDyqqr7goAfGs58moTKUHlYnfLZTiO0D7k0cGlajzzga386QKLs1TLJS8IN4Rdf5N8vbsitkDWzsuvIo3PvKTzKCX6Y0Kj7ibIvRrQ7WpeLNtxt4C4COY7BfFyikbIIWtoH869d1ExPZtPTVsOS5pQR9kISKbH+L1d7sqkh4LfcLxUeaiCm+rWKWCgfFLJT9ZVQUAUORlkruJfE1cZlEf6eG63Z41oRQ01GQG0a/V8LvmuA4TKPsmhU4JU246hjCgVLArTOJoX5rbKsFlSc+HzKznbwI9ASfwQ0JRt7iHWrdQZPvzb66hgCppCbEpSFMFAny4CfCrGZ36IcwmDvvMVpKmxHkW4PXrcr/RX09bbtRXFVq3oki1GTBGCSJ31kLg7GV87f6X2v/mYaxmf4O1cJSf8PA3XEO/1w/BhcWwgkJa9Ri2ozqA1to6gE/ZfgQTEwAtCH0qIkCWSgggzYqh1mpoTchQQfE9qn8of80+XPaiB1RxG8XbKjbG3u3S3W/007LIYVwcdtROrvnhO/fnnWlxUJ7iR/UBuBUsoF+++RlGIRQ33+on3Wp9q24hb3SFLq7yJJtxhni7WpgTv/nZQV4U13xp AnM6S9hr T/08cwfbn4jCUeUoOp63vgOFTnOOPNQ6itypQ9FC9XEF4FekVOzFAzdnf5QmEvNgoOqQbGN/RBv0R4ky6KGNAmBG+KVsqAz6QLmEjTWpTKb+0gjPzkrDbR5oRzf2BnKW88A0BkhTYcsTP+D6dVoSnn2LHOPMZoVi0Dgu6/Tl5SwBqyT9HjE9kUw7/NOGF4PaHAElVL+eSpzP0+iwRdawYkWx2mcN8gWzkvS4cJeVSgeC19rsKZ6yQiWqaDxwPC7ef/br8jD1YsOnsOAS7GtshzUcCC3EovAD8yOrcm6zw44mAG4MbwYfZZfrwDQuyk1TrlHpN X-Bogosity: Ham, tests=bogofilter, spamicity=0.003739, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > This is fine by me. But I want to preemptively caution to please not > spread the disease of further defines based on such multi-bit defines > like fanotify does. I'm specifically worried about stuff like: > > #define ALL_FSNOTIFY_PERM_EVENTS (FS_OPEN_PERM | FS_ACCESS_PERM | \ > FS_OPEN_EXEC_PERM) > > #define FS_EVENTS_POSS_ON_CHILD (ALL_FSNOTIFY_PERM_EVENTS | \ > FS_ACCESS | FS_MODIFY | FS_ATTRIB | \ > FS_CLOSE_WRITE | FS_CLOSE_NOWRITE | \ > FS_OPEN | FS_OPEN_EXEC) What do you mean? Those are masks for event groups, which we test in many cases. What is wrong with those defined? For FMODE_, we do not plan to add anymore defined (famous last words). Thanks, Amir.