From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw1-f70.google.com (mail-yw1-f70.google.com [209.85.161.70]) by kanga.kvack.org (Postfix) with ESMTP id 8A7506B0003 for ; Thu, 11 Oct 2018 10:13:57 -0400 (EDT) Received: by mail-yw1-f70.google.com with SMTP id n143-v6so5114088ywd.6 for ; Thu, 11 Oct 2018 07:13:57 -0700 (PDT) Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id 136-v6sor3984232yws.137.2018.10.11.07.13.56 for (Google Transport Security); Thu, 11 Oct 2018 07:13:56 -0700 (PDT) MIME-Version: 1.0 References: <153923113649.5546.9840926895953408273.stgit@magnolia> <153923115968.5546.9927577186377570573.stgit@magnolia> <20181011134256.GC23424@infradead.org> In-Reply-To: <20181011134256.GC23424@infradead.org> From: Amir Goldstein Date: Thu, 11 Oct 2018 17:13:44 +0300 Message-ID: Subject: Re: [PATCH 03/25] vfs: check file ranges before cloning files Content-Type: text/plain; charset="UTF-8" Sender: owner-linux-mm@kvack.org List-ID: To: Christoph Hellwig Cc: "Darrick J. Wong" , Dave Chinner , Eric Sandeen , Linux NFS Mailing List , linux-cifs@vger.kernel.org, overlayfs , linux-xfs , Linux MM , Linux Btrfs , linux-fsdevel , Christoph Hellwig , ocfs2-devel@oss.oracle.com On Thu, Oct 11, 2018 at 4:43 PM Christoph Hellwig wrote: > > > -EXPORT_SYMBOL(vfs_clone_file_prep_inodes); > > +EXPORT_SYMBOL(vfs_clone_file_prep); > > Btw, why isn't this EXPORT_SYMBOL_GPL? It is rather Linux internal > code, including some that I wrote which you lifted into the core > in "vfs: refactor clone/dedupe_file_range common functions". Because Al will shot down any attempt of those in vfs code: https://lkml.org/lkml/2018/6/10/4 Thanks, Amir.