From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17F35C433F5 for ; Wed, 23 Mar 2022 14:00:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6FDF86B0073; Wed, 23 Mar 2022 10:00:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6AF6A6B0074; Wed, 23 Mar 2022 10:00:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 578076B0075; Wed, 23 Mar 2022 10:00:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0026.hostedemail.com [216.40.44.26]) by kanga.kvack.org (Postfix) with ESMTP id 4994D6B0073 for ; Wed, 23 Mar 2022 10:00:43 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id F2D47A3097 for ; Wed, 23 Mar 2022 14:00:42 +0000 (UTC) X-FDA: 79275811566.30.0D1855F Received: from mail-ot1-f46.google.com (mail-ot1-f46.google.com [209.85.210.46]) by imf07.hostedemail.com (Postfix) with ESMTP id 6FEF440046 for ; Wed, 23 Mar 2022 14:00:42 +0000 (UTC) Received: by mail-ot1-f46.google.com with SMTP id w17-20020a056830111100b005b22c584b93so1111426otq.11 for ; Wed, 23 Mar 2022 07:00:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Hu51fP67kdYj15xOoVUTxBLYAZiS00kUydPDhNF2vMA=; b=kux+HHx44G/nwv5HPB+s1IgURRutyiFbZKVe+7+FkMR1cBLkzsNdHZcOwdH9Ky3r2C yjDRGrJqrfxrv7hxHqlMaGcXpmaYimyf0/7lQWOS+TmS47+1N5b9S0ZwRJvzu7guNY2v oEPSI2mTn4xHB2RY9xRksFZg6lURmvSoOIf7rTMCIPD+GzRLrhDkx44l4ucDaCWxDLD4 Y/vWevxXVeW/EPfUdQHTsOow+ODAFF5adXq6Ve1e9aIFKhIOd571kh+n0HXL2nHIVV0n REW6/WZwPVNE1PnndS7cJEfKB1SwsrBXmb+8XvvmAV+0ExEB0yfE8xLK3443SQVrgmbf tYvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Hu51fP67kdYj15xOoVUTxBLYAZiS00kUydPDhNF2vMA=; b=lqjm9ztnz9RvTHmYYcc619Opb/RzGH8J0C3ANQAD6jtGbez3vqq4wg1xAoTpkF5UBb wqz8A0nHs4y9kZs3x5AZJh5+nxc5AXrmQua+hvGg+6SXrSglzCRz79EqXgaLTkLnfDrx P+8xWzfgaatVgcQZB0f/HvDqVwXRf7K5xOdUonzJk0Kv5KfSkbVuEYVdjr2ZsNfa2Urb 1sVdZZ0BIuPPj9fKDOJlNkzJcu5rHdFMuz020hhTCUV0AbAIlqgH3TYbdszOwmeRlrel mq74bPBdeX1+T30W/2vCDFV/LGUpfno3Q1BIH5cjxFo0D+3PcdSb4WvXDYwZH5kGYmFZ lX0A== X-Gm-Message-State: AOAM532I3eYrnf2iGPIVm6aP1zbPp/1+xNzuuWWFyiO1QyyrF8Oxd9aB TWBBj3xiQBM+2npSYFdNLaVg30lBVmWgLKG1PR8= X-Google-Smtp-Source: ABdhPJxRzuW/s7H91TImOhK5lh7wIgkn/tmRp4MMAMNJphfkj1KTin8lQZFNRpiGUUwT+E6fqJ6j2Gkdno1EESGYhvQ= X-Received: by 2002:a05:6830:40a9:b0:5c9:4a8d:ab1f with SMTP id x41-20020a05683040a900b005c94a8dab1fmr12200981ott.288.1648044041741; Wed, 23 Mar 2022 07:00:41 -0700 (PDT) MIME-Version: 1.0 References: <20220319001635.4097742-1-khazhy@google.com> <20220321112310.vpr7oxro2xkz5llh@quack3.lan> <20220321145111.qz3bngofoi5r5cmh@quack3.lan> <20220323104129.k4djfxtjwdgoz3ci@quack3.lan> <20220323134851.px6s4i6iiaj4zlju@quack3.lan> In-Reply-To: <20220323134851.px6s4i6iiaj4zlju@quack3.lan> From: Amir Goldstein Date: Wed, 23 Mar 2022 16:00:30 +0200 Message-ID: Subject: Re: [PATCH RFC] nfsd: avoid recursive locking through fsnotify To: Jan Kara Cc: "khazhy@google.com" , "linux-mm@kvack.org" , linux-fsdevel Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: b4dadnhtw8hrjoqkfe6emmu4rxkcs6te X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 6FEF440046 Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=kux+HHx4; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf07.hostedemail.com: domain of amir73il@gmail.com designates 209.85.210.46 as permitted sender) smtp.mailfrom=amir73il@gmail.com X-Rspam-User: X-HE-Tag: 1648044042-692854 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000017, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > Well, but reclaim from kswapd is always the main and preferred source of > memory reclaim. And we will kick kswapd to do work if we are running out of > memory. Doing direct filesystem slab reclaim from mark allocation is useful > only to throttle possibly aggressive mark allocations to the speed of > reclaim (instead of getting ENOMEM). So I'm still not convinced this is a > big issue but I certainly won't stop you from implementing more fine > grained GFP mode selection and lockdep annotations if you want to go that > way :). Well it was just two lines of code to annotate the fanotify mutex as its own class, so I just did that: https://github.com/amir73il/linux/commit/7b4b6e2c0bd1942cd130e9202c4b187a8fb468c6 Thanks, Amir.