From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36E34D6ED09 for ; Thu, 21 Nov 2024 11:32:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ABDDD6B00B0; Thu, 21 Nov 2024 06:32:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A6D3A6B00B1; Thu, 21 Nov 2024 06:32:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9345D6B00B2; Thu, 21 Nov 2024 06:32:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 70D5F6B00B0 for ; Thu, 21 Nov 2024 06:32:49 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 22F0DA1117 for ; Thu, 21 Nov 2024 11:32:49 +0000 (UTC) X-FDA: 82809888000.06.C9DF573 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) by imf03.hostedemail.com (Postfix) with ESMTP id 1FFAE20015 for ; Thu, 21 Nov 2024 11:32:22 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=eTxz0+ZR; spf=pass (imf03.hostedemail.com: domain of amir73il@gmail.com designates 209.85.218.51 as permitted sender) smtp.mailfrom=amir73il@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732188705; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OTXAZJZ+nKlKLWkxVmOU3X8its5cDxlRDr4MYuX5+rY=; b=EtJGQknMUfiAtBzSmgVFnFciUVOp0coig3mwhnxOASFAnjsPe+DsTfkKfZCHO/x7Pl6MPC pRUcFGotBsFPzYqIzN5kJ5jPSLJCrfkV9u/Ojh9zfIoQfIJ8uplhvlSKmVQjyjOATGR5AI pLIRMaPaSNU0oNl8+zJaBKMNmoUG8kA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732188705; a=rsa-sha256; cv=none; b=1eWiG5tquJEUiYAnhHZYiKYDYGygMTu9TSCSyOoppwlBsTeVH/XzcN53AX+E9Uad5kXBAT S8YpItmwEjmNSgGbkpdhdVYlOnwuUoJ68/hr4FkNtK4DNpmw7bphIhEfpXKBoqpOzBMM7j YIgx2t78ODUWJpquQhKgg9nbNgnIvH0= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=eTxz0+ZR; spf=pass (imf03.hostedemail.com: domain of amir73il@gmail.com designates 209.85.218.51 as permitted sender) smtp.mailfrom=amir73il@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-a9ef275b980so134702066b.0 for ; Thu, 21 Nov 2024 03:32:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732188766; x=1732793566; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=OTXAZJZ+nKlKLWkxVmOU3X8its5cDxlRDr4MYuX5+rY=; b=eTxz0+ZRMPHz0kycn0/5mg/KZj9/s/bZCaFeE8zZ6vkbTAVEQ/6fTXOnQmHv7qQ/0R raIyfUvUSqIOwcDRwbyTzvMbw8FFiKJRvRvQj3c5caJWmqR+ey+zl5vPk00LuZM9qRiU bzGMehFXC58WhADgshvtDu4CV3fXIHcfg3z3Yyt8A1c2BYIvX5TY6E9MELdiIowgAC/g YJnxjAsnHxGT2IG6r00koivAlBbDplz18KJED1yN/CVYXHX4csWun4w+pGjtsec0COEd 3I0NQFOdc7BdFUf46q0OdT7oCtIkc5HDj4uE8bP5aqHyMpY8kDu0chhQhY39mkrTrsVS GmCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732188766; x=1732793566; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OTXAZJZ+nKlKLWkxVmOU3X8its5cDxlRDr4MYuX5+rY=; b=G/pi3+/PhKIpgu8aNqF5N3GweGu3N17s7NTmtKFSlgpJGmiSpuKKKlWKXAx4GgGD3s gA5ffqDNmO+7qMTZNboqys67Nkk6/IyC99GdZOTstv3LgLm54ss1fY5yj9yaz2cH88R0 Ggc+cTs8/hkzPRjWuHYlweaF47jZs9GhLQGmLc/7WVCFGigMemt73EfWglu1yQmOtzrl iNvasyjQi8xMbnrns1iDa/KLLj7JEd9ck9q3Z9RF8m+UpvbYoknIrpOBLVF6EhcC8pnR h8Y18laIRT5PtK1/hXp+5KqJZEgwJu3tbO4Ai0hYc8XUqJQBt4JfMLpSnGk6Q0zhOTET txAw== X-Forwarded-Encrypted: i=1; AJvYcCUGSwr5mk5M9zHmoJiUAIfz8dVJ2Dv86rL3Gkv2O8SyV0Jv2nEjGzIckdHCYOIKpgwndp5KJnOn+Q==@kvack.org X-Gm-Message-State: AOJu0YzpqEmeFBmOEvAek7tSeddYzHv8s310n13J6nQIhYj2kCWGtcSF gqkiojgiJerbqfG8l7ohDCX3X3tRe49o5ZF/3zER5XheXRDE/yC0i2Iui24R1MqEcBP1VmOP3Fk BNuO+TPk7VsTg5JD9UeVfki3pWjrCxDQ/Rxs= X-Google-Smtp-Source: AGHT+IFDC6Wn8S1wprqutUxY59wWGpsYYGBTQOa63eYhgEaktT9KgVt0nhPBJozxBehGGEWQNwXmv1tOeif+Aiv4XyA= X-Received: by 2002:a17:907:86ac:b0:a99:fba0:e135 with SMTP id a640c23a62f3a-aa4dd723f41mr529153866b.46.1732188765299; Thu, 21 Nov 2024 03:32:45 -0800 (PST) MIME-Version: 1.0 References: <5ea5f8e283d1edb55aa79c35187bfe344056af14.1731684329.git.josef@toxicpanda.com> <20241120155309.lecjqqhohgcgyrkf@quack3> <20241121093918.d2ml5lrfcqwknffb@quack3> <20241121-satirisch-siehst-5cdabde2ff67@brauner> <20241121111644.y63uejriiti4vce5@quack3> In-Reply-To: <20241121111644.y63uejriiti4vce5@quack3> From: Amir Goldstein Date: Thu, 21 Nov 2024 12:32:34 +0100 Message-ID: Subject: Re: [PATCH v8 02/19] fsnotify: opt-in for permission events at file open time To: Jan Kara Cc: Christian Brauner , Josef Bacik , kernel-team@fb.com, linux-fsdevel@vger.kernel.org, torvalds@linux-foundation.org, viro@zeniv.linux.org.uk, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-mm@kvack.org, linux-ext4@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: 1dr1b3thmxebf78mzjniw6coiqpzz9dh X-Rspam-User: X-Rspamd-Queue-Id: 1FFAE20015 X-Rspamd-Server: rspam02 X-HE-Tag: 1732188742-946611 X-HE-Meta: U2FsdGVkX1/xpU8Z4sxnQROdPmcNbyIrDujl6aIxv3h5GOsyNIQmQ6tIUf1U0k6l+B22ciuueX/5aicDkgHVyH2Dh6MTCFwY6PnPQx1MwvdS1fIXCZQe7rMe41CVCUpXsh5h0W7Vp2sMikrw0TxRrrDLg+kj9Xx+k33BZxmqwBt07VWnL4nQRCqc3bCldJpFsBQxytCTFFu+P1wILJWLwb/OE3sM7k2rhDRnOYxhTAlayx+NNUEB3XqrJbKNq55DoUsLmKxVjpcFIfBF/+SB9MxsUzERhv5hVdj73P9l1GdgutEiOMjyVS1wwcGuAsYWDXhxas+M6QGfaFb7kp1ywxZnJ1IONKwaU7eW7Ny6pAYKSV/fBmb3y+kYX3AknkeuHVteB9Bg8tEphHzAnyZs87NPf+CeZ8NLQeoWhpkbvXEv4tagnyUKi2P2rIvNyKvyYJUFa/CWPiXkvofj7YESmSVq8YejCqj2h5EQO6/V7q9HcIi5B3YyayAcxECqV6A/hO9i14NgFiCrNERHl0770Yb7tuZ7tuazqN746ED6GrR01sLGbkEc2ILnUfbsKWIIIVTV0Jda+xgYTZqNAA1WS1LDb3POYgLgqOFi3BblZZfbL5xN+Ycgx4eqE/XvkmuohsI8595jdMs/sqfIEZ/s9X8SM0Mp1v6ajviiASq50TeBWgT9Z4KW31jnxqlpFdIWN7NO5zSB6zPdJ7EFQpQDCi+QIhCaWU3cCP4pKZaVhRcibx8a8MYpkkVzl4ApDUbnRQ/ZH+wfX/WIPn5IK15GD0Z20KVRJnpjiO51ul2Ra5mId5FL/OqtaO3e3xokytOfUOGz3r7kOaF6C9j8qa2BAeCuxdmE4JoJD6lrMHLyD1zog/twgJiTEMOuZsHRYOwIe268PIPhTEIY1p/d1ASWeDnZmesGGr4lqoTDJs7ktxsvPOarLwXitsYmDNt9Brywobq4uUn73exk+nK32lO OPtgmh4O cogaYcyVkziR+Lv0eFny0+L0D75dZqzKlaBQ8zKF4R2ZKkQzD5yMY1mH7zv3kGzUwpK2qwlCuAlEe/YELnD2NxZjk5DZOszdNczLPZKI28kEwCL6LVvftiA1f3w2Ia7qibaZoelWJtDurwsNs8/keMO0iZp+rhQoqw8u3ujSgHGq7y6guOc+VtAJzg3srB+Rgfwio4sB7aNXLiXr879t/GWfw+LWue7+IO42onc+Wa4nSTaY86pbGrE/5gFtjafWH2SVoKHHwJJDRbsYj2EOHpYqgB7EhBpXl0YlkGJpMo9d6FVWtgb/w1q1TGZYwZLmoFQ1Ml47uoMnUzLmE1a+hA540UA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.038859, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Nov 21, 2024 at 12:16=E2=80=AFPM Jan Kara wrote: > > On Thu 21-11-24 12:04:23, Amir Goldstein wrote: > > On Thu, Nov 21, 2024 at 11:09=E2=80=AFAM Christian Brauner wrote: > > > > > > > It is not that I object to "two bit constants". FMODE_FSNOTIFY_MASK= is a > > > > two-bit constant and a good one. But the name clearly suggests it i= s not a > > > > single bit constant. When you have all FMODE_FOO and FMODE_BAR thin= gs > > > > single bit except for FMODE_BAZ which is multi-bit, then this is IM= HO a > > > > recipe for problems and I rather prefer explicitely spelling the > > > > combination out as FMODE_NONOTIFY | FMODE_NONOTIFY_PERM in the few = places > > > > that need this instead of hiding it behind some other name. > > > > > > Very much agreed! > > > > Yes, I agree as well. > > What I meant is that the code that does > > return FMODE_NONOTIFY | FMODE_NONOTIFY_PERM; > > > > is going to be unclear to the future code reviewer unless there is > > a comment above explaining that this is a special flag combination > > to specify "suppress only pre-content events". > > So this combination is used in file_set_fsnotify_mode() only (three > occurences) and there I have: > > /* > * If there are permission event watchers but no pre-content even= t > * watchers, set FMODE_NONOTIFY | FMODE_NONOTIFY_PERM to indicate= that. > */ > > at the first occurence. So hopefully that's enough of an explanation. > Yes, that's the comment that I did not see, but assumed it was there ;) which I wrongly expressed as "I wonder how you annotated". Thanks, Amir.