From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0F71CD4F59 for ; Thu, 5 Sep 2024 08:29:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6591C6B0156; Thu, 5 Sep 2024 04:29:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 60A576B0157; Thu, 5 Sep 2024 04:29:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4AB056B0158; Thu, 5 Sep 2024 04:29:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 285166B0156 for ; Thu, 5 Sep 2024 04:29:20 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id BD41E121A2F for ; Thu, 5 Sep 2024 08:29:19 +0000 (UTC) X-FDA: 82530010038.26.BDDD86B Received: from mail-qk1-f175.google.com (mail-qk1-f175.google.com [209.85.222.175]) by imf03.hostedemail.com (Postfix) with ESMTP id E593420009 for ; Thu, 5 Sep 2024 08:29:17 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=OQqYjEUv; spf=pass (imf03.hostedemail.com: domain of amir73il@gmail.com designates 209.85.222.175 as permitted sender) smtp.mailfrom=amir73il@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725524862; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sQ+fDR63qG5ONZINOJ6uvtkYLtiYBt9ojM8SX48oAdk=; b=uBtvRetujqgbYadInoz7yQrrdj/MO1VsKhUu7TzuikmKMuo/HAW52FDLWHfDd8MSScoBt4 rNb+LjdFD2Ci84OyMC40rpci2Oio1f4LRdzJ6GYU6qty79A0Ut+jwSUrGgYEotwTbxlbx3 zbUlSDM0hCAfL0BJxUPrEn9JoSa/6y4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725524862; a=rsa-sha256; cv=none; b=XAPT/fd8bUCeh5v8yb/eQCs5y6IUK3c4hc0lCD+KqKFFq149NyZjpSDE7gjyxhFpauq0R2 Yj9LaHthw673JJXdIENNPZkdmqJLT74kgdgBuVXQ1EkY5VVfGoVFTYh7fF8GxPMt94hGPV TlbeVkedE+9xjg8KP3kgNda8rPq4RPM= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=OQqYjEUv; spf=pass (imf03.hostedemail.com: domain of amir73il@gmail.com designates 209.85.222.175 as permitted sender) smtp.mailfrom=amir73il@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-qk1-f175.google.com with SMTP id af79cd13be357-7a8053dc6e3so33597385a.0 for ; Thu, 05 Sep 2024 01:29:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725524957; x=1726129757; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=sQ+fDR63qG5ONZINOJ6uvtkYLtiYBt9ojM8SX48oAdk=; b=OQqYjEUvvF9r+Tf0PbQjNLTu7P/mIZ+F4+FTU3lMdxo9CWfB745t4JYF24KqPuubOj +cuxbFQKvAgQMQB2A7UpJqcTm6eC+Vyl+pBhwH5N82FrajdacjVUUULaHm9uB7AqOwSJ PrwuUxSKOv+hqVaO67TZW6SyHtvZg2TNy2dHislqUPb9zx/55QYgFWeKDtJvY+RPo38Z KxwNnv6klQ8Ff+8lF/JkhBHdIY2XcU8ykHBwc9z2zrp54NPAOaCnmresoALduUCifioP 5Zh8vHZD+gWkVzjGNlns3EqiBDVV2f64CzpUvAjc0/u6VC6BAqut+pEp8J99T5sdhUuC eDKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725524957; x=1726129757; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sQ+fDR63qG5ONZINOJ6uvtkYLtiYBt9ojM8SX48oAdk=; b=A3okZ6UXKYskYI0nzqN5MJJibP4OzArCfgMBrFbKyaWbgbLms0S667rj78BDwdpJub yvqPEDCr3FMABFRV59OszEQZidMABEyTb3fL6UgpzakvyxDyefxkzVQp8uQ7PeLkV42Y OhMlWpZv47eGDj+3UAoWvwKuspeXYAbgqElPoYne/kO2Q7h4y7/v010plLBVTmqOYYhF KdzCc0jmtxUHq2N25n7led+Vou/qNBvCp++/nSXuKlzJsZILmFA6s7JlAymyDLwgu221 u0QaapQdt+0g3kIAp23FxKcywLOyn3Gkx+sh2IfQpH5L3iMJCN7Tk1E7LwPVa9Wa5DrW hi5g== X-Forwarded-Encrypted: i=1; AJvYcCXvZ/JwLGVXf633Jv8YwQOP1dREsEoquAaXF94iji7UmmJXpsK1UH+M0wQhZ7zySZif+6KvVGsa5g==@kvack.org X-Gm-Message-State: AOJu0YxQhj3anagOoVoUXlbUMWiv6SdImhJOYO3G53QOjg/3zPRlSJPl SSFKdv+xroaXJntMVleJG9Uren8/AIN0OD46Rwl8cuREcOgedLfEeS+yAOBv7vSiPV+EAbcorhM svOjPEKbE58YdS7wli59CEjxkn2g= X-Google-Smtp-Source: AGHT+IGZ0AETQxfdaEvxYsfVejWywusSIHZm4WCYr1dgsHKToFW8X9SeSMNoiE3iG3b6zr9Wtdecd+e5Vlv4wJ+sLRU= X-Received: by 2002:a05:620a:1901:b0:7a3:524f:7ef7 with SMTP id af79cd13be357-7a80418135emr2520162785a.12.1725524956906; Thu, 05 Sep 2024 01:29:16 -0700 (PDT) MIME-Version: 1.0 References: <12aebe1a4f039d0234ea74393a39614c0244f7e0.1725481503.git.josef@toxicpanda.com> In-Reply-To: <12aebe1a4f039d0234ea74393a39614c0244f7e0.1725481503.git.josef@toxicpanda.com> From: Amir Goldstein Date: Thu, 5 Sep 2024 10:29:06 +0200 Message-ID: Subject: Re: [PATCH v5 16/18] xfs: add pre-content fsnotify hook for write faults To: Josef Bacik Cc: kernel-team@fb.com, linux-fsdevel@vger.kernel.org, jack@suse.cz, brauner@kernel.org, linux-xfs@vger.kernel.org, linux-bcachefs@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: E593420009 X-Stat-Signature: zkcgyiay655bxfgfsoottb9gqinkgj4f X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1725524957-695936 X-HE-Meta: U2FsdGVkX19qxlzDzHtYik6m88nyoeJecUzk4wHejZCMqnhG5SF/7zhJj4jVlG9xzR+XdSlgJjyMlQetw5XzaOeRx9CVFxhntaHc0Irn3YfW7ELrRS7oBeMQ2zxMnZsyd748pMXk54taarl3sl17sTYfbcl1/jtysBu9YioUBNnFtJM2IZFMSMpBXIOWyh3E2RaViD2B/AWM/UTUDjkTP7oZIf6IbMz8v4eyhxwGOIvWAxlM2KvqnouxIoaS4D700ciSRmZ5kNFAIaqC7lbeIIHI6zFB2748oSDczIG1//VSCOjzk1wlf8IupEN1nBA7GSV019vmaSVQDVN606kxuq9m7d+clGiAUpYH3FS+lFxP4JVdCoU9Jor/Z7z3gpWtyUyqAPKIzHeHe6SWj4MgOAWoXzxcXkJNgFgh/TYTCSXFpkIg4Wuhc3Z1+sflR5R573PyrJpaOvOukd6utIjDk8oPGDvOQBNjlWqNCKnaHxTccbyM5eCz2GdH+WlzkvCQSVpYclH50PuBcCTEiNGZnowlxfPFVzan5WM2SkQtNNtxeDYu/z7xch2oMnS+XGJPmXJKU0VUuRzTTN69nekf2joDfWvo0aJtpBf2xsdFSQ8N6B8h4PzMJAzVrhrQQpu1rwwU2IEawON4dsnuU1uHdvmFAcuqDEot73Zw5byIusxVB3up1DcjrDsHfkfy3CP2eLGjiiKyesXfnA/Y9XoxZIOCrzz4CErs8aiNSDyGlxr9Jy2tJGUc0bQ3jkN29K3kgU8Z+nNKZzjMBmD08rZNxWrbN52b/IO6VIzmjZKNX5MW+F84J3vc186d+5vL/7yeDLvyFvGyW0ynD2Rd7sVsj39WkEe4JJCOJVNDfnkqIocAH9cUss29afb8au8oAmWfW9GXfqq3ExKjmnd6hWF2HJtAWcbgXDPKRguvpvn1U6J2v5b2oO6oBAG+ZskmWqD0EyfPFmYAeCz6vO/2T+F 33kxhRjf XDKwH/BGFJFIlEM0GcgldoanBMCrHXJuy2O7+7xRpztG/UTU4PH4l+j5F1DT2toIc+qw5sNDs+9694hTDsGW4XP9JBh9+0VmHHK+9kaGoD956q8y6r7llyZ5QVsCihfewvhdAX7nQ67/bld+fk8Yzrd4MC2tgihg6Y+3bamcsGWXn+vcDPfhK+vwIHgU7zssBKyi74bXYOuSStQhnmeZIjtQ2nZ4/c6NeToUo6gTO5mnbPGOHcSbAnafGU/yen/syW+wPA1hUfMFyPzL1CPHTzhjWBivDiOamEPjhUDK4L/FIhXQ5jAbklZyrlrRMMp8KyEpGK/0A+DYPaQ6cPWrfDbB4ACCKTZSPSIqADCfF3g8vFRDccuEFUkElb1HqelJ/62seqxD/G1nbglSwG1TPd8T+XQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000195, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Sep 4, 2024 at 10:29=E2=80=AFPM Josef Bacik = wrote: > > xfs has it's own handling for write faults, so we need to add the > pre-content fsnotify hook for this case. Reads go through filemap_fault > so they're handled properly there. > > Signed-off-by: Josef Bacik > --- > fs/xfs/xfs_file.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c > index 4cdc54dc9686..3e385756017f 100644 > --- a/fs/xfs/xfs_file.c > +++ b/fs/xfs/xfs_file.c > @@ -1283,6 +1283,10 @@ xfs_write_fault( > unsigned int lock_mode =3D XFS_MMAPLOCK_SHARED; > vm_fault_t ret; > > + ret =3D filemap_fsnotify_fault(vmf); > + if (unlikely(ret)) > + return ret; > + > sb_start_pagefault(inode->i_sb); > file_update_time(vmf->vma->vm_file); > > -- > 2.43.0 > The end result is so much nicer than early sketches ;) Reviewed-by: Amir Goldstein Thanks, Amir.