From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A37CEE9370D for ; Thu, 5 Oct 2023 13:22:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 09C816B0202; Thu, 5 Oct 2023 09:22:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 055E66B02B0; Thu, 5 Oct 2023 09:22:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E2ECA6B02B9; Thu, 5 Oct 2023 09:22:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D23266B0202 for ; Thu, 5 Oct 2023 09:22:34 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id A575380191 for ; Thu, 5 Oct 2023 13:22:34 +0000 (UTC) X-FDA: 81311472228.11.6183393 Received: from mail-ua1-f44.google.com (mail-ua1-f44.google.com [209.85.222.44]) by imf24.hostedemail.com (Postfix) with ESMTP id C33AE180002 for ; Thu, 5 Oct 2023 13:22:32 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=G5+ZFfs4; spf=pass (imf24.hostedemail.com: domain of amir73il@gmail.com designates 209.85.222.44 as permitted sender) smtp.mailfrom=amir73il@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696512152; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UgIhftH4G92rOIHpCooz7/tVkwHfE/wjVpyKVopiGpI=; b=nRPNWwPBnhzZLXr3+qjAww2SgQj4fGv79krxnI6ba17TaEGUP/iPwm/3LSLsXkHBF7ybv0 a8XZmRad9qIx2b+2/1ojGwrhZAd4v1L9hOZ3ThkWlp5t98/uGj8cvFvCcCs9rE2oHnN8TJ H4OhfSpFO1h3KbfRZ6IVCjqV8zEe+Dg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696512152; a=rsa-sha256; cv=none; b=b8PpRG69Vq3/Nh9gZIm1j2Ag15CFVZ/b8PvwyIVb61N8F4LdRHe1wIbmdbf/sPmM7Ehp5N 6mMs5pfKHDaIMa9Qif1XMxixWuNoLUi1w/YXDvYW/7teym0uOIeNEuCj8+lgKj2bXS9+ah hKufCH/K5fruFUKvDwsvTAZvMsppYu4= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=G5+ZFfs4; spf=pass (imf24.hostedemail.com: domain of amir73il@gmail.com designates 209.85.222.44 as permitted sender) smtp.mailfrom=amir73il@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-ua1-f44.google.com with SMTP id a1e0cc1a2514c-7abe4fa15ceso641636241.1 for ; Thu, 05 Oct 2023 06:22:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696512152; x=1697116952; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=UgIhftH4G92rOIHpCooz7/tVkwHfE/wjVpyKVopiGpI=; b=G5+ZFfs4xBz5gJiv+Gv7xmvSK/m3LS1ephVa3X+45C9tsTucE/dQ53H+2aHt8d8OKr Xc9WXbMtNd0JJEJMJ3Xu2+X/NXS8OavaOZXL0KxdzX/v4FiTpej6PFwvE7S5gCuOkakJ ohX709Wyc9uA8bX7q7fL/xJQ0nSM2AABUDiWlRiWYbRr58ADBA0DKBhatAULeJA6ER91 l1dOFdL5MhOYLQYHL+MjcaI6sYpPxRX4kIOjTvN50zzeaTNYiuG67yKpoIrjnZpfM90E WPLlv8hR6vHGngexomotda+V95WGrIorGSkE5nGf3OpTE5xasz8QBoa1IfZTkI8xKDb9 rpVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696512152; x=1697116952; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UgIhftH4G92rOIHpCooz7/tVkwHfE/wjVpyKVopiGpI=; b=obnsn+dwY+KgPnStX594t3zbnmImDBcgQdEIZj+MEYqx8ijpJka8Am/bIr5oTt3Gy+ 50ttDNWm7K9wWUKoZLgmOVmH6eMEcX/tpdB/8K2Ifd9bZeDkH1q0GO51DWyERcA3wgdg uJpoijlvJF1yrMuzxZuBPtFXkiBCqayKpU7HlVAnyUUrdO0SN7U7GO5rSJhxXkYXBQy/ EizcLB06NeSuhGRN+77YDzgSQtLWqPC0UfC/BHvpKDwoRl3HHiy+Kkgj9vwh9sgSp8OO R+4Hny+73s5qys2gd2m21mVkMPy6tDR5q5P8umvZw7TCi/N39SqPXcyj6FNGPEAaSpO1 /crQ== X-Gm-Message-State: AOJu0Ywt+CyzErDgRYa+862OQVLuibwYJfGr4UxGAAzrU7FAqcPPANLK wGaGrYS5K9ppJRNEQ3uf/OA5EyFkDoXPoUkrZ6E= X-Google-Smtp-Source: AGHT+IEAaoXvXyAHbtej0tnlxnEefZxsl35/d3/bkcRzxXHlDTbd63Hu1Wx/seqMYJSPAmspgFgWwlCBgqV9VufIEb4= X-Received: by 2002:a05:6122:1817:b0:496:80b6:2fd1 with SMTP id ay23-20020a056122181700b0049680b62fd1mr807887vkb.5.1696512151811; Thu, 05 Oct 2023 06:22:31 -0700 (PDT) MIME-Version: 1.0 References: <0000000000001081fc0606f52ed9@google.com> <25f6950a67be079e32ad5b4139b1e89e367a91ba.camel@linux.ibm.com> In-Reply-To: <25f6950a67be079e32ad5b4139b1e89e367a91ba.camel@linux.ibm.com> From: Amir Goldstein Date: Thu, 5 Oct 2023 16:22:20 +0300 Message-ID: Subject: Re: [syzbot] [integrity] [overlayfs] possible deadlock in mnt_want_write (2) To: Mimi Zohar Cc: syzbot , hdanton@sina.com, linux-fsdevel@vger.kernel.org, linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-unionfs@vger.kernel.org, miklos@szeredi.hu, mszeredi@redhat.com, syzbot@syzkalhler.appspotmail.com, syzkaller-bugs@googlegroups.com, viro@zeniv.linux.org.uk Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: C33AE180002 X-Rspam-User: X-Stat-Signature: rijmc9qkhzbeuc3rf1ers16tmkppk4fd X-Rspamd-Server: rspam03 X-HE-Tag: 1696512152-229120 X-HE-Meta: U2FsdGVkX197L4P8PRiQZgLh9FPBD6XGw91BKjQYPSaNiJGR6quiiq9q1nWPpfN3WQ9MQC4s6ROFam4e7TdXnyFupzLO6VaypVd8AH8+0Fkxlxb4laCN8gi2Zcvd+1H7ZIhcisgmNi2oLJG5S0X/LxRLT7pi7UxP3ew9JrgKWEIWBVIQqQzU8+TCyH+qLCYUJzDCtUec4StcfDeNB9n/IOy6s5fVg8S01zPWylbpRfpufNTdpM+uBQP12uNvKtKi7WPKxItf85K4HVm9mZoEEI0Tor2rnYqIWmQNx+FoKGN0oeq7I5f+srCUqw65Oz/w8c+HMXBmz6CEYlQr/DJrQ7q0uGwOw1CTPgkoNZL50MHNG+Xj3RkV9iwWP3RPaFrNVfbpZFJ0EI6kVmwmjZEo4N5wT7Da5jj3cTzIaNIsZyR8DtX/KSrjzylw+E9QH4ALkHvP0g9QATnPKO4FXBDsbY0py1SYLS0E803ORHPU7/tKpv72Dptuse0wuD8F/DpOIFHpWd81qaHMGs9JuMKwwmvEX3uPTI2+m2sIZCEWzz2cGfWKNNa85nvZH7VUplmwvf1/dE36sFtULFBgL6lgT9gw6NNf/6U/dLedssFTacihLBFb0t1CtzlcMdM6qy+zbm2mLfuvDXdZBJVdb0VR/nkwBMWSsPMiTm2/UYkaj2HVXenm6zYN1ReUL3DpWzdv/OLKnLKWL4RDaVXyNyObZJ1eJMdEfzKH1Ab3ez/X3Sv3+y4wVY+V2q9VSKMzyMJPffjD6816bPjYDwSCF0DeKZgo2W2RjrIMJM3j6/RlcbVUCSSLvecvMDztYr0d1zVI47F/oC7mhkKBTsNnIVUD1rJMeAvlormnGq9+wNdwH+ql9C86bJ70ddDw3zdt/ZiADFjtF78JUVhfIUNtk5PRGAR3usIZ1K/rR6qqrMkEZuwnPLEQiHoY4f49Un8QP5ExmFjFp6fmgOyHim4nkkN XJ+LQSnN 3ZwjGmM6N4xw1jsNuUZ7XhsGONdI3qJW8I1fUR7k+CyRoHnOfQKq8Z0U5QyervpsI8+OIwDwn0Q15TExFrI4aiOC8GXazIbk5bVlHwLYg3Ath8AG+/PYEK4f7Ds+TVFORKRhj8uHfQt8Imeem8YCtVVVSfD/7wJJYT7iU5Ge73FdgYn3YYCK1QfUMWZkEQFRwgWPpTM1AK37let2UPmkrJFswbTlj+G5v2poz+3sCGDNT9u7ik65kowzNyG7LBMOfn4Z+scMH7EK+WbdfgoOljVXsQGtTsj9qITU8yOAJEtkGCs/6jAg+IWUzXXjcqzbsC+r3LCgDXNytALKpcmNoLmZmRThm78Zr6/xuCWR6IsSSIMZ4m0AkuQh/bvuVIPpkgvqoW+UGJGKDpAYsZH+yzquAWW115p3uG4gtoqDdviWb1gUi7tMCLTiTmSrl6+cR7i1hOGxJeAKPY5cWEgx7WU+4kORtwoUQ+oTCimPrGMgzFBX+tMCdSQhzy13QyAbT7qODhvD2S3eZ+XuxwjQQvjToW9+fmMGeJTZlomuth4vlfDsgmYjtNGzAT6za2+h3xziRBMk7N27kC0rOx7d4TtEomuh2Q1IwZaJO X-Bogosity: Ham, tests=bogofilter, spamicity=0.002984, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 5, 2023 at 4:14=E2=80=AFPM Mimi Zohar wro= te: > > On Thu, 2023-10-05 at 13:26 +0300, Amir Goldstein wrote: > > On Thu, Oct 5, 2023 at 12:59=E2=80=AFPM syzbot > > wrote: > > > > > > Hello, > > > > > > syzbot tried to test the proposed patch but the build/boot failed: > > > > My mistake. Please try again: > > > > #syz test: https://github.com/amir73il/linux ima-ovl-fix > > Thanks, Amir. "mutext_init(&iint->mutex); moved, but the status > initialization lines 161-166 were dropped. They're needed by IMA- > appraisal for signature verification. > > iint->ima_file_status =3D INTEGRITY_UNKNOWN; > iint->ima_mmap_status =3D INTEGRITY_UNKNOWN; > iint->ima_bprm_status =3D INTEGRITY_UNKNOWN; > iint->ima_read_status =3D INTEGRITY_UNKNOWN; > iint->ima_creds_status =3D INTEGRITY_UNKNOWN; > iint->evm_status =3D INTEGRITY_UNKNOWN; > They are dropped from iint_init_once() They are not needed there because there are now set in every iint allocation in iint_init_always() instead of being set in iint_free() This is the standard practice for slab objects. See inode_init_once()/inode_init_always(). Thanks, Amir.