From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2152ACD4F59 for ; Thu, 5 Sep 2024 08:28:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A2A396B0213; Thu, 5 Sep 2024 04:28:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9DC9C6B0248; Thu, 5 Sep 2024 04:28:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 87B026B024A; Thu, 5 Sep 2024 04:28:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 664EF6B0213 for ; Thu, 5 Sep 2024 04:28:06 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 24AE540ACA for ; Thu, 5 Sep 2024 08:28:06 +0000 (UTC) X-FDA: 82530006972.03.CB9E5E1 Received: from mail-vs1-f44.google.com (mail-vs1-f44.google.com [209.85.217.44]) by imf16.hostedemail.com (Postfix) with ESMTP id 617F8180009 for ; Thu, 5 Sep 2024 08:28:04 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="a3QA0Pj/"; spf=pass (imf16.hostedemail.com: domain of amir73il@gmail.com designates 209.85.217.44 as permitted sender) smtp.mailfrom=amir73il@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725524836; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sVZvaQEpRVT3r0fm528EiKgjdfIwrSP8yDYuzflRklo=; b=q5DAj/sobGhrJhO+B5puVPhxc2ULPN8y49MolPCQITesbidl6ajP1BRrmtcJdvXqJcx+Fr 7MQ3mAtW5v6oMmRuwXAKbVaQLvH3TO5QsrwWDeHjKbt7HALU3fqPc01S8kaRVH2PlPGHVO ycIO9tpUy0NWfXWv2+xIxTOBy2veCjI= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="a3QA0Pj/"; spf=pass (imf16.hostedemail.com: domain of amir73il@gmail.com designates 209.85.217.44 as permitted sender) smtp.mailfrom=amir73il@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725524836; a=rsa-sha256; cv=none; b=HukYuhYDqLbybaUZSaJzXSXjqqnX40rOGMEk8UiLIJvaCzVhEdxDXYjdRb0QSZVOqhRt6Q CUsTWkdsYh0NVFboIAIBooFzNTBsyMXwFvBLfMntFBMuz+9SU2uaPMKOdvYj82ldZtgvRu GD5Xo8Lb6oSssmqmN6LRafXF3Somo8g= Received: by mail-vs1-f44.google.com with SMTP id ada2fe7eead31-498cd1112c3so118628137.0 for ; Thu, 05 Sep 2024 01:28:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725524883; x=1726129683; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=sVZvaQEpRVT3r0fm528EiKgjdfIwrSP8yDYuzflRklo=; b=a3QA0Pj/fRPhwInkC6DGqx10YUpY/HfmEJGCAqBSi01TL+qV2PY1VCeQK7YepWk4Da KwZ64AHp7KCT9hiDIpS4n5EO8PtwS1vtESFEBurM3417+ohfdQtIvArJWCUOZRR834I5 Aqm3xHRwKXd77n40Eq+O9KyZee96xRv6GfQVTU3g3Oy79zr3ZWh4JOq35kzFJ+nZo4oh bFhbHFDaSsqII46fHNKv4I1mXSf3jshYdhGia1hMQ8RhA83jDb7ievQCzfpO3JBERbK3 wkZSpXR/MllSOKsLnQFEjrbo/1d9qinTHHkw+Vd0LFv/POWD8WLndOzQTTuKve4N2ajj 3daA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725524883; x=1726129683; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sVZvaQEpRVT3r0fm528EiKgjdfIwrSP8yDYuzflRklo=; b=pOMHvnW3tvGUR/4OJ1jhz6+qlaefzTClka/hlkzpG5YZsJaSHVg8VAn+nEc+inDhKG dX7Hn/AfrxXWfLmOQqOcBRtMEXk6yNhyTKRf1SMleywKz6kZML2Xkv6e3SyUx839DLY1 isTVo7FSZqvwJcOeHlHLkjtvdphJj8zMO+AdCYeW/JM1EtBxh6c8bWfJPWXVRjukDuut NSk6S0zuqc4+CX0hF7qrZf4/61WqMUQdpWrk0ct3oUzQrwTPtNzbHySP0Z610rCova8+ aNyZbotxAtrOeHS/5o5Ah5K+qBbZygpZrLmz0LxF/OrRw9CVxRtXQQuOPJ21TLs0/Ghx ZR4w== X-Forwarded-Encrypted: i=1; AJvYcCUuqEPioGH3kKkMnsRGxvOY1e7ICSw2gFwD7RB0Fco94WpFlScnaVFmhD6aKN7fwCVXdNachnOcVg==@kvack.org X-Gm-Message-State: AOJu0Ywe0BBz+FeCSuFRG2Xmj95C3PcLy7jmZ/Eo861cgRKMZl5+m/5P bQmuF+bUQ89rbnoHTb0Ab/ChHTn8CGzk696aY/r72nBYtLT/pv4SUAAwSlnmf4cL+3Y7NLL7o7p g3LKFEHGhKlJYQn8NfYO9ffnKtWM= X-Google-Smtp-Source: AGHT+IGoNU1jZY6A/h1Uf8w7In4vXi6AGkhvNM/ehWlkjdTlkw88exnYqYilHPuSRQLA2qLVcYdAIC9XX74OtFoPjeU= X-Received: by 2002:a05:6102:2ac2:b0:492:a883:e1d with SMTP id ada2fe7eead31-49a7775732amr18840231137.11.1725524883402; Thu, 05 Sep 2024 01:28:03 -0700 (PDT) MIME-Version: 1.0 References: <33151057684a62a89b45466d53671c6232c34a68.1725481503.git.josef@toxicpanda.com> In-Reply-To: <33151057684a62a89b45466d53671c6232c34a68.1725481503.git.josef@toxicpanda.com> From: Amir Goldstein Date: Thu, 5 Sep 2024 10:27:52 +0200 Message-ID: Subject: Re: [PATCH v5 18/18] fs: enable pre-content events on supported file systems To: Josef Bacik , jack@suse.cz Cc: kernel-team@fb.com, linux-fsdevel@vger.kernel.org, brauner@kernel.org, linux-xfs@vger.kernel.org, linux-bcachefs@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 617F8180009 X-Stat-Signature: h1b39no5yurddhuaap3byb4ugjp5h1ru X-HE-Tag: 1725524884-530072 X-HE-Meta: U2FsdGVkX19wqQ6DGqYEPx+lni1NspcTTiSmBdzgfXdeQ0inKfo4P6wDPrgEt2KrrrrtruBk5xGWXwJ6nc3QId7D14TC2OEHvo5RUUASkmWNq7udLVX4A1JM18aMlurIRFqzfOaGH+374QkkR7pvZuYdeJOQbG5+S/XIqi1+ivjvywUmiTGKmuauUQtnxFqXKFiHX3wDvqHST6PFUG2ZHmRGKnm/fP96lbZJ4krmMe76CL4p/Rv19Lq2LjwCbcI0poWUhTuHuBIqL4Mol3Sw1htMOQy9v4gdilu8la80WRwEaUgzXbd4MIlk7W+fQnkTMwUYpzxIJGF4cxtgujP4dbN+Tcnt/RTRHimUR2R8hNnN0oYNTlvAqZWEfjH7O/NNruGYkJlMN8J/6iGa8YMupYqvmkKIVNZYzzh6OedHxfvgLEna8KyZG2pVdzudthqF21+2KOKyKa081y3Fglc3SCJYXPmGKbTRijvUS1+ZyscxLwHQiNlGufZuOv/PliIySr0vk8ymbwOn+Ctx3rqs2FDcgxs8b2ZnWTuhLfTBdo0iCDey817ACYa1KZjn35jjVtZl5uZnxLi2tjjK6gcNag5FX5rfs7g/UzTc5xVnzy7YEk+gRqzBeMsVMlknRJB4+PpR/9cPckLsnBKbC+KkQq95GUUPnITwUgDaaBj6KrzIeHXo4l3oj/Y3G/kzqk2zpZldUCT7xlYtxiIPZjLjjxafMCqyTXAPTtwvXKp5g8ysZXV3xEcRxM91qqksAowtnT2iZcjTl8GAQF9OqxrE1T/ztvO1rr5Z2Ll187FkLmey830iJ1DYyz9GnpH7gWhypeg8/MTMORO7VqiBQjF3y+9XHP7kBTK7IgVc8mMNU1TNa5SwsG5b8iis25455fCxZKF84Aam0BqGp+1edpfNX3sagTSkt0JaM7xGucs1gIRLIp+9KKu0nqSgJN4EeqaVRUZaqFGU4JI4fA9Wdd2 EBn+jQcg cfPy47JC1+oWc3wPsDvLs+Ad+IFyZGjTSCUnVQeNFclZRSW/u6/qUwHNxFOfM+LZh3kbKW4+ifqki6f9dwcwZhInzB3EFYOn+9R151ZfZUTB/jktxNyp/sLqRkHlJBO3/zdwxiIdh9cvXlY9hGGVgttverT/sL44urgW7DmFHCnT6hdb0zqdztZBwwyVAnuYpQPkwQDcqdu+ZYbMxNaTYd9uueIjSU0hG7eshV1g8DrYCcl2eKZTA5keLBWncS8rnGY2hlXE6+6YM2FV+FOkcHlZ3i8IzrdnzW0IRWYD8OWNCHwzixlaglsCtHW5bWOFxlVprRxDkyfvV/E9I/N9VuwkfZoqEGILRXoO/M6EtaqnxJJxXr0QJsrFZ2kNj2/gX4IfD X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Sep 4, 2024 at 10:29=E2=80=AFPM Josef Bacik = wrote: > > Now that all the code has been added for pre-content events, and the > various file systems that need the page fault hooks for fsnotify have > been updated, add FS_ALLOW_HSM to the currently tested file systems. > > Signed-off-by: Josef Bacik I would not be devastated if this patch remains as is, but I think it would be nicer to: 1. Move it before the fs specific patches 2. Set the HSM flag only on ext* 3. Add the HSM flag in other fs specific patches Thanks, Amir. > --- > fs/bcachefs/fs.c | 2 +- > fs/btrfs/super.c | 3 ++- > fs/ext4/super.c | 6 +++--- > fs/xfs/xfs_super.c | 2 +- > 4 files changed, 7 insertions(+), 6 deletions(-) > > diff --git a/fs/bcachefs/fs.c b/fs/bcachefs/fs.c > index 3a5f49affa0a..f889a105643b 100644 > --- a/fs/bcachefs/fs.c > +++ b/fs/bcachefs/fs.c > @@ -2124,7 +2124,7 @@ static struct file_system_type bcache_fs_type =3D { > .name =3D "bcachefs", > .init_fs_context =3D bch2_init_fs_context, > .kill_sb =3D bch2_kill_sb, > - .fs_flags =3D FS_REQUIRES_DEV, > + .fs_flags =3D FS_REQUIRES_DEV | FS_ALLOW_HSM, > }; > > MODULE_ALIAS_FS("bcachefs"); > diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c > index 0eda8c21d861..201ed90a6083 100644 > --- a/fs/btrfs/super.c > +++ b/fs/btrfs/super.c > @@ -2193,7 +2193,8 @@ static struct file_system_type btrfs_fs_type =3D { > .init_fs_context =3D btrfs_init_fs_context, > .parameters =3D btrfs_fs_parameters, > .kill_sb =3D btrfs_kill_super, > - .fs_flags =3D FS_REQUIRES_DEV | FS_BINARY_MOUNTDATA= | FS_ALLOW_IDMAP, > + .fs_flags =3D FS_REQUIRES_DEV | FS_BINARY_MOUNTDATA= | > + FS_ALLOW_IDMAP | FS_ALLOW_HSM, > }; > > MODULE_ALIAS_FS("btrfs"); > diff --git a/fs/ext4/super.c b/fs/ext4/super.c > index e72145c4ae5a..a042216fb370 100644 > --- a/fs/ext4/super.c > +++ b/fs/ext4/super.c > @@ -137,7 +137,7 @@ static struct file_system_type ext2_fs_type =3D { > .init_fs_context =3D ext4_init_fs_context, > .parameters =3D ext4_param_specs, > .kill_sb =3D ext4_kill_sb, > - .fs_flags =3D FS_REQUIRES_DEV, > + .fs_flags =3D FS_REQUIRES_DEV | FS_ALLOW_HSM, > }; > MODULE_ALIAS_FS("ext2"); > MODULE_ALIAS("ext2"); > @@ -153,7 +153,7 @@ static struct file_system_type ext3_fs_type =3D { > .init_fs_context =3D ext4_init_fs_context, > .parameters =3D ext4_param_specs, > .kill_sb =3D ext4_kill_sb, > - .fs_flags =3D FS_REQUIRES_DEV, > + .fs_flags =3D FS_REQUIRES_DEV | FS_ALLOW_HSM, > }; > MODULE_ALIAS_FS("ext3"); > MODULE_ALIAS("ext3"); > @@ -7298,7 +7298,7 @@ static struct file_system_type ext4_fs_type =3D { > .init_fs_context =3D ext4_init_fs_context, > .parameters =3D ext4_param_specs, > .kill_sb =3D ext4_kill_sb, > - .fs_flags =3D FS_REQUIRES_DEV | FS_ALLOW_IDMAP, > + .fs_flags =3D FS_REQUIRES_DEV | FS_ALLOW_IDMAP | FS= _ALLOW_HSM, > }; > MODULE_ALIAS_FS("ext4"); > > diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c > index 27e9f749c4c7..04a6ec7bc2ae 100644 > --- a/fs/xfs/xfs_super.c > +++ b/fs/xfs/xfs_super.c > @@ -2052,7 +2052,7 @@ static struct file_system_type xfs_fs_type =3D { > .init_fs_context =3D xfs_init_fs_context, > .parameters =3D xfs_fs_parameters, > .kill_sb =3D xfs_kill_sb, > - .fs_flags =3D FS_REQUIRES_DEV | FS_ALLOW_IDMAP, > + .fs_flags =3D FS_REQUIRES_DEV | FS_ALLOW_IDMAP | FS= _ALLOW_HSM, > }; > MODULE_ALIAS_FS("xfs"); > > -- > 2.43.0 >