From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A005AD6ED07 for ; Thu, 21 Nov 2024 11:04:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1D1906B007B; Thu, 21 Nov 2024 06:04:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 181DF6B0082; Thu, 21 Nov 2024 06:04:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 049156B0083; Thu, 21 Nov 2024 06:04:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D777E6B007B for ; Thu, 21 Nov 2024 06:04:37 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 76139411FC for ; Thu, 21 Nov 2024 11:04:37 +0000 (UTC) X-FDA: 82809816642.27.2467E8C Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) by imf08.hostedemail.com (Postfix) with ESMTP id 911A916001A for ; Thu, 21 Nov 2024 11:04:00 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=d5vYjzNe; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf08.hostedemail.com: domain of amir73il@gmail.com designates 209.85.208.53 as permitted sender) smtp.mailfrom=amir73il@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732187008; a=rsa-sha256; cv=none; b=cYwhEQyw1nTHqXRCeierBWLwWvrpgVNnbSbWUyARGqGn9rUp0J/Ud5nztslZfbMulaOTmF xNaSDfeF6hY0S20M1a8WLq3FAQtjAquDheKRMw/Fd2+FMyLIoT36tuSQ2hBvesn4rMVFx5 Bb+qAigxYT08c0+ltaFh6gJxgsLAarY= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=d5vYjzNe; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf08.hostedemail.com: domain of amir73il@gmail.com designates 209.85.208.53 as permitted sender) smtp.mailfrom=amir73il@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732187008; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XWLe/gk6n5WMpVM8HJR3stwF8Zq93MkvXhdaqi1d7jw=; b=Ucj5Mnz7w6aZ8kwLEnFS1RV64M027618q/U5M61nhvohJ+97WECIQIPG6K4XuVDTitXF8T 0Gu6X0eyLckhn98Di/9LdYwS14Z2uGGi45YlOUl88YQf9ArAXrfjRVYJe83DGqURme2Flw VMTjY6uYzhMbwiTiTG5H8di+YeJSs1g= Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-5cef772621eso1017373a12.3 for ; Thu, 21 Nov 2024 03:04:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732187074; x=1732791874; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=XWLe/gk6n5WMpVM8HJR3stwF8Zq93MkvXhdaqi1d7jw=; b=d5vYjzNeRCSqmkoOesC3WmdRvUnWvrxi18wOntjyNl9dAbnSHrVnX+8ace+lEXeMz/ 5F7wMcQ9Jhm7qyKG3auFKnC9tASHnosKw+LfSldqu6N3VEvp+kYJ9KBdpXPrTuxUI/HX WscMxj2FzKjgh4E+2FybH41D5zes1cetnD+8zoiyvfpN4hYOL0hIcQ9PjB9x4a1zA1sT 8jD9s6Yo4B4wbn2/1NV+tby257WuZln6ipF7lX8ZaVtGJnGhhHbNNN92SmGXZ8Iv2qos 3l8nRMPbz528TfJzc35TCfdeDG2r+e5T7Z4AwdH+6xk1A0LgC0tPkvmTLADE/Y76s/Pe Qx9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732187074; x=1732791874; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XWLe/gk6n5WMpVM8HJR3stwF8Zq93MkvXhdaqi1d7jw=; b=iOMBvXB+7iEroBrCvz0k6qK39v/PEAU1tIZkUX1Fu4qs5YPRUKXSFxYxZaIbxPRbi3 wQi8UE6pCW7uvRka4sXN48HakTMJs3hOatHACxe4VG2IsPM/h441bvdTKtwq5ew4MsGm Cp7ffNM4wnpHbEApgNL/VXlkA3p9YGnlnZnRrXAsT9aUssNtM4CkOV6mC++nkNjS2gf+ z15bf5JdLfAQgLvoudExbAUl6GOh1NSDpdF1LRbXCOdkp6SMSkwOeWDqyI2O8NlFDRVX K7RRnN2VEGf+XT43qeYYILZv6X3rCc9WfGx6NzBnwUe4D1jjnmf+6eDNI8ZZHqpSoaMq so0Q== X-Forwarded-Encrypted: i=1; AJvYcCWsrgUwiBaIhB+aJdkuRz2QvW5ovV1Mu1wFK6wJm6qQmG5KnwpCd5G7kQz2XwTF+FNMiXlCEyKckw==@kvack.org X-Gm-Message-State: AOJu0YzVvRicASkrK2LlubZ409iQ7/ZBzAy8bop6IS/P235catc1/zxk p+f16MFEBWKnF5IICeAEL5aCkEC+y5Z7Sl/hgSrocvZO7FoZiMnmmcRCM8o4gsEOXCgWFjULDy9 itHul73u064QM0UP9aInSztg891Y= X-Google-Smtp-Source: AGHT+IGo1V0LUnv7NvqgfMaf1C8hEr3UYbvUtC1KgyBCabOlD4DOhJOY0ssHeuOlaKCL17yq+Twr91bvaNg7AVLf+i0= X-Received: by 2002:a17:907:368a:b0:a9a:14fc:9868 with SMTP id a640c23a62f3a-aa4dd52d0d8mr643939966b.4.1732187073953; Thu, 21 Nov 2024 03:04:33 -0800 (PST) MIME-Version: 1.0 References: <5ea5f8e283d1edb55aa79c35187bfe344056af14.1731684329.git.josef@toxicpanda.com> <20241120155309.lecjqqhohgcgyrkf@quack3> <20241121093918.d2ml5lrfcqwknffb@quack3> <20241121-satirisch-siehst-5cdabde2ff67@brauner> In-Reply-To: <20241121-satirisch-siehst-5cdabde2ff67@brauner> From: Amir Goldstein Date: Thu, 21 Nov 2024 12:04:23 +0100 Message-ID: Subject: Re: [PATCH v8 02/19] fsnotify: opt-in for permission events at file open time To: Christian Brauner Cc: Jan Kara , Josef Bacik , kernel-team@fb.com, linux-fsdevel@vger.kernel.org, torvalds@linux-foundation.org, viro@zeniv.linux.org.uk, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-mm@kvack.org, linux-ext4@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: 911A916001A X-Rspamd-Server: rspam01 X-Stat-Signature: z55mwed78ik56xor5aeo39dag3z3mrd5 X-HE-Tag: 1732187040-253873 X-HE-Meta: U2FsdGVkX1/n5uyZLn2HYlYmr42r1nB6q1dXvwDj7UHc0C/7wIJm4RzVsjtMxL1X9ADNIVKx3JfxNqTTUxOg3YU34ZAUbARVrrRgwESDnUxgxU7m+6LGpNsyJbWTnpC3wdJZAk1VcNgnKp64B/eMt/KPgT7MYy5/0TIqGZxcrirunG2bvXX7vAwjhtsww7kEY0IffMJDePHibXQ5RkTnd0f6QySKqjD75M3ovTZrNfqzdepqW4Ps0M6wh83Lp6WqgRXvCsxE1X0tcNb2agXW2mjrOE4R7AdPr4wpfZB2jxLdwlOO4KrqArIz9FrkfYVTxqUpmHFW3DKi2csqqnJbr8gAuFYWSeOVj+npKKMjF/l090HVxC15LwI0J3zHTYbBz1rdD21rDd9Xo7IYRFUZlbLbe0S6b2CRZNPjCZ9W05GbHlMpMVYLLpVjEZUEFB432Uvisrqj0nHzKcK+osRgd5YhezrmRFUpQqiIokffu/RScG13wJlxrkJQfmmB6vuupweuJJ+K3+jIElj26xuope118buvkIUS/B5MUDoMD3sJsAxFpDvryl22WmzATL8vsa4ivkf3/mAfID7h+rgW2I2Wrk70LbulCG6lSvuHN7aiyJ3wa7WaNcg2vX2n42nm1mPicCJ4a4b/KjmDxIwygVZt5VPaeQ/D2c3BEm6Txxh7ts7YqzmtRxY0c8WT7ejB4SIMAZZwPu7a0ZQTQkKio0jn3X1IKiOgzKABYywKcQ3R4Q4vb4EJvqPEgN6lcKmCWDjA/T3vLGJ4rQPddGan+ITXVJnDyicxTOiZsfOzPpKesfNmN8reoVs3pxaGeInfMzwhCnHF1ez1LLKxDSx8YArv38HVCRFotXPLR1FwX474neSkjs6n8Hq0s/QWLwJURP8q0wvglrJboc3mnmMThZlap2H82DkA3XRZ9V85k1HKqJggRJk6tGy0Bg3kGUjQmBHBeGzSxRu1gKndIQh p7wv9SnN c+CjiyW/ebcRqsxkrLebOSz4iwb4DiCoQ+pp4now+KyIxoBqpv3HjQfle8n7ttgkoXE0XwvO8ZFDa+nw+DGBjCfVctkxe70Uyauk6aTaXOD2YzEHZQBGOpzs+qI82aGNZqFtW3JmduMNIjQTrzSWpsk6uNXFzQkNPKKkok2MxhA+2pSjhn2657PB4LKicGOg8jBEIxkO7eLi2EXUO/7pBE3qqL5YN83fIDZUpCN70IMCn94KF/2RbCZ6PHFVbSfu2hjAANakqX6QBFgCgEp8RneUZ9Sf5saBzHw8Ylyp8wb0FoP82SU3OJ5Bearpb1pz4tViDyWkXZHCcE3byO1KJTKifZA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000624, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Nov 21, 2024 at 11:09=E2=80=AFAM Christian Brauner wrote: > > > It is not that I object to "two bit constants". FMODE_FSNOTIFY_MASK is = a > > two-bit constant and a good one. But the name clearly suggests it is no= t a > > single bit constant. When you have all FMODE_FOO and FMODE_BAR things > > single bit except for FMODE_BAZ which is multi-bit, then this is IMHO a > > recipe for problems and I rather prefer explicitely spelling the > > combination out as FMODE_NONOTIFY | FMODE_NONOTIFY_PERM in the few plac= es > > that need this instead of hiding it behind some other name. > > Very much agreed! Yes, I agree as well. What I meant is that the code that does return FMODE_NONOTIFY | FMODE_NONOTIFY_PERM; is going to be unclear to the future code reviewer unless there is a comment above explaining that this is a special flag combination to specify "suppress only pre-content events". Thanks, Amir.