From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw0-f197.google.com (mail-yw0-f197.google.com [209.85.161.197]) by kanga.kvack.org (Postfix) with ESMTP id 8E8C76B0005 for ; Thu, 25 Jan 2018 15:36:20 -0500 (EST) Received: by mail-yw0-f197.google.com with SMTP id l74so5214167ywc.22 for ; Thu, 25 Jan 2018 12:36:20 -0800 (PST) Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id f127sor1256060ywd.172.2018.01.25.12.36.19 for (Google Transport Security); Thu, 25 Jan 2018 12:36:19 -0800 (PST) MIME-Version: 1.0 In-Reply-To: References: <20171030124358.GF23278@quack2.suse.cz> <76a4d544-833a-5f42-a898-115640b6783b@alibaba-inc.com> <20171031101238.GD8989@quack2.suse.cz> <20171109135444.znaksm4fucmpuylf@dhcp22.suse.cz> <10924085-6275-125f-d56b-547d734b6f4e@alibaba-inc.com> <20171114093909.dbhlm26qnrrb2ww4@dhcp22.suse.cz> <20171115093131.GA17359@quack2.suse.cz> <20180124103454.ibuqt3njaqbjnrfr@quack2.suse.cz> From: Amir Goldstein Date: Thu, 25 Jan 2018 22:36:18 +0200 Message-ID: Subject: Re: [PATCH v2] fs: fsnotify: account fsnotify metadata to kmemcg Content-Type: text/plain; charset="UTF-8" Sender: owner-linux-mm@kvack.org List-ID: To: Shakeel Butt Cc: Jan Kara , Yang Shi , Michal Hocko , linux-fsdevel , Linux MM , LKML On Thu, Jan 25, 2018 at 10:20 PM, Shakeel Butt wrote: > On Wed, Jan 24, 2018 at 11:51 PM, Amir Goldstein wrote: >> >> There is a nicer alternative, instead of failing the file access, >> an overflow event can be queued. I sent a patch for that and Jan >> agreed to the concept, but thought we should let user opt-in for this >> change: >> https://marc.info/?l=linux-fsdevel&m=150944704716447&w=2 >> >> So IMO, if user opts-in for OVERFLOW instead of ENOMEM, >> charging the listener memcg would be non controversial. >> Otherwise, I cannot say that starting to charge the listener memgc >> for events won't break any application. >> > > Thanks Amir, I will send out patches soon for directed charging for > fsnotify. Also are you planning to work on the opt-in overflow for the > above case? Should I wait for your patch? > Don't wait for me. You can pick up my simple patch if you like to implement "opt-in for charging listener memcg" it would make sense with that change. Thanks, Amir. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org