From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61335C02196 for ; Fri, 7 Feb 2025 19:33:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 459C0280004; Fri, 7 Feb 2025 14:33:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3E410280001; Fri, 7 Feb 2025 14:33:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 25CAC280004; Fri, 7 Feb 2025 14:33:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 05464280001 for ; Fri, 7 Feb 2025 14:33:44 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 831B91A1FA4 for ; Fri, 7 Feb 2025 19:33:44 +0000 (UTC) X-FDA: 83094148368.28.C563D93 Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) by imf15.hostedemail.com (Postfix) with ESMTP id 88C22A0009 for ; Fri, 7 Feb 2025 19:33:42 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Taj5eTBy; spf=pass (imf15.hostedemail.com: domain of amir73il@gmail.com designates 209.85.208.41 as permitted sender) smtp.mailfrom=amir73il@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738956822; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wvcv5oFO5yuh0ssL0C2FZl0cPKOHFQnsd+cAtQTfxww=; b=nlFdRCjJ/cjy0djj2dwUt82Xyw6U9CpWmrOvVZOqSjvqftDqb6Txdp4SFa89ZeYRwYpa+5 zWzMpYObzyspmEPqYFBnDpofyq4KIglNKw2Hh8IZGhLdcqNWwf6/eUVfyqV/mRVEqYQyyc c7hr9RqEGqlF0BIqxUFFqVBXLqGYTGY= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Taj5eTBy; spf=pass (imf15.hostedemail.com: domain of amir73il@gmail.com designates 209.85.208.41 as permitted sender) smtp.mailfrom=amir73il@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738956822; a=rsa-sha256; cv=none; b=t9ZQFdU3GM/bjlVv+pmerJevP9wMaKYS85GNBqx0qzyZdj0Ptx5l294XLCTydvk1sifsjf AeeJSOj95wVUg25ABSJ2f0xg2XE3mnxtx1N81AnE7I24xvhoDJVMH7beXPOcWZx7uxuJJh hohYuhZ13lPFcjwsmtDhiSmi3AojaaI= Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-5de4d4adac9so1600210a12.3 for ; Fri, 07 Feb 2025 11:33:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738956821; x=1739561621; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=wvcv5oFO5yuh0ssL0C2FZl0cPKOHFQnsd+cAtQTfxww=; b=Taj5eTBylpLeycAxZK5+GbtUDZ2/wcamcb9SRUL4euVMYyLTjcNTWmggLrJcErnpxz 2xT4ZF7maG3TPQPZypTkFw+g3rrYS7wdHilTvdEuPK9mdigSJPgqKN1uPsS9WIPoI5+B eKHIZYIr+q9Gg2rR0k30/jZ9zfK4gSJuEY8BL6ZxTOAQMbncp64g0OELqiLVXjh9H1w7 6jFIlY83bK6MWdZ6iBpdePyaV2JWi1lx3TTlU5pZKz3xe3YN0JVU1glGvh9z2aEjBJVz QZ9PhogshjgaCyl+uh1B/WlkwxwjAFWgZBPMFVTDKyUh1cuhCaflqeSufFvmcf2fhnIe 5vSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738956821; x=1739561621; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wvcv5oFO5yuh0ssL0C2FZl0cPKOHFQnsd+cAtQTfxww=; b=a4xtsGI7Haupyoka0D5i47MvFU+1JR/ZpMXC1z1Pr9hzNsUOa//YeJynEdWFjU2DPY /HlTJRclYGNC3iRodTNFwy32XMqwzV3Y1hHw5RwngUE9FP8fl4Pb4rFdv4eOn2Pw822u IOx5KcXJSs0btVE4c9/MPi/+Ip6DnIEhxuTtKAK1PzO7AjivHEDM5CO1rT/4O5mVOCTM b+7ZZs8ujbn0rGkqjCPn789NKbTruVPHdnl8SHPqzDunnBvW9I8R9q0gaJA1Q4AxIfvo dYMGUGdv3ESOfSF5hsTr9zmbdFaqIAxXwd9wElUUxwaD57D0V+vUwRpPjvsKj1B/8++p i3CA== X-Forwarded-Encrypted: i=1; AJvYcCVZR1j/HFbj3Niv+HxTRfjyAtm3VIYtT4rBAftEIVpkVnrO9dRAfjpGxuYfW8AHmRnlFMEKTXAYMQ==@kvack.org X-Gm-Message-State: AOJu0YyEvJvDJUOwkogO/3LaJKkmcBxHbKci+8r4V0yTg+RIuCuN/wba 4dgIMIdtsXQgDn6SHo8xvyFZ+iXGkzzMuO2CA0qmUU5Oj4rdPznbB0UhIqjyeFof+QB6HszWcK1 utHPlYxMc+wPpXoiaKZ03s/11gKY= X-Gm-Gg: ASbGncsoYrbV9seCEgIb7c1svexgjXU/HdSvwrbzl8YbLd4ud9/HEPNa3P7f6pUOJQp SrriVgr6jrKhCi/yTLNb9FA9VUzypFNRY+iEZ4PTX5UoKM8oc7N1lFjO9LioDdkeexAI0e2sd X-Google-Smtp-Source: AGHT+IFFs/Rqjxw2rV1FceqF1aOlkkljxp6UG0aTtGzBzzmTu3tUmF2R/pfQViZ76iqviap50rlzTA+TBnKXzO/8mSs= X-Received: by 2002:a05:6402:13c8:b0:5dc:cc02:5d25 with SMTP id 4fb4d7f45d1cf-5de45002faamr4611268a12.11.1738956820532; Fri, 07 Feb 2025 11:33:40 -0800 (PST) MIME-Version: 1.0 References: <67a487f7.050a0220.19061f.05fc.GAE@google.com> <20250206165404.495fd127b4dc32a62574841a@linux-foundation.org> <20250207-teuer-viermal-9c60839ff221@brauner> In-Reply-To: <20250207-teuer-viermal-9c60839ff221@brauner> From: Amir Goldstein Date: Fri, 7 Feb 2025 20:33:28 +0100 X-Gm-Features: AWEUYZmeqLI8aVU-FWqBjZ55K5Oj3LwvTof94Ff0ynkNlOpyfA4oM0EVeDHUmoo Message-ID: Subject: Re: [syzbot] [mm?] WARNING in fsnotify_file_area_perm To: Christian Brauner , Jan Kara Cc: Andrew Morton , syzbot , linux-kernel@vger.kernel.org, linux-mm@kvack.org, syzkaller-bugs@googlegroups.com, linux-fsdevel@vger.kernel.org, Jens Axboe , Josef Bacik Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 88C22A0009 X-Stat-Signature: k3otnhtsukzycc6od85we13z1zd3dmwi X-HE-Tag: 1738956822-900633 X-HE-Meta: U2FsdGVkX1/BpM0RV9qlKTywMb+Ci0INyR/irIHSGcGVwuV/Q7wnGiOiS1gzTRkcbVTvvKMQUtD3ti9waOn+o4qGh44EI2fte52mdBamALqraaegl6zJpxkU4cthL/iXdjWpoqWI4FRkAV4JsSEPWY5q9K2EQ7gEgsUUgaCy9rDu+5pMSXT02aiWhrPZOgXjA12DTBd9x4G041HdJqACoCH42SvC4Tbm6b89F+WnWnZ4b7kVueoimlozpEL6pjM7loGPqvSAyIem4ZKwnFsEHwwE2zdqgrTSwyqdJHyifu/6Yy7RA6R/bDnSYApAZKlmBgas7HB1Xd9Eqfkfh5tAcQcBn6Utn1kMGOAxnv1aQSHFOyjcqfBrtEgjMOTlMDqRTWHwviN4sJVD90BJeFNOXjyIRsTsV4p3Ff66/65wdwXAdUopZ65XauOnv9gcrTCxGPCkIqB7TKDSBYr2+qMItlo/Y2siicUWyugJLrVduHiXReXs6WbsokuFJnqfdXBNhFNKAyMfE+Qn/tbelanlCJBOnt6M+kGTCNl2lztv8VnXvMHuqvJjEK9QnlRyFqcwl+jKtcez1NMzV6ZXE98Den1qWRNgnhQb8jl7f9krUESgPHWslaN1HcFKl2X4iCtk8exhBN0tqvIzLY6ljQSTgMFWWOtiDrRH8AndkVYklqaE+bIk1SXqkNhy33nH+Oi1PrGWWQRT+GUzuEr8rmlkrpo0umexG8zT37GkuTlFNUWAPaxfzFSgKz9xA9kAasbGoG6D+wx+eFKqpBpV9tGV489n661x0U+TR9oULnYDUdPglvWTsbYYmAHbFOAuDmC4cjb5GdJ7T8A4Dx7yGlDkeoqqGb2ozZ2u6Emn0PGrTGw8CB9alk2VAIDFNAIVFGFkqu8AH1KW1ysHAkcTJ7l4bQ+g0GQqh7wB+gUz0FCAHGUnvh3PUJwEVZdQw+T6LP7VFTHgQPNdokcpH/Zez6Y c7BKqp0l u8jRzeEs4RnFoxbK15OAm4bmsiUC9iuXdDIjHeQJe4r528V1huUyp4ArLpPnlgHdd7cDk0YkFdyLKVc4h92SWCwHw99hOyt+HU73EkOk5CycTl8ph5pTnbz3kd8cSw6x20H6AUis61QH7KgRSI6hKZ14VMczkIZVhZTh6Xlx2mhu83fiJOn3rGguhf2RQ/EzK2DgVsR3qC1fxAqGfyaRUZdJGpeNkfmb0N9Cd5ndfySRuYODWNOC3qAarZ+j0r6tZmGUvFYKxBwnh0pDD6cVsOt0qS2Kry5KYDYjBxitliPB7lWqfl0pMcGkng5+gJ+HuNG0hSRjANYHe76jm6wSSuRxemxYxFOMn/CO5IIfJkMo+qKZCTfOxuB7aN+Q5Jhzk8cO1p85/5b/eOvD/sIT6ZdQ3yrs2U6Oee8uUDFV7N17OvwoLuckzHHecuF2LVNRwn6iB4Q3pb5LtGoCrCTjsyMqHFJjqCWse90kqbstskPXEFwZZqSpBd0Hp7zKbBQcrh3vK7nOUxdFqDLia+TtMdW5FFXD5ogZQJ2NsLZfR+Q0MJHG6cHWzvSxrNfO2V22D+emcMqjqNiYh/GDqUZ64OHvwM1QEr0siqt9QNIGvVNHxSi8/aCasrxusBHOL4fNP+V7MyySgMgSkjR21lguWepZmF0E4WJI49WD4df9XNjaDnEWLG08ITcj4Cz8lCAtFI8W4AerxfuFSc5pc7PifJ9CUCl7O8NzaTZfc9fnes29fusmde7OBQkynJn+a4JzNgK4MXcy3/hcJ5sWuI0lj5c4vnCFuxOU5NL4PsgyhGZ+U6iGMpeXdcJulR+9SENwLw7+f09xd012wveZlMyBUfVh9P5kUy7S/1aR9sggRAY8nBmPn/oxJzSp68mhnCk5AZxpw//m+OoUX9GQYBpfwBeD2abxu+LP9JhocgYTxypLekZf98NqRcLER8zIbYVXZKyVSYCOTGfjHn8s= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Feb 7, 2025 at 9:46=E2=80=AFAM Christian Brauner wrote: > > On Thu, Feb 06, 2025 at 04:54:04PM -0800, Andrew Morton wrote: > > > > Thanks. Let me cc linux-fsdevel and a few others who might help with > > this. > > Thanks! I already have a fix for this in vfs.fixes: > > https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git/commit/?h=3Dv= fs.fixes&id=3Db13036454697d83e53bf754efbcaaedf431b7a8a > Yes, I hope that it is fixed. The assertion in a fsnotify_file_area_perm() hook on page read fault on the blockdev, which shouldn't have FMODE_FSNOTIFY_HSM set. > I'll get that out today. > Thanks, Amir. > > > > > > On Thu, 06 Feb 2025 01:59:19 -0800 syzbot wrote: > > > > > Hello, > > > > > > syzbot found the following issue on: > > > > > > HEAD commit: 69e858e0b8b2 Merge tag 'uml-for-linus-6.14-rc1' of gi= t://g.. > > > git tree: upstream > > > console output: https://syzkaller.appspot.com/x/log.txt?x=3D135c17245= 80000 > > > kernel config: https://syzkaller.appspot.com/x/.config?x=3Dd033b14ae= ef39158 > > > dashboard link: https://syzkaller.appspot.com/bug?extid=3D7229071b479= 08b19d5b7 > > > compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for= Debian) 2.40 > > > > > > Unfortunately, I don't have any reproducer for this issue yet. > > > > > > Downloadable assets: > > > disk image (non-bootable): https://storage.googleapis.com/syzbot-asse= ts/7feb34a89c2a/non_bootable_disk-69e858e0.raw.xz > > > vmlinux: https://storage.googleapis.com/syzbot-assets/a53b888c1f3f/vm= linux-69e858e0.xz > > > kernel image: https://storage.googleapis.com/syzbot-assets/6b5e17edaf= c0/bzImage-69e858e0.xz > > > > > > IMPORTANT: if you fix the issue, please add the following tag to the = commit: > > > Reported-by: syzbot+7229071b47908b19d5b7@syzkaller.appspotmail.com > > > > > > loop0: detected capacity change from 0 to 32768 > > > XFS: ikeep mount option is deprecated. > > > XFS (loop0): Mounting V5 Filesystem a2f82aab-77f8-4286-afd4-a8f747a74= bab > > > XFS (loop0): Ending clean mount > > > XFS (loop0): Quotacheck needed: Please wait. > > > XFS (loop0): Quotacheck: Done. > > > ------------[ cut here ]------------ > > > WARNING: CPU: 0 PID: 5321 at ./include/linux/fsnotify.h:145 fsnotify_= file_area_perm+0x1e5/0x250 include/linux/fsnotify.h:145 > > > Modules linked in: > > > CPU: 0 UID: 0 PID: 5321 Comm: syz.0.0 Not tainted 6.13.0-syzkaller-09= 760-g69e858e0b8b2 #0 > > > Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.3-debia= n-1.16.3-2~bpo12+1 04/01/2014 > > > RIP: 0010:fsnotify_file_area_perm+0x1e5/0x250 include/linux/fsnotify.= h:145 > > > Code: c3 cc cc cc cc e8 fb 8f c6 ff 49 83 ec 80 4c 89 e7 48 83 c4 08 = 5b 41 5c 41 5d 41 5e 41 5f 5d e9 01 9f 00 00 e8 dc 8f c6 ff 90 <0f> 0b 90 e= 9 0a ff ff ff 48 c7 c1 10 73 1b 90 80 e1 07 80 c1 03 38 > > > RSP: 0018:ffffc9000d416320 EFLAGS: 00010283 > > > RAX: ffffffff81f8dce4 RBX: 0000000000000001 RCX: 0000000000100000 > > > RDX: ffffc9000e5c2000 RSI: 00000000000008fa RDI: 00000000000008fb > > > RBP: 0000000000008000 R08: ffffffff81f8dbdc R09: 1ffff110087dca2e > > > R10: dffffc0000000000 R11: ffffed10087dca2f R12: ffff888033d4b1c0 > > > R13: 0000000000000010 R14: dffffc0000000000 R15: ffffc9000d416460 > > > FS: 00007f5bca7346c0(0000) GS:ffff88801fc00000(0000) knlGS:000000000= 0000000 > > > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > > > CR2: 0000000020000100 CR3: 0000000033fd2000 CR4: 0000000000352ef0 > > > DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 > > > DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 > > > Call Trace: > > > > > > filemap_fault+0x14a9/0x16c0 mm/filemap.c:3509 > > > __do_fault+0x135/0x390 mm/memory.c:4977 > > > do_read_fault mm/memory.c:5392 [inline] > > > do_fault mm/memory.c:5526 [inline] > > > do_pte_missing mm/memory.c:4047 [inline] > > > handle_pte_fault mm/memory.c:5889 [inline] > > > __handle_mm_fault+0x4c44/0x70f0 mm/memory.c:6032 > > > handle_mm_fault+0x3e5/0x8d0 mm/memory.c:6201 > > > faultin_page mm/gup.c:1196 [inline] > > > __get_user_pages+0x1a92/0x4140 mm/gup.c:1491 > > > __get_user_pages_locked mm/gup.c:1757 [inline] > > > __gup_longterm_locked+0xe64/0x17f0 mm/gup.c:2529 > > > gup_fast_fallback+0x2266/0x29c0 mm/gup.c:3430 > > > pin_user_pages_fast+0xcc/0x160 mm/gup.c:3536 > > > iov_iter_extract_user_pages lib/iov_iter.c:1844 [inline] > > > iov_iter_extract_pages+0x3bb/0x5c0 lib/iov_iter.c:1907 > > > __bio_iov_iter_get_pages block/bio.c:1181 [inline] > > > bio_iov_iter_get_pages+0x4f1/0x1460 block/bio.c:1263 > > > iomap_dio_bio_iter+0xc9c/0x1740 fs/iomap/direct-io.c:406 > > > __iomap_dio_rw+0x13b7/0x25b0 fs/iomap/direct-io.c:703 > > > iomap_dio_rw+0x46/0xa0 fs/iomap/direct-io.c:792 > > > xfs_file_dio_write_unaligned+0x2ef/0x6f0 fs/xfs/xfs_file.c:692 > > > xfs_file_dio_write fs/xfs/xfs_file.c:725 [inline] > > > xfs_file_write_iter+0x5c6/0x720 fs/xfs/xfs_file.c:876 > > > do_iter_readv_writev+0x71a/0x9d0 > > > vfs_writev+0x38b/0xbc0 fs/read_write.c:1050 > > > do_pwritev fs/read_write.c:1146 [inline] > > > __do_sys_pwritev2 fs/read_write.c:1204 [inline] > > > __se_sys_pwritev2+0x196/0x2b0 fs/read_write.c:1195 > > > do_syscall_x64 arch/x86/entry/common.c:52 [inline] > > > do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 > > > entry_SYSCALL_64_after_hwframe+0x77/0x7f > > > RIP: 0033:0x7f5bc998cda9