From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09136C10F1A for ; Tue, 7 May 2024 17:13:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 619596B008A; Tue, 7 May 2024 13:13:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5A2D26B0098; Tue, 7 May 2024 13:13:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 41BDC6B0099; Tue, 7 May 2024 13:13:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 239506B008A for ; Tue, 7 May 2024 13:13:45 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 92A471C0164 for ; Tue, 7 May 2024 17:13:44 +0000 (UTC) X-FDA: 82092246768.14.B1199D2 Received: from mail-yw1-f175.google.com (mail-yw1-f175.google.com [209.85.128.175]) by imf08.hostedemail.com (Postfix) with ESMTP id D9273160007 for ; Tue, 7 May 2024 17:13:42 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=WXXId6pi; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf08.hostedemail.com: domain of allen.lkml@gmail.com designates 209.85.128.175 as permitted sender) smtp.mailfrom=allen.lkml@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715102022; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EYum/RRI+2OZh34IaDs9A+wweg7qNiOwsJ++IUalaZs=; b=knz3moLPeblMb6rk3hvZB8C4jWrQZK+/2Ex3chzBw/S6QbNVQd0Ct67Ik0cjP60QEe0NQA 0qWjhmiKUYwzSd0PzDkw2T1w9Azl1/d14Ayv8MZRxPflcIpZ/9mJaDiREYdJGqW//Wlvoq ofAM16JR48vs8nV1nnkILR9CqN4nFPI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715102022; a=rsa-sha256; cv=none; b=UYtjt4xlTrLDzmxKMr6DzuTlbwmXyCBKABcqV8+fV2mt2ZXO6CN0/0FiTOft0MUDuWZ0pl naGHHeRgBGlaXKh87JZTUipHEdWpaZm5uA8gPE/UXzCPlOf9zkAaY8mmu//NntXpj1rO/L 9hxlROyS2GeFRWlWA8aY7fXBrqEs0gI= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=WXXId6pi; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf08.hostedemail.com: domain of allen.lkml@gmail.com designates 209.85.128.175 as permitted sender) smtp.mailfrom=allen.lkml@gmail.com Received: by mail-yw1-f175.google.com with SMTP id 00721157ae682-61bb219737dso38073687b3.2 for ; Tue, 07 May 2024 10:13:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1715102022; x=1715706822; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=EYum/RRI+2OZh34IaDs9A+wweg7qNiOwsJ++IUalaZs=; b=WXXId6pi7NlOLwHbHlr9n/BWyg6ZtTUlC9l1kTBR9Cl6jJSZNmuEwD9GqRJhGZUtg9 owrKBavonb4NA4sAM8NStr9VaD7eUgJ1c3xW4mftDjau21qAK2eXZMJUgzZn9L20t5OC Zk+JPjskTXxZ4zuqVYFmuLpfXL8jtX/HhuJY9L32UIye6LZb46fNj4+l8PsSv+JKQ19c m0HSfWM4rBdA5pocmFQTksZF1wNSd2kleSmujuufrnqD4VDtFmXaD7H+wmKWNoOnRgxZ 7A4IelsSnbATqTT0pO8ydoiSE0x/5SroVCsRGMwxur9+IXBN3g1NbfdUdzm42FljomPv BlCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715102022; x=1715706822; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=EYum/RRI+2OZh34IaDs9A+wweg7qNiOwsJ++IUalaZs=; b=SbYS60mS5qZ1E2o3FJLJPSEIHdrLFV1o8xlnnp0Tgah+t8D5/FoxIJBRc4YV1bc4bP i7a2aqoDntPKeQ4SRcLboc4omwR4SERGFRvehbO02Rjbk6m4CU0Trtkbor+7AkrHFXK+ lUzX6gT8E2Oa87Hb7k/RXBjD5NQrJoBSGycBczoaowYgSzdAMKbp8RsTVL/3uscgkwJ2 NSw2iHypBBL8N62oR3LwtUyFqOUralmjuTySrVrtQ34BwpGD3DFq6gnRFJj7GBnGD8GK 7uQ3jo48ZEMJNWkC/Th5V/UU6boEFsF/RmyVJwrErOSR3brvD4kfgxonG7LPKv6rAkIj ofXQ== X-Forwarded-Encrypted: i=1; AJvYcCXbTHt2MZ2P61SePAWjzi58yg2cLYMdUswNoSX7XI17dLYkl9Tyih2XdWrEJ6Wfnjgmx9iCb87chW6a4Y6EffGxDkg= X-Gm-Message-State: AOJu0Yxd5RYcrygSUkdEqKiRoDxRPpakBVojp4jH0iYT5fgfvb4PDhAO Pwnyy3B3YHwCOR6BWQfszKlFme/rRChOOdBFNXgKbYwTUXwiAGEpFoku2hKYLNwXZ5yJdgLsGOz 6C1OLK7+nXU2AM2e9QnOUPy2F9u4= X-Google-Smtp-Source: AGHT+IEtaUXVcDdFFPrSZfNzsTmU796n7ghfMyjhUtMghx8kl6qZabBPVyKTNI4/IqH+SGyg0CFCtF4iR3B+DBpgkkU= X-Received: by 2002:a81:4c0d:0:b0:618:5e8c:c66f with SMTP id 00721157ae682-62085d1b43dmr4533657b3.7.1715102021955; Tue, 07 May 2024 10:13:41 -0700 (PDT) MIME-Version: 1.0 References: <20240506193700.7884-1-apais@linux.microsoft.com> <171510137055.3977159.13112533071742599257.b4-ty@chromium.org> In-Reply-To: <171510137055.3977159.13112533071742599257.b4-ty@chromium.org> From: Allen Date: Tue, 7 May 2024 10:13:30 -0700 Message-ID: Subject: Re: [PATCH v4] fs/coredump: Enable dynamic configuration of max file note size To: Kees Cook Cc: linux-fsdevel@vger.kernel.org, Allen Pais , linux-kernel@vger.kernel.org, linux-mm@kvack.org, viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, ebiederm@xmission.com, mcgrof@kernel.org, j.granados@samsung.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: D9273160007 X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: m8fjarrbpdikuzxa5z889z64b5sekw6r X-HE-Tag: 1715102022-317047 X-HE-Meta: U2FsdGVkX18FbkdEvByUHVydg9KSrnRN9h1Dpr8s5M33a9hVZYH1YeqaD5GxSTZIfWfnlF1SNiKuV/g4EJHers4a4TXVk/w6v12tJzVO5BVxyFA+wtux/6P0WNTprkidnwhKNNU9FYbfZ708q8gi7JKRvBy9rTmdH0ghioQSKD657ETZj1Z3VltvQ3e4KxMuVjqS+GCaWJxwRylMrOiFgvRXvE/CpN4XMZi3jXtQdgdwNF8gUfZOoINGs5HQcL/+EEuCoXE7qjgcNh1mF4bEClk78Ivhj0eLC/bUqpMIVPxZTrsnz554QqMn2y68FMglAeZ+Pqw00AXsRXiB6mGBGgyMwNho2Ry4F7tM3wCLvwlsOhvcL3h1hevHkFyOU/LKoKrtqxPUPGlqws/WZeRNUUaZXe1OcqJxJ35w4++xfvkaWXY4rVvow0el6CcAUuZB5BaGeOxVmfz0HsrS2ee2++RvRLovd6w9OckfjU3nf9fIpD4pjQahw8CEzQeiBEmxYH4KMXH98SEbq65jSRWGa3QCHVL6O2zLVGMtPJ4cGeG7jUIuCplqOPBzAzm2/noiYCnxU83ES27Fiszm0htIykwOzTlbeNWEQMXdq7NNt2E/hPZz77Vurufx3pXxUZstuDbhENKiy8XODlJfJEZj0qs8Il3wkdbbQZ+feqxHIjkeFVOPvBn0y1Y+ECG/XX7f6Ph4Umscg+348LvbsML2i+CitBr3ZpbmZuHLM1C/H21EyzItlLdW+GbGusqg7oYpLhjcxEYfWeFBqFqVzaVjQr9oY3A+BKJemLizMvC6FcGgO0Z7JjpatFEpHSZOezu+toU4CGry98K0Kzx3VRlwjkyAGfzbSQP45b/ywvBoTvcLn8MtTHH99Rg9auCjRhLTLgz2oimd0oVqPzw95xOH7NyfWToMggZYHjyTvsTFZz1B4aTNsgMkBOupXbkhEZe62FdAoHo7c6tNFP8KVzK CM5sOEQ3 yAmMbZCCpyvpBFsHJrOUAJSySE55jDrKsWf0A1Io71EXe+tYBqlNN/sQ/Y7VLep6jKaqzT10H9wIuD9JDbqggi3RqM1kHlAGucEcjHaw6BoQMpbzEBo/o8ceBqKmaHINgLh/xksfcNxUXG6JOinPuHr5TJ+GzTwgzTOX5RJr9FI9CklyKIjE+GEmAqk1OwXcqKEnZFGrKp4YZs8FyGWbZj3GvK0Mx17Jg/CsZLK2k1xwPwY3iUKimf05Tt1Ig7i2fegMoWLXIChJ6xsQ/UMJkRBKpMkUuJNWbUkCR8h542qCmzcm6UcIMy5Wrmx0S6Ac8yHvbwtVVr9eAiNXteJCcqOoG0J1vo43Fegc0aYJh1+V/faBn52+cQjoJZInlgBpIilqhALSEl1mA9ORxRxzDyILEMK3ykz5nhbQMJnIuY/ver0+BcwqocC5u04N9Wn+QISU4 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000421, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > On Mon, 06 May 2024 19:37:00 +0000, Allen Pais wrote: > > Introduce the capability to dynamically configure the maximum file > > note size for ELF core dumps via sysctl. > > > > Why is this being done? > > We have observed that during a crash when there are more than 65k mmaps > > in memory, the existing fixed limit on the size of the ELF notes section > > becomes a bottleneck. The notes section quickly reaches its capacity, > > leading to incomplete memory segment information in the resulting coredump. > > This truncation compromises the utility of the coredumps, as crucial > > information about the memory state at the time of the crash might be > > omitted. > > > > [...] > > I adjusted file names, but put it in -next. I had given some confusing > feedback on v3, but I didn't realize until later; apologies for that! The > end result is the sysctl is named kernel.core_file_note_size_limit and > the internal const min/max variables have the _min and _max suffixes. > > Applied to for-next/execve, thanks! > > [1/1] fs/coredump: Enable dynamic configuration of max file note size > https://git.kernel.org/kees/c/81e238b1299e > I should have put some thought into the feedback. Thank you for reviewing and fixing the patch. -- - Allen