From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx107.postini.com [74.125.245.107]) by kanga.kvack.org (Postfix) with SMTP id A984D6B0062 for ; Mon, 6 Aug 2012 13:13:57 -0400 (EDT) Received: by wibhq4 with SMTP id hq4so1636707wib.8 for ; Mon, 06 Aug 2012 10:13:56 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: Date: Mon, 6 Aug 2012 20:13:55 +0300 Message-ID: Subject: Re: [RFC/PATCH] zcache/ramster rewrite and promotion From: Pekka Enberg Content-Type: text/plain; charset=ISO-8859-1 Sender: owner-linux-mm@kvack.org List-ID: To: Dan Magenheimer Cc: Seth Jennings , Konrad Wilk , Minchan Kim , Nitin Gupta , Andrew Morton , Robert Jennings , Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org On Mon, Aug 6, 2012 at 7:10 PM, Dan Magenheimer wrote: > Hmmm.. there's also zbud.c and tmem.c which are critical components > of both zcache and ramster. And there are header files as well which > will need to either be in mm/ or somewhere in include/linux/ > > Is there a reason or rule that mm/ can't have subdirectories? > > Since zcache has at least three .c files plus ramster.c, and > since mm/frontswap.c and mm/cleancache.c are the foundation on > which all of these are built, I was thinking grouping all six > (plus headers) in the same mm/tmem/ subdirectory was a good > way to keep mm/ from continuing to get more cluttered... not counting > new zcache and ramster files, there are now 74 .c files in mm/! > (Personally, I think a directory has too many files in it if > "ls" doesn't fit in a 25x80 window.) > > Thoughts? There's no reason we can't have subdirectories. That said, I really don't see the point of having a separate directory called 'tmem'. It might make sense to have mm/zcache and/or mm/ramster but I suspect you can just fold the core code in mm/zcache.c and mm/ramster.c by slimming down the weird Solaris-like 'tmem' abstractions. Pekka -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org