From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx125.postini.com [74.125.245.125]) by kanga.kvack.org (Postfix) with SMTP id 30DF06B004D for ; Mon, 30 Jul 2012 16:41:38 -0400 (EDT) Received: by weys10 with SMTP id s10so4876208wey.14 for ; Mon, 30 Jul 2012 13:41:36 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1342221125.17464.8.camel@lorien2> Date: Mon, 30 Jul 2012 23:41:35 +0300 Message-ID: Subject: Re: [PATCH TRIVIAL] mm: Fix build warning in kmem_cache_create() From: Pekka Enberg Content-Type: text/plain; charset=ISO-8859-1 Sender: owner-linux-mm@kvack.org List-ID: To: David Rientjes Cc: shuah.khan@hp.com, cl@linux.com, glommer@parallels.com, js1304@gmail.com, shuahkhan@gmail.com, linux-mm@kvack.org, LKML , Andrew Morton , Linus Torvalds On Mon, Jul 30, 2012 at 10:56 PM, David Rientjes wrote: > -Wunused-label is overridden in gcc for a label that is conditionally > referenced by using __maybe_unused in the kernel. I'm not sure what's so > obscure about > > out: __maybe_unused > > Are label attributes really that obsecure? I think they are. The real problem, however, is that label attributes would just paper over the badly thought out control flow in the function and not make the code any better or easier to read. Pekka -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org