From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx184.postini.com [74.125.245.184]) by kanga.kvack.org (Postfix) with SMTP id C12C96B0005 for ; Sun, 10 Mar 2013 06:40:51 -0400 (EDT) Received: by mail-we0-f173.google.com with SMTP id x51so2507494wey.32 for ; Sun, 10 Mar 2013 03:40:50 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1362902470-25787-1-git-send-email-jiang.liu@huawei.com> <1362902470-25787-11-git-send-email-jiang.liu@huawei.com> Date: Sun, 10 Mar 2013 12:40:49 +0200 Message-ID: Subject: Re: [PATCH v2, part2 10/10] mm/x86: use free_highmem_page() to free highmem pages into buddy system From: Pekka Enberg Content-Type: text/plain; charset=ISO-8859-1 Sender: owner-linux-mm@kvack.org List-ID: To: Jiang Liu Cc: Andrew Morton , David Rientjes , Jiang Liu , Wen Congyang , Mel Gorman , Minchan Kim , KAMEZAWA Hiroyuki , Michal Hocko , Jianguo Wu , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Cong Wang , Yinghai Lu , Attilio Rao , konrad.wilk@oracle.com On Sun, Mar 10, 2013 at 12:32 PM, Pekka Enberg wrote: > On Sun, Mar 10, 2013 at 10:01 AM, Jiang Liu wrote: >> Use helper function free_highmem_page() to free highmem pages into >> the buddy system. >> >> Signed-off-by: Jiang Liu >> --- >> arch/x86/mm/highmem_32.c | 1 - >> arch/x86/mm/init_32.c | 10 +--------- >> 2 files changed, 1 insertion(+), 10 deletions(-) >> >> diff --git a/arch/x86/mm/highmem_32.c b/arch/x86/mm/highmem_32.c >> index 6f31ee5..252b8f5 100644 >> --- a/arch/x86/mm/highmem_32.c >> +++ b/arch/x86/mm/highmem_32.c >> @@ -137,5 +137,4 @@ void __init set_highmem_pages_init(void) >> add_highpages_with_active_regions(nid, zone_start_pfn, >> zone_end_pfn); >> } >> - totalram_pages += totalhigh_pages; > > Hmm? I haven't looked at what totalram_pages is used for but could you > explain why this change is safe? Never mind, I should have read the patchset more carefully: Reviewed-by: Pekka Enberg -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org